[jira] [Commented] (KAFKA-3774) GetOffsetShell tool reports 'Missing required argument "[time]"' despite the default

2016-06-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311790#comment-15311790
 ] 

ASF GitHub Bot commented on KAFKA-3774:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1457


> GetOffsetShell tool reports 'Missing required argument "[time]"' despite the 
> default
> 
>
> Key: KAFKA-3774
> URL: https://issues.apache.org/jira/browse/KAFKA-3774
> Project: Kafka
>  Issue Type: Bug
>  Components: tools
>Reporter: Vahid Hashemian
>Assignee: Vahid Hashemian
>Priority: Minor
> Fix For: 0.10.1.0
>
>
> If the {{--time}} argument is not provided to the GetOffsetShell tool, even 
> though there is a default value of {{-1}}, the tool still reports
> {quote}
> {{Missing required argument "[time]"}}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-3774) GetOffsetShell tool reports 'Missing required argument "[time]"' despite the default

2016-06-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311083#comment-15311083
 ] 

ASF GitHub Bot commented on KAFKA-3774:
---

GitHub user vahidhashemian opened a pull request:

https://github.com/apache/kafka/pull/1457

KAFKA-3774: Make 'time' an optional argument of GetOffsetShell tool

Since the 'time' argument has a default value of -1, it makes sense to make 
it an optional argument.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vahidhashemian/kafka KAFKA-3774

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1457


commit aee6b5aba22394f4f7fba6b5e5bacc21acf96986
Author: Vahid Hashemian 
Date:   2016-06-01T20:48:33Z

KAFKA-3774: Make 'time' an optional argument of GetOffsetShell tool

Since the 'time' argument has a default value of -1, it makes sense to make 
it an optional argument.




> GetOffsetShell tool reports 'Missing required argument "[time]"' despite the 
> default
> 
>
> Key: KAFKA-3774
> URL: https://issues.apache.org/jira/browse/KAFKA-3774
> Project: Kafka
>  Issue Type: Bug
>  Components: tools
>Reporter: Vahid Hashemian
>Assignee: Vahid Hashemian
>Priority: Minor
>
> If the {{--time}} argument is not provided to the GetOffsetShell tool, even 
> though there is a default value of {{-1}}, the tool still reports
> {quote}
> {{Missing required argument "[time]"}}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)