[jira] [Commented] (KAFKA-801) Fix MessagesInPerSec mbean to count uncompressed message rate
[ https://issues.apache.org/jira/browse/KAFKA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601252#comment-13601252 ] Neha Narkhede commented on KAFKA-801: - +1. Minor simplification - Can we do the following instead of subtracting 1 and then adding 1 to compute the number of messages ? val numMessages = offsetCounter.get - firstOffset Fix MessagesInPerSec mbean to count uncompressed message rate - Key: KAFKA-801 URL: https://issues.apache.org/jira/browse/KAFKA-801 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: kafka-0.8, p2 Attachments: kafka-801.patch Today, BrokerTopicMetrics.MessagesInPerSec does shallow iteration and hence counts the number of compressed messages in every request. This does not make sense, we should count the number of uncompressed messages stored on the leader. Also, this metric makes sense only on the leader. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-801) Fix MessagesInPerSec mbean to count uncompressed message rate
[ https://issues.apache.org/jira/browse/KAFKA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601295#comment-13601295 ] Neha Narkhede commented on KAFKA-801: - Agree, I guess we can pass on that suggestion Fix MessagesInPerSec mbean to count uncompressed message rate - Key: KAFKA-801 URL: https://issues.apache.org/jira/browse/KAFKA-801 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: kafka-0.8, p2 Attachments: kafka-801.patch Today, BrokerTopicMetrics.MessagesInPerSec does shallow iteration and hence counts the number of compressed messages in every request. This does not make sense, we should count the number of uncompressed messages stored on the leader. Also, this metric makes sense only on the leader. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
