[GitHub] lucene-solr issue #215: SOLR-10123: Fix to better support numeric PointField...
Github user dennisgove commented on the issue: https://github.com/apache/lucene-solr/pull/215 This all looks good to me so far `%> ant precommit` passes `%> ant test` passes Houston is working on a new batch of tests that will specifically test the new analytics expression language. I'm going to wait until those are added (and checked) before merging this PR. @hossman, do you have any other concerns about this and/or possible ramifications of this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #215: SOLR-10123: Fix to better support numeric PointField...
Github user HoustonPutman commented on the issue: https://github.com/apache/lucene-solr/pull/215 If you are asking where in the component are they handled, it's in the ExpressionFactory.createField() method where Trie and Point fields are separated. If you are asking about the tests, they work with both Trie and Point fields. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #215: SOLR-10123: Fix to better support numeric PointField...
Github user dennisgove commented on the issue: https://github.com/apache/lucene-solr/pull/215 Where are point fields specifically handled, or do they not need to be specifically handled like other Trie fields? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org