[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[ https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646719#comment-16646719 ] Kamuela Lau edited comment on SOLR-12367 at 10/12/18 3:09 AM: -- A similar ClassCastException may show up for other LTRScoringModels such as NeuralNetworkModel (in particular, thinking of matrix/bias values for layers). The ambiguous message for CCE will only change for LinearModel as of right now. was (Author: kamulau): A similar ClassCastException may show up for other LTRScoringModels (such as entering an int/long in matrix, ), such as NeuralNetworkModel (in particular, thinking of matrix/bias values for layers). The ambiguous message for CCE will only change for LinearModel as of right now. > When adding a model referencing a non-existent feature the error message is > very ambiguous > -- > > Key: SOLR-12367 > URL: https://issues.apache.org/jira/browse/SOLR-12367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Affects Versions: 7.3.1 >Reporter: Georg Sorst >Priority: Minor > Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch > > > When adding a model that references a non-existent feature a very ambiguous > error message is thrown, something like "Model type does not exist > org.apache.solr.ltr.model.{{LinearModel}}". > > To reproduce, do not add any features and just add a model, for example by > doing this: > > {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store' > --data-binary '}} > { > {{ "class": "org.apache.solr.ltr.model.LinearModel",}} > {{ "name": "myModel",}} > {{ "features": [ \{"name": "whatever" }],}} > {{ "params": {"weights": {"whatever": 1.0 > {{}' -H 'Content-type:application/json'}} > > The resulting error message "Model type does not exist > {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me > a while to figure out the actual cause.}} > > A more suitable error message should probably indicate the name of the > missing feature that the model is trying to reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[ https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646719#comment-16646719 ] Kamuela Lau edited comment on SOLR-12367 at 10/11/18 4:26 PM: -- A similar ClassCastException may show up for other LTRScoringModels (such as entering an int/long in matrix, ), such as NeuralNetworkModel (in particular, thinking of matrix/bias values for layers). The ambiguous message for CCE will only change for LinearModel as of right now. was (Author: kamulau): A similar ClassCastException may show up for other LTRScoringModels (such as entering an int/long in matrix, ), such as NeuralNetworkModel (in particular, thinking of matrix/bias values for layers). Current patch will not change the ambiguous message for NeuralNetworkModel... > When adding a model referencing a non-existent feature the error message is > very ambiguous > -- > > Key: SOLR-12367 > URL: https://issues.apache.org/jira/browse/SOLR-12367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Affects Versions: 7.3.1 >Reporter: Georg Sorst >Priority: Minor > Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch > > > When adding a model that references a non-existent feature a very ambiguous > error message is thrown, something like "Model type does not exist > org.apache.solr.ltr.model.{{LinearModel}}". > > To reproduce, do not add any features and just add a model, for example by > doing this: > > {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store' > --data-binary '}} > { > {{ "class": "org.apache.solr.ltr.model.LinearModel",}} > {{ "name": "myModel",}} > {{ "features": [ \{"name": "whatever" }],}} > {{ "params": {"weights": {"whatever": 1.0 > {{}' -H 'Content-type:application/json'}} > > The resulting error message "Model type does not exist > {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me > a while to figure out the actual cause.}} > > A more suitable error message should probably indicate the name of the > missing feature that the model is trying to reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[ https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642833#comment-16642833 ] Kamuela Lau edited comment on SOLR-12367 at 10/9/18 6:09 AM: - The new patch moved the "weights" params check to LinearModel, instead of LTRScoringModel, as the weights param only exists for LinearModel, and is modified so tests will pass was (Author: kamulau): The new patch moved the "weights" params check to LinearModel, instead of LTRScoringModel, as the weights param only exists for LinearModel. > When adding a model referencing a non-existent feature the error message is > very ambiguous > -- > > Key: SOLR-12367 > URL: https://issues.apache.org/jira/browse/SOLR-12367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Affects Versions: 7.3.1 >Reporter: Georg Sorst >Priority: Minor > Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch > > > When adding a model that references a non-existent feature a very ambiguous > error message is thrown, something like "Model type does not exist > org.apache.solr.ltr.model.{{LinearModel}}". > > To reproduce, do not add any features and just add a model, for example by > doing this: > > {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store' > --data-binary '}} > { > {{ "class": "org.apache.solr.ltr.model.LinearModel",}} > {{ "name": "myModel",}} > {{ "features": [ \{"name": "whatever" }],}} > {{ "params": {"weights": {"whatever": 1.0 > {{}' -H 'Content-type:application/json'}} > > The resulting error message "Model type does not exist > {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me > a while to figure out the actual cause.}} > > A more suitable error message should probably indicate the name of the > missing feature that the model is trying to reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[ https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631637#comment-16631637 ] Kamuela Lau edited comment on SOLR-12367 at 9/28/18 9:54 AM: - I have attached a patch to address the issue in the description. The message will now say "org.apache.solr.ltr.model.ModelException: Features cannot be null; perhaps check for missing features". To reproduce, follow the same procedure as described in the description. For now, I have not dealt with the ClassCastException that shows up in the comment (i.e. upload features, then execute above) for casting a Long to a Double, however should this be deemed necessary, I can add that to the patch, or create another issue for it. This should also close 12676, and (maybe?) 12676. Any comments would be appreciated. was (Author: kamulau): I have attached a patch to address the issue in the description. The message will now say "org.apache.solr.ltr.model.ModelException: Features cannot be null; perhaps check for missing features". To reproduce, follow the same procedure as described in the description. For now, I have not dealt with the ClassCastException that shows up in the comment (i.e. upload features, then execute above) for casting a Long to a Double, however should this be deemed necessary, I can add that to the patch, or create another issue for it. Any comments would be appreciated. > When adding a model referencing a non-existent feature the error message is > very ambiguous > -- > > Key: SOLR-12367 > URL: https://issues.apache.org/jira/browse/SOLR-12367 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Affects Versions: 7.3.1 >Reporter: Georg Sorst >Priority: Minor > Attachments: SOLR-12367.patch > > > When adding a model that references a non-existent feature a very ambiguous > error message is thrown, something like "Model type does not exist > org.apache.solr.ltr.model.{{LinearModel}}". > > To reproduce, do not add any features and just add a model, for example by > doing this: > > {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store' > --data-binary '}} > { > {{ "class": "org.apache.solr.ltr.model.LinearModel",}} > {{ "name": "myModel",}} > {{ "features": [ \{"name": "whatever" }],}} > {{ "params": {"weights": {"whatever": 1.0 > {{}' -H 'Content-type:application/json'}} > > The resulting error message "Model type does not exist > {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me > a while to figure out the actual cause.}} > > A more suitable error message should probably indicate the name of the > missing feature that the model is trying to reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org