[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388736#comment-14388736 ] Paul Elschot commented on LUCENE-6308: -- My pleasure. I'll share the thanks with [~rcmuir], who provided the first changeapi patch. > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Fix For: Trunk, 5.2 > > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388276#comment-14388276 ] ASF subversion and git services commented on LUCENE-6308: - Commit 1670281 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1670281 ] LUCENE-6308: fix test bug > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Fix For: Trunk, 5.2 > > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388271#comment-14388271 ] ASF subversion and git services commented on LUCENE-6308: - Commit 1670279 from [~mikemccand] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670279 ] LUCENE-6308: woops: revert > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Fix For: Trunk, 5.2 > > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388274#comment-14388274 ] ASF subversion and git services commented on LUCENE-6308: - Commit 1670280 from [~mikemccand] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670280 ] LUCENE-6308: fix test bug > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Fix For: Trunk, 5.2 > > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388270#comment-14388270 ] ASF subversion and git services commented on LUCENE-6308: - Commit 1670278 from [~mikemccand] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670278 ] LUCENE-6308: fix test bug > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Fix For: Trunk, 5.2 > > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388253#comment-14388253 ] ASF subversion and git services commented on LUCENE-6308: - Commit 1670273 from [~mikemccand] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670273 ] LUCENE-6308: cutover Spans to DISI, reuse ConjunctionDISI, use two-phased iteration > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388232#comment-14388232 ] ASF subversion and git services commented on LUCENE-6308: - Commit 1670272 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1670272 ] LUCENE-6308: cutover Spans to DISI, reuse ConjunctionDISI, use two-phased iteration > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386902#comment-14386902 ] Adrien Grand commented on LUCENE-6308: -- [~dsmiley] You are right that spans should propagate two-phase approximations so that they can be used when intersected with another query (eg. a boolean FILTER clause). I believe LUCENE-6373 has been open for that reason, maybe we should be more explicit about the remaining work that we need to do. As far as I am concerned, I'm very happy to see spans becoming lazy, which was imo the greatest challenge to get two-phase iteration working on spans. > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386629#comment-14386629 ] David Smiley commented on LUCENE-6308: -- +1 to commit, thanks Paul! [~jpountz] would you mind commenting on my example above -- right below where I mentioned you to get your input? > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386389#comment-14386389 ] Adrien Grand commented on LUCENE-6308: -- +1 to commit > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386317#comment-14386317 ] Michael McCandless commented on LUCENE-6308: If there are no objections, I'll commit this in a day or two ... thanks [~paul.elsc...@xs4all.nl]! > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6308) Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans
[ https://issues.apache.org/jira/browse/LUCENE-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386058#comment-14386058 ] Michael McCandless commented on LUCENE-6308: Thanks [~paul.elsc...@xs4all.nl] patch looks great, +1 to commit... > Spans to extend DocIdSetIterator; was: SpansEnum, deprecate Spans > - > > Key: LUCENE-6308 > URL: https://issues.apache.org/jira/browse/LUCENE-6308 > Project: Lucene - Core > Issue Type: Bug > Components: core/search >Affects Versions: Trunk >Reporter: Paul Elschot >Priority: Minor > Attachments: LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308-changeapi.patch, > LUCENE-6308-changeapi.patch, LUCENE-6308.patch, LUCENE-6308.patch, > LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch, LUCENE-6308.patch > > > An alternative for Spans that looks more like PositionsEnum and adds two > phase doc id iteration -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org