RE: maven-new tests failing
On Wed, 2003-05-28 at 08:54, Paulo Silveira wrote: > > It is and I think Paulo even whipped up a patch for it. I > > explained to him how to fix it in IRC because I don't have > > time to fix it as I'm about to head off to boston. An > > absolute path will allow the tests to pass for now or you can > > fix the interpolation in ArtifactFactory::getMaveRepoLocal. I'm off. > > I am sendig them again. One for mavenRepoLocal, we interpolate it before > the factory creates > all the artifacts. > > The second one if for the mavenRemoteRepositories strings. same thing, > but at the downloader. > > give it a look. they make the tests run. We should localize that interpolation and you should mention that on the lists. Michal had a thought about localizing them. Anyway, I'm off to Boston and will be away for a couple of days. > Paulo > > > > > > > Michal > > > > > > > -Original Message- > > > > From: Rafal Krzewski [mailto:[EMAIL PROTECTED] > > > > Sent: Wednesday, May 28, 2003 12:05 PM > > > > To: Maven Developers List > > > > Subject: Re: maven-new tests failing > > > > > > > > > > > > Ben Walding wrote: > > > > > This stuff is in so much flux that I'd expect tests to > > fail on a > > > > > regular basis. That being said, attaching the output of test > > > > > results would be a good start. > > target/test-reports/whichever ones > > > > > failed > > > > > > > > Ha! Didn't know about that one... (I'm not using Junit in > > my project > > > > yet, tests are cool when you have them already :-() > > > > > > > > Here you go... > > > > > > > > R. > > > > > > > > > > > > > > > > > > > - > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > -- > > jvz. > > > > Jason van Zyl > > [EMAIL PROTECTED] > > http://tambora.zenplex.org > > > > In short, man creates for himself a new religion of a > > rational and technical order to justify his work and to be > > justified in it. > > > > -- Jacques Ellul, The Technological Society > > > > > > - > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > __ > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] -- jvz. Jason van Zyl [EMAIL PROTECTED] http://tambora.zenplex.org In short, man creates for himself a new religion of a rational and technical order to justify his work and to be justified in it. -- Jacques Ellul, The Technological Society - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: maven-new tests failing
> It is and I think Paulo even whipped up a patch for it. I
> explained to him how to fix it in IRC because I don't have
> time to fix it as I'm about to head off to boston. An
> absolute path will allow the tests to pass for now or you can
> fix the interpolation in ArtifactFactory::getMaveRepoLocal. I'm off.
I am sendig them again. One for mavenRepoLocal, we interpolate it before
the factory creates
all the artifacts.
The second one if for the mavenRemoteRepositories strings. same thing,
but at the downloader.
give it a look. they make the tests run.
Paulo
>
> > Michal
> >
> > > -Original Message-
> > > From: Rafal Krzewski [mailto:[EMAIL PROTECTED]
> > > Sent: Wednesday, May 28, 2003 12:05 PM
> > > To: Maven Developers List
> > > Subject: Re: maven-new tests failing
> > >
> > >
> > > Ben Walding wrote:
> > > > This stuff is in so much flux that I'd expect tests to
> fail on a
> > > > regular basis. That being said, attaching the output of test
> > > > results would be a good start.
> target/test-reports/whichever ones
> > > > failed
> > >
> > > Ha! Didn't know about that one... (I'm not using Junit in
> my project
> > > yet, tests are cool when you have them already :-()
> > >
> > > Here you go...
> > >
> > > R.
> > >
> > >
> >
> >
> >
> -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> --
> jvz.
>
> Jason van Zyl
> [EMAIL PROTECTED]
> http://tambora.zenplex.org
>
> In short, man creates for himself a new religion of a
> rational and technical order to justify his work and to be
> justified in it.
>
> -- Jacques Ellul, The Technological Society
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
Index: DefaultArtifactDownloader.java
===
RCS file:
/home/cvspublic/maven-new/core/src/java/org/apache/maven/artifact/download/DefaultArtifactDownloader.java,v
retrieving revision 1.3
diff -u -r1.3 DefaultArtifactDownloader.java
--- DefaultArtifactDownloader.java 25 May 2003 19:04:50 - 1.3
+++ DefaultArtifactDownloader.java 27 May 2003 02:43:16 -
@@ -57,19 +57,18 @@
*/
+import java.io.FileNotFoundException;
+import java.util.Iterator;
+
import org.apache.avalon.framework.configuration.Configurable;
import org.apache.avalon.framework.configuration.Configuration;
import org.apache.avalon.framework.configuration.ConfigurationException;
import org.apache.commons.lang.StringUtils;
+import org.apache.maven.artifact.Artifact;
import org.apache.maven.project.Project;
import org.apache.maven.util.HttpUtils;
-import org.apache.maven.artifact.download.ArtifactDownloader;
-import org.apache.maven.artifact.Artifact;
import org.apache.plexus.logging.AbstractLogEnabled;
-import java.io.FileNotFoundException;
-import java.util.Iterator;
-
/**
* Class resposible to download [EMAIL PROTECTED] org.apache.maven.artifact.Artifact}
from
* remote repository (repositories) to local repository
@@ -110,6 +109,7 @@
for ( Iterator i = project.getMavenRepoRemote().iterator(); i.hasNext(); )
{
String remoteRepo = (String) i.next();
+remoteRepo = org.apache.plexus.util.StringUtils.interpolate( remoteRepo,
project.getProperties() );
// The username and password parameters are not being
// used here. Those are the "" parameters you see below.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: maven-new tests failing
On Wed, 2003-05-28 at 06:24, Michal Maczka wrote:
> My repository path does not start with ${maven.home}...so this problem did
> not show up.
>
> I have something like:
>
> /repository
> /maven
>
> It seems like interpolation problem.
It is and I think Paulo even whipped up a patch for it. I explained to
him how to fix it in IRC because I don't have time to fix it as I'm
about to head off to boston. An absolute path will allow the tests to
pass for now or you can fix the interpolation in
ArtifactFactory::getMaveRepoLocal. I'm off.
> Michal
>
> > -Original Message-
> > From: Rafal Krzewski [mailto:[EMAIL PROTECTED]
> > Sent: Wednesday, May 28, 2003 12:05 PM
> > To: Maven Developers List
> > Subject: Re: maven-new tests failing
> >
> >
> > Ben Walding wrote:
> > > This stuff is in so much flux that I'd expect tests to fail on a regular
> > > basis. That being said, attaching the output of test results would be a
> > > good start.
> > > target/test-reports/whichever ones failed
> >
> > Ha! Didn't know about that one... (I'm not using Junit in my project
> > yet, tests are cool when you have them already :-()
> >
> > Here you go...
> >
> > R.
> >
> >
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
jvz.
Jason van Zyl
[EMAIL PROTECTED]
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: maven-new tests failing
Michal Maczka wrote:
> My repository path does not start with ${maven.home}...so this problem did
> not show up.
>
> I have something like:
>
> /repository
> /maven
>
> It seems like interpolation problem.
I have a question: What is the proper way of building maven-new?
It is not self hosting AFAICT, therefore it needs live Maven-b10-dev to
be built, am I right?
This is my setup:
/usr/local/maven directory is writable to me, and MAVEN_HOME env var
is set up, pointing to that directory.
I go to projects/maven, bootstrap it, and then go to projects/maven-new
and run 'maven' (which runns Maven-b10-dev).
Is this the right way, or am I messing somehting up?
R.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: maven-new tests failing
My repository path does not start with ${maven.home}...so this problem did
not show up.
I have something like:
/repository
/maven
It seems like interpolation problem.
Michal
> -Original Message-
> From: Rafal Krzewski [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, May 28, 2003 12:05 PM
> To: Maven Developers List
> Subject: Re: maven-new tests failing
>
>
> Ben Walding wrote:
> > This stuff is in so much flux that I'd expect tests to fail on a regular
> > basis. That being said, attaching the output of test results would be a
> > good start.
> > target/test-reports/whichever ones failed
>
> Ha! Didn't know about that one... (I'm not using Junit in my project
> yet, tests are cool when you have them already :-()
>
> Here you go...
>
> R.
>
>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: maven-new tests failing
Ben Walding wrote:
> This stuff is in so much flux that I'd expect tests to fail on a regular
> basis. That being said, attaching the output of test results would be a
> good start.
> target/test-reports/whichever ones failed
Ha! Didn't know about that one... (I'm not using Junit in my project
yet, tests are cool when you have them already :-()
Here you go...
R.
Testsuite: org.apache.maven.artifact.factory.DefaultArtifactFactoryTest
Tests run: 3, Failures: 3, Errors: 0, Time elapsed: 1.308 sec
Testcase: testCreateArtifacts took 0.835 sec
FAILED
Artifact file has been set incorrectly.
expected:<${maven.home}/repository/g1/jars/d1-1.0.jar> but
was:
junit.framework.AssertionFailedError: Artifact file has been set incorrectly.
expected:<${maven.home}/repository/g1/jars/d1-1.0.jar> but
was:
at
org.apache.maven.artifact.factory.DefaultArtifactFactoryTest.testCreateArtifacts(DefaultArtifactFactoryTest.java:156)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:231)
at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:88)
at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:116)
at com.werken.werkz.Goal.fire(Goal.java:639)
at com.werken.werkz.Goal.attain(Goal.java:575)
at com.werken.werkz.Goal.attainPrecursors(Goal.java:488)
at com.werken.werkz.Goal.attain(Goal.java:573)
at com.werken.werkz.Goal.attainPrecursors(Goal.java:488)
at com.werken.werkz.Goal.attain(Goal.java:573)
at org.apache.maven.plugin.PluginManager.attainGoals(PluginManager.java:434)
at org.apache.maven.MavenSession.attainGoals(MavenSession.java:369)
at org.apache.maven.jelly.tags.maven.ReactorTag.doTag(ReactorTag.java:374)
at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:116)
at com.werken.werkz.Goal.fire(Goal.java:639)
at com.werken.werkz.Goal.attain(Goal.java:575)
at com.werken.werkz.WerkzProject.attainGoal(WerkzProject.java:193)
at com.werken.werkz.jelly.AttainGoalTag.doTag(AttainGoalTag.java:134)
at
org.apache.maven.jelly.tags.werkz.LazyAttainGoalTag.doTag(LazyAttainGoalTag.java:107)
at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135)
at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233)
at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:116)
at com.werken.werkz.Goal.fire(Goal.java:639)
at com.werken.werkz.Goal.attain(Goal.java:575)
at org.apache.maven.plugin.PluginManager.attainGoals(PluginManager.java:434)
at org.apache.maven.MavenSession.attainGoals(MavenSession.java:357)
at org.apache.maven.cli.App.doMain(App.java:525)
at org.apache.maven.cli.App.main(App.java:1088)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at com.werken.forehead.Forehead.run(Forehead.java:543)
at com.werken.forehead.Forehead.main(Forehead.java:573)
Testcase: testCreateArtifactsTestcase: testArtifactOverrding took 0.251 sec
FAILED
File overriding in POM: Artifact file has been set incorrectly.
expected:<${maven.home}/repository/g1/jars/lutefisk.fish> but
was:
junit.framework.AssertionFailedError: File overriding in POM: Artifact file has been
set incorrectly. expected:<${maven.home}/repository/g1/jars/lutefisk.fish> but
was:
at
org.apache.maven.artifact.factory.DefaultArtifactFactoryTest.doTestArtifact(DefaultArtifactFactoryTest.java:253)
at
org.apache.maven.artifact.factory.DefaultArtifactFactoryTest.testArtifactOverrding(DefaultArtifactFactoryTest.java:178)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorI
Re: maven-new tests failing
This stuff is in so much flux that I'd expect tests to fail on a regular
basis. That being said, attaching the output of test results would be a
good start.
target/test-reports/whichever ones failed
Rafal Krzewski wrote:
I tried to build maven-new and I got this:
[junit] Running
org.apache.maven.artifact.factory.DefaultArtifactFactoryTest
maven.repo.local = ${maven.home}/repository
artifact factory : mavenRepoLocal = ${maven.home}/repository
artifact factory : mavenRepoLocal = ${maven.home}/repository
maven.repo.local = ${maven.home}/repository
artifact factory : mavenRepoLocal = ${maven.home}/repository
artifact factory : mavenRepoLocal = ${maven.home}/repository
maven.repo.local = ${maven.home}/repository
artifact factory : mavenRepoLocal = ${maven.home}/repository
artifact factory : mavenRepoLocal = ${maven.home}/repository
[junit] Tests run: 3, Failures: 3, Errors: 0, Time elapsed: 1.447 sec
[junit] [ERROR] TEST
org.apache.maven.artifact.factory.DefaultArtifactFactoryTest FAILED
The other tests in cli and core went OK. Is this supposed to fail ATM,
or did I step on a legitimate bug? I'd be happy to help if this
is something specific to my system (linux+jdk 1.4.1_01).
R.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
