Re: Javadoc Plugin release
Thanks Robert! On Thu, 12 Mar 2020 at 04:21, Robert Scholte wrote: > The master of maven-javadoc-plugin on the ASF Jenkins is fixed. > Root cause was a change to the settings.xml of the Maven installation. > I'd asked INFRA to add a mirror for central to the https connection for > all Maven installations before 3.2.3 > By accident 3.2.5 on Ubuntu was patched as well. > With the revert of this change the build is back to green. > > Hence ready to be released. > > Robert > > On 11-3-2020 12:49:47, Elliotte Rusty Harold wrote: > On Wed, Mar 11, 2020 at 7:16 AM Olivier Lamy wrote: > > > > failures, which lets much more serious bugs creep in unnoticed. > > > > > > > ok no worries. > > So do you want to be volunteer try to understand the problem on this node > > and fix the problem with ASF infra folks? > > > > Robert already said he was working on that. But just to be really > clear, if nobody steps up to do that, the plugin should not be > released. A passing build is not optional. > > When the build is red (or yellow), it's a hard stop on all commits and > releases until that's fixed. I do wish Jenkins didn't distinguish red > and yellow, and I really think we should figure out how to hook the > Jenkins results directly into Github to avoid bad merges on yellow > like the ones I committed last week; but we can still agree that a red > build is blocker. > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Javadoc Plugin release
The master of maven-javadoc-plugin on the ASF Jenkins is fixed. Root cause was a change to the settings.xml of the Maven installation. I'd asked INFRA to add a mirror for central to the https connection for all Maven installations before 3.2.3 By accident 3.2.5 on Ubuntu was patched as well. With the revert of this change the build is back to green. Hence ready to be released. Robert On 11-3-2020 12:49:47, Elliotte Rusty Harold wrote: On Wed, Mar 11, 2020 at 7:16 AM Olivier Lamy wrote: > > failures, which lets much more serious bugs creep in unnoticed. > > > > ok no worries. > So do you want to be volunteer try to understand the problem on this node > and fix the problem with ASF infra folks? > Robert already said he was working on that. But just to be really clear, if nobody steps up to do that, the plugin should not be released. A passing build is not optional. When the build is red (or yellow), it's a hard stop on all commits and releases until that's fixed. I do wish Jenkins didn't distinguish red and yellow, and I really think we should figure out how to hook the Jenkins results directly into Github to avoid bad merges on yellow like the ones I committed last week; but we can still agree that a red build is blocker. -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
On Wed, Mar 11, 2020 at 7:16 AM Olivier Lamy wrote: > > failures, which lets much more serious bugs creep in unnoticed. > > > > ok no worries. > So do you want to be volunteer try to understand the problem on this node > and fix the problem with ASF infra folks? > Robert already said he was working on that. But just to be really clear, if nobody steps up to do that, the plugin should not be released. A passing build is not optional. When the build is red (or yellow), it's a hard stop on all commits and releases until that's fixed. I do wish Jenkins didn't distinguish red and yellow, and I really think we should figure out how to hook the Jenkins results directly into Github to avoid bad merges on yellow like the ones I committed last week; but we can still agree that a red build is blocker. -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
On Wed, 11 Mar 2020 at 21:07, Elliotte Rusty Harold wrote: > On Tue, Mar 10, 2020 at 7:56 PM Olivier Lamy wrote: > > > > Thanks Robert > > Anyway as the build only fail for jdk7 with mvn 3.2.5 on a particular > node > > of the asf machines. > > I build that perfectly with same jdk/mvn > > So we cannot really consider this as blocker... > > > > I absolutely do consider that a blocker. Even if it's something as > idiosyncratic as we need to turn one build machine off and on again, > this needs to be repaired before a release. Even when the failure mode > is not a true bug, a failing build trains developers to ignore > failures, which lets much more serious bugs creep in unnoticed. > ok no worries. So do you want to be volunteer try to understand the problem on this node and fix the problem with ASF infra folks? > > If you disable one failing test because of a build machine issue, what > happens when that test starts failing everywhere because of an > unrelated change? > I do not disable any test. I'm just saying only one build of the matrix fail (jdk7/mvn 3.2.5) The same test works on every other part of the matrix. And as I said I used the exactly same combination and it works > > I've been there before and it's not pretty. Reliable, non-flaky test > suites are critical for software development. CI systems should be as > automatic as possible, and should not be routed around. > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Javadoc Plugin release
On Tue, Mar 10, 2020 at 7:56 PM Olivier Lamy wrote: > > Thanks Robert > Anyway as the build only fail for jdk7 with mvn 3.2.5 on a particular node > of the asf machines. > I build that perfectly with same jdk/mvn > So we cannot really consider this as blocker... > I absolutely do consider that a blocker. Even if it's something as idiosyncratic as we need to turn one build machine off and on again, this needs to be repaired before a release. Even when the failure mode is not a true bug, a failing build trains developers to ignore failures, which lets much more serious bugs creep in unnoticed. If you disable one failing test because of a build machine issue, what happens when that test starts failing everywhere because of an unrelated change? I've been there before and it's not pretty. Reliable, non-flaky test suites are critical for software development. CI systems should be as automatic as possible, and should not be routed around. -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
On Wed, Mar 11, 2020 at 4:51 AM Olivier Lamy wrote: > Do we really want to use OracleJdk as a source of truth??? > For Java 7, probably not, at least unless we can switch to a later patch release. I'm hitting an unrelated issue in the maven-changes-plugin that stems from TLS 1.2 on the old Oracle JDK 7 we're using. Is there any chance we can switch to the Zulu build from Azul? Or some other more recent OpenJDK 7 build? https://www.azul.com/downloads/zulu-community/?&architecture=x86-64-bit&package=jdk For Java 8 and later it probably is important to include the Oracle JDKs in the matrix, since that's by far the most common VM our customers will be using. -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
this branch should be fixed now as well It was failing on Jenkins ASF as again we hit a bug fixed in OpenJdk but not reported in OracleJdk... (I simply disabled the test) We are back to the famous "It works on my machine" :) Do we really want to use OracleJdk as a source of truth??? On Wed, 11 Mar 2020 at 18:19, Olivier Lamy wrote: > ok the branch MJAVADOC-610 has been created from a old master some code > was missing especially some fixes regarding it test (guava apidocs > relocation for MJAVADOC-555_link..) > > On Wed, 11 Mar 2020 at 09:56, Olivier Lamy wrote: > >> Thanks Robert >> Anyway as the build only fail for jdk7 with mvn 3.2.5 on a particular >> node of the asf machines. >> I build that perfectly with same jdk/mvn >> So we cannot really consider this as blocker... >> >> >> On Wed, 11 Mar 2020 at 05:14, Robert Scholte >> wrote: >> >>> I think I found the root cause. Give me some time to fix this with INFRA >>> On 10-3-2020 12:23:34, Elliotte Rusty Harold wrote: >>> This is from Jenkins: >>> >>> [INFO] - >>> [INFO] Build Summary: >>> [INFO] Passed: 51, Failed: 1, Errors: 0, Skipped: 18 >>> [INFO] - >>> [ERROR] The following builds failed: >>> [ERROR] * MJAVADOC-338_downloadSources/pom.xml >>> [INFO] - >>> [INFO] >>> >>> [INFO] BUILD FAILURE >>> [INFO] >>> >>> [INFO] Total time: 16:41 min >>> [INFO] Finished at: 2020-03-10T00:33:17+00:00 >>> [INFO] Final Memory: 61M/1685M >>> [INFO] >>> >>> [INFO] [jenkins-event-spy] Generated >>> /home/jenkins/jenkins-slave/workspace/_box_maven-javadoc-plugin_master@2 >>> @tmp/withMaven3b7359f7/maven-spy-20200310-001635-6314901836286016347811.log >>> [ERROR] Failed to execute goal >>> org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify >>> (integration-test) on project maven-javadoc-plugin: 1 build failed. >>> See console output above for details. -> [Help 1] >>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to >>> execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify >>> (integration-test) on project maven-javadoc-plugin: 1 build failed. >>> See console output above for details. >>> at >>> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) >>> at >>> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) >>> at or >>> >>> On Tue, Mar 10, 2020 at 7:20 AM Elliotte Rusty Harold >>> wrote: >>> > >>> > I'll see if I can dig up some more logs on this. In the meantime as >>> > Robert pointed out, the CI for this plugin is broken/red: >>> > >>> > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ >>> > >>> > IMHO, getting that to blue is a prerequisite for a release. This >>> > plugin is not currently in a releasable state.. I am (non-binding) -1 >>> > on this release. >>> > >>> > On Mon, Mar 9, 2020 at 11:15 PM Olivier Lamy wrote: >>> > > >>> > > Hi >>> > > The stack trace is truncated in your email. >>> > > Can you paste the logs to a gist so I can try looking at it. >>> > > There are some old flaky tests relying on having an internet >>> connection. >>> > > But I don't want to fix this now.. >>> > > Actually I need a release for the jetty project which is a bit >>> stucked to >>> > > release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM >>> because >>> > > of some bugs here. >>> > > >>> > > >>> > > On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold >>> > > wrote: >>> > > >>> > > > I see two test failures locally: >>> > > > >>> > > > [ERROR] Failures: >>> > > > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 >>> > > > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly >>> > > > newline for string parameters. See options and packages files. >>> > > > [ERROR] Errors: >>> > > > [ERROR] >>> > > > >>> FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 >>> > > > » NullPointer >>> > > > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution >>> > > > MavenReportException: Erro... >>> > > > [ERROR] >>> > > > >>> JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 >>> > > > » MojoExecution >>> > > > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution >>> > > > MavenReportException: Er... >>> > > > [ERROR] JavadocReportTest.testCustomConfiguration:396 » >>> > > > MojoExecution An error has occ... >>> > > > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » >>> > > > MojoExecution An error has oc... >>> > > > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error >>> > > > has occurred in Ja... >>> > > > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error >>> > > > has o
Re: Javadoc Plugin release
ok the branch MJAVADOC-610 has been created from a old master some code was missing especially some fixes regarding it test (guava apidocs relocation for MJAVADOC-555_link..) On Wed, 11 Mar 2020 at 09:56, Olivier Lamy wrote: > Thanks Robert > Anyway as the build only fail for jdk7 with mvn 3.2.5 on a particular node > of the asf machines. > I build that perfectly with same jdk/mvn > So we cannot really consider this as blocker... > > > On Wed, 11 Mar 2020 at 05:14, Robert Scholte wrote: > >> I think I found the root cause. Give me some time to fix this with INFRA >> On 10-3-2020 12:23:34, Elliotte Rusty Harold wrote: >> This is from Jenkins: >> >> [INFO] - >> [INFO] Build Summary: >> [INFO] Passed: 51, Failed: 1, Errors: 0, Skipped: 18 >> [INFO] - >> [ERROR] The following builds failed: >> [ERROR] * MJAVADOC-338_downloadSources/pom.xml >> [INFO] - >> [INFO] >> >> [INFO] BUILD FAILURE >> [INFO] >> >> [INFO] Total time: 16:41 min >> [INFO] Finished at: 2020-03-10T00:33:17+00:00 >> [INFO] Final Memory: 61M/1685M >> [INFO] >> >> [INFO] [jenkins-event-spy] Generated >> /home/jenkins/jenkins-slave/workspace/_box_maven-javadoc-plugin_master@2 >> @tmp/withMaven3b7359f7/maven-spy-20200310-001635-6314901836286016347811.log >> [ERROR] Failed to execute goal >> org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify >> (integration-test) on project maven-javadoc-plugin: 1 build failed. >> See console output above for details. -> [Help 1] >> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to >> execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify >> (integration-test) on project maven-javadoc-plugin: 1 build failed. >> See console output above for details. >> at >> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) >> at >> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) >> at or >> >> On Tue, Mar 10, 2020 at 7:20 AM Elliotte Rusty Harold >> wrote: >> > >> > I'll see if I can dig up some more logs on this. In the meantime as >> > Robert pointed out, the CI for this plugin is broken/red: >> > >> > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ >> > >> > IMHO, getting that to blue is a prerequisite for a release. This >> > plugin is not currently in a releasable state.. I am (non-binding) -1 >> > on this release. >> > >> > On Mon, Mar 9, 2020 at 11:15 PM Olivier Lamy wrote: >> > > >> > > Hi >> > > The stack trace is truncated in your email. >> > > Can you paste the logs to a gist so I can try looking at it. >> > > There are some old flaky tests relying on having an internet >> connection. >> > > But I don't want to fix this now.. >> > > Actually I need a release for the jetty project which is a bit >> stucked to >> > > release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM >> because >> > > of some bugs here. >> > > >> > > >> > > On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold >> > > wrote: >> > > >> > > > I see two test failures locally: >> > > > >> > > > [ERROR] Failures: >> > > > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 >> > > > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly >> > > > newline for string parameters. See options and packages files. >> > > > [ERROR] Errors: >> > > > [ERROR] >> > > > >> FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 >> > > > » NullPointer >> > > > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution >> > > > MavenReportException: Erro... >> > > > [ERROR] >> > > > >> JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 >> > > > » MojoExecution >> > > > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution >> > > > MavenReportException: Er... >> > > > [ERROR] JavadocReportTest.testCustomConfiguration:396 » >> > > > MojoExecution An error has occ... >> > > > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » >> > > > MojoExecution An error has oc... >> > > > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error >> > > > has occurred in Ja... >> > > > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error >> > > > has occurred in Jav... >> > > > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » >> > > > MojoExecution An error has o... >> > > > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An >> > > > error has occurred in ... >> > > > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An >> > > > error has occurre... >> > > > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An >> > > > error has occurred in... >> > >
Re: Javadoc Plugin release
Thanks Robert Anyway as the build only fail for jdk7 with mvn 3.2.5 on a particular node of the asf machines. I build that perfectly with same jdk/mvn So we cannot really consider this as blocker... On Wed, 11 Mar 2020 at 05:14, Robert Scholte wrote: > I think I found the root cause. Give me some time to fix this with INFRA > On 10-3-2020 12:23:34, Elliotte Rusty Harold wrote: > This is from Jenkins: > > [INFO] - > [INFO] Build Summary: > [INFO] Passed: 51, Failed: 1, Errors: 0, Skipped: 18 > [INFO] - > [ERROR] The following builds failed: > [ERROR] * MJAVADOC-338_downloadSources/pom.xml > [INFO] - > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 16:41 min > [INFO] Finished at: 2020-03-10T00:33:17+00:00 > [INFO] Final Memory: 61M/1685M > [INFO] > > [INFO] [jenkins-event-spy] Generated > /home/jenkins/jenkins-slave/workspace/_box_maven-javadoc-plugin_master@2 > @tmp/withMaven3b7359f7/maven-spy-20200310-001635-6314901836286016347811.log > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify > (integration-test) on project maven-javadoc-plugin: 1 build failed. > See console output above for details. -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to > execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify > (integration-test) on project maven-javadoc-plugin: 1 build failed. > See console output above for details. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at or > > On Tue, Mar 10, 2020 at 7:20 AM Elliotte Rusty Harold > wrote: > > > > I'll see if I can dig up some more logs on this. In the meantime as > > Robert pointed out, the CI for this plugin is broken/red: > > > > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ > > > > IMHO, getting that to blue is a prerequisite for a release. This > > plugin is not currently in a releasable state.. I am (non-binding) -1 > > on this release. > > > > On Mon, Mar 9, 2020 at 11:15 PM Olivier Lamy wrote: > > > > > > Hi > > > The stack trace is truncated in your email. > > > Can you paste the logs to a gist so I can try looking at it. > > > There are some old flaky tests relying on having an internet > connection. > > > But I don't want to fix this now.. > > > Actually I need a release for the jetty project which is a bit stucked > to > > > release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM > because > > > of some bugs here. > > > > > > > > > On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold > > > wrote: > > > > > > > I see two test failures locally: > > > > > > > > [ERROR] Failures: > > > > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 > > > > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly > > > > newline for string parameters. See options and packages files. > > > > [ERROR] Errors: > > > > [ERROR] > > > > > FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 > > > > » NullPointer > > > > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution > > > > MavenReportException: Erro... > > > > [ERROR] > > > > JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 > > > > » MojoExecution > > > > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution > > > > MavenReportException: Er... > > > > [ERROR] JavadocReportTest.testCustomConfiguration:396 » > > > > MojoExecution An error has occ... > > > > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » > > > > MojoExecution An error has oc... > > > > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error > > > > has occurred in Ja... > > > > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error > > > > has occurred in Jav... > > > > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » > > > > MojoExecution An error has o... > > > > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An > > > > error has occurred in ... > > > > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An > > > > error has occurre... > > > > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An > > > > error has occurred in... > > > > [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An > > > > error has occurred ... > > > > [INFO] > > > > [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 > > > > > > > > > > > > On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > > > > > > > > > Hi > > > > > I'd like to make a javadoc plugin release. > > > > > 2 iss
Re: Javadoc Plugin release
I think I found the root cause. Give me some time to fix this with INFRA On 10-3-2020 12:23:34, Elliotte Rusty Harold wrote: This is from Jenkins: [INFO] - [INFO] Build Summary: [INFO] Passed: 51, Failed: 1, Errors: 0, Skipped: 18 [INFO] - [ERROR] The following builds failed: [ERROR] * MJAVADOC-338_downloadSources/pom.xml [INFO] - [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 16:41 min [INFO] Finished at: 2020-03-10T00:33:17+00:00 [INFO] Final Memory: 61M/1685M [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-slave/workspace/_box_maven-javadoc-plugin_master@2@tmp/withMaven3b7359f7/maven-spy-20200310-001635-6314901836286016347811.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify (integration-test) on project maven-javadoc-plugin: 1 build failed. See console output above for details. -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify (integration-test) on project maven-javadoc-plugin: 1 build failed. See console output above for details. at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at or On Tue, Mar 10, 2020 at 7:20 AM Elliotte Rusty Harold wrote: > > I'll see if I can dig up some more logs on this. In the meantime as > Robert pointed out, the CI for this plugin is broken/red: > > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ > > IMHO, getting that to blue is a prerequisite for a release. This > plugin is not currently in a releasable state.. I am (non-binding) -1 > on this release. > > On Mon, Mar 9, 2020 at 11:15 PM Olivier Lamy wrote: > > > > Hi > > The stack trace is truncated in your email. > > Can you paste the logs to a gist so I can try looking at it. > > There are some old flaky tests relying on having an internet connection. > > But I don't want to fix this now.. > > Actually I need a release for the jetty project which is a bit stucked to > > release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM because > > of some bugs here. > > > > > > On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold > > wrote: > > > > > I see two test failures locally: > > > > > > [ERROR] Failures: > > > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 > > > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly > > > newline for string parameters. See options and packages files. > > > [ERROR] Errors: > > > [ERROR] > > > FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 > > > » NullPointer > > > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution > > > MavenReportException: Erro... > > > [ERROR] > > > JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 > > > » MojoExecution > > > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution > > > MavenReportException: Er... > > > [ERROR] JavadocReportTest.testCustomConfiguration:396 » > > > MojoExecution An error has occ... > > > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » > > > MojoExecution An error has oc... > > > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error > > > has occurred in Ja... > > > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error > > > has occurred in Jav... > > > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » > > > MojoExecution An error has o... > > > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An > > > error has occurred in ... > > > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An > > > error has occurre... > > > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An > > > error has occurred in... > > > [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An > > > error has occurred ... > > > [INFO] > > > [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 > > > > > > > > > On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > > > > > > > Hi > > > > I'd like to make a javadoc plugin release. > > > > 2 issues left ATM but I can move them to next version. > > > > > > > > Cheers > > > > -- > > > > Olivier > > > > > > > > > > > > -- > > > Elliotte Rusty Harold > > > elh...@ibiblio.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > -- > > Olivier Lamy > > http://twitter.com/olamy | http://linkedin.com/i
Re: Javadoc Plugin release
This is from Jenkins: [INFO] - [INFO] Build Summary: [INFO] Passed: 51, Failed: 1, Errors: 0, Skipped: 18 [INFO] - [ERROR] The following builds failed: [ERROR] * MJAVADOC-338_downloadSources/pom.xml [INFO] - [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 16:41 min [INFO] Finished at: 2020-03-10T00:33:17+00:00 [INFO] Final Memory: 61M/1685M [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-slave/workspace/_box_maven-javadoc-plugin_master@2@tmp/withMaven3b7359f7/maven-spy-20200310-001635-6314901836286016347811.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify (integration-test) on project maven-javadoc-plugin: 1 build failed. See console output above for details. -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.1:verify (integration-test) on project maven-javadoc-plugin: 1 build failed. See console output above for details. at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at or On Tue, Mar 10, 2020 at 7:20 AM Elliotte Rusty Harold wrote: > > I'll see if I can dig up some more logs on this. In the meantime as > Robert pointed out, the CI for this plugin is broken/red: > > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ > > IMHO, getting that to blue is a prerequisite for a release. This > plugin is not currently in a releasable state.. I am (non-binding) -1 > on this release. > > On Mon, Mar 9, 2020 at 11:15 PM Olivier Lamy wrote: > > > > Hi > > The stack trace is truncated in your email. > > Can you paste the logs to a gist so I can try looking at it. > > There are some old flaky tests relying on having an internet connection. > > But I don't want to fix this now.. > > Actually I need a release for the jetty project which is a bit stucked to > > release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM because > > of some bugs here. > > > > > > On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold > > wrote: > > > > > I see two test failures locally: > > > > > > [ERROR] Failures: > > > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 > > > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly > > > newline for string parameters. See options and packages files. > > > [ERROR] Errors: > > > [ERROR] > > > > > > FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 > > > » NullPointer > > > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution > > > MavenReportException: Erro... > > > [ERROR] > > > JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 > > > » MojoExecution > > > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution > > > MavenReportException: Er... > > > [ERROR] JavadocReportTest.testCustomConfiguration:396 » > > > MojoExecution An error has occ... > > > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » > > > MojoExecution An error has oc... > > > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error > > > has occurred in Ja... > > > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error > > > has occurred in Jav... > > > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » > > > MojoExecution An error has o... > > > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An > > > error has occurred in ... > > > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An > > > error has occurre... > > > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An > > > error has occurred in... > > > [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An > > > error has occurred ... > > > [INFO] > > > [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 > > > > > > > > > On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > > > > > > > Hi > > > > I'd like to make a javadoc plugin release. > > > > 2 issues left ATM but I can move them to next version. > > > > > > > > Cheers > > > > -- > > > > Olivier > > > > > > > > > > > > -- > > > Elliotte Rusty Harold > > > elh...@ibiblio.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > -- > > Olivier Lamy > > http://twitter.com/olamy | http://linkedin.com/in/olamy > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org -- Elliotte Ru
Re: Javadoc Plugin release
I'll see if I can dig up some more logs on this. In the meantime as Robert pointed out, the CI for this plugin is broken/red: https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ IMHO, getting that to blue is a prerequisite for a release. This plugin is not currently in a releasable state.. I am (non-binding) -1 on this release. On Mon, Mar 9, 2020 at 11:15 PM Olivier Lamy wrote: > > Hi > The stack trace is truncated in your email. > Can you paste the logs to a gist so I can try looking at it. > There are some old flaky tests relying on having an internet connection. > But I don't want to fix this now.. > Actually I need a release for the jetty project which is a bit stucked to > release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM because > of some bugs here. > > > On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold > wrote: > > > I see two test failures locally: > > > > [ERROR] Failures: > > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 > > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly > > newline for string parameters. See options and packages files. > > [ERROR] Errors: > > [ERROR] > > > > FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 > > » NullPointer > > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution > > MavenReportException: Erro... > > [ERROR] > > JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 > > » MojoExecution > > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution > > MavenReportException: Er... > > [ERROR] JavadocReportTest.testCustomConfiguration:396 » > > MojoExecution An error has occ... > > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » > > MojoExecution An error has oc... > > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error > > has occurred in Ja... > > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error > > has occurred in Jav... > > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » > > MojoExecution An error has o... > > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An > > error has occurred in ... > > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An > > error has occurre... > > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An > > error has occurred in... > > [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An > > error has occurred ... > > [INFO] > > [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 > > > > > > On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > > > > > Hi > > > I'd like to make a javadoc plugin release. > > > 2 issues left ATM but I can move them to next version. > > > > > > Cheers > > > -- > > > Olivier > > > > > > > > -- > > Elliotte Rusty Harold > > elh...@ibiblio.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > Olivier Lamy > http://twitter.com/olamy | http://linkedin.com/in/olamy -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
Hi The stack trace is truncated in your email. Can you paste the logs to a gist so I can try looking at it. There are some old flaky tests relying on having an internet connection. But I don't want to fix this now.. Actually I need a release for the jetty project which is a bit stucked to release jetty 10 as jetty 10 cannot build an aggregated javadoc ATM because of some bugs here. On Mon, 9 Mar 2020 at 22:02, Elliotte Rusty Harold wrote: > I see two test failures locally: > > [ERROR] Failures: > [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 > [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly > newline for string parameters. See options and packages files. > [ERROR] Errors: > [ERROR] > FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 > » NullPointer > [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution > MavenReportException: Erro... > [ERROR] > JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 > » MojoExecution > [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution > MavenReportException: Er... > [ERROR] JavadocReportTest.testCustomConfiguration:396 » > MojoExecution An error has occ... > [ERROR] JavadocReportTest.testDefaultConfiguration:243 » > MojoExecution An error has oc... > [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error > has occurred in Ja... > [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error > has occurred in Jav... > [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » > MojoExecution An error has o... > [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An > error has occurred in ... > [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An > error has occurre... > [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An > error has occurred in... > [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An > error has occurred ... > [INFO] > [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 > > > On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > > > Hi > > I'd like to make a javadoc plugin release. > > 2 issues left ATM but I can move them to next version. > > > > Cheers > > -- > > Olivier > > > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Javadoc Plugin release
I tested using maven 3.2.5 and jdk 1.7.0_80 and could not reproduce the issue. On Mon, 9 Mar 2020 at 17:21, Robert Scholte wrote: > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ [ > https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/] master > is broken. > > It looks like a false positive, JDK7 + Linux is tested with other Maven > versions and these succeed. > If it is happening on the same node, try removing it from the Jenkins > file. > > Robert > On 9-3-2020 07:26:34, Olivier Lamy wrote: > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Javadoc Plugin release
I see two test failures locally: [ERROR] Failures: [ERROR] JavadocJarTest.testContinueIfFailOnErrorIsFalse:170 [ERROR] JavadocReportTest.testNewline:880 Doesn't handle correctly newline for string parameters. See options and packages files. [ERROR] Errors: [ERROR] FixJavadocMojoTest.testFix:123->executeMojoAndTest:576->invokeCompileGoal:629 » NullPointer [ERROR] JavadocJarTest.testDefaultConfig:77 » MojoExecution MavenReportException: Erro... [ERROR] JavadocJarTest.testIncludeMavenDescriptorWhenExplicitlyConfigured:178 » MojoExecution [ERROR] JavadocJarTest.testInvalidDestdir:152 » MojoExecution MavenReportException: Er... [ERROR] JavadocReportTest.testCustomConfiguration:396 » MojoExecution An error has occ... [ERROR] JavadocReportTest.testDefaultConfiguration:243 » MojoExecution An error has oc... [ERROR] JavadocReportTest.testDocfiles:369 » MojoExecution An error has occurred in Ja... [ERROR] JavadocReportTest.testDoclets:490 » MojoExecution An error has occurred in Jav... [ERROR] JavadocReportTest.testOptionsUmlautEncoding:566 » MojoExecution An error has o... [ERROR] JavadocReportTest.testQuotedPath:532 » MojoExecution An error has occurred in ... [ERROR] JavadocReportTest.testStylesheetfile:1251 » MojoExecution An error has occurre... [ERROR] JavadocReportTest.testSubpackages:320 » MojoExecution An error has occurred in... [ERROR] JavadocReportTest.testToFindJavadoc:735 » MojoExecution An error has occurred ... [INFO] [ERROR] Tests run: 67, Failures: 2, Errors: 13, Skipped: 0 On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
There are five open PRs in the repo. It would be nice to review and respond to them. One, I think, can be closed based on the discussion. One is not ready (needs a test). I need to look at the other three. On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
Dependencies in this project look quite out of date. We should probably update the parent POM, doxia, possibly the http client, and several other things first. This shouldn't take long once the CI is fixed. On Mon, Mar 9, 2020 at 2:26 AM Olivier Lamy wrote: > > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier -- Elliotte Rusty Harold elh...@ibiblio.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Javadoc Plugin release
https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/ [https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/] master is broken. It looks like a false positive, JDK7 + Linux is tested with other Maven versions and these succeed. If it is happening on the same node, try removing it from the Jenkins file. Robert On 9-3-2020 07:26:34, Olivier Lamy wrote: Hi I'd like to make a javadoc plugin release. 2 issues left ATM but I can move them to next version. Cheers -- Olivier
Re: Javadoc Plugin release
+1, they can be fixed later IMHO Le lun. 9 mars 2020 à 07:26, Olivier Lamy a écrit : > Hi > I'd like to make a javadoc plugin release. > 2 issues left ATM but I can move them to next version. > > Cheers > -- > Olivier >