Re: Review Request 25261: Check for variadic template support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/#review53715 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2014, 10:26 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/ --- (Updated Sept. 15, 2014, 10:26 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1752 https://issues.apache.org/jira/browse/MESOS-1752 Repository: mesos-git Description --- add c++11 language features to m4 macro that checks for c++11 support Diffs - docs/mesos-c++-style-guide.md 4381d24412aa3d5a6edd940ea8817515d6339f12 m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b Diff: https://reviews.apache.org/r/25261/diff/ Testing --- built with g++-4.4, the minimum compiler we support. Thanks, Dominic Hamon
Re: Review Request 25261: Check for variadic template support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/ --- (Updated Sept. 15, 2014, 3:03 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1752 https://issues.apache.org/jira/browse/MESOS-1752 Repository: mesos-git Description --- add c++11 language features to m4 macro that checks for c++11 support Diffs - m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b Diff: https://reviews.apache.org/r/25261/diff/ Testing --- built with g++-4.4, the minimum compiler we support. Thanks, Dominic Hamon
Re: Review Request 25261: Check for variadic template support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/ --- (Updated Sept. 15, 2014, 3:03 p.m.) Review request for mesos and Benjamin Hindman. Changes --- limit to variadic template check only. Summary (updated) - Check for variadic template support Bugs: MESOS-1752 and MESOS-1753 https://issues.apache.org/jira/browse/MESOS-1752 https://issues.apache.org/jira/browse/MESOS-1753 Repository: mesos-git Description --- add c++11 language features to m4 macro that checks for c++11 support Diffs (updated) - m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b Diff: https://reviews.apache.org/r/25261/diff/ Testing --- built with g++-4.4, the minimum compiler we support. Thanks, Dominic Hamon
Re: Review Request 25261: Check for variadic template support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25261/ --- (Updated Sept. 15, 2014, 3:26 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes --- added doc change. intersects with https://reviews.apache.org/r/25622/ so that should probably land first, but they're not strict dependencies. Bugs: MESOS-1752 https://issues.apache.org/jira/browse/MESOS-1752 Repository: mesos-git Description --- add c++11 language features to m4 macro that checks for c++11 support Diffs (updated) - docs/mesos-c++-style-guide.md 4381d24412aa3d5a6edd940ea8817515d6339f12 m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b Diff: https://reviews.apache.org/r/25261/diff/ Testing --- built with g++-4.4, the minimum compiler we support. Thanks, Dominic Hamon
