[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162514#comment-16162514 ] ASF GitHub Bot commented on MNEMONIC-304: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-mnemonic/pull/66 > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150962#comment-16150962 ] ASF GitHub Bot commented on MNEMONIC-304: - Github user bigdata-memory commented on a diff in the pull request: https://github.com/apache/incubator-mnemonic/pull/66#discussion_r136635829 --- Diff: mnemonic-core/src/main/java/org/apache/mnemonic/ParameterHolder.java --- @@ -105,4 +114,20 @@ public void setHandler(long h) { public long getHandler() { return handler; } + +public void setGenericTypeAndEntityFactoryProxyPair(DurableType[] d, EntityFactoryProxy[] e) { +dpt = new ImmutablePair(d, e); +} + +public DurableType[] getGenericTypeFromPair() { --- End diff -- please remove the suffix "FromPair" would be more concise. > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150963#comment-16150963 ] ASF GitHub Bot commented on MNEMONIC-304: - Github user bigdata-memory commented on a diff in the pull request: https://github.com/apache/incubator-mnemonic/pull/66#discussion_r136635894 --- Diff: mnemonic-core/src/main/java/org/apache/mnemonic/ParameterHolder.java --- @@ -105,4 +114,20 @@ public void setHandler(long h) { public long getHandler() { return handler; } + +public void setGenericTypeAndEntityFactoryProxyPair(DurableType[] d, EntityFactoryProxy[] e) { +dpt = new ImmutablePair(d, e); +} + +public DurableType[] getGenericTypeFromPair() { +return dpt.getLeft(); +} + +public EntityFactoryProxy[] getEntityFactoryProxyFromPair() { --- End diff -- ditto > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150053#comment-16150053 ] ASF GitHub Bot commented on MNEMONIC-304: - GitHub user yzz127 opened a pull request: https://github.com/apache/incubator-mnemonic/pull/66 MNEMONIC-304 Add suppot for Pair to ParameterHolder class Some test cases need to pass Pair as parameters when creating durable class. Current ParameterHolder class doesn't have the support for this feature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yzz127/incubator-mnemonic master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-mnemonic/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 592e9738e20ce91d305ec37daa06760e8d02e332 Author: Yanhui Zhao Date: 2017-08-29T04:28:04Z MNEMONIC-304 Add suppot for Pair to ParameterHolder class > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146613#comment-16146613 ] ASF GitHub Bot commented on MNEMONIC-304: - Github user yzz127 closed the pull request at: https://github.com/apache/incubator-mnemonic/pull/62 > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144735#comment-16144735 ] Yanhui Zhao commented on MNEMONIC-304: -- Support has been implemented. Verified that built is successful and current test case can pass. Sending pull request for peer review. Thanks. > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNEMONIC-304) Add support for Pair to ParameterHolder class to handle optional parameters
[ https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144732#comment-16144732 ] ASF GitHub Bot commented on MNEMONIC-304: - GitHub user yzz127 opened a pull request: https://github.com/apache/incubator-mnemonic/pull/62 MNEMONIC-304 Add suppot for Pair to ParameterHolder class Some test cases need to pass Pair as parameters when creating durable class. Current ParameterHolder class doesn't have the support for this feature. Build is successful and test case passed after ParameterHolder class is updated. Please review and help to double check. Thanks! You can merge this pull request into a Git repository by running: $ git pull https://github.com/yzz127/incubator-mnemonic master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-mnemonic/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit c9812eec2e949d73540e6356bf1b091ef9c220d4 Author: Yanhui Zhao Date: 2017-08-29T04:28:04Z MNEMONIC-304 Add suppot for Pair to ParameterHolder class > Add support for Pair to ParameterHolder class to handle optional parameters > --- > > Key: MNEMONIC-304 > URL: https://issues.apache.org/jira/browse/MNEMONIC-304 > Project: Mnemonic > Issue Type: Improvement > Components: Core >Affects Versions: 0.8.0-incubating >Reporter: Yanhui Zhao >Assignee: Yanhui Zhao >Priority: Minor > Labels: features > > Some test cases need to pass Pair as parameters when creating durable class. > Current ParameterHolder class doesn't have the support for this feature. -- This message was sent by Atlassian JIRA (v6.4.14#64029)