[jira] [Created] (TRINIDAD-2505) URLEncoderFactory ThreadLocal memory leak causing NullPointerException in JSF on Weblogic
Adolfo created TRINIDAD-2505:
Summary: URLEncoderFactory ThreadLocal memory leak causing
NullPointerException in JSF on Weblogic
Key: TRINIDAD-2505
URL: https://issues.apache.org/jira/browse/TRINIDAD-2505
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 2.1.0-core
Environment: Weblogic 12.1.1c
Windows 7, Linux Ubuntu
Reporter: Adolfo
Priority: Critical
URLEncoderFactory has an ThreadLocal to store an instance of URLEncoder for the
entire Request.
The instance initialization store an reference to the current ExternalContext.
The request lifecicle is not cleaning the ThreadLocal, so the next request that
reuse the same thread will retrieve the last instance that has a
ExternalContext refering to an ServletRequest that Weblogic has cleaned the
context reference.
This behavior cause NullPointerException when JSF use encodeResourceURL.
- URLEncoderFactory.java line 74 ---
public URLEncoder getURLEncoder(ExternalContext ec)
{
//even though we should wait until we have a faces context and throw an
error
//if we don't, go ahead and fudge it if the threadlocal is not null. This
just
//means that a URLEncoder has already been set for this thread.
URLEncoder enc = _local.get();
if(null != enc)
{
return enc;
}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (MYFACES-3891) Don't write flash-scoped variables in ErrorPageWriter when FLASH_SCOPE_DISABLED=true
[
https://issues.apache.org/jira/browse/MYFACES-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe updated MYFACES-3891:
Resolution: Fixed
Fix Version/s: 2.2.5
Status: Resolved (was: Patch Available)
I moved the parameter to MyfacesConfig class. Thanks to Martin Koci for provide
this patch.
> Don't write flash-scoped variables in ErrorPageWriter when
> FLASH_SCOPE_DISABLED=true
>
>
> Key: MYFACES-3891
> URL: https://issues.apache.org/jira/browse/MYFACES-3891
> Project: MyFaces Core
> Issue Type: Bug
>Reporter: Martin Kočí
>Assignee: Leonardo Uribe
>Priority: Trivial
> Fix For: 2.2.5
>
> Attachments: MYFACES-3891_ErrorPageWriter.patch,
> MYFACES-3891_FlashImpl.patch
>
>
> 1) in web.xml
>
> org.apache.myfaces.FLASH_SCOPE_DISABLED
> true
>
> 2) ui:debug in .xhtml
> leads to:
> throw new FlashScopeDisabledException("Flash scope was disabled by context
> param "
> + FLASH_SCOPE_DISABLED_PARAM + " but erroneously accessed");
> the cause : ErrorPageWriter._writeVariables writes always the variables,
> regardless of FLASH_SCOPE_DISABLED
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (MYFACES-3789) Change default refresh period for facelets from 2 to 0 sec (=always refresh)
[ https://issues.apache.org/jira/browse/MYFACES-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe updated MYFACES-3789: Resolution: Fixed Fix Version/s: 2.2.5 Status: Resolved (was: Patch Available) > Change default refresh period for facelets from 2 to 0 sec (=always refresh) > > > Key: MYFACES-3789 > URL: https://issues.apache.org/jira/browse/MYFACES-3789 > Project: MyFaces Core > Issue Type: Wish >Reporter: Martin Kočí >Assignee: Leonardo Uribe >Priority: Trivial > Fix For: 2.2.5 > > Attachments: MYFACES-3789.patch > > > A typical developer works as follows > 1) edits a facelets view (template, composite component) > 2) CTRL +S > 3) refresh in browser (or LiveReload) > but: from 2) to 3) takes it sometimes less as 2 secs and the programmer must > repeat the 3) > We can override this behaviour with context-param: > javax.faces.FACELETS_REFRESH_PERIOD=0 > but then is for development neccesary: > javax.faces.PROJECT_STAGE=Development > javax.faces.FACELETS_REFRESH_PERIOD=0 > and for Production: > javax.faces.PROJECT_STAGE=Production > javax.faces.FACELETS_REFRESH_PERIOD=-1 > that means a configuration of 2 params instead of one (ProjectStage) (the > problem is: javax.faces.FACELETS_REFRESH_PERIOD when not default always wins > and PROJECT_STAGE=Production doesn't set FACELETS_REFRESH_PERIOD to -1) > with default refresh period = 0 makes the method > FaceletCacheFactoryImpl.getFaceletCache() the job and only > javax.faces.PROJECT_STAGE=Production is necessary. > Does anybody know why is the default 2 seconds ? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (MYFACES-3913) NPE in SwitchAjaxExceptionHandlerWrapperImpl
[ https://issues.apache.org/jira/browse/MYFACES-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3913. - Resolution: Fixed Fix Version/s: 2.2.5 2.1.16 2.0.22 Assignee: Leonardo Uribe Thanks to Thomas Andraschko for provide this patch > NPE in SwitchAjaxExceptionHandlerWrapperImpl > > > Key: MYFACES-3913 > URL: https://issues.apache.org/jira/browse/MYFACES-3913 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.1.15 >Reporter: Thomas Andraschko >Assignee: Leonardo Uribe > Fix For: 2.0.22, 2.1.16, 2.2.5 > > > _isAjaxRequest = facesContext.getPartialViewContext().isAjaxRequest(); > occurs 2 times in SwitchAjaxExceptionHandlerWrapperImpl and > facesContext.getPartialViewContext() can be null. > We should just return false if it's null. > StackTrace: > java.lang.NullPointerException > at > org.apache.myfaces.shared.context.SwitchAjaxExceptionHandlerWrapperImpl.isAjaxRequest(SwitchAjaxExceptionHandlerWrapperImpl.java:98) > at > org.apache.myfaces.shared.context.SwitchAjaxExceptionHandlerWrapperImpl.getWrapped(SwitchAjaxExceptionHandlerWrapperImpl.java:106) > at > javax.faces.context.ExceptionHandlerWrapper.isListenerForSource(ExceptionHandlerWrapper.java:70) > at > javax.faces.context.ExceptionHandlerWrapper.isListenerForSource(ExceptionHandlerWrapper.java:70) > at > javax.faces.context.ExceptionHandlerWrapper.isListenerForSource(ExceptionHandlerWrapper.java:70) > at > org.apache.myfaces.application.ApplicationImpl._traverseListenerList(ApplicationImpl.java:2480) > at > org.apache.myfaces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:586) > at > org.apache.myfaces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:616) > at > javax.faces.application.ApplicationWrapper.publishEvent(ApplicationWrapper.java:336) > at > javax.faces.application.ApplicationWrapper.publishEvent(ApplicationWrapper.java:336) > at > javax.faces.application.ApplicationWrapper.publishEvent(ApplicationWrapper.java:336) > at > org.apache.deltaspike.jsf.impl.injection.InjectionAwareApplicationWrapper.publishEvent(InjectionAwareApplicationWrapper.java:121) > at > org.apache.myfaces.lifecycle.PhaseListenerManager.publishException(PhaseListenerManager.java:136) > at > org.apache.myfaces.lifecycle.PhaseListenerManager.informPhaseListenersAfter(PhaseListenerManager.java:123) > at > org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:185) > at > org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117) > at > org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89) > at javax.faces.webapp.FacesServlet.service(FacesServlet.java:197) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (MYFACES-3913) NPE in SwitchAjaxExceptionHandlerWrapperImpl
Thomas Andraschko created MYFACES-3913: -- Summary: NPE in SwitchAjaxExceptionHandlerWrapperImpl Key: MYFACES-3913 URL: https://issues.apache.org/jira/browse/MYFACES-3913 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.1.15 Reporter: Thomas Andraschko _isAjaxRequest = facesContext.getPartialViewContext().isAjaxRequest(); occurs 2 times in SwitchAjaxExceptionHandlerWrapperImpl and facesContext.getPartialViewContext() can be null. We should just return false if it's null. StackTrace: java.lang.NullPointerException at org.apache.myfaces.shared.context.SwitchAjaxExceptionHandlerWrapperImpl.isAjaxRequest(SwitchAjaxExceptionHandlerWrapperImpl.java:98) at org.apache.myfaces.shared.context.SwitchAjaxExceptionHandlerWrapperImpl.getWrapped(SwitchAjaxExceptionHandlerWrapperImpl.java:106) at javax.faces.context.ExceptionHandlerWrapper.isListenerForSource(ExceptionHandlerWrapper.java:70) at javax.faces.context.ExceptionHandlerWrapper.isListenerForSource(ExceptionHandlerWrapper.java:70) at javax.faces.context.ExceptionHandlerWrapper.isListenerForSource(ExceptionHandlerWrapper.java:70) at org.apache.myfaces.application.ApplicationImpl._traverseListenerList(ApplicationImpl.java:2480) at org.apache.myfaces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:586) at org.apache.myfaces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:616) at javax.faces.application.ApplicationWrapper.publishEvent(ApplicationWrapper.java:336) at javax.faces.application.ApplicationWrapper.publishEvent(ApplicationWrapper.java:336) at javax.faces.application.ApplicationWrapper.publishEvent(ApplicationWrapper.java:336) at org.apache.deltaspike.jsf.impl.injection.InjectionAwareApplicationWrapper.publishEvent(InjectionAwareApplicationWrapper.java:121) at org.apache.myfaces.lifecycle.PhaseListenerManager.publishException(PhaseListenerManager.java:136) at org.apache.myfaces.lifecycle.PhaseListenerManager.informPhaseListenersAfter(PhaseListenerManager.java:123) at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:185) at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117) at org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:197) -- This message was sent by Atlassian JIRA (v6.2#6252)
[RESULT] [VOTE] Release Tobago 2.0.1
Hi, thank you for voting for the release. The result is +1 werpu (binding) lofwyr (binding) bommel (binding) lu4242 (binding) so I will proceed with the next steps for the release. Regards, Bernd On Mon, Aug 4, 2014 at 5:34 PM, Leonardo Uribe wrote: > +1 > > Regards, > > Leonardo > > On Aug 4, 2014 5:00 AM, "Bernd Bohmann" wrote: >> >> Here is my >> >> +1 >> >> Regards >> >> Bernd >> >> On Fri, Aug 1, 2014 at 12:58 PM, Udo Schnurpfeil >> wrote: >> > -BEGIN PGP SIGNED MESSAGE- >> > Hash: SHA512 >> > >> > here is my >> > >> > +1 >> > >> > @Bernd (bommel), can you please release the Repo after the voting. I >> > may not be online the next days... >> > >> > Regards >> > >> > Udo >> > >> > Am 31.07.14 19:04, schrieb Werner Punz: >> >> +1 >> >> >> >> Werner >> >> >> >> >> >> >> >> Am 31.07.14 15:37, schrieb Udo Schnurpfeil: Hello, >> >> >> >> the upload problem is fixed now. >> >> >> >> I would like to release Tobago 2.0.1. >> >> >> >> For a detail list please consult the release notes: >> >> >> >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273&version=12327455 >> >> >> >> The version is available at the staging repository (Nexus). >> >> >> >> Staging repository: >> >> >> >> >> >> https://repository.apache.org/content/repositories/orgapachemyfaces-1029/ >> >> >> >> The Vote is open for 72h. >> >> >> >> [ ] +1 [ ] +0 [ ] -1 >> >> >> >> Regards, >> >> >> >> Udo >> >> >> >>> >> >> >> >> >> >>
