[jira] Commented: (MYFACES-1415) WebXmlParser needs to be aware of changes in web.xml in version 2.4 of the Servlet spec

2006-09-21 Thread Dan Allen (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-1415?page=comments#action_12436615 
] 

Dan Allen commented on MYFACES-1415:


Oh, and the above patch applies to the branch 
http://svn.apache.org/repos/asf/myfaces/shared/branches/2_0_3

> WebXmlParser needs to be aware of changes in web.xml in version 2.4 of the 
> Servlet spec
> ---
>
> Key: MYFACES-1415
> URL: http://issues.apache.org/jira/browse/MYFACES-1415
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 1.1.4
>Reporter: Gert Vanthienen
>Priority: Trivial
> Attachments: MYFACES-1415.txt
>
>
> When using a Servlet 2.4 compliant web.xml, warnings are shown for some 
> elements that are valid according to the spec.  This is purely a cosmetic 
> issue, with no loss of function whatsoever.  It does create some confusion 
> when users see this message (e.g. 
> http://www.mail-archive.com/users@myfaces.apache.org/msg28066.html), so it 
> might be worth fixing at some time.
> WARN [WebXmlParser] Ignored element 'dispatcher' as child of 'filter-mapping'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (MYFACES-1415) WebXmlParser needs to be aware of changes in web.xml in version 2.4 of the Servlet spec

2006-09-21 Thread Dan Allen (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-1415?page=all ]

Dan Allen updated MYFACES-1415:
---

Status: Patch Available  (was: Open)

> WebXmlParser needs to be aware of changes in web.xml in version 2.4 of the 
> Servlet spec
> ---
>
> Key: MYFACES-1415
> URL: http://issues.apache.org/jira/browse/MYFACES-1415
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 1.1.4
>Reporter: Gert Vanthienen
>Priority: Trivial
>
> When using a Servlet 2.4 compliant web.xml, warnings are shown for some 
> elements that are valid according to the spec.  This is purely a cosmetic 
> issue, with no loss of function whatsoever.  It does create some confusion 
> when users see this message (e.g. 
> http://www.mail-archive.com/users@myfaces.apache.org/msg28066.html), so it 
> might be worth fixing at some time.
> WARN [WebXmlParser] Ignored element 'dispatcher' as child of 'filter-mapping'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (TOMAHAWK-485) Extended DataTable renderRowStart called before setRowIndex

2006-06-09 Thread Dan Allen (JIRA)
 [ http://issues.apache.org/jira/browse/TOMAHAWK-485?page=all ]

Dan Allen updated TOMAHAWK-485:
---

Status: Patch Available  (was: Open)

> Extended DataTable renderRowStart called before setRowIndex
> ---
>
>  Key: TOMAHAWK-485
>  URL: http://issues.apache.org/jira/browse/TOMAHAWK-485
>  Project: MyFaces Tomahawk
> Type: Bug

>   Components: Extended Datatable
> Versions: 1.1.3-SNAPSHOT
>  Environment: linux, java 5, tomcat 5
> Reporter: Dan Allen

>
> When the extended HtmlDataTable was merged with the newspaper table code, a 
> bug was introduced that effects the rendering of the row-level attributes 
> (rowIndexVar, rowStyle, rowStyleClass).  The problem is that the 
> renderRowStart is called before the setRowIndex is called, so therefore all 
> of the data available to the expressions in these attributes is uninitialized 
> on the first row, and then always one row behind rendering subsequent rows.
> The following simple example demonstrates the issue:
>  rowId="row#{index}">
>  
>  row index: ; item:  value="#{item}" />
>  
> 
> You will see when you render this using tomahawk 1.1.3 that the output is as 
> follows:
> row index: 0; item: child1 (rowId=row)
> row index: 1; item: child2 (rowId=row0)
> The expected values would be that the row id would have the same numerical 
> part as the row index, but as you can see it is off by one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (TOMAHAWK-485) Extended DataTable renderRowStart called before setRowIndex

2006-06-09 Thread Dan Allen (JIRA)
Extended DataTable renderRowStart called before setRowIndex
---

 Key: TOMAHAWK-485
 URL: http://issues.apache.org/jira/browse/TOMAHAWK-485
 Project: MyFaces Tomahawk
Type: Bug

  Components: Extended Datatable  
Versions: 1.1.3-SNAPSHOT
 Environment: linux, java 5, tomcat 5
Reporter: Dan Allen


When the extended HtmlDataTable was merged with the newspaper table code, a bug 
was introduced that effects the rendering of the row-level attributes 
(rowIndexVar, rowStyle, rowStyleClass).  The problem is that the renderRowStart 
is called before the setRowIndex is called, so therefore all of the data 
available to the expressions in these attributes is uninitialized on the first 
row, and then always one row behind rendering subsequent rows.

The following simple example demonstrates the issue:


 
 row index: ; item: 
 


You will see when you render this using tomahawk 1.1.3 that the output is as 
follows:

row index: 0; item: child1 (rowId=row)
row index: 1; item: child2 (rowId=row0)

The expected values would be that the row id would have the same numerical part 
as the row index, but as you can see it is off by one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira