[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63699 ] sean schofield commented on MYFACES-197: Once I added this fix I lost *all* TLD docs including the WAP. Build was successful but I noticed this line in my Ant output: [java] com.sun.tlddoc.GeneratorException: Error: D:\open-source\incubator-myfaces\build\temp\myfaces-tlds\myfaces_ext.tld does not have xmlns=http://java.sun.com/xml/ns/j2ee; BTW, I did not alter/remove the dtd in the tlds directory. I left that one alone. TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Assignee: sean schofield Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63696 ] sean schofield commented on MYFACES-197: Does this mean we can remove the web-jsptaglibrary_1_2.dtd file from the tlds directory? TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Assignee: sean schofield Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63735 ] Martin Bosak commented on MYFACES-197: -- Did you removed the xmlns= attribute from the .tlds in the \tlds directory? It boils down to (until tlddoc gets fixed) that if the taglib element has an xmlns= attribute, tlddoc requires it to be http://java.sun.com/xml/ns/j2ee;. If the taglib element does not have an xmlns= attribute; then tlddoc will accept it. Apparently, most tag libraries don't specify an xmlns; so the author never ran across it before when he made the change to tlddoc to support JSP 2.0. Yes, we still need to leave the .dtd there because the codegen task for generating the WAP tag support runs an xmlvalidate step that requires it. I suppose you could move it somewhere else; I was trying to minimize the changes. BTW, sorry it took so long to answer your questions. The E-mail address I registered with is my home one. TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Assignee: sean schofield Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63398 ] Martin Bosak commented on MYFACES-197: -- I was debugging the TLDDOC code when I stumbled upon the xmlns difference. Now I just have to figure out 1) How it's getting inserted in the build (I tried changing the documents in the \tlds directory and re-ran the build. The xmlns attribute was in the generated .tlds) 2) Test the resulting .jars to make sure things work. TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63459 ] Martin Bosak commented on MYFACES-197: -- I know. I've been trying to determine what's changed in this area and, outside of my updated tdldoc.jar that I submitted I can't find anything yet. I also could have sworn that they were there as well. I also think that both were there when I tested my changes to tlddoc. Debugging tlddoc generator isn't going to be too easy; since it uses XSLT to generate the output. I'll keep trying. TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63460 ] Martin Bosak commented on MYFACES-197: -- After some digging on the taglibrarydoc project at java.net, I ran across the following open issue: Issue #5 - JSP 1.2 TLDs with xmlns=http://java.sun.com/JSP/TagLibraryDescriptor; not supported The stated workaround is to remove the xmlns=http://java.sun.com/JSP/TagLibraryDescriptor; attribute from the taglib element before generating. As near as I can figure out, here is the tlddoc.jar saga: 1) When tlddoc.jar was upgraded to version 1.2, the generation of the TLD documentation was broken due to the above taglibrarydoc issue. 2) As a result, I opened MYFACES-156 and attempted to fix it by commenting out the check that generated the following error: myfaces_ext.tld does not have xmlns=http://java.sun.com/xml/ns/j2ee;. I must not have opened up the actual generated documentation and just assumed it worked; since all the files appeared to be there. 3) With the modified tlddoc.jar, only the WAP tags were generated because myfaces_wap.tld does not specify the xmlns attribute on the taglib element. So, I think the xmlns attribute should be removed from the taglib element for the myfaces_core.tld, myfaces_ext.tld, myfaces_ext_sf.tld, and myfaces_html.tld file until tlddoc gets fixed. TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63461 ] Martin Bosak commented on MYFACES-197: -- OK, here's one way to solve this one: 1) Back out my change to tlddoc.jar that I made for MYFACES-156 (might have to get the original tlddoc.jar, version 1.2 if that would be easier. 2) Remove the xmlns attribute from the taglib element in the tld files located in the /tlds directory. 3) Make a copy of the web-jsptaglibrary_1_2.dtd file and change the !ATTLIST taglib id ID #IMPLIED xmlns CDATA #FIXED http://java.sun.com/JSP/TagLibraryDescriptor; to be !ATTLIST taglib id ID #IMPLIED We have to make a copy otherwise the xmlvalidate part of the codegen task will fail. I would suggest placing this modified version of the dtd in a separate directory under the /build directory. 4) Modify the build.xml scripts to: a) Define a property pointing to the modified web-jsptaglibrary_1_2.dtd file for use by the resolve-tld-entities task. b) Change the xmlcatalog element in the resolve-tld-entities task to use the property defined above. I tested this and the x library tags were now in the alltags-frame.html and alltags-noframe.html files. TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-197) TLDDocs Index page only has WAP tags
[ http://issues.apache.org/jira/browse/MYFACES-197?page=comments#action_63360 ] Martin Bosak commented on MYFACES-197: -- I have managed to get TLDDOC to include the x tags along with the WAP tags in the alltags-frame.html file. I simply removed the xmlns attribute from the taglib root element in the myfaces_ext.tld file before I ran it thru tlddoc. I'm not sure I can explain what was going on; but it worked. (BTW, is it valid to specify an xmlns attribute in a document that has a !DOCTYPE specified)? TLDDocs Index page only has WAP tags Key: MYFACES-197 URL: http://issues.apache.org/jira/browse/MYFACES-197 Project: MyFaces Type: Bug Versions: 1.0.9 beta Environment: Any Reporter: Martin Bosak Priority: Minor The index page of the 1.0.9m9 release only contains links for the WAP tags. The individual extension tag documentation files are physically in the tlddocs\x directory; but are missing from the tlddocs\index.html page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
