[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...
Github user lkishalmi closed the pull request at: https://github.com/apache/incubator-netbeans/pull/25 ---
[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...
Github user lkishalmi commented on the issue: https://github.com/apache/incubator-netbeans/pull/25 Thank you! ---
[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...
Github user lkishalmi commented on the issue: https://github.com/apache/incubator-netbeans/pull/25 I've made a small change to do the detection only when the key auth is selected. ---
[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...
Github user lkishalmi commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/25#discussion_r142020017 --- Diff: git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java --- @@ -686,6 +686,7 @@ public SSHConnectionSettingsType () { settingsPanel.savePasswordCheckBox }; acceptableSchemes = EnumSet.of(Scheme.SSH, Scheme.SFTP); + settingsPanel.txtIdentityFile.setText(getDefaultIdentityFilePath()); --- End diff -- Unfortunately populateFields is not called in every case. Most importantly when the repository URL is being copied from github/gitlab where the ssh:// prefix is just missing from the URL. Probably I could raise a bug on that. And mark this line as a workaround in the code, till it gets fixed. I feel the fix would be a bit out of the trivial category. ---
[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...
GitHub user lkishalmi opened a pull request: https://github.com/apache/incubator-netbeans/pull/25 NETBEANS-73: Autodetect id_rsa and id_dsa keys for Git private key. Simple patch for https://issues.apache.org/jira/browse/NETBEANS-73 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lkishalmi/incubator-netbeans NETBEANS-73_Git_Private_Key_Improvement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-netbeans/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 5c1ea668924c481e0d24c82c9fbcd5158e055780 Author: Laszlo Kishalmi <laszlo_kisha...@epam.com> Date: 2017-09-29T22:03:39Z NETBEANS-73: Autodetect id_rsa and id_dsa keys for Git private key. ---