Re: Review Request: OODT-516: Add WorkflowLifecycle tests that check pctComplete for wengine and w1 style lifecycles

2012-10-06 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7438/
---

(Updated Oct. 6, 2012, 9:37 p.m.)


Review request for oodt.


Changes
---

Added code fix that makes tests pass.


Description
---

In testing the OPSUI with the new workflow manager and wengine lifecycles I 
noticed some disparities in computing % complete for a workflow. So I'm going 
to write some unit tests to verify that the % complete is getting correctly 
computed.


This addresses bug OODT-516.
https://issues.apache.org/jira/browse/OODT-516


Diffs (updated)
-

  ./trunk/CHANGES.txt 1391159 
  
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/lifecycle/WorkflowLifecycle.java
 1391158 
  
./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/lifecycle/WorkflowLifecycleManager.java
 1391158 
  
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/lifecycle/TestWorkflowLifecycleManager.java
 1390815 

Diff: https://reviews.apache.org/r/7438/diff/


Testing
---

The attached tests are failing in trunk.


Thanks,

Chris Mattmann



Review Request: OODT-516: Add WorkflowLifecycle tests that check pctComplete for wengine and w1 style lifecycles

2012-10-04 Thread Chris Mattmann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7438/
---

Review request for oodt.


Description
---

In testing the OPSUI with the new workflow manager and wengine lifecycles I 
noticed some disparities in computing % complete for a workflow. So I'm going 
to write some unit tests to verify that the % complete is getting correctly 
computed.


This addresses bug OODT-516.
https://issues.apache.org/jira/browse/OODT-516


Diffs
-

  
./trunk/workflow/src/test/org/apache/oodt/cas/workflow/lifecycle/TestWorkflowLifecycleManager.java
 1390815 

Diff: https://reviews.apache.org/r/7438/diff/


Testing
---

The attached tests are failing in trunk.


Thanks,

Chris Mattmann