[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602994#comment-16602994 ] Andras Piros commented on OOZIE-3061: - Thanks for the contribution [~matijhs]! +1 > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.1.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch, > OOZIE-3061-006.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602262#comment-16602262
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [3] new bugs found in total that would be nice
to have fixed.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:orange}0{color} There are [3] new bugs found in [core] that would be
nice to have fixed.
. You can find the FindBugs diff here: core/findbugs-new.html
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2932
.{color:orange}Tests failed at first run:{color}
TestCoordActionsKillXCommand#testActionKillCommandDate
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/804/
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.1.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch,
> OOZIE-3061-006.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602164#comment-16602164 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.1.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch, > OOZIE-3061-006.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602159#comment-16602159 ] Mate Juhasz commented on OOZIE-3061: Thanks [~andras.piros], I uploaded a patch according to your comments > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.1.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch, > OOZIE-3061-006.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598607#comment-16598607
]
Andras Piros commented on OOZIE-3061:
-
[~matijhs] as I see the patch 005 consists of following parts:
# refactoring {{JavaActionExecutor#kill()}} - doesn't need any new tests
# extending {{LauncherMain#killChildYarnJobs()}} - definitely needs new tests
in {{TestLauncherMain}}
Apart from testing perspective, could you please modify the condition in
{{LauncherMain#killChildYarnJobs():265}} so that instead of getting only the
{{ApplicationReport}} in {{FinalApplicationStatus.UNDEFINED}}, we instead get
the one that is not {{SUCCEED}}, {{FAILED}}, or {{KILLED}}? So that we can stay
future proof just in case someone extends {{FinalApplicationStatus}} with a new
field.
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.1.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596085#comment-16596085 ] Mate Juhasz commented on OOZIE-3061: [~andras.piros], I try to add some tests as well, should we set the applications external status to KILLED when we dont actually kill them as they are already finished? > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.1.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595657#comment-16595657
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
.{color:orange}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:orange}0{color} There are [3] new bugs found in total that would be nice
to have fixed.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:orange}0{color} There are [3] new bugs found in [core] that would be
nice to have fixed.
. You can find the FindBugs diff here: core/findbugs-new.html
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 2926
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/795/
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.1.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595536#comment-16595536 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.1.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch, OOZIE-3061-005.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591826#comment-16591826
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.1.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591811#comment-16591811 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.1.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591803#comment-16591803
]
Andras Piros commented on OOZIE-3061:
-
[~matijhs] thanks for the contribution! Can you please address outstanding
pre-commit build issues, and rebase on top of current {{master}}? Thanks!
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.1.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360979#comment-16360979
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2092
.Tests failed: 3
.Tests errors: 1
.The patch failed the following testcases:
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/387/
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.0.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch, OOZIE-3061-004.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360811#comment-16360811 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360807#comment-16360807 ] Mate Juhasz commented on OOZIE-3061: That makes sense, thanks for pointing out! I have attached a patch for both classes. > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch, OOZIE-3061-004.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357099#comment-16357099 ] Peter Cseh commented on OOZIE-3061: --- Yeah, YarnClient could be more clever about this. Can you upload a cumulative patch that contains changes to both classes in question? Also, instead of checking against KILLED status I think we should only kill an application if the yarnClient.getFinalApplicationStatus() is UNDEFINED, meaning the application is still running. There is no gain in killing already succeeded/failed applications. > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346594#comment-16346594
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2088
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)
.Tests failing with errors:
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/365/
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.0.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch,
> OOZIE-3061-003.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346478#comment-16346478 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch, > OOZIE-3061-003.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345200#comment-16345200
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2088
.Tests failed: 3
.Tests errors: 1
.The patch failed the following testcases:
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/362/
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.0.0
>
> Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345137#comment-16345137 ] Mate Juhasz commented on OOZIE-3061: Wouldn't be nicer to check the application state in the YarnClient"s killApplocation method? > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345047#comment-16345047 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345045#comment-16345045 ] Mate Juhasz commented on OOZIE-3061: [~gezapeti] Sure, I attached the patch containing the changes applied to the JavaActionExecuter. > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch, OOZIE-3061-002.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344970#comment-16344970
]
Hadoop QA commented on OOZIE-3061:
--
Testing JIRA OOZIE-3061
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2088
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)
.Tests failing with errors:
.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/361/
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 4.3.0
>Reporter: Satish Subhashrao Saley
>Assignee: Mate Juhasz
>Priority: Trivial
> Labels: newbie, newbiee
> Fix For: 5.0.0
>
> Attachments: OOZIE-3061-001.patch
>
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344856#comment-16344856 ] Peter Cseh commented on OOZIE-3061: --- Thanks for the patch! Can you apply the same changes in [JavaActionExecutor|https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java#L1741-L1774] as well? > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344840#comment-16344840 ] Mate Juhasz commented on OOZIE-3061: Thanks [~gezapeti] for adding me, I am looking forward to start contributing! I submitted the patch and hope I picked the right version numbers. > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344849#comment-16344849 ] Hadoop QA commented on OOZIE-3061: -- PreCommit-OOZIE-Build started > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Affects Versions: 4.3.0 >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > Fix For: 5.0.0 > > Attachments: OOZIE-3061-001.patch > > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343905#comment-16343905 ] Peter Cseh commented on OOZIE-3061: --- Welcome [~matijhs]! I've added you to the contributor list and assigned this issue to you! Your approach seems fine at first glance, but please submit a patch as described [here|https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute]. Thanks in advance for the contribution! > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Reporter: Satish Subhashrao Saley >Assignee: Mate Juhasz >Priority: Trivial > Labels: newbie, newbiee > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[
https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323885#comment-16323885
]
Mate Juhasz commented on OOZIE-3061:
What do you think of this solution?
{noformat}
if
(YarnApplicationState.KILLED.equals(yarnClient.getApplicationReport(app).getYarnApplicationState()))
{
System.out.println("Application [" + app + "] already killed.");
} else {
yarnClient.killApplication(app);
System.out.println("Done");
}
{noformat}
> Kill only those child jobs which are not already killed
> ---
>
> Key: OOZIE-3061
> URL: https://issues.apache.org/jira/browse/OOZIE-3061
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Priority: Trivial
> Labels: newbie, newbiee
>
> Here we kill all child jobs.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265
> We should check before killing for already killed application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OOZIE-3061) Kill only those child jobs which are not already killed
[ https://issues.apache.org/jira/browse/OOZIE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322352#comment-16322352 ] Mate Juhasz commented on OOZIE-3061: Please add me to the contributors list, thank you! > Kill only those child jobs which are not already killed > --- > > Key: OOZIE-3061 > URL: https://issues.apache.org/jira/browse/OOZIE-3061 > Project: Oozie > Issue Type: Bug >Reporter: Satish Subhashrao Saley >Priority: Trivial > Labels: newbie, newbiee > > Here we kill all child jobs. > https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L265 > We should check before killing for already killed application. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
