[jira] [Created] (PHOENIX-6733) Ref count leaked test failures
Geoffrey Jacoby created PHOENIX-6733: Summary: Ref count leaked test failures Key: PHOENIX-6733 URL: https://issues.apache.org/jira/browse/PHOENIX-6733 Project: Phoenix Issue Type: Bug Affects Versions: 5.2.0 Reporter: Geoffrey Jacoby Fix For: 5.2.0 In pretty much every recent Yetus test run, some tests have flapped in the AfterClass teardown logic which tries to check for HBase Store reference resource leaks. The error message is "Ref count leaked", and some common suites this happens to are: DateTimeIT InListIT SequenceIT IndexToolForDeleteBeforeRebuildIT SpooledTmpFileDeleteIT I haven't had much luck trying to reproduce this locally. It's also not clear yet whether the root cause is an HBase error or a Phoenix one. (And if it's a Phoenix one, is the bug with something in Phoenix or with the resource check?) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (PHOENIX-6732) PherfMainIT and DataIngestIT have failing tests
[ https://issues.apache.org/jira/browse/PHOENIX-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-6732: - Summary: PherfMainIT and DataIngestIT have failing tests (was: PherfMainIT and DriverIngestIT have failing tests) > PherfMainIT and DataIngestIT have failing tests > --- > > Key: PHOENIX-6732 > URL: https://issues.apache.org/jira/browse/PHOENIX-6732 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0 >Reporter: Geoffrey Jacoby >Assignee: Jacob Isaac >Priority: Blocker > Fix For: 5.2.0 > > > PherfMainIT and DriverIngestIT have consistently failing IT tests, which can > be reproduced both locally and in Yetus. (This was shown recently in the test > run for PHOENIX-6554, which is a pherf improvement.) > [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 69.393 s <<< FAILURE! - in org.apache.phoenix.pherf.DataIngestIT > [ERROR] org.apache.phoenix.pherf.DataIngestIT.testColumnRulesApplied Time > elapsed: 0.369 s <<< FAILURE! > java.lang.AssertionError: Expected 100 rows to have been inserted > expected:<30> but was:<31> > [ERROR] org.apache.phoenix.pherf.PherfMainIT.testQueryTimeout Time elapsed: > 15.531 s <<< ERROR! > java.io.FileNotFoundException: > /tmp/RESULTS/RESULT_COMBINED_2022-06-15_05-12-32_detail.csv (No such file or > directory) > [ERROR] org.apache.phoenix.pherf.PherfMainIT.testNoQueryTimeout Time > elapsed: 9.339 s <<< ERROR! > java.io.FileNotFoundException: > /tmp/RESULTS/RESULT_COMBINED_2022-06-15_05-12-23_detail.csv (No such file or > directory) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (PHOENIX-6732) PherfMainIT and DriverIngestIT have failing tests
Geoffrey Jacoby created PHOENIX-6732: Summary: PherfMainIT and DriverIngestIT have failing tests Key: PHOENIX-6732 URL: https://issues.apache.org/jira/browse/PHOENIX-6732 Project: Phoenix Issue Type: Bug Affects Versions: 5.2.0 Reporter: Geoffrey Jacoby Assignee: Jacob Isaac Fix For: 5.2.0 PherfMainIT and DriverIngestIT have consistently failing IT tests, which can be reproduced both locally and in Yetus. (This was shown recently in the test run for PHOENIX-6554, which is a pherf improvement.) [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 69.393 s <<< FAILURE! - in org.apache.phoenix.pherf.DataIngestIT [ERROR] org.apache.phoenix.pherf.DataIngestIT.testColumnRulesApplied Time elapsed: 0.369 s <<< FAILURE! java.lang.AssertionError: Expected 100 rows to have been inserted expected:<30> but was:<31> [ERROR] org.apache.phoenix.pherf.PherfMainIT.testQueryTimeout Time elapsed: 15.531 s <<< ERROR! java.io.FileNotFoundException: /tmp/RESULTS/RESULT_COMBINED_2022-06-15_05-12-32_detail.csv (No such file or directory) [ERROR] org.apache.phoenix.pherf.PherfMainIT.testNoQueryTimeout Time elapsed: 9.339 s <<< ERROR! java.io.FileNotFoundException: /tmp/RESULTS/RESULT_COMBINED_2022-06-15_05-12-23_detail.csv (No such file or directory) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (PHOENIX-6554) Pherf CLI option long/short option names do not follow conventions
[
https://issues.apache.org/jira/browse/PHOENIX-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Jacoby resolved PHOENIX-6554.
--
Fix Version/s: 5.2.0
Release Note: Pherf CLI now allows its long option names to use -- in
addition to -, as the Unix convention suggests. While the existing behavior of
using a single dash "-" for long options doesn't follow the Unix convention, we
still allow it for backward compatibility.
Resolution: Fixed
Merged to master. Thanks [~ankurmahe]!
> Pherf CLI option long/short option names do not follow conventions
> --
>
> Key: PHOENIX-6554
> URL: https://issues.apache.org/jira/browse/PHOENIX-6554
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Affects Versions: 5.2.0
>Reporter: Istvan Toth
>Assignee: Ankur Maheshwari
>Priority: Minor
> Fix For: 5.2.0
>
>
> The Pherf script does not use long and short option names consistently.
> for example:
> -t and --thin are for specifying the the thin PQS URL,
> and
> -z and --zookeeper are for the ZK quorum
> but
> -schemaFile is used to specify the schema file, and
> --schemaFile does not work.
> IMO options that look like long options should also be accepted with double
> dash, or we could just invent new short options for them (which would break
> backwards compatibility).
> i.e. instead of
> {code:java}
> options.addOption("schemaFile", true,
> "Regex or file name for the Test phoenix table schema .sql to
> use.");
> {code}
> we could have one of the following:
> {code:java}
> options.addOption("sf", "schemaFile", true,
> "Regex or file name for the Test phoenix table schema .sql to
> use.");
> options.addOption("schemaFile", "schemaFile", true,
> "Regex or file name for the Test phoenix table schema .sql to
> use.");
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (PHOENIX-6341) Enable running IT tests from PHERF module during builds and patch checkins
[ https://issues.apache.org/jira/browse/PHOENIX-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby resolved PHOENIX-6341. -- Resolution: Cannot Reproduce > Enable running IT tests from PHERF module during builds and patch checkins > -- > > Key: PHOENIX-6341 > URL: https://issues.apache.org/jira/browse/PHOENIX-6341 > Project: Phoenix > Issue Type: Test >Reporter: Jacob Isaac >Assignee: Kiran Kumar Maturi >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898299565 ## pom.xml: ## @@ -190,8 +175,8 @@ 1.10 1.3 -2.13.0 -3.4.9 +4.3.0 Review Comment: I believe in PHOENIX-6723 we set Curator in the main Phoenix to 4.2. Should we be consistent here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898298858
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
Review Comment:
@stoty should this be 2.4.10 given the recent investigation that showed a
Phoenix incompatibility in 2.4.11 and 2.4.12? (Of course, it should be 2.4.13
or 2.5 once they're released)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (PHOENIX-5587) Update documentation for secondary indexes
[ https://issues.apache.org/jira/browse/PHOENIX-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby resolved PHOENIX-5587. -- Fix Version/s: 5.1.3 (was: 4.17.0) (was: 4.16.2) Assignee: Kadir Ozdemir Resolution: Implemented Checked the website and the documentation has been updated -- I think Kadir did this. > Update documentation for secondary indexes > -- > > Key: PHOENIX-5587 > URL: https://issues.apache.org/jira/browse/PHOENIX-5587 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.1.0, 4.14.3 >Reporter: Geoffrey Jacoby >Assignee: Kadir Ozdemir >Priority: Major > Fix For: 5.2.0, 5.1.3 > > > Phoenix 4.14.3 and 4.15 (and the forthcoming 5.1) have a major revamp of the > secondary index framework, which requires manual upgrade steps on the part of > operators. These need to be documented in the Phoenix website docs. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (PHOENIX-5649) IndexScrutinyTool is very slow on view-indexes
[ https://issues.apache.org/jira/browse/PHOENIX-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby resolved PHOENIX-5649. -- Fix Version/s: (was: 4.17.0) (was: 5.2.0) (was: 4.16.2) Resolution: Not A Bug This was because of the particular schemas being used at the time. > IndexScrutinyTool is very slow on view-indexes > -- > > Key: PHOENIX-5649 > URL: https://issues.apache.org/jira/browse/PHOENIX-5649 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.14.3 >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > > From view-index to view, it scrutinizes about 7 rows per minute with batch > size 1. > From view to view-index, it is about 1000 rows per minute with batch size 1, > which is also very slow. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (PHOENIX-5518) Unittests for global index read repair count
[ https://issues.apache.org/jira/browse/PHOENIX-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-5518: - Fix Version/s: 5.2.1 (was: 4.17.0) (was: 5.2.0) (was: 4.16.2) > Unittests for global index read repair count > > > Key: PHOENIX-5518 > URL: https://issues.apache.org/jira/browse/PHOENIX-5518 > Project: Phoenix > Issue Type: Improvement >Reporter: Lars Hofhansl >Assignee: Kadir OZDEMIR >Priority: Major > Fix For: 5.2.1 > > > [~kadir] and I were tracking down a scenario where the read repair kept > increasing. > It turned out not to be a bug, but we realized that there is not test that > checks whether the read repair count is as expected as correctness is > guaranteed in any case. > So let's add a test case based on the read repairs metric we added some time > back. > I will not have time to work in, just filing in case somebody has. -- This message was sent by Atlassian Jira (v8.20.7#820007)
Re: [DISCUSS] New PhoenixDB release
I've just found https://issues.apache.org/jira/browse/PHOENIX-6731 If we can fix this quickly, then I will do a 1.2.0 release with the regenerated protobuf classes. regards Istvan On Wed, Jun 15, 2022 at 12:20 PM Istvan Toth wrote: > Hi! > > We've found and fixed a bug (PHOENIX-6727) in PhoenixDB. > I plan to release version 1.1.1 with the fix sometime in June. > > Any comments or objections ? > > regards > Istvan >
[jira] [Resolved] (PHOENIX-5534) Cursors With Request Metrics Enabled Throws Exception
[
https://issues.apache.org/jira/browse/PHOENIX-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Jacoby resolved PHOENIX-5534.
--
Resolution: Fixed
Merged to master and cherry-picked back to 5.1
> Cursors With Request Metrics Enabled Throws Exception
> -
>
> Key: PHOENIX-5534
> URL: https://issues.apache.org/jira/browse/PHOENIX-5534
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.13.0, 4.14.1, 4.14.2, 4.14.3
>Reporter: Daniel Wong
>Assignee: Geoffrey Jacoby
>Priority: Major
> Fix For: 5.2.0, 5.1.3
>
>
> Metrics are attempted to be setup twice during this path which causes an
> exception to be thrown.
> Recreation:
> Adding
>
> {code:java}
> props.put("phoenix.query.request.metrics.enabled","true");
>
> {code}
> To the CursorLifecycleCompile() method in CursorCompilerTest and running the
> test.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (PHOENIX-6731) PhoenixDB incompatible with Python 3.19+
Istvan Toth created PHOENIX-6731:
Summary: PhoenixDB incompatible with Python 3.19+
Key: PHOENIX-6731
URL: https://issues.apache.org/jira/browse/PHOENIX-6731
Project: Phoenix
Issue Type: Bug
Components: python, queryserver
Affects Versions: queryserver-6.0.0
Reporter: Istvan Toth
While running the PQS test suite on Python 3.19, I got the following error:
{noformat}
Traceback (most recent call last):
File
"/Users/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/phoenix-queryserver-it/./src/it/bin/test_phoenixdb.py",
line 21, in
import phoenixdb
File
"/Users/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/python-phoenixdb/phoenixdb/__init__.py",
line 19, in
from phoenixdb import errors, types
File
"/Users/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/python-phoenixdb/phoenixdb/types.py",
line 21, in
from phoenixdb.avatica.proto import common_pb2
File
"/Users/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/python-phoenixdb/phoenixdb/avatica/__init__.py",
line 16, in
from .client import AvaticaClient # noqa: F401
File
"/Users/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/python-phoenixdb/phoenixdb/avatica/client.py",
line 27, in
from phoenixdb.avatica.proto import common_pb2, requests_pb2, responses_pb2
File
"/Users/stoty/workspaces/apache-phoenix/phoenix-queryserver-parent/python-phoenixdb/phoenixdb/avatica/proto/common_pb2.py",
line 47, in
_descriptor.EnumValueDescriptor(
File
"/private/var/folders/vp/3bcljvzx1rl7cjrs_s7r4mp8gp/T/tmp.SNangr0J/lib/python3.10/site-packages/google/protobuf/descriptor.py",
line 755, in __new__
_message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and
must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible
workarounds are:
1. Downgrade the protobuf package to 3.20.x or lower.
2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use
pure-Python parsing and will be much slower).More information:
https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates{noformat}
The best course of action probably to re-generate the protobuf code as
suggested above.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (PHOENIX-6640) Bump Avatica to latest in PQS
[ https://issues.apache.org/jira/browse/PHOENIX-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated PHOENIX-6640: - Summary: Bump Avatica to latest in PQS (was: Bump Avatica to 1.20 in PQS) > Bump Avatica to latest in PQS > - > > Key: PHOENIX-6640 > URL: https://issues.apache.org/jira/browse/PHOENIX-6640 > Project: Phoenix > Issue Type: Improvement > Components: queryserver >Affects Versions: queryserver-6.0.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (OMID-224) Switch default logging backend to log4j2
Istvan Toth created OMID-224: Summary: Switch default logging backend to log4j2 Key: OMID-224 URL: https://issues.apache.org/jira/browse/OMID-224 Project: Phoenix Omid Issue Type: Bug Reporter: Istvan Toth Assignee: Istvan Toth Hbase 2.4 has already switched, and we've deciced to do the same in the Phoenix projects. This only affects the TSO logging. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[DISCUSS] New PhoenixDB release
Hi! We've found and fixed a bug (PHOENIX-6727) in PhoenixDB. I plan to release version 1.1.1 with the fix sometime in June. Any comments or objections ? regards Istvan
