[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343658#comment-15343658 ] Ankit Singhal commented on PHOENIX-2822: I see this issue committed with addendum. so resolving it. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > Attachments: PHOENIX-2822-98.patch, PHOENIX-2822.addendum, > PHOENIX-2822.addendum-v1.patch, PHOENIX-2822.patch > > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237896#comment-15237896 ] Hudson commented on PHOENIX-2822: - SUCCESS: Integrated in Phoenix-master #1192 (See [https://builds.apache.org/job/Phoenix-master/1192/]) PHOENIX-2822 Addendum to fix failing tests (Rahul Gidwani) (samarth: rev 0490484b022fd8218e52d6d72858192ef3c59441) * phoenix-core/src/it/java/org/apache/phoenix/end2end/HBaseManagedTimeTableReuseTest.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/LikeExpressionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseHBaseManagedTimeTableReuseIT.java * pom.xml * phoenix-core/src/it/java/org/apache/phoenix/end2end/HBaseManagedTimeTest.java > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > Attachments: PHOENIX-2822-98.patch, PHOENIX-2822.addendum, > PHOENIX-2822.addendum-v1.patch, PHOENIX-2822.patch > > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233048#comment-15233048 ] Hudson commented on PHOENIX-2822: - FAILURE: Integrated in Phoenix-master #1189 (See [https://builds.apache.org/job/Phoenix-master/1189/]) PHOENIX-2822 Tests that extend BaseHBaseManagedTimeIT are very (samarth: rev 6d147896f5856e728c454e4a1fa47575d9690aa7) * phoenix-core/src/it/java/org/apache/phoenix/end2end/StoreNullsIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryMoreIT.java * phoenix-core/src/it/java/org/apache/phoenix/iterate/PhoenixQueryTimeoutIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterSessionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/salted/SaltedTableVarLengthRowKeyIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/RTrimFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/AutoCommitIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/AbsFunctionEnd2EndIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicFamilyIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/salted/SaltedTableUpsertSelectIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/LikeExpressionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/PrimitiveTypeIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropViewIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ServerExceptionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayToStringFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/GetSetByteBitFunctionEnd2EndIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/PowerFunctionEnd2EndIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/RegexpSplitFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectAutoCommitIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/MinMaxAggregateFunctionIT.java * phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/TimezoneOffsetFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ArraysWithNullsIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ReverseFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/MD5FunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/MappingTableDataTypeIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/CbrtFunctionEnd2EndIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ConvertTimezoneFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseHBaseManagedTimeIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayFillFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ReadOnlyIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/OctetLengthFunctionEnd2EndIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/SortOrderIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/ArithmeticQueryIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/DecodeFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/StatementHintsIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/RoundFloorCeilFunctionsEnd2EndIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseHBaseManagedTimeTableReuseIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/StringToArrayFunctionIT.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/SignFunctionEnd2EndIT.java * phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/NthValueFunctionIT.java * phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java * phoenix-core/src/it/java/org/apache/phoenix/end2end/FirstValueFunctionIT.java > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > Attachments: PHOENIX-2822-98.patch, PHOENIX-2822.patch > > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont hav
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232955#comment-15232955 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207610636 @samarthjain rebased and put patch up here: https://issues.apache.org/jira/browse/PHOENIX-2822 . Thanks for the review. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > Attachments: PHOENIX-2822.patch > > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232883#comment-15232883 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207594418 @churrodog - can you please post a rebased patch on the jira. The current patch doesn't apply on master. Thanks! > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232872#comment-15232872 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207591521 Thanks @churrodog. Nice work! > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232499#comment-15232499 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207521158 made the changes you requested. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230548#comment-15230548 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-206989941 The pull request looks great @churrodog. Just a couple of minor nits. I will get this committed once you have the changes in. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230516#comment-15230516 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/158#discussion_r58903054 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java --- @@ -94,6 +85,20 @@ private long allocateBytes(long minBytes, long reqBytes) { return nBytes; } +@VisibleForTesting void waitForBytesToFree(long minBytes, long startTimeMs) { --- End diff -- Minor nit: Missing line carriage after @VisibleForTesting > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230507#comment-15230507 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/158#discussion_r58902469 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java --- @@ -69,35 +76,38 @@ private static void sleepFor(long time) { } @Test -public void testWaitForMemoryAvailable() { -final GlobalMemoryManager gmm = new GlobalMemoryManager(100,8000); +public void testWaitForMemoryAvailable() throws Exception { +final GlobalMemoryManager gmm = spy(new GlobalMemoryManager(100, 80)); final ChildMemoryManager rmm1 = new ChildMemoryManager(gmm,100); final ChildMemoryManager rmm2 = new ChildMemoryManager(gmm,100); +final CountDownLatch latch = new CountDownLatch(2); Thread t1 = new Thread() { @Override public void run() { MemoryChunk c1 = rmm1.allocate(50); MemoryChunk c2 = rmm1.allocate(50); -sleepFor(4000); +sleepFor(40); c1.close(); -sleepFor(2000); +sleepFor(20); c2.close(); +latch.countDown(); } }; Thread t2 = new Thread() { @Override public void run() { -sleepFor(2000); +sleepFor(20); // Will require waiting for a bit of time before t1 frees the requested memory -long startTime = System.currentTimeMillis(); +Stopwatch watch = new Stopwatch().start(); --- End diff -- Actually, I don't see this watch being used anywhere. Make sure you have the phoenix eclipse preferences imported. This should have been flagged as an unused variable warning. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230504#comment-15230504 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/158#discussion_r58902347 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/memory/MemoryManagerTest.java --- @@ -19,19 +19,26 @@ import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; +import static org.mockito.Matchers.anyLong; +import static org.mockito.Mockito.atLeastOnce; +import static org.mockito.Mockito.spy; +import com.google.common.base.Stopwatch; --- End diff -- Don't use the guava StopWatch here. We have run into conflicts before because of mismatches in guava versions. You can use the PhoenixStopWatch class here instead. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228574#comment-15228574 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-206450571 I also un-ignored the memory manager test in the last commit and fixed it up to remove the long sleeps. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228544#comment-15228544 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/158#discussion_r58735016 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AbsFunctionEnd2EndIT.java --- @@ -43,9 +44,10 @@ public void initTable() throws Exception { Connection conn = null; PreparedStatement stmt = null; try { +System.out.println("TABLE_NAME = " + TABLE_NAME); --- End diff -- no problem > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227869#comment-15227869 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-206168313 @samarthjain - would you mind reviewing and committing if it looks good to you? > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227868#comment-15227868 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/158#discussion_r58660241 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AbsFunctionEnd2EndIT.java --- @@ -43,9 +44,10 @@ public void initTable() throws Exception { Connection conn = null; PreparedStatement stmt = null; try { +System.out.println("TABLE_NAME = " + TABLE_NAME); --- End diff -- Minor nit - remove this. > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227000#comment-15227000 ] ASF GitHub Bot commented on PHOENIX-2822: - GitHub user churrodog opened a pull request: https://github.com/apache/phoenix/pull/158 PHOENIX-2822 - Tests that extend BaseHBaseManagedTimeIT are very slow You can merge this pull request into a Git repository by running: $ git pull https://github.com/churrodog/phoenix PHOENIX-2822 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 8325d00cd01b2a7d71b52b7c6d0ff5f6147ba47a Author: rahul gidwani Date: 2016-04-05T19:38:21Z PHOENIX-2822 - Tests that extend BaseHBaseManagedTimeIT are very slow Conflicts: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java > Tests that extend BaseHBaseManagedTimeIT are very slow > -- > > Key: PHOENIX-2822 > URL: https://issues.apache.org/jira/browse/PHOENIX-2822 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.8.0 >Reporter: churro morales >Assignee: churro morales > Labels: HBASEDEPENDENCIES > > Since I am trying to refactor out all the hbase private dependencies, I have > to constantly run tests to make sure I didn't break anything. The tests that > extend BaseHBaseManagedTimeIT are very slow as they have to delete all > non-system tables after every test case. This takes around 5-10 seconds to > accomplish. This adds significant time to the test suite. > I created a new class named: BaseHBaseManagedTimeTableReuseIT and it creates > a random table name such that we dont have collisions for tests. It also > doesn't do any cleanup after each test case or class because these table > names should be unique. I moved about 30-35 tests out from > BaseHBaseManagedTimeIT to BaseHBaseManagedTimeTableReuseIT and it > significantly improved the overall time it takes to run tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)