[jira] Created: (PIVOT-502) Building with Ant 1.8 gives warnings on the javac tasks
Building with Ant 1.8 gives warnings on the javac tasks --- Key: PIVOT-502 URL: https://issues.apache.org/jira/browse/PIVOT-502 Project: Pivot Issue Type: Improvement Affects Versions: 1.5 Environment: Windows XP SP3, Sun JDK 1.6.0_16, Apache Ant 1.8.0, using Pivot SVN trunk as of 5/24/10 Reporter: Roger Whitcomb Priority: Minor Fix For: 1.5 If I do an ant install (for instance) there are a series of warnings in the output: [javac] C:\Projects\Pivot\svn\trunk\build.xml:127: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds It would be cleaner if the build.xml set includeAntRuntime='false' on all the javac tasks to get rid of this warning (or else persuade the Ant project to change this behavior ;) ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIVOT-503) Using ClearType, bold text in Pivot 1.5 looks very bad
[ https://issues.apache.org/jira/browse/PIVOT-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-503: - Attachment: screenshot-1.jpg This is from Pivot 1.4 Using ClearType, bold text in Pivot 1.5 looks very bad -- Key: PIVOT-503 URL: https://issues.apache.org/jira/browse/PIVOT-503 Project: Pivot Issue Type: Bug Affects Versions: 1.5 Environment: WIndows XP SP3, Dell 24 monitor, 1920x1200 resolution, NVIDIA Quadro FX 570 video card, Dell T5400 machine, Pivot 1.5 using SVN trunk on 5/24/10 Reporter: Roger Whitcomb Fix For: 1.5 Attachments: screenshot-1.jpg ClearType is enabled and setup using the Wizard for best readability on my system. Text rendered as BOLD (for instance in Border components) looks good in Pivot 1.4 (release), but looks very bad in 1.5 as of 5/24/10. See attached screenshots. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIVOT-503) Using ClearType, bold text in Pivot 1.5 looks very bad
[ https://issues.apache.org/jira/browse/PIVOT-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-503: - Attachment: screenshot-2.jpg This is from 1.5 -- notice the O characters appear taller and the verticals on the N appear thinner. Using ClearType, bold text in Pivot 1.5 looks very bad -- Key: PIVOT-503 URL: https://issues.apache.org/jira/browse/PIVOT-503 Project: Pivot Issue Type: Bug Affects Versions: 1.5 Environment: WIndows XP SP3, Dell 24 monitor, 1920x1200 resolution, NVIDIA Quadro FX 570 video card, Dell T5400 machine, Pivot 1.5 using SVN trunk on 5/24/10 Reporter: Roger Whitcomb Fix For: 1.5 Attachments: screenshot-1.jpg, screenshot-2.jpg ClearType is enabled and setup using the Wizard for best readability on my system. Text rendered as BOLD (for instance in Border components) looks good in Pivot 1.4 (release), but looks very bad in 1.5 as of 5/24/10. See attached screenshots. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-503) Using ClearType, bold text in Pivot 1.5 looks very bad
[ https://issues.apache.org/jira/browse/PIVOT-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870872#action_12870872 ] Roger Whitcomb commented on PIVOT-503: -- I like screenshot-1.jpg myself, but that I got using 1.4. screenshot-2.jpg (which I don't like) was what I got with 1.5 -- it doesn't look like any of your screenshots. So, am I doing something different than you are? Using ClearType, bold text in Pivot 1.5 looks very bad -- Key: PIVOT-503 URL: https://issues.apache.org/jira/browse/PIVOT-503 Project: Pivot Issue Type: Bug Affects Versions: 1.5 Environment: WIndows XP SP3, Dell 24 monitor, 1920x1200 resolution, NVIDIA Quadro FX 570 video card, Dell T5400 machine, Pivot 1.5 using SVN trunk on 5/24/10 Reporter: Roger Whitcomb Assignee: Greg Brown Fix For: 1.5 Attachments: osx-pivot.png, screenshot-1.jpg, screenshot-2.jpg, windows-native.png, windows-pivot.png ClearType is enabled and setup using the Wizard for best readability on my system. Text rendered as BOLD (for instance in Border components) looks good in Pivot 1.4 (release), but looks very bad in 1.5 as of 5/24/10. See attached screenshots. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-503) Using ClearType, bold text in Pivot 1.5 looks very bad
[
https://issues.apache.org/jira/browse/PIVOT-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870883#action_12870883
]
Roger Whitcomb commented on PIVOT-503:
--
I didn't do anything to change the font. Here is the declaration:
Border title= INFORMATION
preferredWidth=460 preferredHeight=320
styles={color:'#404040',
titleColor:'#00', thickness:2,
cornerRadii:20, padding:8,
backgroundColor:'#E8E8E8'}
That's why I'm a little puzzled. I wouldn't mind either of your Windows
screenshots, it' just the one I'm getting that I don't like. The O is fuzzy
and looks too tall, and the verticals on the N look thin, neither of which I
see in your Windows-native, nor windows-pivot screenshot.
I'm wondering if something weird is going on with the Border component? Does
it do something different that a straight label?
Using ClearType, bold text in Pivot 1.5 looks very bad
--
Key: PIVOT-503
URL: https://issues.apache.org/jira/browse/PIVOT-503
Project: Pivot
Issue Type: Bug
Affects Versions: 1.5
Environment: WIndows XP SP3, Dell 24 monitor, 1920x1200 resolution,
NVIDIA Quadro FX 570 video card, Dell T5400 machine, Pivot 1.5 using SVN
trunk on 5/24/10
Reporter: Roger Whitcomb
Assignee: Greg Brown
Fix For: 1.5
Attachments: osx-pivot.png, screenshot-1.jpg, screenshot-2.jpg,
windows-native.png, windows-pivot.png
ClearType is enabled and setup using the Wizard for best readability on my
system. Text rendered as BOLD (for instance in Border components) looks
good in Pivot 1.4 (release), but looks very bad in 1.5 as of 5/24/10. See
attached screenshots.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-503) Using ClearType, bold text in Pivot 1.5 looks very bad
[ https://issues.apache.org/jira/browse/PIVOT-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870958#action_12870958 ] Roger Whitcomb commented on PIVOT-503: -- Thank you for fixing it so promptly! Using ClearType, bold text in Pivot 1.5 looks very bad -- Key: PIVOT-503 URL: https://issues.apache.org/jira/browse/PIVOT-503 Project: Pivot Issue Type: Bug Affects Versions: 1.5 Environment: WIndows XP SP3, Dell 24 monitor, 1920x1200 resolution, NVIDIA Quadro FX 570 video card, Dell T5400 machine, Pivot 1.5 using SVN trunk on 5/24/10 Reporter: Roger Whitcomb Assignee: Greg Brown Fix For: 1.5 Attachments: osx-pivot.png, screenshot-1.jpg, screenshot-2.jpg, windows-native.png, windows-pivot.png ClearType is enabled and setup using the Wizard for best readability on my system. Text rendered as BOLD (for instance in Border components) looks good in Pivot 1.4 (release), but looks very bad in 1.5 as of 5/24/10. See attached screenshots. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-544) Add a command line argument, --undecorated, to support removing native Frame chrome on a non-fullscreen window
[ https://issues.apache.org/jira/browse/PIVOT-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12882229#action_12882229 ] Roger Whitcomb commented on PIVOT-544: -- Just wanted to add to the use case for this change: Kiosk applications where the app is deployed in a mall or store setting and the computer is running only this app and users interact with it without knowing the OS or anything behind it. Generally you DON'T want the user to close the app anyway ;) Add a command line argument, --undecorated, to support removing native Frame chrome on a non-fullscreen window Key: PIVOT-544 URL: https://issues.apache.org/jira/browse/PIVOT-544 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 1.5 Reporter: Michael Allman Fix For: 2.0 Attachments: undecorated_command_line_arg_trunk.patch Attached is a patch which adds a new command line argument for Pivot desktop apps, --undecorated=(true|false), that allows for an undecorated top level frame. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-583) Add parent to TreeNode/TreeBranch
[ https://issues.apache.org/jira/browse/PIVOT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894971#action_12894971 ] Roger Whitcomb commented on PIVOT-583: -- FWIW -- every time I've implemented my own Tree data structures they always have had a parent link -- makes many things that you have to do in traversing the tree much easier. Add parent to TreeNode/TreeBranch - Key: PIVOT-583 URL: https://issues.apache.org/jira/browse/PIVOT-583 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Greg Brown Priority: Minor Fix For: 2.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (PIVOT-626) Add userData member to TreeNode to facilitate right-click menu handling (among other things)
Add userData member to TreeNode to facilitate right-click menu handling (among other things) -- Key: PIVOT-626 URL: https://issues.apache.org/jira/browse/PIVOT-626 Project: Pivot Issue Type: Wish Components: wtk Affects Versions: 1.5.1 Environment: WIndows XP SP3 Reporter: Roger Whitcomb Priority: Minor Fix For: 1.5.2 This wish/enhancement would be useful for those using the default TreeNode/TreeBranch as the data model for a TreeView -- the use case is the situation where an icon and/or string is sufficient for rendering in the tree but another type of object is more appropriate for determining (for instance) the right-click menu behavior, or the selection behavior of the tree node. The String override for setUserData also allows setting this property via WTKX/BXML files. Diff file attached to the issue I have running already. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-626) Add userData member to TreeNode to facilitate right-click menu handling (among other things)
[ https://issues.apache.org/jira/browse/PIVOT-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906084#action_12906084 ] Roger Whitcomb commented on PIVOT-626: -- Cool. Thank you. Yeah, I added the String setter just to make sure it would work, but if it's not necessary, then that's great. Add userData member to TreeNode to facilitate right-click menu handling (among other things) -- Key: PIVOT-626 URL: https://issues.apache.org/jira/browse/PIVOT-626 Project: Pivot Issue Type: Wish Components: wtk Affects Versions: 1.5.1 Environment: WIndows XP SP3 Reporter: Roger Whitcomb Priority: Minor Fix For: 1.5.2, 2.0 Attachments: userdata.diff Original Estimate: 0.17h Remaining Estimate: 0.17h This wish/enhancement would be useful for those using the default TreeNode/TreeBranch as the data model for a TreeView -- the use case is the situation where an icon and/or string is sufficient for rendering in the tree but another type of object is more appropriate for determining (for instance) the right-click menu behavior, or the selection behavior of the tree node. The String override for setUserData also allows setting this property via WTKX/BXML files. Diff file attached to the issue I have running already. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (PIVOT-644) Improve JSONSerializer to ignore a BOM at the beginning of file
Improve JSONSerializer to ignore a BOM at the beginning of file --- Key: PIVOT-644 URL: https://issues.apache.org/jira/browse/PIVOT-644 Project: Pivot Issue Type: Improvement Components: core-json Affects Versions: 1.5.1 Environment: Windows XP SP3, Java JDK 1.6.0_16 Reporter: Roger Whitcomb Priority: Minor Fix For: 1.5.2 A true UTF-8 file that includes the UTF-8 BOM at the beginning (0xEF, 0xBB, 0xBF) produces a SerializationError on the BOM character. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIVOT-674) Add Translations for existing Resources
[ https://issues.apache.org/jira/browse/PIVOT-674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-674: - Attachment: local_zh_cn.zip Here are Chinese versions from one of our developers. The files have a UTF-8 BOM still Add Translations for existing Resources --- Key: PIVOT-674 URL: https://issues.apache.org/jira/browse/PIVOT-674 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0 Attachments: local_zh_cn.zip, localized_de.zip, localized_es.zip, localized_fr.tar.gz, localized_fr.zip, localized_pl.zip We have a few localizable assets in the Pivot codebase: /org/apache/pivot/wtk/Alert.json /org/apache/pivot/wtk/Prompt.json /org/apache/pivot/wtk/skin/terra/TerraFileBrowserSheetSkin.json /org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.json Currently, we only have English versions for most of these, though recently a German version of Alert.json was added. It would be great if these could be translated into more languages before 2.0 is released. If anyone is willing to perform this translation, it would be very much appreciated. Important: remember to create json files in UTF-8 (maybe copying existing ones, but please verify if they are UTF-8 encoded, as should be), or with some chars there could be some encoding problems. Last, please remember to add localized resources here (possibly inside a zip, by Language or Country), and to flag the Inclusion for ASF Work license grant, so we can use them. As soon as possible I'll post mine for Italian, so others are welcome ... Thank you very much for your help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIVOT-674) Add Translations for existing Resources
[ https://issues.apache.org/jira/browse/PIVOT-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935534#action_12935534 ] Roger Whitcomb edited comment on PIVOT-674 at 11/24/10 5:10 PM: Here are Chinese versions from one of our developers. The files are in UTF-16 format (with a BOM). was (Author: whiro01): Here are Chinese versions from one of our developers. The files have a UTF-8 BOM still Add Translations for existing Resources --- Key: PIVOT-674 URL: https://issues.apache.org/jira/browse/PIVOT-674 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0 Attachments: local_zh_cn.zip, localized_de.zip, localized_es.zip, localized_fr.tar.gz, localized_fr.zip, localized_pl.zip We have a few localizable assets in the Pivot codebase: /org/apache/pivot/wtk/Alert.json /org/apache/pivot/wtk/Prompt.json /org/apache/pivot/wtk/skin/terra/TerraFileBrowserSheetSkin.json /org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.json Currently, we only have English versions for most of these, though recently a German version of Alert.json was added. It would be great if these could be translated into more languages before 2.0 is released. If anyone is willing to perform this translation, it would be very much appreciated. Important: remember to create json files in UTF-8 (maybe copying existing ones, but please verify if they are UTF-8 encoded, as should be), or with some chars there could be some encoding problems. Last, please remember to add localized resources here (possibly inside a zip, by Language or Country), and to flag the Inclusion for ASF Work license grant, so we can use them. As soon as possible I'll post mine for Italian, so others are welcome ... Thank you very much for your help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIVOT-703) Allow BXMLSerializer.bind() to access superclass fields
[ https://issues.apache.org/jira/browse/PIVOT-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-703: - Attachment: diff Here is a patch to implement this change -- required refactoring the loop inside bind to loop over keys in the namespace and call either getDeclaredField() or getField() on the name. Allow BXMLSerializer.bind() to access superclass fields --- Key: PIVOT-703 URL: https://issues.apache.org/jira/browse/PIVOT-703 Project: Pivot Issue Type: Improvement Components: core-beans Affects Versions: 2.0 Environment: Windows XP SP3, Java version 1.6.0_23 Reporter: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.0.1 Attachments: diff Original Estimate: 1h Remaining Estimate: 1h Loading a standard object from a BXML file (such as a Dialog) so that the code to bind to a superclass when the Bindable interface is present on the serialized object is not exercised, allow bind to find public fields in a superclass by calling getField() if getDeclaredField() fails. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (PIVOT-703) Allow BXMLSerializer.bind() to access superclass fields
Allow BXMLSerializer.bind() to access superclass fields --- Key: PIVOT-703 URL: https://issues.apache.org/jira/browse/PIVOT-703 Project: Pivot Issue Type: Improvement Components: core-beans Affects Versions: 2.0 Environment: Windows XP SP3, Java version 1.6.0_23 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: diff Loading a standard object from a BXML file (such as a Dialog) so that the code to bind to a superclass when the Bindable interface is present on the serialized object is not exercised, allow bind to find public fields in a superclass by calling getField() if getDeclaredField() fails. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (PIVOT-703) Allow BXMLSerializer.bind() to access superclass fields
[ https://issues.apache.org/jira/browse/PIVOT-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-703. Resolution: Not A Problem Using the bind(Object object, Class? type) method is perfect to do what I needed. Allow BXMLSerializer.bind() to access superclass fields --- Key: PIVOT-703 URL: https://issues.apache.org/jira/browse/PIVOT-703 Project: Pivot Issue Type: Improvement Components: core-beans Affects Versions: 2.0 Environment: Windows XP SP3, Java version 1.6.0_23 Reporter: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.0.1 Attachments: diff Original Estimate: 1h Remaining Estimate: 1h Loading a standard object from a BXML file (such as a Dialog) so that the code to bind to a superclass when the Bindable interface is present on the serialized object is not exercised, allow bind to find public fields in a superclass by calling getField() if getDeclaredField() fails. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
[ https://issues.apache.org/jira/browse/PIVOT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-719: - Attachment: windows-normal-usage-1.jpg Example of normal Windows usage Ctrl+Alt+F Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: windows-keyboard-shortcut-problem.jpg, windows-normal-usage-1.jpg Original Estimate: 1h Remaining Estimate: 1h All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
[ https://issues.apache.org/jira/browse/PIVOT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-719: - Attachment: windows-normal-usage-2.jpg Here is an example with just F5. Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: windows-keyboard-shortcut-problem.jpg, windows-normal-usage-1.jpg, windows-normal-usage-2.jpg Original Estimate: 1h Remaining Estimate: 1h All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
[ https://issues.apache.org/jira/browse/PIVOT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-719: - Attachment: keyboard.patch Here is a patch to fix both problems. Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: keyboard.patch, windows-keyboard-shortcut-problem.jpg, windows-normal-usage-1.jpg, windows-normal-usage-2.jpg Original Estimate: 1h Remaining Estimate: 1h All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-745) Illegal argument exception on tristate checkbox using stateKey binding
Illegal argument exception on tristate checkbox using stateKey binding
--
Key: PIVOT-745
URL: https://issues.apache.org/jira/browse/PIVOT-745
Project: Pivot
Issue Type: Bug
Components: wtk
Affects Versions: 2.0.1
Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Priority: Minor
Fix For: 2.0.1
Button.store on a tristate checkbox using stateKey binding gets an error:
java.lang.IllegalArgumentException: path is null.
at org.apache.pivot.json.JSON.parse(JSON.java:259)
at org.apache.pivot.json.JSON.put(JSON.java:137)
at org.apache.pivot.wtk.Button.store(Button.java:772)
Due to the following code:
if (stateKey != null
stateBindType != BindType.LOAD) {
JSON.put(context, selectedKey, (stateBindMapping == null) ?
The put should be using stateKey not selectedKey.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-745) Illegal argument exception on tristate checkbox using stateKey binding
[
https://issues.apache.org/jira/browse/PIVOT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-745:
-
Attachment: button.diff
Here is a patch that fixes the problem.
Illegal argument exception on tristate checkbox using stateKey binding
--
Key: PIVOT-745
URL: https://issues.apache.org/jira/browse/PIVOT-745
Project: Pivot
Issue Type: Bug
Components: wtk
Affects Versions: 2.0.1
Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Priority: Minor
Fix For: 2.0.1
Attachments: button.diff
Original Estimate: 0.5h
Remaining Estimate: 0.5h
Button.store on a tristate checkbox using stateKey binding gets an error:
java.lang.IllegalArgumentException: path is null.
at org.apache.pivot.json.JSON.parse(JSON.java:259)
at org.apache.pivot.json.JSON.put(JSON.java:137)
at org.apache.pivot.wtk.Button.store(Button.java:772)
Due to the following code:
if (stateKey != null
stateBindType != BindType.LOAD) {
JSON.put(context, selectedKey, (stateBindMapping == null)
?
The put should be using stateKey not selectedKey.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.0.1 Attachments: version.patch Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-746: - Attachment: version.patch Here is a patch that implements this feature. Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.0.1 Attachments: version.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036896#comment-13036896 ] Roger Whitcomb commented on PIVOT-746: -- I was piggybacking on two things: 1) ApplicationContext already has a getJVMVersion() method, so this is very similar -- since ApplicationContext is in the wtk area, this is where it had to happen. However, I changed the generic package macro, so actually the version file build.properties is embedded in all the .jar files. 2) The build.properties file was already being used as the sole source for the Pivot version number, so I added nothing new. If the name needs to be changed for Eclipse, that is definitely outside the realm of this small change. AFAIK the classloader I'm using should be correct because it must load the build.properties from the same .jar file where the ApplicationContext.class file is located. Is there a problem with that in other environments?? Thanks. Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.0.1 Attachments: version.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13037987#comment-13037987 ] Roger Whitcomb commented on PIVOT-746: -- I'd be happy to do it, except that I know next to nothing about Eclipse... But if someone can point me to what has to change I can do it. Sandro, all I did was add our build.properties file to all the built .jar files. So, if there is a setting in the Eclipse projects that specifies what the .jar files contain, that just needs to be updated (or something like that). Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Greg Brown Priority: Trivial Fix For: 2.0.1 Attachments: pivot746_patch2.patch, version.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13038012#comment-13038012 ] Roger Whitcomb commented on PIVOT-746: -- Can't we just set the classpath for Eclipse to include our build.properties and leave the code the way it was? If we just ensure that build.properties is always available then there is nothing more to do. I just don't know how to set the Eclipse classpath. Is that done in some of the .settings files? Or somehow via the .classpath file? Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Greg Brown Priority: Trivial Fix For: 2.0.1 Attachments: pivot746_patch2.patch, version.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-746: - Attachment: version2.patch Patch to use Package.getImplementationVersion() instead of the build.properties file; removes build.properties from the .jar files. Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Greg Brown Priority: Trivial Fix For: 2.0.1 Attachments: pivot746_patch2.patch, version.patch, version2.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13038949#comment-13038949 ] Roger Whitcomb commented on PIVOT-746: -- Okay, so here's a patch that reverts the addition of build.properties to the .jar files and instead uses Andrei's method to get the Implementation-Version (which is already set by the value from build.properties). It should be fail-safe in the case of running from .class files and not from .jars. Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Greg Brown Priority: Trivial Fix For: 2.0.1 Attachments: pivot746_patch2.patch, version.patch, version2.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties
[ https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13039252#comment-13039252 ] Roger Whitcomb commented on PIVOT-746: -- The only think I was wondering (which is why I was super-cautious) is that getPackage() can return null (such as when Pivot is run from .class files instead of a .jar?) so I didn't want Sandro's case to be broken again if that happened. Add API to return Version of Pivot retrieved from build.properties Key: PIVOT-746 URL: https://issues.apache.org/jira/browse/PIVOT-746 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Greg Brown Priority: Trivial Fix For: 2.0.1 Attachments: pivot746_patch2.patch, version.patch, version2.patch Original Estimate: 1h Remaining Estimate: 1h Would be helpful to be able to determine programmatically what the version of Pivot is. The simplest method is to include build.properties which is the original source of this information in the packaged .jar files and then to provide an API to read and parse this value into a Version structure. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-623) ellipsis style on labels
[ https://issues.apache.org/jira/browse/PIVOT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044494#comment-13044494 ] Roger Whitcomb commented on PIVOT-623: -- I have a slightly different possible solution to this type of problem: provide a wrapChars:'' style to add a list of characters to be used to split a string when there is not whitespace (to be used in conjunction with wrapText:true. ellipsis style on labels Key: PIVOT-623 URL: https://issues.apache.org/jira/browse/PIVOT-623 Project: Pivot Issue Type: Wish Components: wtk, wtk-terra Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.1 Add an ellipsis style on labels (default off), to trim the drawn label if it's too long in respect of the space assigned. Depending on the chosen style, ellipsis chars could go at end of the label, at center, at start, etc ... Could be useful in some cases to have also strange behaviors, like for URLs or file paths where for example could be useful to trim some parts of the string but near the end of the path, but keeping the filename part full (if possible). Verify if enable user defined behaviors also (for example giving in a sub-style attribute the full classname of a custom implementation, but maybe this could be too complex or not in line with other parts in Pivot. Verify if add also a sub-style attribute to set a different char to use for the ellipsis (instead of the default ...). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-623) ellipsis style on labels
[
https://issues.apache.org/jira/browse/PIVOT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Whitcomb updated PIVOT-623:
-
Attachment: label.diff
This patch implements the wrapChars style.
An example of its use is:
Label bxml:id=serverName styles={font:{bold:true, italic:true},
padding:{left:10}, wrapText:true, wrapChars:'.-_/\\'} /
ellipsis style on labels
Key: PIVOT-623
URL: https://issues.apache.org/jira/browse/PIVOT-623
Project: Pivot
Issue Type: Wish
Components: wtk, wtk-terra
Reporter: Sandro Martini
Assignee: Sandro Martini
Priority: Minor
Fix For: 2.1
Attachments: label.diff
Add an ellipsis style on labels (default off), to trim the drawn label if
it's too long in respect of the space assigned.
Depending on the chosen style, ellipsis chars could go at end of the label,
at center, at start, etc ...
Could be useful in some cases to have also strange behaviors, like for URLs
or file paths where for example could be useful to trim some parts of the
string but near the end of the path, but keeping the filename part full (if
possible).
Verify if enable user defined behaviors also (for example giving in a
sub-style attribute the full classname of a custom implementation, but maybe
this could be too complex or not in line with other parts in Pivot.
Verify if add also a sub-style attribute to set a different char to use for
the ellipsis (instead of the default ...).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-623) ellipsis style on labels
[ https://issues.apache.org/jira/browse/PIVOT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044767#comment-13044767 ] Roger Whitcomb commented on PIVOT-623: -- Hi Sandro, I haven't been told I have commit grants yet, so . Better if you want to commit the patch (assuming no objections). ellipsis style on labels Key: PIVOT-623 URL: https://issues.apache.org/jira/browse/PIVOT-623 Project: Pivot Issue Type: Wish Components: wtk, wtk-terra Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.1 Attachments: label.diff Add an ellipsis style on labels (default off), to trim the drawn label if it's too long in respect of the space assigned. Depending on the chosen style, ellipsis chars could go at end of the label, at center, at start, etc ... Could be useful in some cases to have also strange behaviors, like for URLs or file paths where for example could be useful to trim some parts of the string but near the end of the path, but keeping the filename part full (if possible). Verify if enable user defined behaviors also (for example giving in a sub-style attribute the full classname of a custom implementation, but maybe this could be too complex or not in line with other parts in Pivot. Verify if add also a sub-style attribute to set a different char to use for the ellipsis (instead of the default ...). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-623) ellipsis style on labels
[ https://issues.apache.org/jira/browse/PIVOT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044906#comment-13044906 ] Roger Whitcomb commented on PIVOT-623: -- I have a label field that displays a server/machine/host name, which normally (maybe always) will not have any spaces. On most systems the screen space available is sufficient, but on some (where the host includes the domain name or is simply a long name) there is not enough space, so I would like the text to wrap. But, even if wrapText is true it won't wrap this text because there is no whitespace. So, the intention is to be able to specify a list (one or more) of characters that can be used instead of whitespace to break the string for wrapping. This is specified to the skin as a style (same as wrapText). In my particular case, I have a wrapChars setting of .-_/\\ which are the only possible punctuation that would be in my text. What the patch does is prescan the text to see if there is any whitespace, and if not, then if a wrapChars string is specified it will use those characters instead of whitespace to break. The only other wrinkle is that is has to back up one char so that the non-whitespace wrapping character will still be displayed (on the subsequent line). So, on my example, my label text is roger-whitcombs-computer.local/MX. Without this change there is enough room for about roger-whitcombs-compu and then it disappears off the right edge. With this change and the wrapChars setting above it displays as: roger-whitcombs -computer.local/MX Is that a clear explanation? I'm not wedded to this concept, but I was trying to figure out a sensible scheme for allowing a wrap in the absence of whitespace. I thought of just using any punctuation, but there is not a single function in the Character class to figure this out and it was sort of messy to check all the possible Unicode punctuation attribute values. So, this approach seemed simpler and a bit more flexible (you could break on selected punctuation, or even on certain alphabetic or numeric characters if that made sense in your application). If it doesn't seem like something you want in Pivot, I can do the wrapping myself also in my app. Just seemed nicer to leverage the calculations that were already being done in LabelSkin. Thanks. ellipsis style on labels Key: PIVOT-623 URL: https://issues.apache.org/jira/browse/PIVOT-623 Project: Pivot Issue Type: Wish Components: wtk, wtk-terra Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.1 Attachments: label.diff Add an ellipsis style on labels (default off), to trim the drawn label if it's too long in respect of the space assigned. Depending on the chosen style, ellipsis chars could go at end of the label, at center, at start, etc ... Could be useful in some cases to have also strange behaviors, like for URLs or file paths where for example could be useful to trim some parts of the string but near the end of the path, but keeping the filename part full (if possible). Verify if enable user defined behaviors also (for example giving in a sub-style attribute the full classname of a custom implementation, but maybe this could be too complex or not in line with other parts in Pivot. Verify if add also a sub-style attribute to set a different char to use for the ellipsis (instead of the default ...). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-623) ellipsis style on labels
[ https://issues.apache.org/jira/browse/PIVOT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044952#comment-13044952 ] Roger Whitcomb commented on PIVOT-623: -- That's fairly reasonable, and in some of my cases this would work alright. I was just wondering if there might be additional reasonable break characters, but then the question was: which ones, which is why I let the user specify it. I kind of hijacked this issue because it was related, but we could open a separate one for just this feature. Having alternative break characters was another way to address the issue that ellipsis would provide. ellipsis style on labels Key: PIVOT-623 URL: https://issues.apache.org/jira/browse/PIVOT-623 Project: Pivot Issue Type: Wish Components: wtk, wtk-terra Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.1 Attachments: label.diff Add an ellipsis style on labels (default off), to trim the drawn label if it's too long in respect of the space assigned. Depending on the chosen style, ellipsis chars could go at end of the label, at center, at start, etc ... Could be useful in some cases to have also strange behaviors, like for URLs or file paths where for example could be useful to trim some parts of the string but near the end of the path, but keeping the filename part full (if possible). Verify if enable user defined behaviors also (for example giving in a sub-style attribute the full classname of a custom implementation, but maybe this could be too complex or not in line with other parts in Pivot. Verify if add also a sub-style attribute to set a different char to use for the ellipsis (instead of the default ...). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-753) Provide an alternative to whitespace for wrapping long Label text
Provide an alternative to whitespace for wrapping long Label text - Key: PIVOT-753 URL: https://issues.apache.org/jira/browse/PIVOT-753 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, OSX 10.6.7, RHEL 5.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.1 For long Label text that doesn't contain whitespace but with wrapText:true it would be nice to have an alternative place to wrap the text. Possible Solutions: - Provide a user-supplied wrapChars string containing suggested break characters - Break on either whitespace or some combination of Character attributes (for instance: DASH_PUNCTUATION or CONNECTOR_PUNCTUATION) - If there is no whitespace, then break at the exact boundary on whatever character is there (could be conditional on another wrapAnywhere:true style) - Some combination of the above - Use ellipsis as in PIVOT-623 without wrapText set. Note: there was preliminary discussion of this issue as part of the comments in PIVOT-623. Moved to a new issue to avoid further confusion of the original ellipsis issue there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-753) Provide an alternative to whitespace for wrapping long Label text
[ https://issues.apache.org/jira/browse/PIVOT-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-753: - Attachment: label.patch Patch originally attached to PIVOT-623 to implement the wrapChars:'string' style on Label to provide a list of possible characters to break the text on. Perhaps a better name would be breakChars. Provide an alternative to whitespace for wrapping long Label text - Key: PIVOT-753 URL: https://issues.apache.org/jira/browse/PIVOT-753 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, OSX 10.6.7, RHEL 5.6 Reporter: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.1 Attachments: label.patch For long Label text that doesn't contain whitespace but with wrapText:true it would be nice to have an alternative place to wrap the text. Possible Solutions: - Provide a user-supplied wrapChars string containing suggested break characters - Break on either whitespace or some combination of Character attributes (for instance: DASH_PUNCTUATION or CONNECTOR_PUNCTUATION) - If there is no whitespace, then break at the exact boundary on whatever character is there (could be conditional on another wrapAnywhere:true style) - Some combination of the above - Use ellipsis as in PIVOT-623 without wrapText set. Note: there was preliminary discussion of this issue as part of the comments in PIVOT-623. Moved to a new issue to avoid further confusion of the original ellipsis issue there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-753) Provide an alternative to whitespace for wrapping long Label text
[ https://issues.apache.org/jira/browse/PIVOT-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-753: - Attachment: label2.patch Here is an updated patch that (more or less) implements Greg's suggestion to just use Character types to decide where to wrap (in addition to whitespace). The only wrinkle is that for non-whitespace we have to set the location one ahead to display the wrapping character on the previous line and then jump back one so that the character actually gets displayed (whitespace doesn't need this). I took the liberty of adding one more type to Greg's suggestion (OTHER_PUNCTUATION) to catch dots and slashes as well. What do you think? Provide an alternative to whitespace for wrapping long Label text - Key: PIVOT-753 URL: https://issues.apache.org/jira/browse/PIVOT-753 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, OSX 10.6.7, RHEL 5.6 Reporter: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.1 Attachments: label.patch, label2.patch For long Label text that doesn't contain whitespace but with wrapText:true it would be nice to have an alternative place to wrap the text. Possible Solutions: - Provide a user-supplied wrapChars string containing suggested break characters - Break on either whitespace or some combination of Character attributes (for instance: DASH_PUNCTUATION or CONNECTOR_PUNCTUATION) - If there is no whitespace, then break at the exact boundary on whatever character is there (could be conditional on another wrapAnywhere:true style) - Some combination of the above - Use ellipsis as in PIVOT-623 without wrapText set. Note: there was preliminary discussion of this issue as part of the comments in PIVOT-623. Moved to a new issue to avoid further confusion of the original ellipsis issue there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-753) Provide an alternative to whitespace for wrapping long Label text
[ https://issues.apache.org/jira/browse/PIVOT-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048801#comment-13048801 ] Roger Whitcomb commented on PIVOT-753: -- Will do and I will post the testing results here also. Provide an alternative to whitespace for wrapping long Label text - Key: PIVOT-753 URL: https://issues.apache.org/jira/browse/PIVOT-753 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, OSX 10.6.7, RHEL 5.6 Reporter: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.1 Attachments: label.patch, label2.patch For long Label text that doesn't contain whitespace but with wrapText:true it would be nice to have an alternative place to wrap the text. Possible Solutions: - Provide a user-supplied wrapChars string containing suggested break characters - Break on either whitespace or some combination of Character attributes (for instance: DASH_PUNCTUATION or CONNECTOR_PUNCTUATION) - If there is no whitespace, then break at the exact boundary on whatever character is there (could be conditional on another wrapAnywhere:true style) - Some combination of the above - Use ellipsis as in PIVOT-623 without wrapText set. Note: there was preliminary discussion of this issue as part of the comments in PIVOT-623. Moved to a new issue to avoid further confusion of the original ellipsis issue there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-762) Incorrect handling of TAB key in SuggestionPopup
Incorrect handling of TAB key in SuggestionPopup Key: PIVOT-762 URL: https://issues.apache.org/jira/browse/PIVOT-762 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.7 beta Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-762) Incorrect handling of TAB key in SuggestionPopup
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-762: - Attachment: suggest.patch This patch seems to work for my test case. Incorrect handling of TAB key in SuggestionPopup Key: PIVOT-762 URL: https://issues.apache.org/jira/browse/PIVOT-762 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.7 beta Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: suggest.patch Original Estimate: 4h Remaining Estimate: 4h It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.1 Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-763: - Attachment: tristate.patch This patch implements the feature. Tested in our application where we have a TriState column in several of our TableViews. Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.1 Attachments: tristate.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052875#comment-13052875 ] Roger Whitcomb commented on PIVOT-763: -- That was the way I originally implemented it, but there was so much code overlap that I tried essentially combining them. But, it is easy enough to go back the other way. What do you think of using the load method on the Checkbox to set the value in the render() method? It seems like it does everything that is needed Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.1 Attachments: tristate.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052879#comment-13052879 ] Roger Whitcomb commented on PIVOT-763: -- The other thing I thought about was only changing the BooleanRenderer to make the checkbox protected, and then only override the constructor and render methods in the TriState case. That way there would be no tri-state code in the boolean one, and there would still be less code duplication Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.1 Attachments: tristate.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052884#comment-13052884 ] Roger Whitcomb commented on PIVOT-763: -- Do you mean making a base class TableViewCheckboxCellRenderer (that is just a rename of what I have for the Boolean one) and two subclasses: TableViewBooleanCellRenderer which just has a constructor that calls super(), and another subclass TableViewTriStateCellRenderer that just has a constructor with the super() and the setTriState() call? That way it wouldn't break any existing code, and make maximum reuse Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.1 Attachments: tristate.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-763: - Attachment: tristate2.patch Okay, this implements this hierarchy: base class with two subclasses. Tested with my application and all is well. Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.1 Attachments: tristate.patch, tristate2.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-763: - Fix Version/s: (was: 2.1) 2.0.1 Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.0.1 Attachments: tristate.patch, tristate2.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-763. -- Resolution: Fixed Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Priority: Trivial Fix For: 2.0.1 Attachments: tristate.patch, tristate2.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-763) Add tri-state checkbox renderer for TableView row editors
[ https://issues.apache.org/jira/browse/PIVOT-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reassigned PIVOT-763: Assignee: Roger Whitcomb Add tri-state checkbox renderer for TableView row editors - Key: PIVOT-763 URL: https://issues.apache.org/jira/browse/PIVOT-763 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, JDK 1.6_16 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Trivial Fix For: 2.0.1 Attachments: tristate.patch, tristate2.patch Original Estimate: 2h Remaining Estimate: 2h Adds a trivial extension to the possible cell editors for a TableView to support tri-state checkboxes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-762) Incorrect handling of TAB key in SuggestionPopup
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-762: - Attachment: suggest2.patch Updated patch with just the TAB/SHIFT-TAB handling straightened out. Incorrect handling of TAB key in SuggestionPopup Key: PIVOT-762 URL: https://issues.apache.org/jira/browse/PIVOT-762 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.7 beta Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml Original Estimate: 4h Remaining Estimate: 4h It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-762) Incorrect handling of TAB key in SuggestionPopup
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-762. -- Resolution: Fixed There are some ancillary issues which are/will be covered by other tickets. I believe this commit fixes the Tab/Shift-Tab issues for SuggestionPopup. Incorrect handling of TAB key in SuggestionPopup Key: PIVOT-762 URL: https://issues.apache.org/jira/browse/PIVOT-762 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.7 beta Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml Original Estimate: 4h Remaining Estimate: 4h It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-762) Incorrect handling of TAB key in SuggestionPopup
[ https://issues.apache.org/jira/browse/PIVOT-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053410#comment-13053410 ] Roger Whitcomb commented on PIVOT-762: -- Committed revision 1138592. Incorrect handling of TAB key in SuggestionPopup Key: PIVOT-762 URL: https://issues.apache.org/jira/browse/PIVOT-762 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.7 beta Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: suggest.patch, suggest2.patch, suggestion_popup_test.bxml Original Estimate: 4h Remaining Estimate: 4h It appears the TAB key handling inside SuggestionPopup either doesn't work at all to transfer focus or it tries to transfer and then transfers back to the TextInput. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-753) Provide an alternative to whitespace for wrapping long Label text
[ https://issues.apache.org/jira/browse/PIVOT-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reassigned PIVOT-753: Assignee: Roger Whitcomb Provide an alternative to whitespace for wrapping long Label text - Key: PIVOT-753 URL: https://issues.apache.org/jira/browse/PIVOT-753 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, OSX 10.6.7, RHEL 5.6 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.1 Attachments: label.patch, label2.patch For long Label text that doesn't contain whitespace but with wrapText:true it would be nice to have an alternative place to wrap the text. Possible Solutions: - Provide a user-supplied wrapChars string containing suggested break characters - Break on either whitespace or some combination of Character attributes (for instance: DASH_PUNCTUATION or CONNECTOR_PUNCTUATION) - If there is no whitespace, then break at the exact boundary on whatever character is there (could be conditional on another wrapAnywhere:true style) - Some combination of the above - Use ellipsis as in PIVOT-623 without wrapText set. Note: there was preliminary discussion of this issue as part of the comments in PIVOT-623. Moved to a new issue to avoid further confusion of the original ellipsis issue there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-753) Provide an alternative to whitespace for wrapping long Label text
[ https://issues.apache.org/jira/browse/PIVOT-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053537#comment-13053537 ] Roger Whitcomb commented on PIVOT-753: -- Went through every use of Label in our (pretty big now) application and the wrapping or non-wrapping was perfect. Places where it used to not wrap because of no whitespace are now wrapping nicely and there were no places where inappropriate wrap happened. There are some places where it is parsing RSS Feed text and putting into Labels with wrapText on and all these wrapped the way they should. Provide an alternative to whitespace for wrapping long Label text - Key: PIVOT-753 URL: https://issues.apache.org/jira/browse/PIVOT-753 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, OSX 10.6.7, RHEL 5.6 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Labels: features Fix For: 2.1 Attachments: label.patch, label2.patch For long Label text that doesn't contain whitespace but with wrapText:true it would be nice to have an alternative place to wrap the text. Possible Solutions: - Provide a user-supplied wrapChars string containing suggested break characters - Break on either whitespace or some combination of Character attributes (for instance: DASH_PUNCTUATION or CONNECTOR_PUNCTUATION) - If there is no whitespace, then break at the exact boundary on whatever character is there (could be conditional on another wrapAnywhere:true style) - Some combination of the above - Use ellipsis as in PIVOT-623 without wrapText set. Note: there was preliminary discussion of this issue as part of the comments in PIVOT-623. Moved to a new issue to avoid further confusion of the original ellipsis issue there. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-772) Exceptions thrown when calling scrollAreaToVisible of TextArea when incomplete lines exist
Exceptions thrown when calling scrollAreaToVisible of TextArea when incomplete lines exist -- Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-772) Exceptions thrown when calling scrollAreaToVisible of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-772: - Attachment: scroll.bxml Scroll.java Just compile and run the test code. There are three choices: one demonstrate working code and two forms of non-working code that throws the exceptions. Thanks. Exceptions thrown when calling scrollAreaToVisible of TextArea when incomplete lines exist -- Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: Scroll.java, scroll.bxml Original Estimate: 48h Remaining Estimate: 48h If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-772) Exceptions thrown when calling scrollAreaToVisible of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067423#comment-13067423 ] Roger Whitcomb commented on PIVOT-772: -- Actually the title of the issue is misleading: the actual exception is coming from getCharacterBounds before the scrollAreaToVisible even gets called. Exceptions thrown when calling scrollAreaToVisible of TextArea when incomplete lines exist -- Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: Scroll.java, scroll.bxml Original Estimate: 48h Remaining Estimate: 48h If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-772) Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-772: - Attachment: scroll2.log scroll.log scroll.log is the result choosing Multiple Lines Per Append, and scroll2.log is from Partial Line Per Append. Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist - Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: Scroll.java, scroll.bxml, scroll.log, scroll2.log Original Estimate: 48h Remaining Estimate: 48h If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (PIVOT-772) Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reopened PIVOT-772: -- See previous comment for reason to reopen. Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist - Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Assignee: Noel Grandin Priority: Minor Fix For: 2.0.1 Attachments: Scroll.java, scroll.bxml, scroll.log, scroll2.log Original Estimate: 48h Remaining Estimate: 48h If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (PIVOT-772) Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reopened PIVOT-772: -- Hi Noel, After some more testing with our real application, there are still some funny things remaining: 1) Often the first time I call getCharacterBounds after an arbitrary insert it gets really large Y values: index: 90, char 0xa, bounds: org.apache.pivot.wtk.Bounds [4,1306;2x16] index: 123, char 0x2e, bounds: org.apache.pivot.wtk.Bounds [214,116;7x16] 2) It seems to not scroll enough so that by the last line often the last one or more lines are not visible. This looks to be because the TextArea component height isn't getting updated correctly. For instance, in this case the Bounds is returning a Y value of 308 (plus line size of 16), but the viewHeight for the TextArea component (during scrollAreaToVisible) is only returning 280, resulting in an incorrect scrollTop calculation: index: 414, char 0xa, bounds: org.apache.pivot.wtk.Bounds [291,308;2x16] scrollAreaToVisible: area [291,304,2,16], viewport org.apache.pivot.wtk.Bounds [0,0;523x260] scrollAreaToVisible: deltaX = 0 scrollAreaToVisible: deltaY = 60 scrollAreaToVisible: viewHeight = 280 scrollAreaToVisible: new scrollTop=20 But, if you take the scrollbar to the bottom end, the final scrollTop gets to be (and should be) 84 (which includes the 308 + 16 for that line, plus another 16 for the empty line at the bottom + 4 for ??, or 344 altogether which = 260 + 84). So, the cumulative error is 64 pixels in this example, which leaves me about 4 lines still scrolled off the bottom. As you can probably tell, I still don't understand all the calculations involved here. You can see these errors (a little bit, not as pronounced) using the example code. I put tracing statements into Component.scrollAreaToVisible to get these results. Thanks again for your attention to this issue. Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist - Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Assignee: Noel Grandin Priority: Minor Fix For: 2.0.1 Attachments: Scroll.java, scroll.bxml, scroll.log, scroll2.log Original Estimate: 48h Remaining Estimate: 48h If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-772) Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-772: - Attachment: Scroll2.java Hi Noel, If you use the new attached Scroll2.java and choose Multiple Lines per Append, you can see the behavior very clearly. Once it finishes (and the buttons are enabled again), you will see line 34 at the bottom of the TextArea, but if you move the scroll bar down you will see that there are lines 35-38 that are still not visible (and a blank line underneath that as well). So, even though we are consistently getting the character bounds of the very last character every time, the scroll doesn't quite scroll enough so that by the end we still have five lines that are not visible and could still be scrolled into view with the scroll bar. Thanks! Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist - Key: PIVOT-772 URL: https://issues.apache.org/jira/browse/PIVOT-772 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0.1 Environment: Windows XP SP3, JRE 1.6_25 or JRE 1.7 (beta) Reporter: Roger Whitcomb Assignee: Noel Grandin Priority: Minor Fix For: 2.0.1 Attachments: Scroll.java, Scroll2.java, scroll.bxml, scroll.log, scroll2.log Original Estimate: 48h Remaining Estimate: 48h If partial lines are appended to a TextArea and then getCharacterBounds followed by scrollAreaToVisible is called, Pivot throws java.lang.IndexOutOfBoundsException from TextAreaSkinParagraphView.getCharacterBounds: java.lang.IndexOutOfBoundsException: ix = 38 at sun.font.StandardGlyphVector.getGlyphLogicalBounds(Unknown Source) at org.apache.pivot.wtk.skin.TextAreaSkinParagraphView.getCharacterBounds(TextAreaSkinParagraphView.java:393) at org.apache.pivot.wtk.skin.TextAreaSkin.getCharacterBounds(TextAreaSkin.java:442) at org.apache.pivot.wtk.TextArea.getCharacterBounds(TextArea.java:1243) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-772) Exceptions thrown when calling getCharacterBounds of TextArea when incomplete lines exist
[ https://issues.apache.org/jira/browse/PIVOT-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071898#comment-13071898 ] Roger Whitcomb commented on PIVOT-772: -- Hi Noel, Just tried it and it seems to work for the normal cases, but if I do a paste into a TextArea the code goes into an infinite loop, eventually leading to StackOverflowError: Exception in thread AWT-EventQueue-0 java.lang.StackOverflowError at java.awt.Component.repaint(Unknown Source) at java.awt.Component.repaint(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.repaint(ApplicationContext.java:414) at org.apache.pivot.wtk.Display.repaint(Display.java:97) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Component.repaint(Component.java:2041) at org.apache.pivot.wtk.Viewport.repaint(Viewport.java:174) at org.apache.pivot.wtk.Component.repaint(Component.java:2000) at org.apache.pivot.wtk.Component.repaint(Component.java:1985) at org.apache.pivot.wtk.Component.setSize(Component.java:935) at org.apache.pivot.wtk.skin.ScrollPaneSkin.layoutHelper(ScrollPaneSkin.java:730) at org.apache.pivot.wtk.skin.ScrollPaneSkin.layout(ScrollPaneSkin.java:585) at org.apache.pivot.wtk.Component.layout(Component.java:1960) at org.apache.pivot.wtk.Container.layout(Container.java:348) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Component.scrollAreaToVisible(Component.java:1831) at org.apache.pivot.wtk.skin.TextAreaSkin.scrollCharacterToVisible(TextAreaSkin.java:462) at org.apache.pivot.wtk.skin.TextAreaSkin.layout(TextAreaSkin.java:238) at org.apache.pivot.wtk.Component.layout(Component.java:1960) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at org.apache.pivot.wtk.Component.validate(Component.java:1951) at org.apache.pivot.wtk.Container.layout(Container.java:352) at
[jira] [Updated] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-669: - Attachment: tooltip.patch This patch addresses this issue. tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Priority: Minor Fix For: 2.1 Attachments: tooltip.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-669: - Attachment: tooltip2.patch Better patch that also addresses the issues if the window is very small and makes every effort to keep the tooltip in the window and out from behind the mouse cursor. tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Priority: Minor Fix For: 2.1 Attachments: tooltip2.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-669: - Attachment: (was: tooltip2.patch) tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Priority: Minor Fix For: 2.1 there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-669: - Attachment: tooltip2.patch Even better patch that positions the tip better for cases near the upper right corner and still works well in the lower right of a narrow display. tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Priority: Minor Fix For: 2.1 Attachments: tooltip2.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087306#comment-13087306 ] Roger Whitcomb commented on PIVOT-669: -- Sorry, having trouble getting screenshots to show the effect, but it works pretty well (much better than before). If no objections I'll commit tomorrow. Thanks. tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Priority: Minor Fix For: 2.1 Attachments: tooltip2.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-669: - Fix Version/s: (was: 2.1) 2.0.1 Assignee: Roger Whitcomb tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: tooltip2.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087788#comment-13087788 ] Roger Whitcomb commented on PIVOT-669: -- Sendingwtk\src\org\apache\pivot\wtk\skin\ComponentSkin.java Transmitting file data . Committed revision 1159676. tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: tooltip2.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-669) tooltip being displayed outside of the window
[ https://issues.apache.org/jira/browse/PIVOT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-669. -- Resolution: Fixed Revision 1159676. tooltip being displayed outside of the window - Key: PIVOT-669 URL: https://issues.apache.org/jira/browse/PIVOT-669 Project: Pivot Issue Type: Bug Components: wtk Environment: windows xp. jdk 1.6.20 Reporter: Dhaval Vyas Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: tooltip2.patch there is a bug with the tooltip. it is being displayed outside of the window. see attached screenshot. screenshot link http://img253.imageshack.us/img253/5686/screenshotpd.png -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Would like to have a FIllPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-790: - Attachment: fill.patch Attached fill.patch implements this feature and adds it to ComponentExplorer. Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch Original Estimate: 2h Remaining Estimate: 2h Would like to have a FIllPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-790: - Description: Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. (was: Would like to have a FIllPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space.) Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088315#comment-13088315 ] Roger Whitcomb commented on PIVOT-790: -- Hmm, interesting thought. Although the code for the interesting part of FillPane (the layout method) turned out to be a fair amount different than BoxPane is (see the attached patch). I'm experimenting with this implementation of FillPane in my own code to see what it feels like. I'm ending up replacing a lot of BoxPane with FillPane because often I've wanted to fill up the space. To my mind, even though the implementation is similar there is a different purpose for BoxPane and this FillPane: the former arranges things in a line, while the latter fills up the space and contains/constrains its children. Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-790: - Attachment: fill_pane_horizontal.jpg This is what it looks like in ComponentExplorer with horizontal orientation. Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch, fill_pane_horizontal.jpg, fill_pane_vertical.jpg Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-790: - Attachment: fill_pane_vertical.jpg And vertical orientation. Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch, fill_pane_horizontal.jpg, fill_pane_vertical.jpg Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1304#comment-1304 ] Roger Whitcomb commented on PIVOT-790: -- Would like to know if the consensus is to add this as a feature at this time. Thanks. Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch, fill_pane_horizontal.jpg, fill_pane_vertical.jpg Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089552#comment-13089552 ] Roger Whitcomb commented on PIVOT-790: -- Noel, I can see your point, although changing the fill to an enum would likely require a LOT of existing code to change because it is not backward compatible with the existing stuff. My proposal, although it does duplicate *some* code doesn't require changing any existing stuff if you don't want the new feature. It looks like your proposal, on the other hand, is a bit more flexible than what I implemented. Although, I imagine the code inside BoxPane.getPreferredHeight, getPreferredWidth and layout would be fairly ugly At any rate, looks like anything we do will be 2.1 now Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch, fill_pane_horizontal.jpg, fill_pane_vertical.jpg Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-790) Add FillPane layout container that acts like a BoxPane with fill=true in both directions
[ https://issues.apache.org/jira/browse/PIVOT-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-790. -- Resolution: Fixed Added to layout tutorials as well. Sending trunk\tutorials\src\org\apache\pivot\tutorials\explorer\component_explorer_window.bxml Adding trunk\tutorials\src\org\apache\pivot\tutorials\explorer\fill_pane.bxml Adding trunk\tutorials\src\org\apache\pivot\tutorials\layout\FillPanes.java Adding trunk\tutorials\src\org\apache\pivot\tutorials\layout\fill_panes.bxml Adding trunk\tutorials\www\fill-panes.xml Sendingtrunk\tutorials\www\index.xml Sendingtrunk\tutorials\www\layout-containers.xml Adding trunk\wtk\src\org\apache\pivot\wtk\FillPane.java Adding trunk\wtk\src\org\apache\pivot\wtk\FillPaneListener.java Sendingtrunk\wtk\src\org\apache\pivot\wtk\Theme.java Adding trunk\wtk\src\org\apache\pivot\wtk\skin\FillPaneSkin.java Adding trunk\wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFillPaneSkin.java Transmitting file data Committed revision 1161290. Add FillPane layout container that acts like a BoxPane with fill=true in both directions Key: PIVOT-790 URL: https://issues.apache.org/jira/browse/PIVOT-790 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: fill.patch, fill_pane_horizontal.jpg, fill_pane_vertical.jpg Original Estimate: 2h Remaining Estimate: 2h Would like to have a FillPane that lays out its components to fill the available space both horizontally and vertically. It does have an orientation (like BoxPane) to specify the direction to lay things out but it always allows its children to fill up the space. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-844) SuggestionPopup Allow replacing selected text to the beginning index until current cursor of TextInput or TextArea Component
[ https://issues.apache.org/jira/browse/PIVOT-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259389#comment-13259389 ] Roger Whitcomb commented on PIVOT-844: -- That sounds good to me, although I think it should be -1 to act like before (0 is a valid index for an append). SuggestionPopup Allow replacing selected text to the beginning index until current cursor of TextInput or TextArea Component - Key: PIVOT-844 URL: https://issues.apache.org/jira/browse/PIVOT-844 Project: Pivot Issue Type: Improvement Components: wtk, wtk-terra Reporter: Brendan Assignee: Sandro Martini Priority: Minor Fix For: 2.1 Attachments: PIVOT-844_second_rough_version.patch Original Estimate: 96h Remaining Estimate: 96h SuggestionPopup used to replacing whole content of TextInput once user make a selection. This creates difficulties in implementing, for example, a list of comma separated email addresses in recipients column. I suggest to modify the replacing methodology to allow additional parameter of Index of the beginning word to input so that the SuggestionPopup will replace from the beginning index to the current caret (text cursor) with user selection. Additionally, allow not only TextInput but also TextArea to be served with, which we can build a typing assistant like function. The finding the beginning index is user code responsibility which opens up the choice of usages, like email address assistant where ; is the separator and space as separator when general typing assistant. The user code just need to use Java String Split to locate the closet word to the caret for SuggestionPopup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-856) TerraLabelSkin.setDisabledColor throws exception
[ https://issues.apache.org/jira/browse/PIVOT-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285169#comment-13285169 ] Roger Whitcomb commented on PIVOT-856: -- Okay, that looks correct (manifests would probably only be used if running your application as a single .jar file). So, I wonder if this is a caching problem. Can you try clearing all the browser caches. Because, terra 2.0.1 will not reference the setDisabledColor method, so it would work with wtk 2.0.1. So, it still sounds to me like the wtk 2.0.1 .jar file is in play here somehow. What are you using as your HTTP server? Is it possible that both the 2.0.1 and 2.0.2 .jar files are in the cache or are somewhere inside your HTTP server? TerraLabelSkin.setDisabledColor throws exception Key: PIVOT-856 URL: https://issues.apache.org/jira/browse/PIVOT-856 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.2 Environment: Windows, Tomcat Reporter: Ilian Pavlov Labels: skin Switching from 2.0.1 to 2.0.2 without changing the bxml causes the following exception. The offendding line 14 is Form bxml:id=quickForm disabledColor is not set anywhere in the bxml or the applet. An error occurred at line number 14 in file /ARS/ars/print/print.bxml: org.apache.pivot.serialization.SerializationException: java.lang.NoSuchMethodError: org.apache.pivot.wtk.skin.terra.TerraLabelSkin.setDisabledColor(Ljava/awt/Color;)V at org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:775) at org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) at org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:630) at org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:603) at ars.print.PrintApplet.startup(PrintApplet.java:132) at org.apache.pivot.wtk.BrowserApplicationContext$HostApplet$StartCallback.run(BrowserApplicationContext.java:190) at org.apache.pivot.wtk.ApplicationContext$QueuedCallback.run(ApplicationContext.java:1518) at java.awt.event.InvocationEvent.dispatch(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) Caused by: java.lang.NoSuchMethodError: org.apache.pivot.wtk.skin.terra.TerraLabelSkin.setDisabledColor(Ljava/awt/Color;)V at org.apache.pivot.wtk.skin.terra.TerraLabelSkin.setDisabledColor(TerraLabelSkin.java:38) at org.apache.pivot.wtk.skin.terra.TerraLabelSkin.init(TerraLabelSkin.java:28) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Unknown Source) at java.lang.Class.newInstance0(Unknown Source) at java.lang.Class.newInstance(Unknown Source) at org.apache.pivot.wtk.Component.installSkin(Component.java:832) at org.apache.pivot.wtk.Label.init(Label.java:97) at org.apache.pivot.wtk.Label.init(Label.java:91) at org.apache.pivot.wtk.skin.terra.TerraFormSkin.init(TerraFormSkin.java:212) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Unknown Source) at java.lang.Class.newInstance0(Unknown Source) at java.lang.Class.newInstance(Unknown Source) at org.apache.pivot.wtk.Component.installSkin(Component.java:832) at org.apache.pivot.wtk.Form.init(Form.java:435) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at
[jira] [Created] (PIVOT-857) Add activity indicator to file browser while loading a directory
Roger Whitcomb created PIVOT-857: Summary: Add activity indicator to file browser while loading a directory Key: PIVOT-857 URL: https://issues.apache.org/jira/browse/PIVOT-857 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 2.0.2 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Fix For: 2.0.3 While the File Browser is loading the contents of a directory (which can take some time depending on the environment, and whether it is a network drive), there is no indication that anything is happening. Perhaps an ActivityIndicator could be overlaid on the file list display area to indicate that something is happening in the background. This should work since loading the files is happening on a second thread. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-856) TerraLabelSkin.setDisabledColor throws exception
[ https://issues.apache.org/jira/browse/PIVOT-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285207#comment-13285207 ] Roger Whitcomb commented on PIVOT-856: -- No problem. I'm going to close the issue, then, as resolved. TerraLabelSkin.setDisabledColor throws exception Key: PIVOT-856 URL: https://issues.apache.org/jira/browse/PIVOT-856 Project: Pivot Issue Type: Bug Components: wtk-terra Affects Versions: 2.0.2 Environment: Windows, Tomcat Reporter: Ilian Pavlov Labels: skin Switching from 2.0.1 to 2.0.2 without changing the bxml causes the following exception. The offendding line 14 is Form bxml:id=quickForm disabledColor is not set anywhere in the bxml or the applet. An error occurred at line number 14 in file /ARS/ars/print/print.bxml: org.apache.pivot.serialization.SerializationException: java.lang.NoSuchMethodError: org.apache.pivot.wtk.skin.terra.TerraLabelSkin.setDisabledColor(Ljava/awt/Color;)V at org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:775) at org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:443) at org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:630) at org.apache.pivot.beans.BXMLSerializer.readObject(BXMLSerializer.java:603) at ars.print.PrintApplet.startup(PrintApplet.java:132) at org.apache.pivot.wtk.BrowserApplicationContext$HostApplet$StartCallback.run(BrowserApplicationContext.java:190) at org.apache.pivot.wtk.ApplicationContext$QueuedCallback.run(ApplicationContext.java:1518) at java.awt.event.InvocationEvent.dispatch(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) Caused by: java.lang.NoSuchMethodError: org.apache.pivot.wtk.skin.terra.TerraLabelSkin.setDisabledColor(Ljava/awt/Color;)V at org.apache.pivot.wtk.skin.terra.TerraLabelSkin.setDisabledColor(TerraLabelSkin.java:38) at org.apache.pivot.wtk.skin.terra.TerraLabelSkin.init(TerraLabelSkin.java:28) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Unknown Source) at java.lang.Class.newInstance0(Unknown Source) at java.lang.Class.newInstance(Unknown Source) at org.apache.pivot.wtk.Component.installSkin(Component.java:832) at org.apache.pivot.wtk.Label.init(Label.java:97) at org.apache.pivot.wtk.Label.init(Label.java:91) at org.apache.pivot.wtk.skin.terra.TerraFormSkin.init(TerraFormSkin.java:212) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Unknown Source) at java.lang.Class.newInstance0(Unknown Source) at java.lang.Class.newInstance(Unknown Source) at org.apache.pivot.wtk.Component.installSkin(Component.java:832) at org.apache.pivot.wtk.Form.init(Form.java:435) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at java.lang.reflect.Constructor.newInstance(Unknown Source) at java.lang.Class.newInstance0(Unknown Source) at java.lang.Class.newInstance(Unknown Source) at org.apache.pivot.beans.BXMLSerializer.newTypedObject(BXMLSerializer.java:1567) at org.apache.pivot.beans.BXMLSerializer.processStartElement(BXMLSerializer.java:773)
[jira] [Updated] (PIVOT-817) Implement borderThickness style for TerraPushButtonSkin
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-817: - Due Date: 31/Jul/12 (was: 30/Dec/11) This needs a lot more thought. The simple solution looks terrible. Implement borderThickness style for TerraPushButtonSkin - Key: PIVOT-817 URL: https://issues.apache.org/jira/browse/PIVOT-817 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Labels: pushbutton,, thickness Fix For: 2.1 Attachments: thick.patch Original Estimate: 168h Remaining Estimate: 168h In order to somewhat simulate the appearance of the default button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-817) Implement borderThickness style for TerraPushButtonSkin
[ https://issues.apache.org/jira/browse/PIVOT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285802#comment-13285802 ] Roger Whitcomb commented on PIVOT-817: -- If it looked right, that is, the same way Windows buttons do, then yes, I would use it. I don't need it by any particular date, since we just are releasing the product and it is unclear when the next release will be. I updated the due date just to get it off the top of the TO DO list. But, the due date could be erased, and it could be moved to 2.1 as well. Implement borderThickness style for TerraPushButtonSkin - Key: PIVOT-817 URL: https://issues.apache.org/jira/browse/PIVOT-817 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 2.0.1 Environment: Windows XP SP3, JDK 1.6.0_16 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Labels: pushbutton,, thickness Fix For: 2.1 Attachments: thick.patch Original Estimate: 168h Remaining Estimate: 168h In order to somewhat simulate the appearance of the default button on Windows, which has a thicker border, it would be nice to be able to set the border thickness of a PushButton to something bigger than one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-857) Add activity indicator to file browser while loading a directory
[ https://issues.apache.org/jira/browse/PIVOT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-857: - Attachment: browser.patch The browser.patch implements this functionality and also speeds up the whole process by about 2x in some cases (slow drive in a VM, for instance) by filtering the files ahead of time and then using Arrays.sort on the exact list. Add activity indicator to file browser while loading a directory Key: PIVOT-857 URL: https://issues.apache.org/jira/browse/PIVOT-857 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 2.0.2 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Labels: filebrowser Fix For: 2.0.3 Attachments: browser.patch Original Estimate: 72h Remaining Estimate: 72h While the File Browser is loading the contents of a directory (which can take some time depending on the environment, and whether it is a network drive), there is no indication that anything is happening. Perhaps an ActivityIndicator could be overlaid on the file list display area to indicate that something is happening in the background. This should work since loading the files is happening on a second thread. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-857) Add activity indicator to file browser while loading a directory
[ https://issues.apache.org/jira/browse/PIVOT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-857. -- Resolution: Fixed Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\terra_file_browser_skin.bxml Transmitting file data .. Committed revision 1346574. Add activity indicator to file browser while loading a directory Key: PIVOT-857 URL: https://issues.apache.org/jira/browse/PIVOT-857 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 2.0.2 Environment: All Reporter: Roger Whitcomb Assignee: Roger Whitcomb Priority: Minor Labels: filebrowser Fix For: 2.0.3 Attachments: browser.patch Original Estimate: 72h Remaining Estimate: 72h While the File Browser is loading the contents of a directory (which can take some time depending on the environment, and whether it is a network drive), there is no indication that anything is happening. Perhaps an ActivityIndicator could be overlaid on the file list display area to indicate that something is happening in the background. This should work since loading the files is happening on a second thread. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-796) TerraFileBrowserSheetSkin: improve user experience with slow drives
[ https://issues.apache.org/jira/browse/PIVOT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418415#comment-13418415 ] Roger Whitcomb commented on PIVOT-796: -- I will take a look at this, yes. TerraFileBrowserSheetSkin: improve user experience with slow drives --- Key: PIVOT-796 URL: https://issues.apache.org/jira/browse/PIVOT-796 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 1.1, 1.2, 1.3, 1.4, 1.5, 2.0 Environment: Windows with Network (SMB-) drives attached and/ or special drives like card reader drive letters or virtual cd drives Reporter: Thomas Guretzki Priority: Minor Labels: patch Fix For: 2.1 Attachments: terra_file_browser_skin_RefreshIndicator.patch Original Estimate: 1.5h Remaining Estimate: 1.5h The current TerraFileBrowserSheetSkin blocks quite often on the UI Thread when reading the list of root directory after each directory change, and when refreshing the file list of directories on slow drives. On Windows, the reason seems to be that reading file attributes of those drives (especially isDirectory()) is quite slow. This has a number of consequences: - Retreiving the list of files on slow drives freezes the UI, and users don't necessarily realize that the system is still working - Sorting of the retreived files is quite slow, as the FileComparator keeps refreshing those attributes - After each directory change in the FileBrowser, users have to wait until the complete list of drive letters (root directories) has been refreshed. This also happens on local drives. In response to these problems, I've enhanced TerraFileBrowserSheetSkin in a number of ways: - FileComparator caches file attributes, leading to approx. 70% decrease in file refresh time - refreshing the drive letter list uses dedicated tasks, so the user doesn't have to wait for the slow drives to respond - while drive letters are refreshed, a small ActivityIndicator next to the ListButton is displayed - while the file list is refreshed, an ActivityIndicator is display instead of an empty file list - the responsibility of RefreshFileListTask has been extended to include sorting the files, as this used to take roundabout 50% of refreshing time and to freeze the UI - changing the sort while RefreshFileListTask is running is now supported The patch, including a few extensions of the bxml file, is attached to this ticket -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-796) TerraFileBrowserSheetSkin: improve user experience with slow drives
[ https://issues.apache.org/jira/browse/PIVOT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reassigned PIVOT-796: Assignee: Roger Whitcomb TerraFileBrowserSheetSkin: improve user experience with slow drives --- Key: PIVOT-796 URL: https://issues.apache.org/jira/browse/PIVOT-796 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 1.1, 1.2, 1.3, 1.4, 1.5, 2.0 Environment: Windows with Network (SMB-) drives attached and/ or special drives like card reader drive letters or virtual cd drives Reporter: Thomas Guretzki Assignee: Roger Whitcomb Priority: Minor Labels: patch Fix For: 2.1 Attachments: terra_file_browser_skin_RefreshIndicator.patch Original Estimate: 1.5h Remaining Estimate: 1.5h The current TerraFileBrowserSheetSkin blocks quite often on the UI Thread when reading the list of root directory after each directory change, and when refreshing the file list of directories on slow drives. On Windows, the reason seems to be that reading file attributes of those drives (especially isDirectory()) is quite slow. This has a number of consequences: - Retreiving the list of files on slow drives freezes the UI, and users don't necessarily realize that the system is still working - Sorting of the retreived files is quite slow, as the FileComparator keeps refreshing those attributes - After each directory change in the FileBrowser, users have to wait until the complete list of drive letters (root directories) has been refreshed. This also happens on local drives. In response to these problems, I've enhanced TerraFileBrowserSheetSkin in a number of ways: - FileComparator caches file attributes, leading to approx. 70% decrease in file refresh time - refreshing the drive letter list uses dedicated tasks, so the user doesn't have to wait for the slow drives to respond - while drive letters are refreshed, a small ActivityIndicator next to the ListButton is displayed - while the file list is refreshed, an ActivityIndicator is display instead of an empty file list - the responsibility of RefreshFileListTask has been extended to include sorting the files, as this used to take roundabout 50% of refreshing time and to freeze the UI - changing the sort while RefreshFileListTask is running is now supported The patch, including a few extensions of the bxml file, is attached to this ticket -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-796) TerraFileBrowserSheetSkin: improve user experience with slow drives
[ https://issues.apache.org/jira/browse/PIVOT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418424#comment-13418424 ] Roger Whitcomb commented on PIVOT-796: -- I added an overlay Activity Indicator to 2.0.2 a few weeks ago. How would that interact with these changes? Do you have a 2.0.2 patch? Thanks TerraFileBrowserSheetSkin: improve user experience with slow drives --- Key: PIVOT-796 URL: https://issues.apache.org/jira/browse/PIVOT-796 Project: Pivot Issue Type: Improvement Components: wtk-terra Affects Versions: 1.1, 1.2, 1.3, 1.4, 1.5, 2.0 Environment: Windows with Network (SMB-) drives attached and/ or special drives like card reader drive letters or virtual cd drives Reporter: Thomas Guretzki Assignee: Roger Whitcomb Priority: Minor Labels: patch Fix For: 2.1 Attachments: terra_file_browser_skin_RefreshIndicator.patch Original Estimate: 1.5h Remaining Estimate: 1.5h The current TerraFileBrowserSheetSkin blocks quite often on the UI Thread when reading the list of root directory after each directory change, and when refreshing the file list of directories on slow drives. On Windows, the reason seems to be that reading file attributes of those drives (especially isDirectory()) is quite slow. This has a number of consequences: - Retreiving the list of files on slow drives freezes the UI, and users don't necessarily realize that the system is still working - Sorting of the retreived files is quite slow, as the FileComparator keeps refreshing those attributes - After each directory change in the FileBrowser, users have to wait until the complete list of drive letters (root directories) has been refreshed. This also happens on local drives. In response to these problems, I've enhanced TerraFileBrowserSheetSkin in a number of ways: - FileComparator caches file attributes, leading to approx. 70% decrease in file refresh time - refreshing the drive letter list uses dedicated tasks, so the user doesn't have to wait for the slow drives to respond - while drive letters are refreshed, a small ActivityIndicator next to the ListButton is displayed - while the file list is refreshed, an ActivityIndicator is display instead of an empty file list - the responsibility of RefreshFileListTask has been extended to include sorting the files, as this used to take roundabout 50% of refreshing time and to freeze the UI - changing the sort while RefreshFileListTask is running is now supported The patch, including a few extensions of the bxml file, is attached to this ticket -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-864) Add a pluggable file system architecture to FileBrowser so remote browsing can be done
Roger Whitcomb created PIVOT-864: Summary: Add a pluggable file system architecture to FileBrowser so remote browsing can be done Key: PIVOT-864 URL: https://issues.apache.org/jira/browse/PIVOT-864 Project: Pivot Issue Type: New Feature Components: wtk Affects Versions: 2.0.2 Environment: Windows, Linux, OSX Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.1 Our application requires the ability to be able to browse (for instance) a Linux machine from the Windows desktop. For this I would like to add (somehow) a pluggable file system architecture so that I could (for instance) implement an FTP protocol underneath the FileBrowser so that I can browse through directories and files on something other than the local machine. We would also need to be able to type in a host name or TCP/IP address to start browsing the remote machine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
Roger Whitcomb created PIVOT-865: Summary: Crash in Save, As dialog when path + filename entered in text field Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.0.3 In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
[ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423336#comment-13423336 ] Roger Whitcomb commented on PIVOT-865: -- Related to Pivot-825. Looks like the fix for that problem was not entirely correct. Crash in Save, As dialog when path + filename entered in text field --- Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Labels: filebrowser Fix For: 2.0.3 Original Estimate: 48h Remaining Estimate: 48h In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
[ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423349#comment-13423349 ] Roger Whitcomb commented on PIVOT-865: -- Simple fix for this problem: getName() - getPath(). BUT, there are further problems: * What if the input text contains an invalid directory name? Still have an IllegalArgumentException in this case. Should there be an error message in this case? * What if the input text contains ONLY a directory name? We should set the root directory and clear the selected files list. Will try to resolve these issues as well. Crash in Save, As dialog when path + filename entered in text field --- Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Labels: filebrowser Fix For: 2.0.3 Original Estimate: 48h Remaining Estimate: 48h In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) -- This message is automatically generated by JIRA. If you think it was sent
[jira] [Comment Edited] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
[ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423349#comment-13423349 ] Roger Whitcomb edited comment on PIVOT-865 at 7/26/12 7:22 PM: --- Simple fix for this problem: getName() - getPath(). BUT, there are further problems: * What if the input text contains an invalid directory name? Still have an IllegalArgumentException in this case. Should there be an error message in this case? * What if the input text contains ONLY a directory name? We should set the root directory and clear the selected files list and not close the sheet. Will try to resolve these issues as well. was (Author: rwhitcomb): Simple fix for this problem: getName() - getPath(). BUT, there are further problems: * What if the input text contains an invalid directory name? Still have an IllegalArgumentException in this case. Should there be an error message in this case? * What if the input text contains ONLY a directory name? We should set the root directory and clear the selected files list. Will try to resolve these issues as well. Crash in Save, As dialog when path + filename entered in text field --- Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Labels: filebrowser Fix For: 2.0.3 Original Estimate: 48h Remaining Estimate: 48h In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at
[jira] [Updated] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
[ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-865: - Attachment: pivot865.patch Attached is a patch to fixes all the problems that I could find. It indicates an invalid path (with a file name) by flagging the text input field as an error (with no message, to avoid having to translate a new string). I can't commit right now because of password problems, which I hope to have resolved in the next couple of days. Crash in Save, As dialog when path + filename entered in text field --- Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Labels: filebrowser Fix For: 2.0.3 Attachments: pivot865.patch Original Estimate: 48h Remaining Estimate: 48h In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators:
[jira] [Comment Edited] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
[ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423659#comment-13423659 ] Roger Whitcomb edited comment on PIVOT-865 at 7/27/12 4:07 AM: --- Attached is a patch that fixes all the problems I could find. It indicates an invalid path (in several cases) by flagging the text input field as an error (with a Form.Flag with no message, to avoid having to translate a new string). I can't commit the patch right now because of password problems, which I hope to have resolved in the next couple of days. I intend also to merge to the 2.0.x branch as soon as possible so this will be available for 2.0.3. was (Author: rwhitcomb): Attached is a patch to fixes all the problems that I could find. It indicates an invalid path (with a file name) by flagging the text input field as an error (with no message, to avoid having to translate a new string). I can't commit right now because of password problems, which I hope to have resolved in the next couple of days. Crash in Save, As dialog when path + filename entered in text field --- Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Labels: filebrowser Fix For: 2.0.3 Attachments: pivot865.patch Original Estimate: 48h Remaining Estimate: 48h In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown
[jira] [Commented] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field
[ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423907#comment-13423907 ] Roger Whitcomb commented on PIVOT-865: -- Hi Sandro, that would be great if you could commit for me (? and do the merge to 2.0.x as well?). Thank you! Should be simple -- just two files in the patch. Here's the text I wanted to use for the commit message: PIVOT-865: Crash in TerraFileBrowserSheetSkin when specifying a relative path and file name in the SAVE_AS mode text input field. This is also a follow-on to PIVOT-825 which was an earlier case of a crash here. Made several fixes: 1) Put the text input inside a form so we can put an error flag on the field. 2) Much more understanding when the user types something in the field to try to interpret what is meant, whether a file name only, a relative path, an absolute path, or path + file name. 3) Using Canonical file name always to set the root directory so it will make sense if the root directory is used to set the current directory for the next time around. 4) Clear the form flag whenever the text changes. Crash in Save, As dialog when path + filename entered in text field --- Key: PIVOT-865 URL: https://issues.apache.org/jira/browse/PIVOT-865 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra Affects Versions: 2.0.2 Environment: Windows XP, Windows 7, JRE 1.6 or 1.7 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Labels: filebrowser Fix For: 2.0.3 Attachments: pivot865.patch Original Estimate: 48h Time Spent: 4h Remaining Estimate: 0h In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] test\script\test.txt) in the text field and it will throw this exception: java.lang.IllegalArgumentException at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139) at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296) at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34) at org.apache.pivot.wtk.Sheet.close(Sheet.java:118) at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502) at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853) at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339) at java.awt.Component.processEvent(Unknown Source) at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$000(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at
[jira] [Assigned] (PIVOT-860) CPU Usage at 100% when displaying an Expander
[ https://issues.apache.org/jira/browse/PIVOT-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reassigned PIVOT-860: Assignee: Roger Whitcomb (was: Sandro Martini) CPU Usage at 100% when displaying an Expander - Key: PIVOT-860 URL: https://issues.apache.org/jira/browse/PIVOT-860 Project: Pivot Issue Type: Bug Affects Versions: 2.0.2 Environment: Windows XP, reproduced on Java 6 (various versions) and Java 7 Reporter: Guillaume Deshors Assignee: Roger Whitcomb Labels: performance Fix For: 2.0.3 Attachments: pivot_kitchensink_expanders_profile_test_0.png, pivot_kitchensink_expanders_profile_test_1.png, pivot_kitchensink_expanders_profile_test_2.png When displaying an Expander component, the CPU usage immediately goes up and stays at 100% as long as the component is displayed (even if the window is background, reduced or whatever). To be precise, I really had 50% because I have a dual core : one of the core was 100%. Reproduced on 3 different computers, all Windows XP, with Java 6 and 7. Reproduced in applet and in standalone application shape. Steps to reproduce : 1/ go to http://pivot.apache.org/tutorials/sample-application.html - CPU is normal, say 5% 2/ click on navigation to see the expander - CPU is at 100%, at least one of the cores. Alternative : just go to http://pivot.apache.org/tutorials/expanders.html and expect the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
