[GitHub] incubator-predictionio issue #397: [PIO-69] Add license report generation us...

2017-06-21 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/397
  
I checked the license of all non-ASL libraries and all them can be included 
as binary form in the distribution. I added their license text to `LICENSE.txt` 
and updated `make-distribution.sh` to include `LICENSE.txt` and `NOTICE.txt` in 
the binary distribution.

I think all tasks about 3rd party license is done. Let me know if I have to 
do something else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (PIO-69) Create binary version of PredictionIO as part of release process

2017-06-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PIO-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058593#comment-16058593
 ] 

ASF GitHub Bot commented on PIO-69:
---

Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/397
  
I checked the license of all non-ASL libraries and all them can be included 
as binary form in the distribution. I added their license text to `LICENSE.txt` 
and updated `make-distribution.sh` to include `LICENSE.txt` and `NOTICE.txt` in 
the binary distribution.

I think all tasks about 3rd party license is done. Let me know if I have to 
do something else.


> Create binary version of PredictionIO as part of release process
> 
>
> Key: PIO-69
> URL: https://issues.apache.org/jira/browse/PIO-69
> Project: PredictionIO
>  Issue Type: New Feature
>  Components: Build
>Reporter: Sara Asher
>Assignee: Shinsuke Sugaya
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] incubator-predictionio issue #387: Oracle databas supports

2017-06-21 Thread liningalex
Github user liningalex commented on the issue:

https://github.com/apache/incubator-predictionio/pull/387
  
Hi Donald, I think we should have integration test. do you have
instructions how?

On Tue, Jun 20, 2017 at 4:49 PM, Donald Szeto 
wrote:

> Hey @liningalex , if you don't have a
> chance adding integration test yet, I would like to merge this to a 
feature
> branch so that we can join forces on that.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio issue #395: [PIO-92] Bump HBase to 1.2.6

2017-06-21 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/395
  
I found HBase version inconsistency in documentation and build 
configuration: 
https://github.com/apache/incubator-predictionio/pull/391#issuecomment-310151519
So I close this request and confirm the correct state at first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio pull request #395: [PIO-92] Bump HBase to 1.2.6

2017-06-21 Thread takezoe
Github user takezoe closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio issue #391: [PIO-92] Bump HBase to 1.2.6 (and fix dep...

2017-06-21 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/391
  
@pferrel and I found 3 versions of HBase at least in `build.sbt` and 
documentation, so I'm not sure what versions are supported in the current 
PredictionIIO.

- 0.98.5 in 
https://github.com/apache/incubator-predictionio/blob/develop/storage/hbase/build.sbt
- 0.98.6 in https://predictionio.incubator.apache.org/install/
- 1.2.5 in 
https://predictionio.incubator.apache.org/install/install-sourcecode/

It is inconsistent. What's state that should be originally?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio pull request #396: [PIO-69] Add sbt-dependency-graph ...

2017-06-21 Thread takezoe
Github user takezoe closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/396


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio issue #396: [PIO-69] Add sbt-dependency-graph plugin

2017-06-21 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/396
  
Close this request because sbt-license-report plugin looks more useful to 
extract license information of depended libraries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio issue #397: [PIO-69] Add license report generation us...

2017-06-21 Thread takezoe
Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/397
  
I added license information for the binary distribution to `LICENSE.txt` 
and `NOTICE.txt`, but rather it might be nice to create separate files for the 
binary distribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-predictionio pull request #397: [PIO-69] Add license report genera...

2017-06-21 Thread takezoe
GitHub user takezoe opened a pull request:

https://github.com/apache/incubator-predictionio/pull/397

[PIO-69] Add license report generation using sbt-license-report plugin

`make-licensereport.sh` generates `license-reports/licences-notice.csv` 
which contains only non-ASL libraries. The result in the latest develop branch 
is:

```
Common Public License,Common Public License Version 1.0 
(http://www.opensource.org/licenses/cpl1.0.txt),junit # junit # 4.11,
GPL,GPL2 w/ CPE 
(http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # 
jersey-core # 1.8,
GPL,GPL2 w/ CPE 
(http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # 
jersey-core # 1.9,
GPL,GPL2 w/ CPE 
(http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # 
jersey-json # 1.8,
GPL,GPL2 w/ CPE 
(http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # 
jersey-json # 1.9,
GPL,GPL2 w/ CPE 
(http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # 
jersey-server # 1.8,
GPL,GPL2 w/ CPE 
(http://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.jersey # 
jersey-server # 1.9,
GPL,GPL2 w/ CPE 
(https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html),javax.xml.bind # 
jaxb-api # 2.2.2,
GPL,GPL2 w/ CPE 
(https://glassfish.java.net/public/CDDL+GPL_1_1.html),com.sun.xml.bind # 
jaxb-impl # 2.2.3-1,
GPL,GPL2 w/ CPE 
(https://glassfish.java.net/public/CDDL+GPL_1_1.html),org.jvnet.mimepull # 
mimepull # 1.9.5,
MIT,MIT 
(https://github.com/softprops/semverfi/blob/0.1.3/LICENSE),me.lessis # 
semverfi_2.10 # 0.1.3,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),com.github.scopt # 
scopt_2.10 # 3.5.0,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 
1.7.14,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 
1.7.18,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 
1.7.2,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 
1.7.5,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-api # 
1.7.7,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-log4j12 
# 1.7.18,
MIT,MIT License 
(http://www.opensource.org/licenses/mit-license.php),org.slf4j # slf4j-log4j12 
# 1.7.5,
Mozilla,Mozilla Public License Version 1.1 
(http://www.mozilla.org/MPL/MPL-1.1.txt),org.jamon # jamon-runtime # 2.3.1,
Public Domain,Public Domain 
(http://creativecommons.org/licenses/publicdomain),com.github.stephenc.high-scale-lib
 # high-scale-lib # 1.1.1,
Public Domain,Public Domain,org.tukaani # xz # 1.0,
unrecognized,none specified (none specified),asm # asm # 3.1,
unrecognized,none specified (none specified),javax.servlet # servlet-api # 
2.5,
unrecognized,none specified (none specified),javax.servlet.jsp # jsp-api # 
2.1,
unrecognized,none specified (none specified),org.apache.zookeeper # 
zookeeper # 3.4.6,
unrecognized,none specified (none specified),org.codehaus.jettison # 
jettison # 1.1,
```

We would able to create a NOTICE file for the binary distribution from this 
report.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/takezoe/incubator-predictionio license-report

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-predictionio/pull/397.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #397


commit b6c296e1e2eea55cd097388a4b0d8adaab93ffd4
Author: Naoki Takezoe 
Date:   2017-06-21T02:56:21Z

[PIO-69] Add license report generation using sbt-license-report plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (PIO-92) HBase version is too old

2017-06-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PIO-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057903#comment-16057903
 ] 

ASF GitHub Bot commented on PIO-92:
---

Github user takezoe closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/395


> HBase version is too old
> 
>
> Key: PIO-92
> URL: https://issues.apache.org/jira/browse/PIO-92
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.11.0-incubating
>Reporter: Naoki Takezoe
>
> The current HBase storage implementation in PredictionIO has dependencies to 
> HBase 0.98.5, but it's already EOM. We should upgrade it to 1.2 at least.
> Here is the status of HBase and Hadoop versions:
> http://hbase.apache.org/book.html#hadoop 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (PIO-92) HBase version is too old

2017-06-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PIO-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057902#comment-16057902
 ] 

ASF GitHub Bot commented on PIO-92:
---

Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/395
  
I found HBase version inconsistency in documentation and build 
configuration: 
https://github.com/apache/incubator-predictionio/pull/391#issuecomment-310151519
So I close this request and confirm the correct state at first.


> HBase version is too old
> 
>
> Key: PIO-92
> URL: https://issues.apache.org/jira/browse/PIO-92
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.11.0-incubating
>Reporter: Naoki Takezoe
>
> The current HBase storage implementation in PredictionIO has dependencies to 
> HBase 0.98.5, but it's already EOM. We should upgrade it to 1.2 at least.
> Here is the status of HBase and Hadoop versions:
> http://hbase.apache.org/book.html#hadoop 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (PIO-92) HBase version is too old

2017-06-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PIO-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057891#comment-16057891
 ] 

ASF GitHub Bot commented on PIO-92:
---

Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/391
  
@pferrel and I found 3 versions of HBase at least in `build.sbt` and 
documentation, so I'm not sure what versions are supported in the current 
PredictionIIO.

- 0.98.5 in 
https://github.com/apache/incubator-predictionio/blob/develop/storage/hbase/build.sbt
- 0.98.6 in https://predictionio.incubator.apache.org/install/
- 1.2.5 in 
https://predictionio.incubator.apache.org/install/install-sourcecode/

It is inconsistent. What's state that should be originally?


> HBase version is too old
> 
>
> Key: PIO-92
> URL: https://issues.apache.org/jira/browse/PIO-92
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.11.0-incubating
>Reporter: Naoki Takezoe
>
> The current HBase storage implementation in PredictionIO has dependencies to 
> HBase 0.98.5, but it's already EOM. We should upgrade it to 1.2 at least.
> Here is the status of HBase and Hadoop versions:
> http://hbase.apache.org/book.html#hadoop 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (PIO-69) Create binary version of PredictionIO as part of release process

2017-06-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PIO-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057877#comment-16057877
 ] 

ASF GitHub Bot commented on PIO-69:
---

Github user takezoe commented on the issue:

https://github.com/apache/incubator-predictionio/pull/397
  
I added license information for the binary distribution to `LICENSE.txt` 
and `NOTICE.txt`, but rather it might be nice to create separate files for the 
binary distribution.


> Create binary version of PredictionIO as part of release process
> 
>
> Key: PIO-69
> URL: https://issues.apache.org/jira/browse/PIO-69
> Project: PredictionIO
>  Issue Type: New Feature
>  Components: Build
>Reporter: Sara Asher
>Assignee: Shinsuke Sugaya
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (PIO-99) `pio build` exits successfully even when compilation fails

2017-06-21 Thread Mars Hall (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIO-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mars Hall updated PIO-99:
-
Description: 
The build command does not fail as expected. While not a big deal when working 
locally, it seems like this could be problematic for automated, continuous 
build/integration workflows.

{code}
$ pio build
…
[ERROR] [Engine$] [error] one error found
[ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
[ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
[ERROR] [Engine$] Return code of build command: 
/Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt  
package assemblyPackageDependency is 1. Aborting.
[INFO] [Engine$] Looking for an engine...
[INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
[INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
[INFO] [Engine$] Build finished successfully.
[INFO] [Pio$] Your engine is ready for training.
{code}

It certainly appears successful at the end, and exit code was {{0}}.

Looking back for the error is not hard, but this behavior is problematic when 
composing {{pio build}} command into a shell script.

  was:
The build command does not fail as expected. While not a big deal when working 
locally, it seems like this could be problematic for automated, continuous 
build/integration workflows.

{code}
$ pio build
…
[ERROR] [Engine$] [error] one error found
[ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
[ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
[ERROR] [Engine$] Return code of build command: 
/Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt  
package assemblyPackageDependency is 1. Aborting.
[INFO] [Engine$] Looking for an engine...
[INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
[INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
[INFO] [Engine$] Build finished successfully.
[INFO] [Pio$] Your engine is ready for training.
{code}

It certainly appears successful at the end, and exit code was {{0}}.

Looking back for the error is not hard, but this behavior is problematic when 
composing {pio build} command into a shell script.


> `pio build` exits successfully even when compilation fails
> --
>
> Key: PIO-99
> URL: https://issues.apache.org/jira/browse/PIO-99
> Project: PredictionIO
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 0.11.0-incubating
>Reporter: Mars Hall
>
> The build command does not fail as expected. While not a big deal when 
> working locally, it seems like this could be problematic for automated, 
> continuous build/integration workflows.
> {code}
> $ pio build
> …
> [ERROR] [Engine$] [error] one error found
> [ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
> [ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
> [ERROR] [Engine$] Return code of build command: 
> /Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt  
> package assemblyPackageDependency is 1. Aborting.
> [INFO] [Engine$] Looking for an engine...
> [INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
> [INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
> [INFO] [Engine$] Build finished successfully.
> [INFO] [Pio$] Your engine is ready for training.
> {code}
> It certainly appears successful at the end, and exit code was {{0}}.
> Looking back for the error is not hard, but this behavior is problematic when 
> composing {{pio build}} command into a shell script.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (PIO-99) `pio build` exits successfully even when compilation fails

2017-06-21 Thread Mars Hall (JIRA)
Mars Hall created PIO-99:


 Summary: `pio build` exits successfully even when compilation fails
 Key: PIO-99
 URL: https://issues.apache.org/jira/browse/PIO-99
 Project: PredictionIO
  Issue Type: Bug
  Components: Build
Affects Versions: 0.11.0-incubating
Reporter: Mars Hall


The build command does not fail as expected. While not a big deal when working 
locally, it seems like this could be problematic for automated, continuous 
build/integration workflows.

{code}
$ pio build
…
[ERROR] [Engine$] [error] one error found
[ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
[ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
[ERROR] [Engine$] Return code of build command: 
/Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt  
package assemblyPackageDependency is 1. Aborting.
[INFO] [Engine$] Looking for an engine...
[INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
[INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
[INFO] [Engine$] Build finished successfully.
[INFO] [Pio$] Your engine is ready for training.
{code}

It certainly appears successful at the end, and exit code was {{0}}.

Looking back for the error is not hard, but this behavior is problematic when 
composing {pio build} command into a shell script.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (PIO-98) Issues in building Complementary Purchase Engine Template

2017-06-21 Thread salil chawla (JIRA)
salil chawla created PIO-98:
---

 Summary: Issues in building Complementary Purchase Engine Template
 Key: PIO-98
 URL: https://issues.apache.org/jira/browse/PIO-98
 Project: PredictionIO
  Issue Type: Bug
Reporter: salil chawla


http://predictionio.incubator.apache.org/templates/complementarypurchase/quickstart/
 doesn't get built with 0.11.0-incubating release of predictionIO.

Looks like it is pointing to the packages and classes relevant to the older 
version of PredictionIO

for example, 
template-scala-parallel-complementarypurchase/src/main/scala/Algorithm.scala is 
importing the P2LAlgorithm class with qualified name as 
io.prediction.controller.P2LAlgorithm

but ideally it should have been org.apache.predictionio.controller.P2LAlgorithm 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)