[jira] [Created] (DISPATCH-1139) support prioritized addresses

2018-10-04 Thread michael goulish (JIRA)
michael goulish created DISPATCH-1139:
-

 Summary: support prioritized addresses
 Key: DISPATCH-1139
 URL: https://issues.apache.org/jira/browse/DISPATCH-1139
 Project: Qpid Dispatch
  Issue Type: New Feature
  Components: Router Node, Routing Engine, Tests
Reporter: michael goulish
Assignee: michael goulish


Support a new field in the address descriptor in router configuration files 
that will assign a priority to the address.

Any message that does not have an intrinsic priority already assigned will 
inherit the priority of the address to which it is sent.  If no priority is 
explicitly assigned to an address, then it will be assigned the default 
priority.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1126) ERROR Attempt to attach too many inter-router links for priority sheaf.

2018-10-04 Thread michael goulish (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638896#comment-16638896
 ] 

michael goulish commented on DISPATCH-1126:
---

pending fix for this in PR 384

> ERROR Attempt to attach too many inter-router links for priority sheaf.
> ---
>
> Key: DISPATCH-1126
> URL: https://issues.apache.org/jira/browse/DISPATCH-1126
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.3.0
> Environment: Fedora 28
>  * Three router network in linear arrangement A - B - C.
>  * B has a listener; A and C connect to it
>  
>Reporter: Chuck Rolke
>Assignee: michael goulish
>Priority: Major
> Attachments: taj-GRN.log
>
>
> Some state probably not cleaned up when router connections are lost. 10 
> messages
>     (error) Attempt to attach too many inter-router links for priority sheaf.
> appear when routers reconnect.
> Start the network. Then kill routers A and C and restart them. Router B 
> prints the messages.
> Log file attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (DISPATCH-1100) Allow link routes to auto delete when the corresponding container is removed

2018-10-04 Thread Ken Giusti (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti closed DISPATCH-1100.

Resolution: Won't Do

Not quite works as expected.   Discussed an alternative approach with Ted and 
Ganesh, will open jira on that soon.

> Allow link routes to auto delete when the corresponding container is removed
> 
>
> Key: DISPATCH-1100
> URL: https://issues.apache.org/jira/browse/DISPATCH-1100
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Management Agent, Router Node
>Affects Versions: 1.2.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 1.4.0
>
>
> This would allow a server to create its own link route which is removed when 
> the server is no longer attached to the router.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (DISPATCH-1138) auto delete link routes do not auto delete on normal or edge connections

2018-10-04 Thread Ken Giusti (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti closed DISPATCH-1138.

Resolution: Won't Fix

Have reverted the deleteOnClose feature.  This fix is no longer necessary.

> auto delete link routes do not auto delete on normal or edge connections
> 
>
> Key: DISPATCH-1138
> URL: https://issues.apache.org/jira/browse/DISPATCH-1138
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.3.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.4.0, 2.0.0
>
>
> Link routes with "deleteOnClose" set to True will  only auto-delete if the 
> connection's role is "route-container".
> They also need to auto delete for connections whose roles are normal and 
> edge-uplink



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1100) Allow link routes to auto delete when the corresponding container is removed

2018-10-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638818#comment-16638818
 ] 

ASF subversion and git services commented on DISPATCH-1100:
---

Commit 3f92be9015615d119cd4707e0ff63a2cf1a73a7c in qpid-dispatch's branch 
refs/heads/master from Kenneth Giusti
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=3f92be9 ]

Revert "DISPATCH-1100: add auto delete linkRoutes"

This reverts commit c03a9f0ab6773471faa9b7411a76e4f68b3023d2.


> Allow link routes to auto delete when the corresponding container is removed
> 
>
> Key: DISPATCH-1100
> URL: https://issues.apache.org/jira/browse/DISPATCH-1100
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Management Agent, Router Node
>Affects Versions: 1.2.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 1.4.0
>
>
> This would allow a server to create its own link route which is removed when 
> the server is no longer attached to the router.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1110) Intermittent router hang while running QIT's AMQP large content test

2018-10-04 Thread Chuck Rolke (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638770#comment-16638770
 ] 

Chuck Rolke commented on DISPATCH-1110:
---

qpid-interop-test (qit) is printing the error message to stderr on the sender 
when this error occurs. Unfortunately due to a defect in qit implementation a 
user at the test console never sees it. Qit throws away Sender and Receiver 
output if the process hangs and must be killed. An improvement for qit would be 
to print stdout and stderr from the Sender and Receiver even if those processes 
hang. The trick I pulled to get the error message to show up without messing 
with qit internals is to wait for the process to hang and then kill it by pid.

The message I get is:
 
{quote}
stderr=
amqp_large_content_test::Sender::on_connection_error: 
amqp:session:invalid-field: sequencing error, expected delivery-id 6, got 5
{quote}

Knowing this the next step is to figure out from where the error is coming.

> Intermittent router hang while running QIT's AMQP large content test
> 
>
> Key: DISPATCH-1110
> URL: https://issues.apache.org/jira/browse/DISPATCH-1110
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Standard QIT environment.
> Once QIT is built and installed, the environment is set using the config.sh 
> file. See QUICKSTART for details.
>Reporter: Kim van der Riet
>Assignee: Ganesh Murthy
>Priority: Major
> Attachments: qdrouterd.conf
>
>
> When running the Qpid Interop Test's AMQP large content test, a stand-alone 
> router will intermittently hang and cause the test to time out.
> The failure appears to be limited to either the AMQP list or map types, and 
> usually with the C++ client as the message sender.  The C++, Python2 and 
> Python3 as receiver clients have all seen this failure, but the Python2 
> receiver client seems to reproduce more readily on my hardware.
> In all cases, the test fails when the router sends what I suppose is the 
> final transfer of a large message (I have not added up/counted the bytes of 
> the many preceding transfers) to the consumer. The consumer then sends a 
> disposition, but the router does not respond again until the test times out. 
> The consumer can be seen to send heartbeats to the router, but the router 
> does not send any of its own.
> {noformat}
> ... (plenty of 65550-sized frames R->C)
> R->C 5976 3.454766::1 ::1 AMQP65550
> R->C 5977 3.454775::1 ::1 AMQP65550
> R->C 5978 3.454783::1 ::1 AMQP48171
> C->R 5982 3.529881::1 ::1 AMQP115 disposition
> C->R 5984 7.530704::1 ::1 AMQP94  (empty)
> C->R 5986 11.532306   ::1 ::1 AMQP94  (empty)
> ...{noformat}
> There are no errors to be seen in the router logs other than when the 
> consuming client is killed owing to the test timeout.
> {noformat}
> ...
> 2018-08-29 12:50:23.191754 -0400 SERVER (info) [14]: Accepted connection to 
> ::1:amqp from ::1:37262
> 2018-08-29 12:51:19.562695 -0400 SERVER (info) [14]: Connection from 
> ::1:37262 (to ::1:amqp) failed: amqp:connection:framing-error connection 
> aborted
> {noformat}
> The reproducer is not very tight on this, and the error occurs about 50% of 
> the time on my hardware.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1131) validate link route prefix field

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638742#comment-16638742
 ] 

ASF GitHub Bot commented on DISPATCH-1131:
--

GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/387

DISPATCH-1131: add better validation of address patterns and prefixes

This moves the address pattern/prefix validation to a common function
that can be share by both link routes add configured addresses.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/dispatch DISPATCH-1131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #387


commit a99de9a3cb5ad42d34f61b22be5e9e0aa25debc0
Author: Kenneth Giusti 
Date:   2018-09-27T17:22:51Z

DISPATCH-1131: add better validation of address patterns and prefixes

This moves the address pattern/prefix validation to a common function
that can be share by both link routes add configured addresses.




> validate link route prefix field
> 
>
> Key: DISPATCH-1131
> URL: https://issues.apache.org/jira/browse/DISPATCH-1131
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 1.3.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.4.0
>
>
> Verify the link route prefix field contains a valid prefix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1131) validate link route prefix field

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638736#comment-16638736
 ] 

ASF GitHub Bot commented on DISPATCH-1131:
--

Github user kgiusti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/385
  
Oops left in an extraneous check..


> validate link route prefix field
> 
>
> Key: DISPATCH-1131
> URL: https://issues.apache.org/jira/browse/DISPATCH-1131
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 1.3.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.4.0
>
>
> Verify the link route prefix field contains a valid prefix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #387: DISPATCH-1131: add better validation of add...

2018-10-04 Thread kgiusti
GitHub user kgiusti opened a pull request:

https://github.com/apache/qpid-dispatch/pull/387

DISPATCH-1131: add better validation of address patterns and prefixes

This moves the address pattern/prefix validation to a common function
that can be share by both link routes add configured addresses.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kgiusti/dispatch DISPATCH-1131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #387


commit a99de9a3cb5ad42d34f61b22be5e9e0aa25debc0
Author: Kenneth Giusti 
Date:   2018-09-27T17:22:51Z

DISPATCH-1131: add better validation of address patterns and prefixes

This moves the address pattern/prefix validation to a common function
that can be share by both link routes add configured addresses.




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #385: DISPATCH-1131: add better validation of address pa...

2018-10-04 Thread kgiusti
Github user kgiusti commented on the issue:

https://github.com/apache/qpid-dispatch/pull/385
  
Oops left in an extraneous check..


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1131) validate link route prefix field

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638737#comment-16638737
 ] 

ASF GitHub Bot commented on DISPATCH-1131:
--

Github user kgiusti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/385


> validate link route prefix field
> 
>
> Key: DISPATCH-1131
> URL: https://issues.apache.org/jira/browse/DISPATCH-1131
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Management Agent
>Affects Versions: 1.3.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.4.0
>
>
> Verify the link route prefix field contains a valid prefix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #385: DISPATCH-1131: add better validation of add...

2018-10-04 Thread kgiusti
Github user kgiusti closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/385


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1133) Router core modules for Core extensions

2018-10-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638483#comment-16638483
 ] 

ASF subversion and git services commented on DISPATCH-1133:
---

Commit 41c582838771317ed79cbcf68b022c6665aaf8f1 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=41c5828 ]

DISPATCH-1133 - Updated the attach/detach behavior of the core-endpoint API, 
added echo test for attach/detach.


> Router core modules for Core extensions
> ---
>
> Key: DISPATCH-1133
> URL: https://issues.apache.org/jira/browse/DISPATCH-1133
> Project: Qpid Dispatch
>  Issue Type: New Feature
>  Components: Router Node
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.4.0
>
>
> Introduce a formal notion of Router Core Module.  Such a module is an 
> extension to the router core engine.  The purpose of establishing core 
> modules is to isolate new functionality into a separate module file, rather 
> than embed it into the heart of the core files (which has happened too much).
> The first core module is the test-hooks module used to aid in the testing of 
> the various core APIs (like the core_endpoint API).  Modules shall be used in 
> the core extensions related to the Edge Router feature.
> In the future, existing capabilities can be moved into modules to provide 
> better code organization in the core.  The management agent is a good 
> candidate for this.  Link-routing can also be moved out to a core module.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1949) no message header if priority == default

2018-10-04 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638452#comment-16638452
 ] 

Robbie Gemmell commented on PROTON-1949:


I don't think your desire really works. Messages with no header do still have a 
priority, 4. The spec is clear that its semantically the same whether the 
header is sent or not, or the value is populated or not. I don't think you can 
reasonably treat the field/value's presence or not as definitely indicating it 
'had one assigned' when that value is 4. For example, to complicate matters, I 
think perhaps in the past proton-c actually sent the value 4 if you included a 
header but hadn't explicitly set the priority to 4.

(The JMS client also omits a header when it can, as its a waste of bytes and 
work done encoding/decoding it)

> no message header if priority == default
> 
>
> Key: PROTON-1949
> URL: https://issues.apache.org/jira/browse/PROTON-1949
> Project: Qpid Proton
>  Issue Type: Bug
>Reporter: michael goulish
>Priority: Major
>
> Proton does not send a message header if there would be nothing in it but the 
> priority field, and if the priority was set to the default value (4). 
> At the router level, we are allowing the user to set priorities on addresses. 
> Those priorities will be given to any message sent to that address if the 
> message otherwise had no priority set.
> So - we need to be able to distinguish between messages that were assigned 
> the default priority, and messages in which the priority was left undefined.
> We would like proton to send the priority field in the message header if the 
> user sets any priority. Then we will be able to interpret no header, or no 
> priority field in the header as "no priority was assigned".
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1137) Connection info contains stale pointer to container id

2018-10-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638326#comment-16638326
 ] 

ASF GitHub Bot commented on DISPATCH-1137:
--

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/386


> Connection info contains stale pointer to container id
> --
>
> Key: DISPATCH-1137
> URL: https://issues.apache.org/jira/browse/DISPATCH-1137
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.3.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.4.0, 2.0.0
>
>
> On connection close the memory pointed to by the container name pointer in 
> the connection info structure has been freed (as found by valgrind).  Need to 
> keep a copy of the name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1137) Connection info contains stale pointer to container id

2018-10-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638324#comment-16638324
 ] 

ASF subversion and git services commented on DISPATCH-1137:
---

Commit 3b1d84c969dad91d66641a719bc4374728902b58 in qpid-dispatch's branch 
refs/heads/master from Kenneth Giusti
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=3b1d84c ]

DISPATCH-1137: fix stale container name pointer in connection info

This closes #386


> Connection info contains stale pointer to container id
> --
>
> Key: DISPATCH-1137
> URL: https://issues.apache.org/jira/browse/DISPATCH-1137
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 1.3.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.4.0, 2.0.0
>
>
> On connection close the memory pointed to by the container name pointer in 
> the connection info structure has been freed (as found by valgrind).  Need to 
> keep a copy of the name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #386: DISPATCH-1137: fix stale container name poi...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/386


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1949) no message header if priority == default

2018-10-04 Thread michael goulish (JIRA)
michael goulish created PROTON-1949:
---

 Summary: no message header if priority == default
 Key: PROTON-1949
 URL: https://issues.apache.org/jira/browse/PROTON-1949
 Project: Qpid Proton
  Issue Type: Bug
Reporter: michael goulish


Proton does not send a message header if there would be nothing in it but the 
priority field, and if the priority was set to the default value (4). 

At the router level, we are allowing the user to set priorities on addresses. 
Those priorities will be given to any message sent to that address if the 
message otherwise had no priority set.

So - we need to be able to distinguish between messages that were assigned the 
default priority, and messages in which the priority was left undefined.

We would like proton to send the priority field in the message header if the 
user sets any priority. Then we will be able to interpret no header, or no 
priority field in the header as "no priority was assigned".

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1946) [cpp] connection config file parser mis-handling TLS defaults

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1946:
---
Fix Version/s: (was: proton-c-0.26.0)

> [cpp] connection config file parser mis-handling TLS defaults
> -
>
> Key: PROTON-1946
> URL: https://issues.apache.org/jira/browse/PROTON-1946
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>
> The C++ connection configuration parser mis-handles default values in several 
> ways:
>  * tls is not enabled unless there is a tls: {} section - it should be 
> enabled (with default config) if scheme: amqps is present even if there is no 
> tls section
>  * in several cases an explicit 'field: null' is treated differently (as an 
> error) from field being absent (use default value). null and absent should be 
> equivalent.
>  * Host defaults to "", it should be "localhost"
>  * Some exceptions from jsoncpp are leaked, they should be wrapped in 
> proton::error
>  * Need additional tests to cover all of the above



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1935) [cpp] Read a config file to get default connection parameters

2018-10-04 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638130#comment-16638130
 ] 

Robbie Gemmell commented on PROTON-1935:


See also relevant fixups made against PROTON-1946 and PROTON-1947 sub-tasks.

> [cpp] Read a config file to get default connection parameters 
> --
>
> Key: PROTON-1935
> URL: https://issues.apache.org/jira/browse/PROTON-1935
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> Implement no-argument C++ connect() to connect using information loaded from 
> a config file located and formatted as follows:
>  
> {code:java}
> # Connection Configuration {#connect_config}
> Proton clients can read default connection information from a
> configuration file.
> If the environment variable `MESSAGING_CONNECT_FILE` is set, it is the
> path to the file. Otherwise the client looks for a file named
> `connect.json` in the following locations, using the first one found:
> * Current working directory of client process.
> * `$HOME/.config/messaging/` - $HOME is user's home directory.
> * `/etc/messaging/`
> The configuration file is in JSON object format. Comments are allowed,
> as defined by the [JavaScript 
> Minifier](https://www.crockford.com/javascript/jsmin.html)
> The file format is as follows. Properties are shown with their default
> values, all properties are optional.
>     {
>     "scheme": "amqp",    // [string] URL scheme for connection. Use 
> "amqps" for a TLS connection.
>     "host": "localhost", // [string] DNS or IP address for connection.
>     "port": "amqp",  // [string] Defaults to be the same as the 
> scheme.
>     "user": null,    // [string] Authentication user name
>     "password": null,    // [string] Authentication password
>     "sasl": {
>     "enable": true, // [boolean] Enable/disable SASL 
> authentication
>     "mechanisms": null, // [list] List of SASL mechanism names. 
> If null the library determines the default list.
>     "allow_insecure": false // [boolean] Allow mechanisms that send 
> clear-text passwords, even on an unencrypted connection.
>     }
>     "tls": {
>     // NOTE: This section is not final and will change.
>     "enable": true,  // boolean (true)
>     "pem_cert_store": null,  // string [file or dir or ?] 
> (null)
>     "pem_ca_cert_store": null,   // string [file or dir or ?] 
> (null)
>     "pem_key_file": null,    // string file path (null)
>     "pkcs12_key_store": null,    // string (null)
>     "pkcs12_trust_store": null,  // string (null)
>     "key_password": null,    // string (null)
>     "verify_hostname": true  // boolean (true)
>     },
>     }{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (PROTON-1946) [cpp] connection config file parser mis-handling TLS defaults

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell closed PROTON-1946.
--

Converted to a sub-task of PROTON-1935 and dropped fix-version to avoid 
multiple release notes for a single new bit of functionality.

> [cpp] connection config file parser mis-handling TLS defaults
> -
>
> Key: PROTON-1946
> URL: https://issues.apache.org/jira/browse/PROTON-1946
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>
> The C++ connection configuration parser mis-handles default values in several 
> ways:
>  * tls is not enabled unless there is a tls: {} section - it should be 
> enabled (with default config) if scheme: amqps is present even if there is no 
> tls section
>  * in several cases an explicit 'field: null' is treated differently (as an 
> error) from field being absent (use default value). null and absent should be 
> equivalent.
>  * Host defaults to "", it should be "localhost"
>  * Some exceptions from jsoncpp are leaked, they should be wrapped in 
> proton::error
>  * Need additional tests to cover all of the above



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell closed PROTON-1947.
--
Resolution: Fixed

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1946) [cpp] connection config file parser mis-handling TLS defaults

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1946:
---
Issue Type: Sub-task  (was: Bug)
Parent: PROTON-1935

> [cpp] connection config file parser mis-handling TLS defaults
> -
>
> Key: PROTON-1946
> URL: https://issues.apache.org/jira/browse/PROTON-1946
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> The C++ connection configuration parser mis-handles default values in several 
> ways:
>  * tls is not enabled unless there is a tls: {} section - it should be 
> enabled (with default config) if scheme: amqps is present even if there is no 
> tls section
>  * in several cases an explicit 'field: null' is treated differently (as an 
> error) from field being absent (use default value). null and absent should be 
> equivalent.
>  * Host defaults to "", it should be "localhost"
>  * Some exceptions from jsoncpp are leaked, they should be wrapped in 
> proton::error
>  * Need additional tests to cover all of the above



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638127#comment-16638127
 ] 

Robbie Gemmell edited comment on PROTON-1947 at 10/4/18 12:11 PM:
--

Converted to a sub-task of --PROTON-1935 and dropped fix-version to avoid 
multiple release notes for a single new bit of functionality.


was (Author: gemmellr):
Converted to a sub-task of PROTON-1888 and dropped fix-version to avoid 
multiple release notes for a single new bit of functionality.

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Reopened] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reopened PROTON-1947:


> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638127#comment-16638127
 ] 

Robbie Gemmell edited comment on PROTON-1947 at 10/4/18 12:11 PM:
--

Converted to a sub-task of PROTON-1935 and dropped fix-version to avoid 
multiple release notes for a single new bit of functionality.


was (Author: gemmellr):
Converted to a sub-task of --PROTON-1935 and dropped fix-version to avoid 
multiple release notes for a single new bit of functionality.

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1947:
---
Parent Issue: PROTON-1935  (was: PROTON-1888)

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell closed PROTON-1947.
--
   Resolution: Fixed
Fix Version/s: (was: proton-c-0.26.0)

Converted to a sub-task of PROTON-1888 and dropped fix-version to avoid 
multiple release notes for a single new bit of functionality.

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1947:
---
Issue Type: Sub-task  (was: Bug)
Parent: PROTON-1888

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Sub-task
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638125#comment-16638125
 ] 

Robbie Gemmell commented on PROTON-1947:


This commit was for this JIRA but mis-tagged:

{noformat}
PROTON-1974: [cpp] modify to work with older jsoncpp (1.7.4)

- add jsoncpp to travis packages for CI testing
- fix string conversions - rules changed between 1.7.4 and 1.8
- better error handling/reporting


Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/aa85a1fe
Commit: aa85a1fe86827656501fe01f5695cd7ff4a842f3
Committer: Alan Conway
Committed: Tue Oct 2 13:53:11 2018 -0400
{noformat}

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (PROTON-1947) [cpp] not correctly locating jsoncpp library on some platforms

2018-10-04 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638125#comment-16638125
 ] 

Robbie Gemmell edited comment on PROTON-1947 at 10/4/18 12:07 PM:
--

This commit was for this JIRA but mis-tagged:

{quote}
PROTON-1974: [cpp] modify to work with older jsoncpp (1.7.4)

- add jsoncpp to travis packages for CI testing
- fix string conversions - rules changed between 1.7.4 and 1.8
- better error handling/reporting


Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/aa85a1fe
Commit: aa85a1fe86827656501fe01f5695cd7ff4a842f3
Committer: Alan Conway
Committed: Tue Oct 2 13:53:11 2018 -0400
{quote}


was (Author: gemmellr):
This commit was for this JIRA but mis-tagged:

{noformat}
PROTON-1974: [cpp] modify to work with older jsoncpp (1.7.4)

- add jsoncpp to travis packages for CI testing
- fix string conversions - rules changed between 1.7.4 and 1.8
- better error handling/reporting


Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/aa85a1fe
Commit: aa85a1fe86827656501fe01f5695cd7ff4a842f3
Committer: Alan Conway
Committed: Tue Oct 2 13:53:11 2018 -0400
{noformat}

> [cpp] not correctly locating jsoncpp library on some platforms
> --
>
> Key: PROTON-1947
> URL: https://issues.apache.org/jira/browse/PROTON-1947
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1926) 0.26.0 release tasks

2018-10-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638109#comment-16638109
 ] 

ASF subversion and git services commented on PROTON-1926:
-

Commit e769f784ee9752148f36fc8c5cc59ee06850de27 in qpid-proton's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e769f78 ]

PROTON-1944, PROTON-1926: update versions for 0.27.0-SNAPSHOT


> 0.26.0 release tasks
> 
>
> Key: PROTON-1926
> URL: https://issues.apache.org/jira/browse/PROTON-1926
> Project: Qpid Proton
>  Issue Type: Task
>  Components: proton-c, release
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: proton-c-0.26.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1926) 0.26.0 release tasks

2018-10-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638106#comment-16638106
 ] 

ASF subversion and git services commented on PROTON-1926:
-

Commit 5b5927de939c83162b543801532c61fdb0434826 in qpid-proton's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5b5927d ]

PROTON-1926, PROTON-1944: restore versions for 0.26.0-rc2

This reverts commit 1b554aad70452d6501cb3e13a6c10186d14e9dc9.


> 0.26.0 release tasks
> 
>
> Key: PROTON-1926
> URL: https://issues.apache.org/jira/browse/PROTON-1926
> Project: Qpid Proton
>  Issue Type: Task
>  Components: proton-c, release
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: proton-c-0.26.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1944) 0.27.0 release tasks

2018-10-04 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638108#comment-16638108
 ] 

ASF subversion and git services commented on PROTON-1944:
-

Commit e769f784ee9752148f36fc8c5cc59ee06850de27 in qpid-proton's branch 
refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e769f78 ]

PROTON-1944, PROTON-1926: update versions for 0.27.0-SNAPSHOT


> 0.27.0 release tasks
> 
>
> Key: PROTON-1944
> URL: https://issues.apache.org/jira/browse/PROTON-1944
> Project: Qpid Proton
>  Issue Type: Task
>  Components: proton-c, release
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: proton-c-0.27.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton pull request #161: NO-JIRA: Removed python upgrade for xcode7.3 ...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/161


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org