[jira] [Created] (PROTON-2800) [proton-dotnet] Ensure set message format get sent on first transfer frame
Timothy A. Bish created PROTON-2800: --- Summary: [proton-dotnet] Ensure set message format get sent on first transfer frame Key: PROTON-2800 URL: https://issues.apache.org/jira/browse/PROTON-2800 Project: Qpid Proton Issue Type: Bug Components: proton-dotnet Affects Versions: proton-dotnet-1.0.0-M9 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: proton-dotnet-1.0.0-M10 Ensure that the message format value always get set on the first transfer frame when set from the Advanced Message object or running with the defaults. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-2799) [proton-dotnet] Update sender create to match source and target address
[ https://issues.apache.org/jira/browse/PROTON-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy A. Bish resolved PROTON-2799. - Resolution: Fixed > [proton-dotnet] Update sender create to match source and target address > --- > > Key: PROTON-2799 > URL: https://issues.apache.org/jira/browse/PROTON-2799 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-dotnet >Affects Versions: proton-dotnet-1.0.0-M9 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Trivial > Fix For: proton-dotnet-1.0.0-M10 > > > Sender and Receiver create should both do the same action when building the > link objects, currently sender doesn't use the address value on source and > target while receiver does, we should match them and have them both use the > address value. > Add tests to ensure they are both doing what we expect in this case -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2799) [proton-dotnet] Update sender create to match source and target address
[ https://issues.apache.org/jira/browse/PROTON-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821450#comment-17821450 ] ASF subversion and git services commented on PROTON-2799: - Commit da5d24e03e11107b0168c240b62b58583731531f in qpid-proton-dotnet's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=qpid-proton-dotnet.git;h=da5d24e ] PROTON-2799 Ensure source and target address values set are matched Use consistent values for creating senders and receivers in the source and target address element. Add tests to cover this expectation. > [proton-dotnet] Update sender create to match source and target address > --- > > Key: PROTON-2799 > URL: https://issues.apache.org/jira/browse/PROTON-2799 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-dotnet >Affects Versions: proton-dotnet-1.0.0-M9 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Trivial > Fix For: proton-dotnet-1.0.0-M10 > > > Sender and Receiver create should both do the same action when building the > link objects, currently sender doesn't use the address value on source and > target while receiver does, we should match them and have them both use the > address value. > Add tests to ensure they are both doing what we expect in this case -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-2799) [proton-dotnet] Update sender create to match source and target address
Timothy A. Bish created PROTON-2799: --- Summary: [proton-dotnet] Update sender create to match source and target address Key: PROTON-2799 URL: https://issues.apache.org/jira/browse/PROTON-2799 Project: Qpid Proton Issue Type: Improvement Components: proton-dotnet Affects Versions: proton-dotnet-1.0.0-M9 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: proton-dotnet-1.0.0-M10 Sender and Receiver create should both do the same action when building the link objects, currently sender doesn't use the address value on source and target while receiver does, we should match them and have them both use the address value. Add tests to ensure they are both doing what we expect in this case -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-2795) [protonj2] Message format cannot be set to 0 on outbound messages
[
https://issues.apache.org/jira/browse/PROTON-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy A. Bish updated PROTON-2795:
Summary: [protonj2] Message format cannot be set to 0 on outbound messages
(was: Message format cannot be set to 0 on outbound messages)
> [protonj2] Message format cannot be set to 0 on outbound messages
> -
>
> Key: PROTON-2795
> URL: https://issues.apache.org/jira/browse/PROTON-2795
> Project: Qpid Proton
> Issue Type: Bug
> Components: protonj2
>Affects Versions: protonj2-1.0.0-M19
>Reporter: Arnaud Cogoluègnes
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: protonj2-1.0.0-M20
>
>
> Setting the message format to 0 or keeping the default value results in a
> null value in the {{transfer}} frame.
> 0 seems to be considered [a special
> value|https://github.com/apache/qpid-protonj2/blob/d5144af7818b2695747782bacc410580d3ec7943/protonj2/src/main/java/org/apache/qpid/protonj2/engine/impl/ProtonSessionOutgoingWindow.java#L270-L274]
> in the code.
> This contradicts [the
> Javadoc|https://github.com/apache/qpid-protonj2/blob/d5144af7818b2695747782bacc410580d3ec7943/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/AdvancedMessage.java#L170-L200]:
> {quote}This field MUST be specified for the first transfer of a
> multi-transfer message, if it is not set at the time of send of the first
> transfer the sender uses the AMQP default value of zero for this field.{quote}
> As well as the AMQP spec (section 2.7.5):
> {quote}This field MUST be specified for the first transfer of a
> multi-transfer message and can only be omitted for continuation transfers. It
> is an error if the message-format on a continuation transfer differs from the
> message-format on the first transfer of a delivery.{quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2438) [cpp] Cancellable tasks
[
https://issues.apache.org/jira/browse/PROTON-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821189#comment-17821189
]
ASF GitHub Bot commented on PROTON-2438:
DreamPearl commented on code in PR #379:
URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1504081204
##
cpp/src/proactor_container_impl.cpp:
##
@@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() {
// We've now taken the tasks to run from the deferred tasks
// so we can run them unlocked
// NB. We copied the due tasks in reverse order so execute from end
-for (int i = tasks.size()-1; i>=0; --i) tasks[i].task();
+
+for (int i = tasks.size()-1; i>=0; --i) {
+if(is_active_.count(tasks[i].w_handle)) {
+tasks[i].task();
+is_active_.erase(tasks[i].w_handle);
Review Comment:
@zlomek Thank you for raising this!
Would you like to raise a PR having a fix if you are interested? Otherwise,
I can.
> [cpp] Cancellable tasks
> ---
>
> Key: PROTON-2438
> URL: https://issues.apache.org/jira/browse/PROTON-2438
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Reporter: Božo Dragojevič
>Assignee: Rakhi Kumari
>Priority: Major
> Fix For: proton-c-0.38.0
>
>
> Allow scheduled tasks to be cancelled.
> A cancelled task does not keep reactor from stoping running
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [PR] PROTON-2438: [cpp] Cancellable tasks [qpid-proton]
DreamPearl commented on code in PR #379:
URL: https://github.com/apache/qpid-proton/pull/379#discussion_r1504081204
##
cpp/src/proactor_container_impl.cpp:
##
@@ -532,7 +540,13 @@ void container::impl::run_timer_jobs() {
// We've now taken the tasks to run from the deferred tasks
// so we can run them unlocked
// NB. We copied the due tasks in reverse order so execute from end
-for (int i = tasks.size()-1; i>=0; --i) tasks[i].task();
+
+for (int i = tasks.size()-1; i>=0; --i) {
+if(is_active_.count(tasks[i].w_handle)) {
+tasks[i].task();
+is_active_.erase(tasks[i].w_handle);
Review Comment:
@zlomek Thank you for raising this!
Would you like to raise a PR having a fix if you are interested? Otherwise,
I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
