[jira] [Commented] (QPID-3921) C++ header files need tidyup (in several different ways)
[ https://issues.apache.org/jira/browse/QPID-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050586#comment-14050586 ] ASF subversion and git services commented on QPID-3921: --- Commit 1607452 from [~astitcher] in branch 'qpid/trunk' [ https://svn.apache.org/r1607452 ] QPID-3921: Removed unused header includes > C++ header files need tidyup (in several different ways) > > > Key: QPID-3921 > URL: https://issues.apache.org/jira/browse/QPID-3921 > Project: Qpid > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > There are a number of problems with the header files and their use in the > qpid code base: > 1. There are many header files with non standard header guards - > - either using incorrect definitions (some starting with double underscore, > some with the header guards in the wrong place in the header file. > 2. There are many header files that are included unnecessarily, making the > compile times longer. > - This is especially true when a header file is included in another header > file instead of an implementation file. > - There are (many?) cases where types could be forward declared instead of > using the header file that defines them. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-3921) C++ header files need tidyup (in several different ways)
[ https://issues.apache.org/jira/browse/QPID-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049248#comment-14049248 ] ASF subversion and git services commented on QPID-3921: --- Commit 1607176 from [~astitcher] in branch 'qpid/trunk' [ https://svn.apache.org/r1607176 ] QPID-3921: Deleted unnecessary header file includes > C++ header files need tidyup (in several different ways) > > > Key: QPID-3921 > URL: https://issues.apache.org/jira/browse/QPID-3921 > Project: Qpid > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > There are a number of problems with the header files and their use in the > qpid code base: > 1. There are many header files with non standard header guards - > - either using incorrect definitions (some starting with double underscore, > some with the header guards in the wrong place in the header file. > 2. There are many header files that are included unnecessarily, making the > compile times longer. > - This is especially true when a header file is included in another header > file instead of an implementation file. > - There are (many?) cases where types could be forward declared instead of > using the header file that defines them. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-3921) C++ header files need tidyup (in several different ways)
[ https://issues.apache.org/jira/browse/QPID-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049208#comment-14049208 ] ASF subversion and git services commented on QPID-3921: --- Commit 1607166 from [~astitcher] in branch 'qpid/trunk' [ https://svn.apache.org/r1607166 ] QPID-3921: Refactored Broker::Options into its own independent class - Now called BrokerOptions - Added extra getters to Broker so that nothing else needs to know about BrokerOptions - Significantly reduces header coupling as lots of files include Broker.h, but now don't need Options.h > C++ header files need tidyup (in several different ways) > > > Key: QPID-3921 > URL: https://issues.apache.org/jira/browse/QPID-3921 > Project: Qpid > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > There are a number of problems with the header files and their use in the > qpid code base: > 1. There are many header files with non standard header guards - > - either using incorrect definitions (some starting with double underscore, > some with the header guards in the wrong place in the header file. > 2. There are many header files that are included unnecessarily, making the > compile times longer. > - This is especially true when a header file is included in another header > file instead of an implementation file. > - There are (many?) cases where types could be forward declared instead of > using the header file that defines them. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-3921) C++ header files need tidyup (in several different ways)
[ https://issues.apache.org/jira/browse/QPID-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029902#comment-14029902 ] ASF subversion and git services commented on QPID-3921: --- Commit 1602305 from [~astitcher] in branch 'qpid/trunk' [ https://svn.apache.org/r1602305 ] QPID-3921: Don't leak use qpid/Options.h header unnecessarily. > C++ header files need tidyup (in several different ways) > > > Key: QPID-3921 > URL: https://issues.apache.org/jira/browse/QPID-3921 > Project: Qpid > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > There are a number of problems with the header files and their use in the > qpid code base: > 1. There are many header files with non standard header guards - > - either using incorrect definitions (some starting with double underscore, > some with the header guards in the wrong place in the header file. > 2. There are many header files that are included unnecessarily, making the > compile times longer. > - This is especially true when a header file is included in another header > file instead of an implementation file. > - There are (many?) cases where types could be forward declared instead of > using the header file that defines them. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
