Re: Contributer Patches - Committers Requested

2010-05-03 Thread Andrew Stitcher 
On Mon, 2010-05-03 at 11:06 -0400, Alan Conway wrote:
> On 04/22/2010 02:04 PM, Kerry Bonin wrote:
> > I'd also suggest the patch I made w/ QPID-1904 - The C++ AbsTime&
> > Duration values are not set to a consistent epoch, which causes
> > problems when you try using QMF timestamps across Linux and Windows,
> > and even on Windows when you try and talk between Python and C++
> > clients.  I submitted a patch which forces the epoch to that specified
> > in AMQP, instead of inheriting it from the platform, which seems quite
> > wrong for a network protocol across platforms with differing native
> > epochs.  The epoch is calculated once, and the conversion was already
> > relative to a base, so there should be no performance hit.
> >
> 
> There is already an EPOCH constant in Time.h that is consistent for windows & 
> posix, it was added recently. Does this address your issue?

I checked in a fix for QPID_1904 last week.

A



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Contributer Patches - Committers Requested

2010-05-03 Thread Alan Conway 

On 04/22/2010 02:04 PM, Kerry Bonin wrote:

I'd also suggest the patch I made w/ QPID-1904 - The C++ AbsTime&
Duration values are not set to a consistent epoch, which causes
problems when you try using QMF timestamps across Linux and Windows,
and even on Windows when you try and talk between Python and C++
clients.  I submitted a patch which forces the epoch to that specified
in AMQP, instead of inheriting it from the platform, which seems quite
wrong for a network protocol across platforms with differing native
epochs.  The epoch is calculated once, and the conversion was already
relative to a base, so there should be no performance hit.



There is already an EPOCH constant in Time.h that is consistent for windows & 
posix, it was added recently. Does this address your issue?


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

RE: Contributer Patches - Committers Requested

2010-04-23 Thread Steve Huston 
I assigned the WCF and Windows SSL ones to me.

-Steve

> -Original Message-
> From: Marnie McCormack [mailto:marnie.mccorm...@googlemail.com] 
> Sent: Thursday, April 22, 2010 7:06 AM
> To: dev@qpid.apache.org
> Subject: Contributer Patches - Committers Requested
> 
> 
> Hi All,
> 
> I think there may be a few JIRAs out there with patches 
> looking for a committer to pick up.
> 
> We've got quite a few contributers who are new/just getting 
> established just now so I'd like to propose we volunteer to 
> pair up with the new submitters to pick up patches. Perhaps 
> the ad hoc system is working just now, but I'm not sure how 
> else we avoid items dropping into gaps ? Be good to have 
> thoughts on this subject.
> 
> I've spotted a few patches (below) in need of a committer, 
> just from recent activity on JIRA and I think Emmanuel might 
> have a couple of older ones about too. (There's a couple I 
> wasn't sure if the patch had been applied/issue resolved or not.)
> 
> Contributers - please shout if I've missed anything else 
> you're waiting for us to pick up ? Thank you.
> 
>  *Key*
>  *Summary*
>  *Assignee*
>  *Reporter*
>  QPID-2498 <http://issues.apache.org/jira/browse/QPID-2498>
>  Upgrade Mina to 1.1.7
>  Martin Ritchie
>  Emmanuel Bourg
>  QPID-2531 <http://issues.apache.org/jira/browse/QPID-2531>
>  Improve the qpid broker build system to automatically build 
> OSGI modules on broker-plugins directory  Unassigned  Sorin 
> Suciu  QPID-2530 <http://issues.apache.org/jira/browse/QPID-2530>
>  Refactor the broker-plugins directory setup to allow adding 
> new modules  Unassigned  Sorin Suciu  QPID-2529 
> <http://issues.apache.org/jira/browse/QPID-2529>
>  Update the Felix OSGI framework to a recent release
>  Unassigned
>  Sorin Suciu
>  QPID-2528 <http://issues.apache.org/jira/browse/QPID-2528>
>  qpid-config's add exchange option "--durable" doesn't work  
> Unassigned  Tim Powers  QPID-1811 
> <http://issues.apache.org/jira/browse/QPID-1811>
>  Unable to compile qpid on FreeBSD
>  ? Andrew Stitcher
>  Attila Nagy
>  QPID-2526 <http://issues.apache.org/jira/browse/QPID-2526>
>  Ant build fails if the path contains a space character  
> Unassigned  Emmanuel Bourg  QPID-2513 
> <http://issues.apache.org/jira/browse/QPID-2513>
>  Expose the ServerConfiguration as an OSGI service for use in 
> plugins  Unassigned  Sorin Suciu  QPID-2519 
> <http://issues.apache.org/jira/browse/QPID-2519>
>  Allow Windows Broker to run as a Service
>  Unassigned
>  Kerry Bonin
>  QPID-2520 <http://issues.apache.org/jira/browse/QPID-2520>
>  Broken POM generation on Windows
>  Unassigned
>  Emmanuel Bourg
>  QPID-2516 <http://issues.apache.org/jira/browse/QPID-2516>
>  New sample to show how to specify WCF bindings in config 
> files  Unassigned  Cliff Jansen  QPID-2501 
> <http://issues.apache.org/jira/browse/QPID-2501>
>  WCF Binding Configuration parameters
>  Unassigned
>  Cliff Jansen
>  QPID-2500 <http://issues.apache.org/jira/browse/QPID-2500>
>  Transport security for the WCF channel
>  Unassigned
>  Cliff Jansen
>  QPID-2502 <http://issues.apache.org/jira/browse/QPID-2502>
>  securityTracker open() call is made on exchangeTracker 
> instance instead  Unassigned  Sorin Suciu Regards, Marnie
> 


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Contributer Patches - Committers Requested

2010-04-23 Thread Martin Ritchie 
On 22 April 2010 12:08, Martin Ritchie  wrote:
> On 22 April 2010 12:05, Marnie McCormack
>  wrote:
>> Hi All,
>>
>> I think there may be a few JIRAs out there with patches looking for a
>> committer to pick up.
>>
>> We've got quite a few contributers who are new/just getting established just
>> now so I'd like to propose we volunteer to pair up with the new submitters
>> to pick up patches. Perhaps the ad hoc system is working just now, but I'm
>> not sure how else we avoid items dropping into gaps ? Be good to have
>> thoughts on this subject.
>>
>> I've spotted a few patches (below) in need of a committer, just from recent
>> activity on JIRA and I think Emmanuel might have a couple of older ones
>> about too. (There's a couple I wasn't sure if the patch had been
>> applied/issue resolved or not.)
>>
>> Contributers - please shout if I've missed anything else you're waiting for
>> us to pick up ? Thank you.
>>
>> *Key*
>>  *Summary*
>>  *Assignee*
>>  *Reporter*
>>  QPID-2498 
>>  Upgrade Mina to 1.1.7
>>  Martin Ritchie
>>  Emmanuel Bourg
>>  QPID-2531 
>>  Improve the qpid broker build system to automatically build OSGI modules on
>> broker-plugins directory
>>  Unassigned
>>  Sorin Suciu
>>  QPID-2530 
>>  Refactor the broker-plugins directory setup to allow adding new modules
>>  Unassigned
>>  Sorin Suciu
>>  QPID-2529 
>>  Update the Felix OSGI framework to a recent release
>>  Unassigned
>>  Sorin Suciu
>>  QPID-2528 
>>  qpid-config's add exchange option "--durable" doesn't work
>>  Unassigned
>>  Tim Powers
>>  QPID-1811 
>>  Unable to compile qpid on FreeBSD
>>  ? Andrew Stitcher
>>  Attila Nagy
>>  QPID-2526 
>>  Ant build fails if the path contains a space character
>>  Unassigned
>>  Emmanuel Bourg
>>  QPID-2513 
>>  Expose the ServerConfiguration as an OSGI service for use in plugins
>>  Unassigned
>>  Sorin Suciu
>>  QPID-2519 
>>  Allow Windows Broker to run as a Service
>>  Unassigned
>>  Kerry Bonin
>>  QPID-2520 
>>  Broken POM generation on Windows
>>  Unassigned
>>  Emmanuel Bourg
>>  QPID-2516 
>>  New sample to show how to specify WCF bindings in config files
>>  Unassigned
>>  Cliff Jansen
>>  QPID-2501 
>>  WCF Binding Configuration parameters
>>  Unassigned
>>  Cliff Jansen
>>  QPID-2500 
>>  Transport security for the WCF channel
>>  Unassigned
>>  Cliff Jansen
>>  QPID-2502 
>>  securityTracker open() call is made on exchangeTracker instance instead
>>  Unassigned
>>  Sorin Suciu
>> Regards,
>> Marnie
>
> I'll take a look at the following:
> QPID-2498
> QPID-2502
> QPID-2513
> QPID-2529
> QPID-2530
> QPID-2531
>
> I'll assign them over to me now.
>
> Martin
>
>
> --
> Martin Ritchie
>

I've reviewed and applied Sorin's patches. Thanks for those Sorin,
OSGi is the new hotness for the broker.

Will look at QPID-2529 again when you've got a patch on it.

Thanks again for those.

Emmanuel will look at the mina one next.

Cheers
-- 
Martin Ritchie

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Contributer Patches - Committers Requested

2010-04-23 Thread Marnie McCormack 
I'll try to pick up a few more later today, on the Java side.

Regards,
Marnie

On Fri, Apr 23, 2010 at 10:39 AM, Marnie McCormack <
marnie.mccorm...@googlemail.com> wrote:

> QPID-2433 done, after careful consideration ;-)
>
> Regards,
> Marnie
>
>  On Thu, Apr 22, 2010 at 2:27 PM, Emmanuel Bourg wrote:
>
>> Rajith Attapattu a écrit :
>>
>> I have taken care of QPID-2508 and QPID-2522 from Emmanuel.
>>> I left the MINA patch to Martin as he is more familiar with that side.
>>>
>>
>> Thanks all for taking care of the patches. There is also an involved patch
>> waiting for a thorough review in QPID-2433.
>>
>>https://issues.apache.org/jira/browse/QPID-2433
>>
>> Emmanuel Bourg
>>
>>
>> -
>> Apache Qpid - AMQP Messaging Implementation
>> Project:  http://qpid.apache.org
>> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>>
>>
>

Re: Contributer Patches - Committers Requested

2010-04-23 Thread Marnie McCormack 
QPID-2433 done, after careful consideration ;-)

Regards,
Marnie

On Thu, Apr 22, 2010 at 2:27 PM, Emmanuel Bourg  wrote:

> Rajith Attapattu a écrit :
>
> I have taken care of QPID-2508 and QPID-2522 from Emmanuel.
>> I left the MINA patch to Martin as he is more familiar with that side.
>>
>
> Thanks all for taking care of the patches. There is also an involved patch
> waiting for a thorough review in QPID-2433.
>
>https://issues.apache.org/jira/browse/QPID-2433
>
> Emmanuel Bourg
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>

Re: Contributer Patches - Committers Requested

2010-04-22 Thread Kerry Bonin 
I'd also suggest the patch I made w/ QPID-1904 - The C++ AbsTime &
Duration values are not set to a consistent epoch, which causes
problems when you try using QMF timestamps across Linux and Windows,
and even on Windows when you try and talk between Python and C++
clients.  I submitted a patch which forces the epoch to that specified
in AMQP, instead of inheriting it from the platform, which seems quite
wrong for a network protocol across platforms with differing native
epochs.  The epoch is calculated once, and the conversion was already
relative to a base, so there should be no performance hit.


On Thu, Apr 22, 2010 at 8:27 AM, Emmanuel Bourg  wrote:
> Rajith Attapattu a écrit :
>>
>> I have taken care of QPID-2508 and QPID-2522 from Emmanuel.
>> I left the MINA patch to Martin as he is more familiar with that side.
>
> Thanks all for taking care of the patches. There is also an involved patch
> waiting for a thorough review in QPID-2433.
>
>    https://issues.apache.org/jira/browse/QPID-2433
>
> Emmanuel Bourg
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Contributer Patches - Committers Requested

2010-04-22 Thread Emmanuel Bourg 

Rajith Attapattu a écrit :

I have taken care of QPID-2508 and QPID-2522 from Emmanuel.
I left the MINA patch to Martin as he is more familiar with that side.


Thanks all for taking care of the patches. There is also an involved 
patch waiting for a thorough review in QPID-2433.


https://issues.apache.org/jira/browse/QPID-2433

Emmanuel Bourg

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Contributer Patches - Committers Requested

2010-04-22 Thread Rajith Attapattu 
I have taken care of QPID-2508 and QPID-2522 from Emmanuel.
I left the MINA patch to Martin as he is more familiar with that side.

Rajith

On Thu, Apr 22, 2010 at 7:05 AM, Marnie McCormack
 wrote:
> Hi All,
>
> I think there may be a few JIRAs out there with patches looking for a
> committer to pick up.
>
> We've got quite a few contributers who are new/just getting established just
> now so I'd like to propose we volunteer to pair up with the new submitters
> to pick up patches. Perhaps the ad hoc system is working just now, but I'm
> not sure how else we avoid items dropping into gaps ? Be good to have
> thoughts on this subject.
>
> I've spotted a few patches (below) in need of a committer, just from recent
> activity on JIRA and I think Emmanuel might have a couple of older ones
> about too. (There's a couple I wasn't sure if the patch had been
> applied/issue resolved or not.)
>
> Contributers - please shout if I've missed anything else you're waiting for
> us to pick up ? Thank you.
>
>     *Key*
>  *Summary*
>  *Assignee*
>  *Reporter*
>  QPID-2498 
>  Upgrade Mina to 1.1.7
>  Martin Ritchie
>  Emmanuel Bourg
>  QPID-2531 
>  Improve the qpid broker build system to automatically build OSGI modules on
> broker-plugins directory
>  Unassigned
>  Sorin Suciu
>  QPID-2530 
>  Refactor the broker-plugins directory setup to allow adding new modules
>  Unassigned
>  Sorin Suciu
>  QPID-2529 
>  Update the Felix OSGI framework to a recent release
>  Unassigned
>  Sorin Suciu
>  QPID-2528 
>  qpid-config's add exchange option "--durable" doesn't work
>  Unassigned
>  Tim Powers
>  QPID-1811 
>  Unable to compile qpid on FreeBSD
>  ? Andrew Stitcher
>  Attila Nagy
>  QPID-2526 
>  Ant build fails if the path contains a space character
>  Unassigned
>  Emmanuel Bourg
>  QPID-2513 
>  Expose the ServerConfiguration as an OSGI service for use in plugins
>  Unassigned
>  Sorin Suciu
>  QPID-2519 
>  Allow Windows Broker to run as a Service
>  Unassigned
>  Kerry Bonin
>  QPID-2520 
>  Broken POM generation on Windows
>  Unassigned
>  Emmanuel Bourg
>  QPID-2516 
>  New sample to show how to specify WCF bindings in config files
>  Unassigned
>  Cliff Jansen
>  QPID-2501 
>  WCF Binding Configuration parameters
>  Unassigned
>  Cliff Jansen
>  QPID-2500 
>  Transport security for the WCF channel
>  Unassigned
>  Cliff Jansen
>  QPID-2502 
>  securityTracker open() call is made on exchangeTracker instance instead
>  Unassigned
>  Sorin Suciu
> Regards,
> Marnie
>



-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Contributer Patches - Committers Requested

2010-04-22 Thread Martin Ritchie 
On 22 April 2010 12:05, Marnie McCormack
 wrote:
> Hi All,
>
> I think there may be a few JIRAs out there with patches looking for a
> committer to pick up.
>
> We've got quite a few contributers who are new/just getting established just
> now so I'd like to propose we volunteer to pair up with the new submitters
> to pick up patches. Perhaps the ad hoc system is working just now, but I'm
> not sure how else we avoid items dropping into gaps ? Be good to have
> thoughts on this subject.
>
> I've spotted a few patches (below) in need of a committer, just from recent
> activity on JIRA and I think Emmanuel might have a couple of older ones
> about too. (There's a couple I wasn't sure if the patch had been
> applied/issue resolved or not.)
>
> Contributers - please shout if I've missed anything else you're waiting for
> us to pick up ? Thank you.
>
> *Key*
>  *Summary*
>  *Assignee*
>  *Reporter*
>  QPID-2498 
>  Upgrade Mina to 1.1.7
>  Martin Ritchie
>  Emmanuel Bourg
>  QPID-2531 
>  Improve the qpid broker build system to automatically build OSGI modules on
> broker-plugins directory
>  Unassigned
>  Sorin Suciu
>  QPID-2530 
>  Refactor the broker-plugins directory setup to allow adding new modules
>  Unassigned
>  Sorin Suciu
>  QPID-2529 
>  Update the Felix OSGI framework to a recent release
>  Unassigned
>  Sorin Suciu
>  QPID-2528 
>  qpid-config's add exchange option "--durable" doesn't work
>  Unassigned
>  Tim Powers
>  QPID-1811 
>  Unable to compile qpid on FreeBSD
>  ? Andrew Stitcher
>  Attila Nagy
>  QPID-2526 
>  Ant build fails if the path contains a space character
>  Unassigned
>  Emmanuel Bourg
>  QPID-2513 
>  Expose the ServerConfiguration as an OSGI service for use in plugins
>  Unassigned
>  Sorin Suciu
>  QPID-2519 
>  Allow Windows Broker to run as a Service
>  Unassigned
>  Kerry Bonin
>  QPID-2520 
>  Broken POM generation on Windows
>  Unassigned
>  Emmanuel Bourg
>  QPID-2516 
>  New sample to show how to specify WCF bindings in config files
>  Unassigned
>  Cliff Jansen
>  QPID-2501 
>  WCF Binding Configuration parameters
>  Unassigned
>  Cliff Jansen
>  QPID-2500 
>  Transport security for the WCF channel
>  Unassigned
>  Cliff Jansen
>  QPID-2502 
>  securityTracker open() call is made on exchangeTracker instance instead
>  Unassigned
>  Sorin Suciu
> Regards,
> Marnie

I'll take a look at the following:
QPID-2498
QPID-2502
QPID-2513
QPID-2529
QPID-2530
QPID-2531

I'll assign them over to me now.

Martin


-- 
Martin Ritchie

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Contributer Patches - Committers Requested

2010-04-22 Thread Marnie McCormack 
Hi All,

I think there may be a few JIRAs out there with patches looking for a
committer to pick up.

We've got quite a few contributers who are new/just getting established just
now so I'd like to propose we volunteer to pair up with the new submitters
to pick up patches. Perhaps the ad hoc system is working just now, but I'm
not sure how else we avoid items dropping into gaps ? Be good to have
thoughts on this subject.

I've spotted a few patches (below) in need of a committer, just from recent
activity on JIRA and I think Emmanuel might have a couple of older ones
about too. (There's a couple I wasn't sure if the patch had been
applied/issue resolved or not.)

Contributers - please shout if I've missed anything else you're waiting for
us to pick up ? Thank you.

 *Key*
 *Summary*
 *Assignee*
 *Reporter*
 QPID-2498 
 Upgrade Mina to 1.1.7
 Martin Ritchie
 Emmanuel Bourg
 QPID-2531 
 Improve the qpid broker build system to automatically build OSGI modules on
broker-plugins directory
 Unassigned
 Sorin Suciu
 QPID-2530 
 Refactor the broker-plugins directory setup to allow adding new modules
 Unassigned
 Sorin Suciu
 QPID-2529 
 Update the Felix OSGI framework to a recent release
 Unassigned
 Sorin Suciu
 QPID-2528 
 qpid-config's add exchange option "--durable" doesn't work
 Unassigned
 Tim Powers
 QPID-1811 
 Unable to compile qpid on FreeBSD
 ? Andrew Stitcher
 Attila Nagy
 QPID-2526 
 Ant build fails if the path contains a space character
 Unassigned
 Emmanuel Bourg
 QPID-2513 
 Expose the ServerConfiguration as an OSGI service for use in plugins
 Unassigned
 Sorin Suciu
 QPID-2519 
 Allow Windows Broker to run as a Service
 Unassigned
 Kerry Bonin
 QPID-2520 
 Broken POM generation on Windows
 Unassigned
 Emmanuel Bourg
 QPID-2516 
 New sample to show how to specify WCF bindings in config files
 Unassigned
 Cliff Jansen
 QPID-2501 
 WCF Binding Configuration parameters
 Unassigned
 Cliff Jansen
 QPID-2500 
 Transport security for the WCF channel
 Unassigned
 Cliff Jansen
 QPID-2502 
 securityTracker open() call is made on exchangeTracker instance instead
 Unassigned
 Sorin Suciu
Regards,
Marnie