Re: [GitHub] [sedona] BarbieQkiller opened a new pull request, #755: [SEDONA-179] Claim OGC compliance.

2023-02-05 Thread Mo Sarwat
This is a great PR!

Just wondering how the output of the test looks like. I will show all OGC
standard requirements and for each requirement a check mark ✅ is printed
out if Sedona supports it. On the other hand, if Sedona does not satisfy a
specific OGC requirement, the test will print out a cross mark ❌

Is that how it works?

Thanks,
-Mo



On Sun, Feb 5, 2023 at 9:51 AM BarbieQkiller (via GitHub) 
wrote:

>
> BarbieQkiller opened a new pull request, #755:
> URL: https://github.com/apache/sedona/pull/755
>
>
>## Did you read the Contributor Guide?
>
>- Yes, I have read [Contributor Rules](
> https://sedona.apache.org/community/rule/) and [Contributor Development
> Guide](https://sedona.apache.org/community/develop/)
>
>## Is this PR related to a JIRA ticket?
>
>- Yes, the URL of the assoicated JIRA ticket is
> https://issues.apache.org/jira/browse/SEDONA-179. The PR name follows the
> format `[SEDONA-179] my subject`.
>
>## What changes were proposed in this PR?
>
>The most relevant parts of OGC sfs tests for Geometry types and
> functions are implemented.
>Findings: Two functions are not compliant plus some functions are not
> implemented in Sedona.
>Tests for those are ignored with comments.
>
>## How was this patch tested?
>
>Test suite.
>
>## Did this PR include necessary documentation updates?
>
>- No, this PR does not affect any public API so no need to change the
> docs.
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>


[GitHub] [sedona] BarbieQkiller opened a new pull request, #755: [SEDONA-179] Claim OGC compliance.

2023-02-05 Thread via GitHub


BarbieQkiller opened a new pull request, #755:
URL: https://github.com/apache/sedona/pull/755

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor 
Rules](https://sedona.apache.org/community/rule/) and [Contributor Development 
Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is 
https://issues.apache.org/jira/browse/SEDONA-179. The PR name follows the 
format `[SEDONA-179] my subject`.
   
   ## What changes were proposed in this PR?
   
   The most relevant parts of OGC sfs tests for Geometry types and functions 
are implemented.
   Findings: Two functions are not compliant plus some functions are not 
implemented in Sedona.
   Tests for those are ignored with comments.
   
   ## How was this patch tested?
   
   Test suite.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org