[jira] [Created] (SLING-2251) RedirectServlet should create relative Location headers as often as possible
RedirectServlet should create relative Location headers as often as possible Key: SLING-2251 URL: https://issues.apache.org/jira/browse/SLING-2251 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Get 2.1.2 Reporter: Alexander Klimetschek SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175 ) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain. Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2251) RedirectServlet should create relative Location headers as often as possible
[ https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated SLING-2251: - Description: SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain (e.g. https://my.domain.com;). Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. was: SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175 ) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain. Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. RedirectServlet should create relative Location headers as often as possible Key: SLING-2251 URL: https://issues.apache.org/jira/browse/SLING-2251 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Get 2.1.2 Reporter: Alexander Klimetschek SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain (e.g. https://my.domain.com;). Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2251) RedirectServlet should create relative Location headers as often as possible
[ https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated SLING-2251: - Description: SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175 ) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain (e.g. https://my.domain.com;). Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. was: SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain (e.g. https://my.domain.com;). Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. RedirectServlet should create relative Location headers as often as possible Key: SLING-2251 URL: https://issues.apache.org/jira/browse/SLING-2251 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Get 2.1.2 Reporter: Alexander Klimetschek SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175 ) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain (e.g. https://my.domain.com;). Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2251) RedirectServlet should create relative Location headers as often as possible
[ https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130579#comment-13130579 ] Alexander Klimetschek commented on SLING-2251: -- An (untested) patch would be - at the end of toRedirect(), lines 230-237 - simply return the result of the mapping: return request.getResourceResolver().map(request, target.toString()); AFAIK, the resource resolver's map method (with request object) already does the necessary logic to create a relative path if the request domain matches the mapping domain, and an absolute path if it differs. RedirectServlet should create relative Location headers as often as possible Key: SLING-2251 URL: https://issues.apache.org/jira/browse/SLING-2251 Project: Sling Issue Type: Improvement Components: Servlets Affects Versions: Servlets Get 2.1.2 Reporter: Alexander Klimetschek SLING-1965 (more specifically http://svn.apache.org/viewvc?view=revisionrevision=903175 ) changed the redirect servlet so that it _always_ generates an absolute location header. The issue does not give much reasoning for that. The problem is that this breaks cases where a Sling server is run behind a proxy (which does not or cannot rewrite the Location header), as the redirect (http://localhost:8080/some/path;) might not match the externally visible domain (e.g. https://my.domain.com;). Also, the schema is fixed (e.g. might switch external https back to http). A solution would be to generate absolute URLs only if a resource resolver mapping (/etc/map) includes an explicit domain and thus generates an absolute URL. For all other cases, relative URLs should be generated. AFAICS, this was the case before SLING-1965. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2194: -- Description: if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. (was: if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at runlevel 1, but this can be set by configuration.) generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2194: -- Assignee: Justin Edelson generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130796#comment-13130796 ] Justin Edelson commented on SLING-2194: --- making two changes: 1) This should apply to any project, not just partial bundle list projects 2) It should be disabled by default generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130798#comment-13130798 ] Justin Edelson commented on SLING-2194: --- dependencyStartLevel0/dependencyStartLevel triggers this. generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-2194: -- Fix Version/s: Maven Launchpad Plugin 2.1.2 generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Maven Launchpad Plugin 2.1.2 if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-2194. --- Resolution: Fixed generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Maven Launchpad Plugin 2.1.2 if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2194) generate a partial bundle list from a project's dependencies
[ https://issues.apache.org/jira/browse/SLING-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130893#comment-13130893 ] Justin Edelson commented on SLING-2194: --- done in r1186417 generate a partial bundle list from a project's dependencies Key: SLING-2194 URL: https://issues.apache.org/jira/browse/SLING-2194 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Maven Launchpad Plugin 2.1.2 if a project is of type partialbundlelist, its dependencies should be added to the bundle list. if the project doesn't include a bundle list file, one should be created. by default, a project's dependencies should be added at startlevel 0, but this can be set by configuration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Installer Integration Tests #1079
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/1079/
Jenkins build became unstable: sling-trunk-1.6 #1079
See https://builds.apache.org/job/sling-trunk-1.6/1079/changes
Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Installer Integration Tests #1400
See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.installer.it/1400/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Installer Integration Tests #1080
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/1080/
Jenkins build is still unstable: sling-trunk-1.6 #1080
See https://builds.apache.org/job/sling-trunk-1.6/changes
