[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909245#action_12909245 ] Justin Edelson commented on SLING-1737: --- ditto. going on my third good build. > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > Attachments: ConfigInstallTest-debug.log.gz, debug.zip, > RemovedResourceDetectionTest-debug.log.gz > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909222#action_12909222 ] Carsten Ziegeler commented on SLING-1737: - Great, thanks Pontus. So once we have confirmation from Justin we can hopefully close this bug. > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > Attachments: ConfigInstallTest-debug.log.gz, debug.zip, > RemovedResourceDetectionTest-debug.log.gz > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909211#action_12909211 ] Pontus Amberg commented on SLING-1737: -- Looks like the sync problem might have been the cause of my problems. I can now build the current trunk with no test failures. > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > Attachments: ConfigInstallTest-debug.log.gz, debug.zip, > RemovedResourceDetectionTest-debug.log.gz > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909197#action_12909197 ] Carsten Ziegeler commented on SLING-1737: - I still can't reproduce it - even with high load :( But I fixed the potential sync problem in revision 996845 - so maybe this fixes the problems? > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > Attachments: ConfigInstallTest-debug.log.gz, debug.zip, > RemovedResourceDetectionTest-debug.log.gz > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909162#action_12909162 ] Carsten Ziegeler commented on SLING-1737: - This might be a sync problem in the OsgiInstallerImpl - Felix reported that he got similar errors while running the tests under load. Looking at the OsgiInstallerImpl it can definitly run into a deadlock (this bug has been there forever, but is more prominent now), so once I can reproduce, I'll try to fix this sync problem > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > Attachments: ConfigInstallTest-debug.log.gz, debug.zip, > RemovedResourceDetectionTest-debug.log.gz > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909141#action_12909141 ] Carsten Ziegeler commented on SLING-1737: - I retried the tests running on Java 5 and Java 6 - and they run each time :( It seems the -Dpax.exam.log.level=DEBUG test option does not work like I expected; at least I can't find the relevant log statements in the logs you provided :( So maybe could you please rerun the tests and change directly the property value in the pom.xml? Please also make sure that you did a "mvn install" on the installer/osgi/installer project before you run the tests. @Justin - Are the tests for you failing with both Maven versions or just with 3.0-beta-3? - I'm just speculating here, but as I'm also using OS X with Maven 2.2.1, there must be some difference between our environments. > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > Attachments: ConfigInstallTest-debug.log.gz, debug.zip, > RemovedResourceDetectionTest-debug.log.gz > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[
https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908812#action_12908812
]
Carsten Ziegeler commented on SLING-1737:
-
@Justin and @Pontus: Could you both please retest with latest trunk (revision
996562). If a test case is failing, please create a debug log by
> mvn -D={TestCase} -Dpax.exam.log.level=DEBUG test
and attach it to this issue.
All tests are now passing for me and I can't get them failing by just rerunning
(which I could some days ago)
> Add state management for resources
> --
>
> Key: SLING-1737
> URL: https://issues.apache.org/jira/browse/SLING-1737
> Project: Sling
> Issue Type: Improvement
> Components: Installer
>Affects Versions: OSGi Installer 3.0.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: OSGi Installer 3.0.0
>
>
> Currently there is no state management, so it is hard to tell if a resource
> has been installed, should be installed, uninstalled etc.
> In some situations this leads to endless loops where something is tried over
> and over again - although nothing needs to be done anymore or can't be done.
> If we add proper state management to the resources, the installer knows what
> needs to be done and can act accordingly
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908811#action_12908811 ] Carsten Ziegeler commented on SLING-1737: - Finished the state handling implementation with revision 996562. The tasks are now computed by the state of the resources to be installed/uninstalled and the current state of the system. This avoids reinstallation of resources or accidental uninstall etc. > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908807#action_12908807 ] Justin Edelson commented on SLING-1737: --- FWIW, I'm now getting 19 failures: Failed tests: testRemoveResourceAndRestart [felix](org.apache.sling.osgi.installer.it.RemovedResourceDetectionTest) testContextUpdate [felix](org.apache.sling.osgi.installer.it.ContextBundleUpdateTest) initialRegistrationTest [felix](org.apache.sling.osgi.installer.it.RegisterResourcesTest) removeAndReaddBundlesTest [felix](org.apache.sling.osgi.installer.it.RegisterResourcesTest) reAddZeroResourcesTest [felix](org.apache.sling.osgi.installer.it.RegisterResourcesTest) testSemiRandomInstall [felix](org.apache.sling.osgi.installer.it.BundleInstallStressTest) testPrioritiesUsingSnapshots [felix](org.apache.sling.osgi.installer.it.BundlePrioritiesTest) testInstallUpgradeDowngradeBundle [felix](org.apache.sling.osgi.installer.it.BundleInstallUpgradeDowngradeTest) testRemoveAndReadd [felix](org.apache.sling.osgi.installer.it.BundleInstallUpgradeDowngradeTest) testBundleDependencies [felix](org.apache.sling.osgi.installer.it.BundleDependenciesTest) testInstallAndRemoveConfig [felix](org.apache.sling.osgi.installer.it.ConfigInstallTest) testDeferredConfigInstall [felix](org.apache.sling.osgi.installer.it.ConfigInstallTest) testReinstallSameConfig [felix](org.apache.sling.osgi.installer.it.ConfigInstallTest) testNonSnapshot [felix](org.apache.sling.osgi.installer.it.BundleSnapshotUpdateTest) testSnapshot [felix](org.apache.sling.osgi.installer.it.BundleSnapshotUpdateTest) testSnapshotWithInstallerRestart [felix](org.apache.sling.osgi.installer.it.BundleSnapshotUpdateTest) testRegisterInvalidBundles [felix](org.apache.sling.osgi.installer.it.InvalidBundlesTest) testIndividualInvalidBundles [felix](org.apache.sling.osgi.installer.it.InvalidBundlesTest) testBundleStatePreserved [felix](org.apache.sling.osgi.installer.it.BundleStatePreservedTest) with both Maven 2.2.1 and 3.0-beta-3 on OS X > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908805#action_12908805 ] Pontus Amberg commented on SLING-1737: -- Strange. For me it's impossible to pass the testSemiRandomInstall. The surefire log contains the following info testSemiRandomInstall [felix](org.apache.sling.osgi.installer.it.BundleInstallStressTest) Time elapsed: 40.201 sec <<< FAILURE! java.lang.AssertionError: All bundles should be installed in cycle 5 : Expected events=[ BundleEvent null, version=null, state=16 BundleEvent null, version=null, state=1 ] received events=[ BundleEvent osgi-installer-testA, version=1.0.0, state=1 BundleEvent osgi-installer-testA, version=1.0.0, state=32 BundleEvent osgi-installer-testA, version=1.0.0, state=128 BundleEvent osgi-installer-testA, version=1.0.0, state=2 ] > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908734#action_12908734 ] Carsten Ziegeler commented on SLING-1737: - No, with all the latest changes this one is passing fine on my machine - but very rarely the testBundleStatePreserved test (org.apache.sling.osgi.installer.it.BundleStatePreservedTest) fails now for me > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908730#action_12908730 ] Pontus Amberg commented on SLING-1737: -- Is the randomly failing test testSemiRandomInstall in org.apache.sling.osgi.installer.it.BundleInstallStressTest? > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908477#action_12908477 ] Carsten Ziegeler commented on SLING-1737: - Further code cleanup and refactoring. Don't create a configuration object if it is not needed! Revision: 996322 > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908471#action_12908471 ] Carsten Ziegeler commented on SLING-1737: - Started further refactoring of internal data objects in revision 996317 The EntityResourceList object will get whole state logic for a single entity, this keeps state handling in a single central place (WIP) > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908437#action_12908437 ] Carsten Ziegeler commented on SLING-1737: - Updated the configuration state handling and bundle state handling in revisoin 996285 > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1737) Add state management for resources
[ https://issues.apache.org/jira/browse/SLING-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907924#action_12907924 ] Carsten Ziegeler commented on SLING-1737: - Revision 995689 : Added a first implementation which uses various states - everything except the random stress it test seems to work again > Add state management for resources > -- > > Key: SLING-1737 > URL: https://issues.apache.org/jira/browse/SLING-1737 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: OSGi Installer 3.0.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: OSGi Installer 3.0.0 > > > Currently there is no state management, so it is hard to tell if a resource > has been installed, should be installed, uninstalled etc. > In some situations this leads to endless loops where something is tried over > and over again - although nothing needs to be done anymore or can't be done. > If we add proper state management to the resources, the installer knows what > needs to be done and can act accordingly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
