[GitHub] storm issue #2026: Eventhub3

2017-04-04 Thread harshach
Github user harshach commented on the issue:

https://github.com/apache/storm/pull/2026
  
@rban1 can you change the PR title to reflect the JIRA title. You can look 
other PRs for example


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2026: Eventhub3

2017-03-30 Thread SreeramGarlapati
Github user SreeramGarlapati commented on the issue:

https://github.com/apache/storm/pull/2026
  
:shipit:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2026: Eventhub3

2017-03-29 Thread rban1
Github user rban1 commented on the issue:

https://github.com/apache/storm/pull/2026
  
@SreeramGarlapati  Made all the relavant changes(Serialization, exception 
handling, enqueuetimefilter)
@harshach I will be using this PR going forward. I have addressed your 
comments on syntax as well. On your comment of backporting the changes to 1.x 
branches it cannot be done as the latest eventhubclient is valid only from java 
8 environment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2026: Eventhub3

2017-03-28 Thread harshach
Github user harshach commented on the issue:

https://github.com/apache/storm/pull/2026
  
@rban1 you are keep re-opening the PRs. We should keep only one PR. If you 
want to address the comments and update the PR , all you need to do is to work 
on the same git branch and push changes into the same branch that will update 
the PR you opened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---