Re: [S2] [VOTE] Struts 2.0.8 Quality
2007/6/7, Rainer Hermanns [EMAIL PROTECTED]: Wendy, thanks for reminding me,... Just called the vote :) Ok, I change my vote to +1 to GA (non binding), since the call for struts-annotations vote has been done. Sorry for any incovenience this may cause :-) Antonio - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tiles 2
2007/6/10, Paul Benedict [EMAIL PROTECTED]: * The TLP address exists but it is not listed on Apache home page Thanks Paul, but how can it be corrected? Is there a repository for Apache home page? * http://struts.apache.org/struts-sandbox/tiles/ is what I find in a google search for Tiles 2. This appears to be the old site, right? Right! I think it should be deleted. +1 Perhaps a redirect should be in place too? That would be nice. I moved some links in the SVN repo, but the site has not been published yet. Thanks again Antonio
Re: [VOTE] Release Struts Annotations 1.0.2
Here is my +1 for GA. -Rainer Struts Annotations 1.0.2 has been tagged and is available for testing in the following Maven repository: http://people.apache.org/builds/struts/struts-annotations-1.0.2/m2- staging-repository/ To test this build, temporarily add a repository to pom.xml or settings.xml. The the struts-annotations dependency version number in the Struts2 on branch STRUTS_2_0_X has already been altered to 1.0.2. repository idstruts-annotations-102-staging/id nameStruts Annotations 1.0.2 Staging Repository/name urlhttp://people.apache.org/builds/struts/struts-annotations-1.0.2/ m2-staging-repository//url /repository This is a build-time dependency for Struts 2, and there is no distribution assembly, though source and javadoc jars are available in the Maven repo. Once you have had a chance to test this build, please vote on whether to release it to the central Maven repository. -Rainer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Rainer Hermanns aixcept Neupforte 16 52062 Aachen - Germany w: http://aixcept.de/ t:+49-241-4012247 m: +49-170-3432912 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] [VOTE] Struts 2.0.8 Quality
[ ] Leave at test build [ ] Alpha [ ] Beta [X] General Availability (GA) I am using this build in 2 inhouse projects without problems. So I think it's time for going GA as well. cheers, Rainer -- Rainer Hermanns aixcept Neupforte 16 52062 Aachen - Germany w: http://aixcept.de/ t:+49-241-4012247 m: +49-170-3432912 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[VOTE RESULT] Release Struts Annotations 1.0.2
Here are the results of the vote for going GA with the Struts Annotations release 1.0.2 Binding: +1 Don Brown (binding) +1 Rene Gielen (binding) +1 Rainer Hermanns (binding) +0 Ian Roughley (binding) Non Binding: +1 Musachy Barroso +1 Antonio Petrelli I'll post an announcement as soon as the files are available. Thanks, Rainer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[VOTE RESULT] Struts 2.0.8 Quality
Here are the results of the vote: +1 GA Ian Roughley (binding), Don Brown (binding), James Mitchell (binding), Rene Gielen (binding), Rainer Hermanns (binding) +1 GA Pedro Herrera (non binding), Matt Raible (non binding), Antonio Petrelli (non binding) Thanks for your votes, I'll post the announcement, when the release files are copied over and available. Rainer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
name inconsistency
This is a really minor thing, but it gets me all the time, the set tag uses the name attribute for the variable name, while the url, and bean tags use id, anybody against deprecating the name attribute in set and using id instead? regards musachy -- Hey you! Would you help me to carry the stone? Pink Floyd
Re: Portlet plugin
I have finally been able to extract the portlet code into a plugin, but it required some shortcuts due to couplings between the Components (URL, Form and it's super classes) and generating the URLs. But at least all tests pass, and there are no more dependencies to the portlet API in the core. I have attached the files as patches to the JIRA ticket (https://issues.apache.org/struts/browse/WW-1645), since it needs a review and probably some discussion. Nils-H On 4/11/07, Nils-Helge Garli [EMAIL PROTECTED] wrote: I have started the process of moving the portlet code to a plugin. But any further progress requires the url building abstraction discussed earlier. What is the status for this code? Also, I think the code in general would benefit from a common abstraction of the servlet- and portlet types (request, response, context etc). It would most certainly reduce the amount of almost duplicated code needed to operate Struts in a portlet. Nils-H On 3/26/07, Ted Husted [EMAIL PROTECTED] wrote: The trunk is the correct place (we branched for 2.0.x). On 3/25/07, Nils-Helge Garli [EMAIL PROTECTED] wrote: Hi! I want to start looking into moving the portlet support to a plugin, but need a little guidance to get started. - What is the status of refactoring the URL-building, as discussed in previous mail threads? - From what I understand, a hook for injecting a URL builder implementation from the plugin must be provided. How is that achieved? - Is trunk the correct place to work on, or will a 2.1.x branch be created? Nils-H - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Need help with 1.3.9
On 6/6/07, Henri Yandell [EMAIL PROTECTED] wrote: On 5/3/07, Paul Benedict [EMAIL PROTECTED] wrote: My hands are full with two jobs at the moment. I can roll the 1.3.9 release because Maven is easy, but I'd like someone to help out with these pre-tasks, if anyone is available: * Checkin release notes for 1.3.9 * Correct any site errors (http://www.nabble.com/struts-1.x-website-needs-fixing-badly-tf3648645.html) * Test the webapps They're not building for me: cd apps mvn install [INFO] Skipping missing optional mojo: org.apache.maven.plugins:maven-site-plugin:attach-descriptor [INFO] [ERROR] BUILD ERROR [INFO] [INFO] The plugin 'org.codehaus.cargo:cargo-maven2-plugin' does not exist or no valid version could be found I've gone ahead and added a version (Paul pointed this out on IM). Builds for me now, so time to walk through the apps. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: name inconsistency
From a S2 user perspective the consistency would be appreciated (understanding I'd likely have to do a search and replace in my JSPs sooner or later). - Original Message From: Musachy Barroso [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Sent: Monday, June 11, 2007 12:21:03 PM Subject: name inconsistency This is a really minor thing, but it gets me all the time, the set tag uses the name attribute for the variable name, while the url, and bean tags use id, anybody against deprecating the name attribute in set and using id instead? regards musachy -- Hey you! Would you help me to carry the stone? Pink Floyd
Re: name inconsistency
Thanks for the feedback. I logged: https://issues.apache.org/struts/browse/WW-1981 if nobody is against it I will deprecate name and start using id instead. musachy On 6/11/07, Jon Wilmoth [EMAIL PROTECTED] wrote: From a S2 user perspective the consistency would be appreciated (understanding I'd likely have to do a search and replace in my JSPs sooner or later). - Original Message From: Musachy Barroso [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Sent: Monday, June 11, 2007 12:21:03 PM Subject: name inconsistency This is a really minor thing, but it gets me all the time, the set tag uses the name attribute for the variable name, while the url, and bean tags use id, anybody against deprecating the name attribute in set and using id instead? regards musachy -- Hey you! Would you help me to carry the stone? Pink Floyd -- Hey you! Would you help me to carry the stone? Pink Floyd
Re: name inconsistency
+1 I still have to look up S1 tag syntax; I'd hate to have to play that game w/ S2 :) --- Jon Wilmoth [EMAIL PROTECTED] wrote: From a S2 user perspective the consistency would be appreciated (understanding I'd likely have to do a search and replace in my JSPs sooner or later). - Original Message From: Musachy Barroso [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Sent: Monday, June 11, 2007 12:21:03 PM Subject: name inconsistency This is a really minor thing, but it gets me all the time, the set tag uses the name attribute for the variable name, while the url, and bean tags use id, anybody against deprecating the name attribute in set and using id instead? regards musachy -- Hey you! Would you help me to carry the stone? Pink Floyd Boardwalk for $500? In 2007? Ha! Play Monopoly Here and Now (it's updated for today's economy) at Yahoo! Games. http://get.games.yahoo.com/proddesc?gamekey=monopolyherenow - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Need help with 1.3.9
On 5/3/07, Paul Benedict [EMAIL PROTECTED] wrote:
* Test the webapps
Blank: GOOD.
Cookbook: GOOD.
EL-Examples:
html-el:multibox. When first started, none of the checkboxes were
selected. Also, the '50' on the right hand side is not selectable due
to the 'disabled=${!empty pageScope}'. Bit of a confusing example to
have that sneaking in there; any idea why that bit is used? 'empty
pageScope'? The same thing appears all over.
html-el:string. The bottom two on the left hand side don't change
the backing bean when save is hit. Possibly they just shouldn't be
enabled as the two on the bottom right have the same behaviour.
Struts-Faces-Example1: GOOD.
Struts-Faces-Example2: GOOD.
Struts-Mailreader: GOOD.
Struts-Scripting-Mailreader: GOOD.
Hen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Need help with 1.3.9
On 6/11/07, Henri Yandell [EMAIL PROTECTED] wrote: On 5/3/07, Paul Benedict [EMAIL PROTECTED] wrote: * Test the webapps EL-Examples: Digging more into the major issues: html-el:multibox. When first started, none of the checkboxes were selected. Looks to me like the text is plain wrong. The underlying testBean doesn't fill the multiboxes with any data, so presumably the text should say should NOT be selected. I've made that change (easy to change back :) - r546298). html-el:string. The bottom two on the left hand side don't change the backing bean when save is hit. Possibly they just shouldn't be enabled as the two on the bottom right have the same behaviour. Presumably the problem here is that there are three fields with the same name, and (for my browser/server combination) the first field is the one that wins. I'm going to go ahead and add the disabled to the two bottom left field (r546294). Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tiles 2
The main website has been updated. I am +1 with the redirect -- a permanent one too. Paul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Portlet plugin
Nils, This is a great start. I had wanted to do this myself, but I never found the time. I only took a brief look at the patch, but a few things jumped out at me: 1. I'm not sure the UrlRendererFactory is needed. I believe the whole purpose of guice is to not have anymore factories anymore, so guice should just inject the necessary UrlRenderer. (especially if they are stateless) 2. As a first step in separating out the url building logic I like how you have the form url building seperate from the typical url building. I tried to combine these and couldn't find a clean way to resolve the differences. HTH, Tom I have finally been able to extract the portlet code into a plugin, but it required some shortcuts due to couplings between the Components (URL, Form and it's super classes) and generating the URLs. But at least all tests pass, and there are no more dependencies to the portlet API in the core. I have attached the files as patches to the JIRA ticket (https://issues.apache.org/struts/browse/WW-1645), since it needs a review and probably some discussion. Nils-H On 4/11/07, Nils-Helge Garli [EMAIL PROTECTED] wrote: I have started the process of moving the portlet code to a plugin. But any further progress requires the url building abstraction discussed earlier. What is the status for this code? Also, I think the code in general would benefit from a common abstraction of the servlet- and portlet types (request, response, context etc). It would most certainly reduce the amount of almost duplicated code needed to operate Struts in a portlet. Nils-H On 3/26/07, Ted Husted [EMAIL PROTECTED] wrote: The trunk is the correct place (we branched for 2.0.x). On 3/25/07, Nils-Helge Garli [EMAIL PROTECTED] wrote: Hi! I want to start looking into moving the portlet support to a plugin, but need a little guidance to get started. - What is the status of refactoring the URL-building, as discussed in previous mail threads? - From what I understand, a hook for injecting a URL builder implementation from the plugin must be provided. How is that achieved? - Is trunk the correct place to work on, or will a 2.1.x branch be created? Nils-H - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Portlet plugin
Thanks for the feedback! On 6/12/07, Tom Schneider [EMAIL PROTECTED] wrote: 1. I'm not sure the UrlRendererFactory is needed. I believe the whole purpose of guice is to not have anymore factories anymore, so guice should just inject the necessary UrlRenderer. (especially if they are stateless) Ahof course... I just saw some other factories when trying to figure out how the injection works, and assumed wrong. I'll remove them. 2. As a first step in separating out the url building logic I like how you have the form url building seperate from the typical url building. I tried to combine these and couldn't find a clean way to resolve the differences. HTH, Tom Yeah, I couldn't find a way to combine them either. So I think separating them, for now, is the easiest route to go. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
