Re: [S2] - FilterDispatcher and ActionContextCleanup (WW-2240 FileUploadInterceptor causes null pointer exception)
Since we're getting close to a 2.1.1 release, I thought I should bring
this one up again. I'm still not sure what to do about this issue. I
committed a patch that is a temp work around, but the real issue has
not been resolved.
https://issues.apache.org/struts/browse/WW-2240
Nils-H
On Jan 23, 2008 5:43 PM, Nils-Helge Garli Hegvik <[EMAIL PROTECTED]> wrote:
> I would really like a second opinion on this issue. Please let me know
> if something I wrote was unclear.
>
> Nils-H
>
>
> On Jan 20, 2008 1:03 PM, Nils-Helge Garli Hegvik <[EMAIL PROTECTED]> wrote:
> > Hi!
> >
> > I've been debugging WW-2240 (had to install WebLogic 10 to reproduce
> > it) and have seen some strange behavior (at least I think so) in
> > the ActionContext initialization and cleanup performed by the
> > FilterDispatcher. The problem is that the cleanup of the ActionContext
> > (ActionContext.setContext(null)) happens before the
> > FileUploadInterceptor is finished executing, so when a log statement
> > in the interceptor tries to access a value in the ActionContext, it
> > fails with an NPE. I think I've traced it down to this:
> >
> > In the FilterDispatcher a call to ActionContextCleanUp.cleanUp(req) is
> > invoked in the finally block. In ActionContextCleanup.cleanUp, the
> > request is checked for a COUNT request attribute to see if the context
> > should be cleaned up. And in this case, this attribute is always null,
> > since it's only set and incremented in ActionContextCleanUp.doFilter
> > (which in this case is not configured in web.xml). So it seems strange
> > to me that the FilterDispatcher tries to clean up the context when it
> > apparently does not keep track of if it should be cleaned or not
> > ("nested" invocation)?
> >
> > Is this an actual bug, or am I just overlooking something?
> >
> > I could only reproduce this in WebLogic 10. So it's apparently
> > container dependent how this is handled.
> >
> > Nils-H
> >
>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Let's get out Struts 2.1.1
Oh, I know how to release Struts; I was referring to the XWork release. IIRC, this will be the first release with the Maven 2 build, so we'll see how it goes... Don On 2/20/08, Wendy Smoak <[EMAIL PROTECTED]> wrote: > On Feb 19, 2008 6:01 AM, Don Brown <[EMAIL PROTECTED]> wrote: > > Are there any special instructions or is it a simple 'mvn > > release:prepare release:perform'? > > Antonio linked to this earlier: > http://cwiki.apache.org/confluence/display/WW/Creating+and+Signing+a+Struts+2.1.x+Distribution > > -- > Wendy > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Let's get out Struts 2.1.1
I think you should release the convention plugin at all costs - but this is just a vote from an user. piero Am Montag, 18. Februar 2008 18:16:52 schrieb Brian Pontarelli: > Don Brown wrote: > > I've cleared all but a couple issues out of Struts 2.1.1, so I think > > we are ready for a release. The only kinda blocking issue is the > > portlet tests failing, but that seems to have something to do with the > > setup, not our portlet code, so we could even punt that one. > > > > Any objections to rolling a release(*) in the next day or so? > > Shall we queue up the convention plugin addition and deprecation of the > smarturls and code-behind plugins for next release than? > > -bp > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Let's get out Struts 2.1.1
On Feb 19, 2008 6:01 AM, Don Brown <[EMAIL PROTECTED]> wrote: > Are there any special instructions or is it a simple 'mvn > release:prepare release:perform'? Antonio linked to this earlier: http://cwiki.apache.org/confluence/display/WW/Creating+and+Signing+a+Struts+2.1.x+Distribution -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [s2] Let's get out Struts 2.1.1
Are there any special instructions or is it a simple 'mvn
release:prepare release:perform'?
Don
On 2/18/08, Rainer Hermanns <[EMAIL PROTECTED]> wrote:
> Don,
>
> great work, thanks for your help...
> I'm really busy during the week so that I can not release before
> friday evening (GMT+2), 23rd. If this will still meet you timeline I can
> do the release otherwise either you or Pat could roll the release.
>
> If you need any help, I'm available via IM.
>
> cheers,
> Rainer
>
> > Ok, here are the release notes so far:
> > http://cwiki.apache.org/confluence/display/WW/Version+Notes+2.1.1
> >
> > I'm planning on a date of Feb 24 Australia time so Feb 23 for the US.
> > I've closed out all but one ticket in XWork 2.1.1, which I may bump as
> > well.
> >
> > Rainer, any chance on getting an XWork 2.1.1 release out? If you are
> > busy, I can stumble through that release as well.
> >
> > Don
> >
> > On 2/17/08, Don Brown <[EMAIL PROTECTED]> wrote:
> >> I've cleared all but a couple issues out of Struts 2.1.1, so I think
> >> we are ready for a release. The only kinda blocking issue is the
> >> portlet tests failing, but that seems to have something to do with the
> >> setup, not our portlet code, so we could even punt that one.
> >>
> >> Any objections to rolling a release(*) in the next day or so?
> >>
> >> Don
> >>
> >> {*} build, test build, or whatever we are calling it this week :)
> >>
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
>
> --
> Rainer Hermanns
> aixcept
> Mariahilfstrasse 9
> 52062 Aachen - Germany
> w: http://aixcept.de/
> t: +49-241-4012247
> m: +49-170-3432912
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
