[GitHub] jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2

2018-03-26 Thread GitBox
jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2
URL: 
https://github.com/apache/incubator-superset/pull/4299#issuecomment-376216211
 
 
   @xrmx Yup. I just opened one 
[here](https://github.com/LocusEnergy/sqlalchemy-vertica-python/issues/12), 
since it is dependent on which Vertica dialect you are using, and that is the 
one recommended in the docs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2

2018-03-26 Thread GitBox
jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2
URL: 
https://github.com/apache/incubator-superset/pull/4299#issuecomment-376216211
 
 
   @xrmx Yeah I opened one 
[here](https://github.com/LocusEnergy/sqlalchemy-vertica-python/issues/12), 
since it is dependent on which Vertica dialect you are using, and that is the 
one recommended in the docs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2

2018-03-23 Thread GitBox
jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2
URL: 
https://github.com/apache/incubator-superset/pull/4299#issuecomment-375812162
 
 
   We're also having issues with the version bump related to the addition of 
the `get_table_comment` method as described 
[here](http://docs.sqlalchemy.org/en/latest/core/reflection.html#sqlalchemy.engine.reflection.Inspector.get_table_comment),
 as some postgresql-specific 
[logic](https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/dialects/postgresql/base.py#L3004)
 is being inherited by other db engines.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services