[jira] [Closed] (THRIFT-3863) Can't "make install" Lua Library
[ https://issues.apache.org/jira/browse/THRIFT-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3863. Resolution: Fixed Fix Version/s: 0.12.0 > Can't "make install" Lua Library > > > Key: THRIFT-3863 > URL: https://issues.apache.org/jira/browse/THRIFT-3863 > Project: Thrift > Issue Type: Bug > Components: Lua - Library >Affects Versions: 0.9.3, 0.10.0 > Environment: OS X 10.11.3, ubuntu-artful docker image >Reporter: Hel Soule >Assignee: James E. King III >Priority: Minor > Fix For: 0.12.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > I'm coming to Apache Thrift with a background in mobile development and Torch > CNNs so I apologize beforehand if this is a dumb question but I cannot build > the Lua library. > In /lib/lua, when I try > sudo make install > I get the following error that > /usr/bin/ld: cannot find -llualongnumber > I know that this error is because LD cannot find a .a or .so files, and I > know that we are generating .la files in the makefile so I am confused about > how to resolve this linkage issue. Any help would be appreciated. Thank you! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4647) Node.js Fileserver webroot path
[ https://issues.apache.org/jira/browse/THRIFT-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639206#comment-16639206 ] Jake Farrell commented on THRIFT-4647: -- PR: https://github.com/apache/thrift/pull/1606 > Node.js Fileserver webroot path > > > Key: THRIFT-4647 > URL: https://issues.apache.org/jira/browse/THRIFT-4647 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library >Reporter: Jake Farrell >Assignee: Jake Farrell >Priority: Critical > Fix For: 0.12.0 > > > Node.js fileserver allows for escaping the set file path -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (THRIFT-4647) Node.js Fileserver webroot path
Jake Farrell created THRIFT-4647: Summary: Node.js Fileserver webroot path Key: THRIFT-4647 URL: https://issues.apache.org/jira/browse/THRIFT-4647 Project: Thrift Issue Type: Bug Components: Node.js - Library Reporter: Jake Farrell Assignee: Jake Farrell Fix For: 0.12.0 Node.js fileserver allows for escaping the set file path -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-4569) Typo in field requiredness section of IDL docs
[ https://issues.apache.org/jira/browse/THRIFT-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4569. Resolution: Fixed > Typo in field requiredness section of IDL docs > -- > > Key: THRIFT-4569 > URL: https://issues.apache.org/jira/browse/THRIFT-4569 > Project: Thrift > Issue Type: Documentation > Components: Documentation >Reporter: Chad Knight >Priority: Trivial > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (THRIFT-4569) Typo in field requiredness section of IDL docs
[ https://issues.apache.org/jira/browse/THRIFT-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-4569: - Fix Version/s: 0.12.0 > Typo in field requiredness section of IDL docs > -- > > Key: THRIFT-4569 > URL: https://issues.apache.org/jira/browse/THRIFT-4569 > Project: Thrift > Issue Type: Documentation > Components: Documentation >Reporter: Chad Knight >Priority: Trivial > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-4413) Publish a Maven artifact for Thrift v0.11
[ https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4413. Resolution: Fixed > Publish a Maven artifact for Thrift v0.11 > - > > Key: THRIFT-4413 > URL: https://issues.apache.org/jira/browse/THRIFT-4413 > Project: Thrift > Issue Type: Task > Components: Java - Library >Affects Versions: 0.11.0 >Reporter: Buğra Gedik >Assignee: Jake Farrell >Priority: Major > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4413) Publish a Maven artifact for Thrift v0.11
[ https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326574#comment-16326574 ] Jake Farrell commented on THRIFT-4413: -- Signed and published by hand to unblock this issue. Tested downloading jar at [1] and looked at repository.apache.org index and it contained the jar, sources, javadoc, and test artifacts. Will look back into fixing THRIFT-3983 and automating this for 0.12.0 so that there is no delay after release. Apologize for any inconveniences post 0.11.0 this caused. Can take up to 24h for maven central to mirror [3] and pick up the promoted artifacts, closing this issue [1]: [https://repository.apache.org/service/local/repositories/releases/content/org/apache/thrift/libthrift/0.11.0/libthrift-0.11.0.jar] [2]: [https://repository.apache.org/index.html#view-repositories;releases~browsestorage~/org/apache/thrift/libthrift/0.11.0/libthrift-0.11.0.pom] [3]: https://search.maven.org/#search%7Cga%7C1%7Ca%3A%22libthrift%22 > Publish a Maven artifact for Thrift v0.11 > - > > Key: THRIFT-4413 > URL: https://issues.apache.org/jira/browse/THRIFT-4413 > Project: Thrift > Issue Type: Task > Components: Java - Library >Affects Versions: 0.11.0 >Reporter: Buğra Gedik >Assignee: Jake Farrell >Priority: Major > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-4425) Publish Thrift v0.11 to packagist.org
[ https://issues.apache.org/jira/browse/THRIFT-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4425. Resolution: Fixed > Publish Thrift v0.11 to packagist.org > - > > Key: THRIFT-4425 > URL: https://issues.apache.org/jira/browse/THRIFT-4425 > Project: Thrift > Issue Type: Task > Components: PHP - Library >Reporter: Robert Lu >Assignee: Jake Farrell >Priority: Major > Fix For: 0.11.0 > > > Please release 0.11.0 to [https://packagist.org/packages/apache/thrift] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4119) bootstrap.sh is missing from the source tarball
[ https://issues.apache.org/jira/browse/THRIFT-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292552#comment-16292552 ] Jake Farrell commented on THRIFT-4119: -- bootstrap.sh missing from the source release is intended behavior. If you need it then you should pull from the github source release branch, when we cut a new release we do not backport fixes and those branches contain what you need. Moving forward the plan is to remove bootstrap.sh completely and transition to using cmake as the only build mechanism along with doing a git archive for source releases instead of how we pick and choose files today. For the release directories all non source binaries are kept at bintray and the links you pointed out are http redirects to the ASF bintray account. As we automate the release process we will make it easier to package and distribute these artifacts so they can be available faster as today it all is a by hand process > bootstrap.sh is missing from the source tarball > --- > > Key: THRIFT-4119 > URL: https://issues.apache.org/jira/browse/THRIFT-4119 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.10.0, 0.11.0 >Reporter: Christopher Tubbs >Assignee: Jens Geyer >Priority: Critical > Labels: autoconf, packaging > Fix For: 0.12.0 > > > The bootstrap.sh file is missing from the source tarball. This makes building > from source difficult. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-3351) Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org)
[ https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163718#comment-16163718 ] Jake Farrell commented on THRIFT-3351: -- [~markerickson-wk] Does publishing to dart still require a gmail address or can we use our @apache.org email addresses for artifact publishing? > Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org) > - > > Key: THRIFT-3351 > URL: https://issues.apache.org/jira/browse/THRIFT-3351 > Project: Thrift > Issue Type: Story > Components: Dart - Library >Reporter: Evan Weible >Assignee: Jake Farrell > > The thrift library for Dart has been released in 0.10.0 > In order for developers to actually make use of the library, the Dart package > needs to be published to https://pub.dartlang.org. The current workaround is > to create a new GitHub repo with a copy of the Dart thrift library, and > reference that in consuming Dart code via a Git reference, which is not ideal. > This may become a little better with Dart 1.25.0 (not released yet), which > [adds the > ability|https://github.com/dart-lang/sdk/blob/1.25.0-dev.16.3/CHANGELOG.md#tool-changes] > to reference a library in a subdirectory via git. But it would still be > better to explicitly publish releases for Dart to pub.dartlang.org. > More information here: > - https://www.dartlang.org/tools/pub/publishing > - https://www.dartlang.org/tools/pub/cmd/pub-lish.html > Since we're creating the Dart bindings for Thrift, we are also more than > willing to publish them to Pub - but we wanted to give the apache thrift team > the opportunity to handle this process. Ownership of the publishing process > can be shared by adding multiple email addresses to the uploader list, and > the uploader list can be updated at any time. It does require a Google email > address (gmail or Google Apps) to perform the upload. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (THRIFT-4146) Appveyor builds are being triggered by apache master pushes
[ https://issues.apache.org/jira/browse/THRIFT-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4146. Resolution: Fixed Fix Version/s: 0.11.0 Updated config to run all except branch master > Appveyor builds are being triggered by apache master pushes > --- > > Key: THRIFT-4146 > URL: https://issues.apache.org/jira/browse/THRIFT-4146 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.10.0 > Environment: Appveyor >Reporter: James E. King, III >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.11.0 > > > When I commit and push something into the apache git repository for thrift, > it synchronizes to github and that seems to add an Appveyor job to build it. > Appveyor auto-build triggering needs to be configured to ignore updates to > "master". > This is an example: > https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1121 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4102) TBufferedTransport performance issue since 0.10.0
[
https://issues.apache.org/jira/browse/THRIFT-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935143#comment-15935143
]
Jake Farrell commented on THRIFT-4102:
--
ack, can start pulling together an RC within the next week, typical hold ups
are if I hit any blockers on tests/missing files during creation or any last
minute patches that extend test cycles
> TBufferedTransport performance issue since 0.10.0
> -
>
> Key: THRIFT-4102
> URL: https://issues.apache.org/jira/browse/THRIFT-4102
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Jin Yao
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> I upgrade thrift from 0.9.3 to 0.10.0, and our rpc calls slow down.
> I digged around the code, and find maybe it caused by the write function in
> TBufferedTransport.
> The last line seems useless, but cost time.
> {code:title=TTransport.py|borderStyle=solid}
> def write(self, buf):
> try:
> self.__wbuf.write(buf)
> except Exception as e:
> # on exception reset wbuf so it doesn't contain a partial
> function call
> self.__wbuf = BufferIO()
> raise e
> self.__wbuf.getvalue() # it seems useless, but cost time
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-4064) Update node library dependencies
[ https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848744#comment-15848744 ] Jake Farrell commented on THRIFT-4064: -- We typically try and stay with the latest versions available that comes with support in the current common latest LTS, which have nodejs versions of ubuntu:16.04 - v4.2.6 centos:7 - v6.9.1 debian:8 - v0.10.29 would probably go with ws@2.x.x since 2/3 OS versions are defaulting node 4+, will have to update the Dockerfile for debian to install a newer version so tests continue to pass > Update node library dependencies > > > Key: THRIFT-4064 > URL: https://issues.apache.org/jira/browse/THRIFT-4064 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.10.0 >Reporter: Andres Suarez > > ws@0.4.32 is really old and presents issues for users using modern versions > of Node (see > https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should > be updated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4032) no libthrift 0.10.0 in https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
[
https://issues.apache.org/jira/browse/THRIFT-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848569#comment-15848569
]
Jake Farrell commented on THRIFT-4032:
--
0.10.0 now has jar, sources, and javadoc on repository.apache.org. This should
get mirrored over to Maven Central in the next 24 hours
https://repository.apache.org/#nexus-search;quick~org.apache.thrift
> no libthrift 0.10.0 in
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> --
>
> Key: THRIFT-4032
> URL: https://issues.apache.org/jira/browse/THRIFT-4032
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Xiaoshuang LU
>Assignee: Jake Farrell
> Fix For: 0.10.0
>
>
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> {code}
> Index of /maven2/org/apache/thrift/libthrift/
> ../
> 0.6.1/ 2011-04-25 08:54
> -
> 0.7.0/ 2011-08-13 17:27
> -
> 0.8.0/ 2011-11-29 18:34
> -
> 0.9.0/ 2012-10-15 21:50
> -
> 0.9.1/ 2013-08-23 10:26
> -
> 0.9.2/ 2014-11-18 12:19
> -
> 0.9.3/ 2015-10-11 21:19
> -
> maven-metadata.xml 2015-10-11 21:19
>519
> maven-metadata.xml.md5 2015-10-11 21:19
> 32
> maven-metadata.xml.sha12015-10-11 21:19
> 40
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central
[ https://issues.apache.org/jira/browse/THRIFT-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4063. Resolution: Fixed 0.10.0 now has jar, sources, and javadoc on repository.apache.org. This should get mirrored over to Maven Central in the next 24 hours https://repository.apache.org/#nexus-search;quick~org.apache.thrift > Sources for libthrift 0.10.0 are missing from Maven Central > --- > > Key: THRIFT-4063 > URL: https://issues.apache.org/jira/browse/THRIFT-4063 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.10.0 >Reporter: Zac Bentley >Assignee: Jake Farrell >Priority: Minor > > The other versions of libthrift have source JARs on Maven Central; 0.10.0 > does not. > Could sources be published? > Alternatively, is there some way to wire up the Git repository as a source > JAR, using e.g. jitpack.io's maven dependency-from-git-repo converter? > Tentatively classifying this as a bug, since it seems inconsistent with all > the other releases on Central. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4032) no libthrift 0.10.0 in https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
[
https://issues.apache.org/jira/browse/THRIFT-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848526#comment-15848526
]
Jake Farrell commented on THRIFT-4032:
--
sources should not be required to mirror jars over to maven central, the
thrift-maven-plugin was mirrored over successfully [1] and it does not contain
a sources jar, looking into this
[1]:
https://search.maven.org/#artifactdetails%7Corg.apache.thrift%7Cthrift-maven-plugin%7C0.10.0%7Cmaven-plugin
> no libthrift 0.10.0 in
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> --
>
> Key: THRIFT-4032
> URL: https://issues.apache.org/jira/browse/THRIFT-4032
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Xiaoshuang LU
>Assignee: Jake Farrell
> Fix For: 0.10.0
>
>
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> {code}
> Index of /maven2/org/apache/thrift/libthrift/
> ../
> 0.6.1/ 2011-04-25 08:54
> -
> 0.7.0/ 2011-08-13 17:27
> -
> 0.8.0/ 2011-11-29 18:34
> -
> 0.9.0/ 2012-10-15 21:50
> -
> 0.9.1/ 2013-08-23 10:26
> -
> 0.9.2/ 2014-11-18 12:19
> -
> 0.9.3/ 2015-10-11 21:19
> -
> maven-metadata.xml 2015-10-11 21:19
>519
> maven-metadata.xml.md5 2015-10-11 21:19
> 32
> maven-metadata.xml.sha12015-10-11 21:19
> 40
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-2504) TMultiplexedProcessor should allow registering default processor called if no service name is present
[ https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831159#comment-15831159 ] Jake Farrell commented on THRIFT-2504: -- mockito is MIT licensed so no issues, just needs to be given attribution in our LICENSE file at the bottom, there are examples there that can be used as a reference or ping me on IRC and i'll walk you through whats needed > TMultiplexedProcessor should allow registering default processor called if no > service name is present > - > > Key: THRIFT-2504 > URL: https://issues.apache.org/jira/browse/THRIFT-2504 > Project: Thrift > Issue Type: Improvement > Components: Java - Library >Reporter: Aleksey Pesternikov > > Compatibility feature: TMultiplexedProcessor could be used with old clients > when configured with old service as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-4028) Please remove System.out.format from the source code
[
https://issues.apache.org/jira/browse/THRIFT-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-4028:
-
Fix Version/s: (was: 0.10.0)
0.11.0
> Please remove System.out.format from the source code
>
>
> Key: THRIFT-4028
> URL: https://issues.apache.org/jira/browse/THRIFT-4028
> Project: Thrift
> Issue Type: Task
> Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Arthur Du
>Priority: Trivial
> Fix For: 0.11.0
>
>
> thrift-0.10.0/lib/java/src/org/apache/thrift/TServiceClient.java
> line 84:
> System.out.format("Received %d%n", msg.seqid);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-4032) no libthrift 0.10.0 in https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
[
https://issues.apache.org/jira/browse/THRIFT-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-4032.
Resolution: Fixed
Fix Version/s: 0.10.0
0.10.0 published to repository.apache.org, mirrors should pick it up in the
next 24 hours and make it available on repo1.maven.org
> no libthrift 0.10.0 in
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> --
>
> Key: THRIFT-4032
> URL: https://issues.apache.org/jira/browse/THRIFT-4032
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Xiaoshuang LU
>Assignee: Jake Farrell
> Fix For: 0.10.0
>
>
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> {code}
> Index of /maven2/org/apache/thrift/libthrift/
> ../
> 0.6.1/ 2011-04-25 08:54
> -
> 0.7.0/ 2011-08-13 17:27
> -
> 0.8.0/ 2011-11-29 18:34
> -
> 0.9.0/ 2012-10-15 21:50
> -
> 0.9.1/ 2013-08-23 10:26
> -
> 0.9.2/ 2014-11-18 12:19
> -
> 0.9.3/ 2015-10-11 21:19
> -
> maven-metadata.xml 2015-10-11 21:19
>519
> maven-metadata.xml.md5 2015-10-11 21:19
> 32
> maven-metadata.xml.sha12015-10-11 21:19
> 40
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822948#comment-15822948
]
Jake Farrell commented on THRIFT-4029:
--
Uploaded a new package which has the headers in it. It is a zip instead of a
tar.gz due to the awful behavior of pypi not allowing multiple uploads of the
same named packages
{code}
Submitting dist/thrift-0.10.0.tar.gz to https://pypi.python.org/pypi
Upload failed (400): This filename has previously been used, you should use a
different version.
error: Upload failed (400): This filename has previously been used, you should
use a different version.
{code}
> Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
>
>
> Key: THRIFT-4029
> URL: https://issues.apache.org/jira/browse/THRIFT-4029
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>Assignee: Jake Farrell
>
> The thrift 0.10.0 distribution on PyPI does not include extension headers and
> a C++ (template) file, preventing the accelerated protocols from being built.
> {{pip install}} reports a brief error:
> {code}
> Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir
> /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL
> cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for
> C/ObjC but not for C++
> src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory
> #include "types.h"
>^
> compilation terminated.
> ()
>
> An error occurred while trying to compile with the C extension enabled
> Attempting to build without the extension now
>
> ()
> {code}
> The list of files that is not included in the distribution is as follows. In
> addition to the headers and source file mentioned above, there's a Windows
> compatibility header missing and a couple of test files missing. It looks
> like there was a file extension filter (accidentally) applied to the C++
> files at least:
> {code}
> src/ext/binary.h
> src/ext/compact.h
> src/ext/endian.h
> src/ext/protocol.h
> src/ext/protocol.tcc
> src/ext/types.h
> compat/win32/stdint.h
> test/_import_local_thrift.py
> test/thrift_json.py
> {code}
> [~jfarrell] were you who made the release? Is it possible to hotfix? My
> team has been waiting on the release of the accelerated compact protocol for
> a while, this discovery is saddening for us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821932#comment-15821932
]
Jake Farrell commented on THRIFT-4029:
--
Not sure why `python setup.py sdist` is not including the headers as the
include_dirs is listed for the extension, nothing new occurring here as far as
the steps used to package and push that artifact. Does using a MANIFEST.in with
the following fix the issue for you? If so we could look at getting that fixed
{code}
graft src
graft compat
graft tests
global-exclude __pycache__
global-exclude *.py[co]
{code}
> Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
>
>
> Key: THRIFT-4029
> URL: https://issues.apache.org/jira/browse/THRIFT-4029
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>
> The thrift 0.10.0 distribution on PyPI does not include extension headers and
> a C++ (template) file, preventing the accelerated protocols from being built.
> {{pip install}} reports a brief error:
> {code}
> Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir
> /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL
> cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for
> C/ObjC but not for C++
> src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory
> #include "types.h"
>^
> compilation terminated.
> ()
>
> An error occurred while trying to compile with the C extension enabled
> Attempting to build without the extension now
>
> ()
> {code}
> The list of files that is not included in the distribution is as follows. In
> addition to the headers and source file mentioned above, there's a Windows
> compatibility header missing and a couple of test files missing. It looks
> like there was a file extension filter (accidentally) applied to the C++
> files at least:
> {code}
> src/ext/binary.h
> src/ext/compact.h
> src/ext/endian.h
> src/ext/protocol.h
> src/ext/protocol.tcc
> src/ext/types.h
> compat/win32/stdint.h
> test/_import_local_thrift.py
> test/thrift_json.py
> {code}
> [~jfarrell] were you who made the release? Is it possible to hotfix? My
> team has been waiting on the release of the accelerated compact protocol for
> a while, this discovery is saddening for us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-4029:
Assignee: Jake Farrell
> Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
>
>
> Key: THRIFT-4029
> URL: https://issues.apache.org/jira/browse/THRIFT-4029
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>Assignee: Jake Farrell
>
> The thrift 0.10.0 distribution on PyPI does not include extension headers and
> a C++ (template) file, preventing the accelerated protocols from being built.
> {{pip install}} reports a brief error:
> {code}
> Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir
> /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL
> cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for
> C/ObjC but not for C++
> src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory
> #include "types.h"
>^
> compilation terminated.
> ()
>
> An error occurred while trying to compile with the C extension enabled
> Attempting to build without the extension now
>
> ()
> {code}
> The list of files that is not included in the distribution is as follows. In
> addition to the headers and source file mentioned above, there's a Windows
> compatibility header missing and a couple of test files missing. It looks
> like there was a file extension filter (accidentally) applied to the C++
> files at least:
> {code}
> src/ext/binary.h
> src/ext/compact.h
> src/ext/endian.h
> src/ext/protocol.h
> src/ext/protocol.tcc
> src/ext/types.h
> compat/win32/stdint.h
> test/_import_local_thrift.py
> test/thrift_json.py
> {code}
> [~jfarrell] were you who made the release? Is it possible to hotfix? My
> team has been waiting on the release of the accelerated compact protocol for
> a while, this discovery is saddening for us.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-3775) 0.10.0 release candidate
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3775. Resolution: Fixed Fix Version/s: 0.10.0 > 0.10.0 release candidate > > > Key: THRIFT-3775 > URL: https://issues.apache.org/jira/browse/THRIFT-3775 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Jake Farrell >Assignee: Jake Farrell > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4008) broken ci due to upstream dependency versioning break
[ https://issues.apache.org/jira/browse/THRIFT-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799251#comment-15799251 ] Jake Farrell commented on THRIFT-4008: -- 0.11.0.0 is the current version of vector released back in November, but had an issue with it when i tried using the latest (forget what the exact failure was), I pinned it to latest version which worked. Honestly I am +1 for whatever specific version will work here and not break moving forward https://hackage.haskell.org/package/vector > broken ci due to upstream dependency versioning break > - > > Key: THRIFT-4008 > URL: https://issues.apache.org/jira/browse/THRIFT-4008 > Project: Thrift > Issue Type: Bug > Components: Haskell - Library >Reporter: Jake Farrell >Assignee: Jake Farrell > Fix For: 0.10.0, 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4008) broken ci due to upstream dependency versioning break
[
https://issues.apache.org/jira/browse/THRIFT-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798744#comment-15798744
]
Jake Farrell commented on THRIFT-4008:
--
When testing the release candidate I hit the issue where vector was getting an
older version, 0.2, due to another dep pulling in that version. Since we did
not have a vector version pinned it took the system version and tried to use it
causing the CI issue of
{code}
gen-hs/ThriftTest_Types.hs:288:15:`
No instance for (P.Show (Vector.Vector Xtruct))
arising from the 'deriving' clause of a data type declaration
Possible fix:
add an instance declaration for (P.Show (Vector.Vector Xtruct))
or use a standalone 'deriving instance' declaration,
so you can specify the instance context yourself
When deriving the instance for (P.Show Insanity)
{code}
for some reason the latest version also was having an error with it and the
latest version had just recently been released. I pinned specifically to a
newer version that passed CI and worked which is why it was == vs the >=.
> broken ci due to upstream dependency versioning break
> -
>
> Key: THRIFT-4008
> URL: https://issues.apache.org/jira/browse/THRIFT-4008
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
>Reporter: Jake Farrell
>Assignee: Jake Farrell
> Fix For: 0.10.0, 0.11.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-3999) Fix Debian & Ubuntu package dependencies
[
https://issues.apache.org/jira/browse/THRIFT-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-3999.
Resolution: Fixed
Fix Version/s: (was: 0.11.0)
0.10.0
> Fix Debian & Ubuntu package dependencies
>
>
> Key: THRIFT-3999
> URL: https://issues.apache.org/jira/browse/THRIFT-3999
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3
> Environment: Ubuntu 16.04.1 LTS
>Reporter: Akira Nakagawa
>Assignee: Akira Nakagawa
>Priority: Minor
> Fix For: 0.10.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> debian/control has typo and missing packages and it prevents building
> packages.
> There are many bugs to build and lintian warning.
> All error and warning messages are here:
> {quote}
> E: thrift changes: bad-distribution-in-changes-file stable
> W: thrift source: native-package-with-dash-version
> W: thrift source: diff-contains-git-control-dir .git
> W: thrift source: configure-generated-file-in-source config.log
> W: thrift source: configure-generated-file-in-source config.status
> E: thrift source: source-is-missing lib/js/test/phantom-client.js line length
> is 2016 characters (>512)
> E: thrift source: source-is-missing lib/js/test/test-async.js line length is
> 2016 characters (>512)
> E: thrift source: source-is-missing lib/js/test/test.js line length is 2016
> characters (>512)
> W: thrift source: configure-generated-file-in-source
> lib/php/src/ext/thrift_protocol/config.log
> W: thrift source: configure-generated-file-in-source
> lib/php/src/ext/thrift_protocol/config.status
> W: thrift source: dh-clean-k-is-deprecated
> E: thrift source: build-depends-on-build-essential build-depends
> E: thrift source: build-depends-on-metapackage build-depends: qt5-default
> W: thrift source: debian-rules-ignores-make-clean-error line 97
> W: thrift source: timewarp-standards-version (2013-01-08 < 2013-10-28)
> W: thrift source: ancient-standards-version 3.9.5 (current is 3.9.7)
> W: libthrift-cil: executable-not-elf-or-script usr/lib/cli/thrift/Thrift.dll
> W: libthrift0: package-name-doesnt-match-sonames libthrift-1.0.0-dev
> libthriftnb-1.0.0-dev libthriftqt-1.0.0-dev libthriftqt5-1.0.0-dev
> libthriftz-1.0.0-dev
> W: libthrift0: dev-pkg-without-shlib-symlink usr/lib/libthriftz-1.0.0-dev.so
> usr/lib/libthriftz-1.0.0-dev.so
> W: libthrift0: dev-pkg-without-shlib-symlink
> usr/lib/libthriftqt5-1.0.0-dev.so usr/lib/libthriftqt5-1.0.0-dev.so
> W: libthrift0: dev-pkg-without-shlib-symlink usr/lib/libthrift-1.0.0-dev.so
> usr/lib/libthrift-1.0.0-dev.so
> W: libthrift0: dev-pkg-without-shlib-symlink usr/lib/libthriftqt-1.0.0-dev.so
> usr/lib/libthriftqt-1.0.0-dev.so
> W: libthrift0: dev-pkg-without-shlib-symlink usr/lib/libthriftnb-1.0.0-dev.so
> usr/lib/libthriftnb-1.0.0-dev.so
> E: libthrift0: shlib-missing-in-control-file libthriftz 1.0.0-dev for
> usr/lib/libthriftz-1.0.0-dev.so
> E: libthrift0: shlib-missing-in-control-file libthriftqt5 1.0.0-dev for
> usr/lib/libthriftqt5-1.0.0-dev.so
> E: libthrift0: shlib-missing-in-control-file libthrift 1.0.0-dev for
> usr/lib/libthrift-1.0.0-dev.so
> E: libthrift0: shlib-missing-in-control-file libthriftqt 1.0.0-dev for
> usr/lib/libthriftqt-1.0.0-dev.so
> E: libthrift0: shlib-missing-in-control-file libthriftnb 1.0.0-dev for
> usr/lib/libthriftnb-1.0.0-dev.so
> W: libthrift0: unused-shlib-entry-in-control-file libthriftqt-1.0.0 dev
> W: libthrift0: unused-shlib-entry-in-control-file libthriftqt5-1.0.0 dev
> W: libthrift0: unused-shlib-entry-in-control-file libthrift-1.0.0 dev
> W: libthrift0: unused-shlib-entry-in-control-file libthriftz-1.0.0 dev
> W: libthrift0: unused-shlib-entry-in-control-file libthriftnb-1.0.0 dev
> W: libthrift-java: needless-dependency-on-jre
> E: libthrift-dev: non-empty-dependency_libs-in-la-file usr/lib/libthrift.la
> E: libthrift-dev: non-empty-dependency_libs-in-la-file
> usr/lib/libthrift_c_glib.la
> E: libthrift-dev: non-empty-dependency_libs-in-la-file usr/lib/libthriftnb.la
> E: libthrift-dev: non-empty-dependency_libs-in-la-file usr/lib/libthriftqt.la
> E: libthrift-dev: non-empty-dependency_libs-in-la-file usr/lib/libthriftqt5.la
> E: libthrift-dev: non-empty-dependency_libs-in-la-file usr/lib/libthriftz.la
> W: thrift-compiler: binary-without-manpage usr/bin/thrift
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-4008) broken ci due to upstream dependency versioning break
[ https://issues.apache.org/jira/browse/THRIFT-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4008. Resolution: Fixed > broken ci due to upstream dependency versioning break > - > > Key: THRIFT-4008 > URL: https://issues.apache.org/jira/browse/THRIFT-4008 > Project: Thrift > Issue Type: Bug > Components: Haskell - Library >Reporter: Jake Farrell >Assignee: Jake Farrell > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-4008) broken ci due to upstream dependency versioning break
Jake Farrell created THRIFT-4008: Summary: broken ci due to upstream dependency versioning break Key: THRIFT-4008 URL: https://issues.apache.org/jira/browse/THRIFT-4008 Project: Thrift Issue Type: Bug Components: Haskell - Library Reporter: Jake Farrell Assignee: Jake Farrell Fix For: 0.10.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3965) VisualStudio project cannot build compiler CPP project
[
https://issues.apache.org/jira/browse/THRIFT-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651988#comment-15651988
]
Jake Farrell commented on THRIFT-3965:
--
+1, simplifies a lot on the release side from having to touch a bunch of IDE
files with new version strings
> VisualStudio project cannot build compiler CPP project
> --
>
> Key: THRIFT-3965
> URL: https://issues.apache.org/jira/browse/THRIFT-3965
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: Microsoft Visual Studio Enterprise 2015
> Version 14.0.25123.00 Update 2
> Microsoft .NET Framework
> Version 4.6.01055
> Installed Version: Enterprise
> Architecture and Modeling Tools 00322-8-0-AA924
> Microsoft Architecture and Modeling Tools
>
> UML® and Unified Modeling Language™ are trademarks or registered trademarks
> of the Object Management Group, Inc. in the United States and other countries.
> Visual Basic 2015 00322-8-0-AA924
> Microsoft Visual Basic 2015
> Visual C# 2015 00322-8-0-AA924
> Microsoft Visual C# 2015
> Visual C++ 2015 00322-8-0-AA924
> Microsoft Visual C++ 2015
> Application Insights Tools for Visual Studio Package 5.209.60613.1
> Application Insights Tools for Visual Studio
> ASP.NET and Web Tools 2015.1 (Beta8) 14.1.11106.0
> ASP.NET and Web Tools 2015.1 (Beta8)
> ASP.NET Web Frameworks and Tools 2012.2 4.1.41102.0
> For additional information, visit
> http://go.microsoft.com/fwlink/?LinkID=309563
> ASP.NET Web Frameworks and Tools 2013 5.2.40314.0
> For additional information, visit http://www.asp.net/
> Common Azure Tools 1.7
> Provides common services for use by Azure Mobile Services and Microsoft Azure
> Tools.
> JavaScript Language Service 2.0
> JavaScript Language Service
> JavaScript Project System 2.0
> JavaScript Project System
> Microsoft Azure Mobile Services Tools 1.4
> Microsoft Azure Mobile Services Tools
> NuGet Package Manager 3.4.4
> NuGet Package Manager in Visual Studio. For more information about NuGet,
> visit http://docs.nuget.org/.
> PreEmptive Analytics Visualizer 1.2
> Microsoft Visual Studio extension to visualize aggregated summaries from the
> PreEmptive Analytics product.
> SQL Server Data Tools 14.0.60311.1
> Microsoft SQL Server Data Tools
> TypeScript 1.8.31.0
> TypeScript tools for Visual Studio
>Reporter: Gary Gregory
>Assignee: James E. King, III
> Labels: Windows
>
> Based on the current git master branch.
> The project's {{t_generator.h}} want to use the header file {{version.h}}:
> {code}
> #include "thrift/version.h"
> {code}
> The file does not exist but {{version.h.in}} is there and looks to be
> expected by the CMake build's {{CMakeLists.txt}}:
> {code}
> configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in
> ${CMAKE_CURRENT_BINARY_DIR}/thrift/version.h)
> {code}
> As a workaround I just copied {{version.h.in}} to {{version.h}}.
> It would be nice to fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3550) Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is present
[ https://issues.apache.org/jira/browse/THRIFT-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602218#comment-15602218 ] Jake Farrell commented on THRIFT-3550: -- I'm not aware of any, if you can give details on where I need to signup for an account and whats needed i'll add it to the release process > Latest indexed version of the perl lib on CPAN is 0.8.0, although 0.9.0 is > present > -- > > Key: THRIFT-3550 > URL: https://issues.apache.org/jira/browse/THRIFT-3550 > Project: Thrift > Issue Type: Wish > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: David Morel > > Running cpanm or cpan installs version 0.8.0 of the perl lib, although 0.9.0 > has been uploaded on PAUSE. > Also, would be nice to have v 0.9.3 since it's available? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571808#comment-15571808
]
Jake Farrell commented on THRIFT-3932:
--
Ran through the patch and with the size and number of files that this is
touching in the C++ lib I would error on the side of caution and look at
committing this right after 0.10.0 is released so it does not block the release
and it can get proper testing and soak time in before 0.11.0 gets cut.
[~ben.craig] do you have a second to review this patch?
> C++ ThreadManager has a rare termination race
> -
>
> Key: THRIFT-3932
> URL: https://issues.apache.org/jira/browse/THRIFT-3932
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Buğra Gedik
>Assignee: James E. King, III
> Fix For: 0.11.0
>
> Attachments: thrift-patch
>
> Time Spent: 17h
> Remaining Estimate: 0h
>
> {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls
> {{removeWorker(workerCount_);}}. The latter waits until {{while (workerCount_
> != workerMaxCount_)}}. Within the {{run}} method of the workers, the last
> thread that detects {{workerCount_ == workerMaxCount_}} notifies
> {{removeWorker}}. The {{run}} method has the following additional code that
> is executed at the very end:
> {code}
> {
> Synchronized s(manager_->workerMonitor_);
> manager_->deadWorkers_.insert(this->thread());
> if (notifyManager) {
> manager_->workerMonitor_.notify();
> }
> }
> {code}
> This is an independent synchronized block. Now assume 2 threads. One of them
> has {{notifyManager=true}} as it detected the {{workerCount_ ==
> workerMaxCount_}} condition earlier. It is possible that this thread gets to
> execute the above code block first, {{ThreadManager}}'s {{removeWorker}}
> method unblocks, and eventually {{ThreadManager}}'s {{join}} returns and the
> object is destructed. When the other thread reaches the synchronized block
> above, it will crash, as the manager is not around anymore.
> Besides, {{ThreadManager}} never joins its threads.
> Attached is a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-3932:
-
Fix Version/s: 0.11.0
> C++ ThreadManager has a rare termination race
> -
>
> Key: THRIFT-3932
> URL: https://issues.apache.org/jira/browse/THRIFT-3932
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Buğra Gedik
>Assignee: James E. King, III
> Fix For: 0.11.0
>
> Attachments: thrift-patch
>
> Time Spent: 17h
> Remaining Estimate: 0h
>
> {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls
> {{removeWorker(workerCount_);}}. The latter waits until {{while (workerCount_
> != workerMaxCount_)}}. Within the {{run}} method of the workers, the last
> thread that detects {{workerCount_ == workerMaxCount_}} notifies
> {{removeWorker}}. The {{run}} method has the following additional code that
> is executed at the very end:
> {code}
> {
> Synchronized s(manager_->workerMonitor_);
> manager_->deadWorkers_.insert(this->thread());
> if (notifyManager) {
> manager_->workerMonitor_.notify();
> }
> }
> {code}
> This is an independent synchronized block. Now assume 2 threads. One of them
> has {{notifyManager=true}} as it detected the {{workerCount_ ==
> workerMaxCount_}} condition earlier. It is possible that this thread gets to
> execute the above code block first, {{ThreadManager}}'s {{removeWorker}}
> method unblocks, and eventually {{ThreadManager}}'s {{join}} returns and the
> object is destructed. When the other thread reaches the synchronized block
> above, it will crash, as the manager is not around anymore.
> Besides, {{ThreadManager}} never joins its threads.
> Attached is a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3546. Resolution: Fixed Fix Version/s: 0.10.0 > NodeJS code should not be namespaced (and is currently not strict-mode > compliant) > - > > Key: THRIFT-3546 > URL: https://issues.apache.org/jira/browse/THRIFT-3546 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler >Affects Versions: 0.9.3 >Reporter: Yunchi Luo >Assignee: Benjamin Gould > Fix For: 0.10.0 > > > Code generated for NodeJS, whether with a js namespace specified or not, > seems to fail strict mode. Specifically, it doesn't always generate "var" > when needed. This might not sound like a big issue but it's quite a pain to > deal with... > It is standard nowadays to enable strict mode for Javascript code > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode). > And babel, which is one of most popular ES6 => ES5 transpilers, while does > not force strict mode, does seem to break when you don't use "var". > I think the best solution here is really to just stop using namespaces in > node code. Every type will be declared with "var", and if exported, also > assigned to "module.exports". > I don't believe namespaces currently generated in the node code is directly > used anywhere or is even accessible outside the file? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3546) NodeJS code should not be namespaced (and is currently not strict-mode compliant)
[ https://issues.apache.org/jira/browse/THRIFT-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3546: - Assignee: Benjamin Gould > NodeJS code should not be namespaced (and is currently not strict-mode > compliant) > - > > Key: THRIFT-3546 > URL: https://issues.apache.org/jira/browse/THRIFT-3546 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler >Affects Versions: 0.9.3 >Reporter: Yunchi Luo >Assignee: Benjamin Gould > > Code generated for NodeJS, whether with a js namespace specified or not, > seems to fail strict mode. Specifically, it doesn't always generate "var" > when needed. This might not sound like a big issue but it's quite a pain to > deal with... > It is standard nowadays to enable strict mode for Javascript code > (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode). > And babel, which is one of most popular ES6 => ES5 transpilers, while does > not force strict mode, does seem to break when you don't use "var". > I think the best solution here is really to just stop using namespaces in > node code. Every type will be declared with "var", and if exported, also > assigned to "module.exports". > I don't believe namespaces currently generated in the node code is directly > used anywhere or is even accessible outside the file? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565413#comment-15565413 ] Jake Farrell commented on THRIFT-3775: -- My latest pull request update [1] against trunk at d6bcb26 is now passing all tests[1]. final call for patches before I branch and start packaging this as 0.10.0-rc1 [1]: https://github.com/apache/thrift/pull/1098 [2]: https://travis-ci.org/apache/thrift/builds/166610540 > 0.10.0 release candidate > > > Key: THRIFT-3775 > URL: https://issues.apache.org/jira/browse/THRIFT-3775 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Jake Farrell >Assignee: Jake Farrell > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537133#comment-15537133
]
Jake Farrell commented on THRIFT-3855:
--
hey [~asm0dey], the 0.10.0 release candidate is in process, you can follow
THRIFT-3775 for progress. We have had some issues with our CI and tooling and
have been working through them and with the new changes we are making hope to
get back to a more regular release cadence.
> In the go simple server, if Stop() is called multiple times it hangs
>
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Assignee: Paul Finkelshteyn
>Priority: Minor
> Fix For: 0.10.0
>
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533769#comment-15533769
]
Jake Farrell commented on THRIFT-3937:
--
[~jking3] we can not use the autoconf macro that you linked in your pull
request due to a non-compatible license. GPLWithACException can not include it
with Apache Thrift, this is outlined by Apache Legal at
http://www.apache.org/legal/resolved.html#category-x.
Since we are deprecating autoconf, pre previous dev@ list discussions and
votes, and this will be the last release with its support I would not invest
too much time into a workaround for this. Perhaps a README update for the min
required versions should be enough for this, thoughts?
> Cannot compile 0.10.0 development tip with gcc-4.6.x
>
>
> Key: THRIFT-3937
> URL: https://issues.apache.org/jira/browse/THRIFT-3937
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
> Environment: Ubuntu 12.04.5 LTS with gcc-4.6.3 and boost 1.53.0,
> Ubuntu 14.04.2 LTS with gcc-4.6.4 and boost-1.54.0
>Reporter: James E. King, III
>Assignee: Aki Sukegawa
>
> While building the tip using cmake:
> {noformat}
> [ 51%] Building CXX object
> compiler/cpp/CMakeFiles/thriftc_static.dir/src/thrift/plugin/plugin_output.cc.o
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_enum, To =
> apache::thrift::plugin::t_enum]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:181:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator
> >, )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:181:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From =
> t_const_value, To = apache::thrift::plugin::t_const_value]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:212:5:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator
> >, )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:212:5:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_struct, To
> = apache::thrift::plugin::t_struct]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:235:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator >,
> )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:235:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_service,
> To = apache::thrift::plugin::t_service]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:267:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator >,
> )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:267:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter,
[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533477#comment-15533477
]
Jake Farrell commented on THRIFT-3937:
--
sounds like you have most of this worked out all ready, lets get the patches in
for 0.10.0
> Cannot compile 0.10.0 development tip with gcc-4.6.x
>
>
> Key: THRIFT-3937
> URL: https://issues.apache.org/jira/browse/THRIFT-3937
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
> Environment: Ubuntu 12.04.5 LTS with gcc-4.6.3 and boost 1.53.0,
> Ubuntu 14.04.2 LTS with gcc-4.6.4 and boost-1.54.0
>Reporter: James E. King, III
>Assignee: Aki Sukegawa
>
> While building the tip using cmake:
> {noformat}
> [ 51%] Building CXX object
> compiler/cpp/CMakeFiles/thriftc_static.dir/src/thrift/plugin/plugin_output.cc.o
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_enum, To =
> apache::thrift::plugin::t_enum]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:181:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator
> >, )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:181:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From =
> t_const_value, To = apache::thrift::plugin::t_const_value]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:212:5:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator
> >, )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:212:5:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_struct, To
> = apache::thrift::plugin::t_struct]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:235:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator >,
> )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:235:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_service,
> To = apache::thrift::plugin::t_service]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:267:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator >,
> )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:267:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_program,
> To = apache::thrift::plugin::t_program]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:360:3:
> error: no matching function for call to
> ‘transform(std::vector::iterator,
>
[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533362#comment-15533362
]
Jake Farrell commented on THRIFT-3937:
--
I would say that if its not working for VS2010 don't try and force it, try and
keep to the latest LTS versions and possible the previous version. Same goes
for centos, ubuntu and debian which we should have Dockerfiles for and should
test and show usage and install examples for each client lib within.
> Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53
> ---
>
> Key: THRIFT-3937
> URL: https://issues.apache.org/jira/browse/THRIFT-3937
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
> Environment: Ubuntu 12.04.5 LTS with gcc-4.6.3 and boost 1.53.0,
> Ubuntu 14.04.2 LTS with gcc-4.6.4 and boost-1.54.0
>Reporter: James E. King, III
>Assignee: Aki Sukegawa
>
> While building the tip using cmake:
> {noformat}
> [ 51%] Building CXX object
> compiler/cpp/CMakeFiles/thriftc_static.dir/src/thrift/plugin/plugin_output.cc.o
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_enum, To =
> apache::thrift::plugin::t_enum]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:181:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator
> >, )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:181:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From =
> t_const_value, To = apache::thrift::plugin::t_const_value]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:212:5:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator
> >, )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:212:5:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_struct, To
> = apache::thrift::plugin::t_struct]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:235:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator >,
> )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:235:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert(From*, To&) [with From = t_service,
> To = apache::thrift::plugin::t_service]’:
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:267:3:
> error: no matching function for call to
> ‘transform(std::vector::const_iterator,
> std::vector::const_iterator,
> std::back_insert_iterator >,
> )’
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc:267:3:
> note: candidates are:
> /usr/include/c++/4.6/bits/stl_algo.h:4871:5: note: template class _OIter, class _UnaryOperation> _OIter std::transform(_IIter, _IIter,
> _OIter, _UnaryOperation)
> /usr/include/c++/4.6/bits/stl_algo.h:4907:5: note: template class _IIter2, class _OIter, class _BinaryOperation> _OIter
> std::transform(_IIter1, _IIter1, _IIter2, _OIter, _BinaryOperation)
> /home/jking/thrift/compiler/cpp/src/thrift/plugin/plugin_output.cc: In
> function ‘void plugin_output::convert
[jira] [Closed] (THRIFT-1108) SSL support for the Ruby library
[ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1108. Resolution: Fixed Fix Version/s: 0.10.0 Thanks for the update and tests, committed > SSL support for the Ruby library > - > > Key: THRIFT-1108 > URL: https://issues.apache.org/jira/browse/THRIFT-1108 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.6 >Reporter: Alex >Assignee: Mansi >Priority: Minor > Labels: ssl > Fix For: 0.10.0 > > Attachments: ssl_support.diff > > > Attached are modified versions of the socket and server_socket files which > include SSL support. I do not consider these implementations complete, > however they work well for my purposes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-1108) SSL support for the Ruby library
[ https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1108: - Assignee: Mansi > SSL support for the Ruby library > - > > Key: THRIFT-1108 > URL: https://issues.apache.org/jira/browse/THRIFT-1108 > Project: Thrift > Issue Type: Improvement > Components: Ruby - Library >Affects Versions: 0.6 >Reporter: Alex >Assignee: Mansi >Priority: Minor > Labels: ssl > Attachments: ssl_support.diff > > > Attached are modified versions of the socket and server_socket files which > include SSL support. I do not consider these implementations complete, > however they work well for my purposes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-948) SSL socket support for PHP
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-948. --- Resolution: Fixed Fix Version/s: 0.10.0 Committed, thanks for the patch > SSL socket support for PHP > -- > > Key: THRIFT-948 > URL: https://issues.apache.org/jira/browse/THRIFT-948 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: David Reiss >Assignee: Mansi >Priority: Minor > Fix For: 0.10.0 > > Attachments: php-ssl-0.9.2.patch, php-ssl.patch > > > This had some basic testing, but was never used in production. If someone > wants to implement this feature, they can start with this patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-948) SSL socket support for PHP
[ https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-948: Assignee: Mansi > SSL socket support for PHP > -- > > Key: THRIFT-948 > URL: https://issues.apache.org/jira/browse/THRIFT-948 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: David Reiss >Assignee: Mansi >Priority: Minor > Attachments: php-ssl-0.9.2.patch, php-ssl.patch > > > This had some basic testing, but was never used in production. If someone > wants to implement this feature, they can start with this patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3927) Emit an error instead of throw an error in the async callback
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3927. Resolution: Fixed Fix Version/s: 0.10.0 committed, thanks for the patch, appreciate the help > Emit an error instead of throw an error in the async callback > - > > Key: THRIFT-3927 > URL: https://issues.apache.org/jira/browse/THRIFT-3927 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Reporter: 李飛 > Fix For: 0.10.0 > > > because the data event of a connection is async handled, throw an exception > can not tell the code the error. emit the error should be the correct way to > handle the errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3816) Reduce docker build duration on Travis-CI
[ https://issues.apache.org/jira/browse/THRIFT-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418249#comment-15418249 ] Jake Farrell commented on THRIFT-3816: -- The docker files where not intended to be fast, but give a repeatable base for builds as well as full details for users on how to setup and install a given client libs deps on a given system. These changes are also breaking the release candidate build > Reduce docker build duration on Travis-CI > - > > Key: THRIFT-3816 > URL: https://issues.apache.org/jira/browse/THRIFT-3816 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > Fix For: 0.10.0 > > > cross test jobs on Travis-CI are frequently hitting 50 min limit. > For now, reducing docker build time by several minutes should fix it. > Dockerfile changes: > * buildpack-deps base image for fewer apt packages > https://hub.docker.com/_/buildpack-deps > * fewer apt-get packages > It would cause problem for retrying. in that case we can split them again > .travis.yml changes: > * remove "docker pull" because cache can no longer be reused because of > docker change -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata
[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294671#comment-15294671 ] Jake Farrell commented on THRIFT-3834: -- You can follow along in THRIFT-3775 for the 0.10.0 release, right now it was held until CI could get back on track and fixed. Local tests in the docker container where passing at last listed commit hash, but jenkins and travis where failing > Erlang namespacing and exception metadata > - > > Key: THRIFT-3834 > URL: https://issues.apache.org/jira/browse/THRIFT-3834 > Project: Thrift > Issue Type: New Feature > Components: Erlang - Compiler >Reporter: Steve Cohen >Assignee: Steve Cohen > Fix For: 0.10.0 > > Attachments: add_namespacing.patch > > > The erlang modules generated by thrift cannot be namespaced, this change > allows namespacing like in other thrift types. > If Module A defines a struct S and Module B defines a struct S and Module A > includes Module B, it will not compile. This change fixes that problem. > If at all possible, I'd like this to get into 0.10 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2342) Add __FILE__ and __LINE__ to Thrift C++ excpetions
[ https://issues.apache.org/jira/browse/THRIFT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224837#comment-15224837 ] Jake Farrell commented on THRIFT-2342: -- bulk edit by jira moving all 1.0 over to 0.10.0 for THRIFT-3775 - 0.10.0 release. please feel free to change resolution as needed > Add __FILE__ and __LINE__ to Thrift C++ excpetions > -- > > Key: THRIFT-2342 > URL: https://issues.apache.org/jira/browse/THRIFT-2342 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler, C++ - Library >Reporter: George Godik >Assignee: James E. King, III >Priority: Minor > Labels: newbie > Fix For: 0.10.0 > > > Thrift exceptions are somewhat difficult to trace from debug logs. I'd like > to add __FILE__AND__LINE__ as a second parameter to some exceptions to make > them easier to find. > For example: > Every time a required field is not set, the exception that gets generated is > a very generic > throw TProtocolException(TProtocolException::INVALID_DATA) > see - > https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372 > I think I'll start with patching up TProtocolExcpetion in the compiler and if > people like this I can make a separate issue and patch for other exceptions -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224832#comment-15224832 ] Jake Farrell commented on THRIFT-3775: -- - Run through and verify all files are accounted for from make dist - Ran make/make check/cross tests against master - Cut 0.10.0 branch at cdc83335d60756c4bfb0d2c8af7933500c9e3c06 - Updated version to 0.10.0 - Changelog generated from jira query: "project=THRIFT AND fixVersion='0.10.0' AND status = Closed" - Tests currently running against new versioned code @todo pending passing tests against new branch: - Create source dist package - Creating binary artifact packaging - Draft RC vote email > 0.10.0 release candidate > > > Key: THRIFT-3775 > URL: https://issues.apache.org/jira/browse/THRIFT-3775 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Jake Farrell >Assignee: Jake Farrell > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2019) Writing on a disconnected socket on Mac causes SIG PIPE
[ https://issues.apache.org/jira/browse/THRIFT-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2019. Resolution: Fixed > Writing on a disconnected socket on Mac causes SIG PIPE > --- > > Key: THRIFT-2019 > URL: https://issues.apache.org/jira/browse/THRIFT-2019 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 > Environment: Mac OSX >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: mac_sigpipe.patch > > > Suppose you have a successful client / server connection on Mac. The client > suddenly disconnects while the server is writing the reply to the socket. > Currently, this causes SIG PIPE. > Thrift already has code to deal with this on Linux, but Mac / BSD do this > differently. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3306) Java: TBinaryProtocol: Use 1 temp buffer instead of allocating 8
[ https://issues.apache.org/jira/browse/THRIFT-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3306. Resolution: Fixed > Java: TBinaryProtocol: Use 1 temp buffer instead of allocating 8 > > > Key: THRIFT-3306 > URL: https://issues.apache.org/jira/browse/THRIFT-3306 > Project: Thrift > Issue Type: Improvement > Components: Java - Library >Reporter: Evan Jones >Assignee: Roger Meier >Priority: Minor > Fix For: 0.10.0 > > > TBinaryProtocol has a member buffer for reading and for serializing each of > the integer types. It can get by with only a single one: 8 bytes long for the > maximum length integer. This causes a significant reduction in allocations > and GC in cases that create the TBinaryProtocol to serialize a single > message, instead of reusing it. > This passes "ant test". I ran the existing SerializationBenchmark and there > is no statistically significant difference (the average of 5 runs is smaller > on my machine, but I don't think we should read much into that). > I have a JMH benchmark for this, and it shows that when the TBinaryProtocol > is allocated each time, this change is better, but is more or less the same > when you reuse the TBinaryProtocol in a loop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-35) Move language tests into their appropriate library directory
[ https://issues.apache.org/jira/browse/THRIFT-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-35. -- Resolution: Fixed > Move language tests into their appropriate library directory > > > Key: THRIFT-35 > URL: https://issues.apache.org/jira/browse/THRIFT-35 > Project: Thrift > Issue Type: Improvement > Components: Test Suite >Reporter: Bryan Duxbury >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.10.0 > > > It would be cleaner to keep the libraries and test code for each language > together under the lib/ directory. It would cut down on duplication of code, > make tests easier to run, and unclutter the top of the project a bit. > It's been suggested that if we do this, we should change ALL the languages at > once. Does that make this an overly monumental project? Should we make a > sub-issue on this issue for every implemented language? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2162) Missing calls to inherited CTOR at misc. places
[ https://issues.apache.org/jira/browse/THRIFT-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2162. Resolution: Fixed > Missing calls to inherited CTOR at misc. places > --- > > Key: THRIFT-2162 > URL: https://issues.apache.org/jira/browse/THRIFT-2162 > Project: Thrift > Issue Type: Bug > Components: Delphi - Compiler, Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.10.0 > > Attachments: > THRIFT-2162_Missing_calls_to_inherited_CTOR_at_misc_places.patch > > > Not calling the inherited CTOR is bad practice with Delphi and can lead to > strange errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2049) Go compiler doesn't build on native Windows
[ https://issues.apache.org/jira/browse/THRIFT-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2049. Resolution: Fixed > Go compiler doesn't build on native Windows > --- > > Key: THRIFT-2049 > URL: https://issues.apache.org/jira/browse/THRIFT-2049 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 0.9 >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: windows_go_compiler.patch, windows_go_compiler_v2.patch > > > Some of the mkdir and chmod stuff that the go compiler does is fine on mingw, > but doesn't work with Visual Studio. Adjusting the preprocessor guards makes > things work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2014) Change C++ lib includes to use style throughout
[ https://issues.apache.org/jira/browse/THRIFT-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2014. Resolution: Fixed > Change C++ lib includes to use style throughout > > > Key: THRIFT-2014 > URL: https://issues.apache.org/jira/browse/THRIFT-2014 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 1.0 > Environment: All >Reporter: Randy Abernethy >Assignee: Randy Abernethy >Priority: Minor > Fix For: 0.10.0 > > Attachments: 0004-Changed-C-lib-includes-to-use-namespace-form.patch > > > Use #include style include statements throughout C++ library (see > Exception below) > Rational: Improve consistency and predictability in C++ library and user > builds. Because Apache Thrift is a library, system style includes (<>) may be > a better fit than local style includes (“”). System style includes are > presently used predominantly (4:1) but not exclusively and the choice between > the two often appears to have no pattern. Making the library’s approach > consistent will improve build predictability (e.g local copies of > include files will not be picked up). Using explicit thrift relative paths > (i.e. namespaces like thrift/transport) also adds clarity and specificity > (e.g. two files with the same name can exist in separate directories and can > be included with obvious and predictable results, avoiding most path order > dependencies). The “” include is commonly designated as a user include (e.g. > gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html#Include-Syntax), the search > pattern for “” tends to vary from compiler to compiler a bit also. > bg: POSIX compliant compilers (and many others) search only –I directories > and then standard directories for system #include<> dependencies (good for > libraries). A local #include “” causes local directories (typically the > location of the including file) to be searched, then the –I, then built-in > paths. The POSIX spec is not adhered to by all platforms/compilers and more > complex behavior is common, making "" tricky on occasion. > Current situation: > 447 instances of e.g.: > lib/cpp/src/thrift/transport/TFileTransport.h:#include > > lib/cpp/src/thrift/transport/TTransportUtils.h:#include > > 116 instances of “file.h” e.g.: > lib/cpp/src/thrift/transport/TSocket.h:#include "TTransport.h" >//Same header with “” and <> styles in different files > lib/cpp/src/thrift/transport/TFileTransport.cpp:#include "TTransportUtils.h" >//Single file including thrift headers in different ways (“” and <>) > Exceptions: A header presented with local style (“”) delimiters is a hint > indicating that the header is designed to be locally defined or potentially > overloaded. The config.h header (associated with HAVE_CONFIG_H) may have this > “locally defined” semantic. The config.h is also included with <> and “” in > different locations. Assuming we want people to be able to locally override > config.h, #include “config.h” is the right answer. That said config.h is a > pretty generic name to be including with "config.h" safely. If only the > config.h in the thrift root should be allowed then may be > the right answer. Thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2022) CoB and dense code generation still uses TR1 bind, even though that doesn't work with clang
[ https://issues.apache.org/jira/browse/THRIFT-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2022. Resolution: Fixed > CoB and dense code generation still uses TR1 bind, even though that doesn't > work with clang > --- > > Key: THRIFT-2022 > URL: https://issues.apache.org/jira/browse/THRIFT-2022 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.9 >Reporter: Ben Craig > Fix For: 0.10.0 > > Attachments: tr1_purge.patch > > > Until recently, lots of Thrift stuff used std::tr1::function and > std::tr1::bind. Most stuff got retrofit to use apache::thrift::stdcxx > versions, but cob and dense code generation got missed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2895) Tutorial cpp
[ https://issues.apache.org/jira/browse/THRIFT-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2895. Resolution: Fixed > Tutorial cpp > > > Key: THRIFT-2895 > URL: https://issues.apache.org/jira/browse/THRIFT-2895 > Project: Thrift > Issue Type: Question > Components: C++ - Library > Environment: Windows 7_64bit > Visual Studio 2010 > cygwin64 >Reporter: saber hattay >Assignee: James E. King, III > Fix For: 0.10.0 > > Attachments: TutoCppMake.jpg > > > I cannot use the tutorial for CPP. > I tried to build the example with the command make but I have some issues > with BOOST link. > So, I tried to build it with Visual Studio directly, but I have some other > matter with unresolved external symbol. > By example with the class "Work" defined in the files "tutorial_types.cpp" > included in the folder gen-cpp. > I included this folder in my visual project. > Thank you in advance for any help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library
[ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2027. Resolution: Fixed > Minor 64-bit and NOMINMAX issues in C++ library > --- > > Key: THRIFT-2027 > URL: https://issues.apache.org/jira/browse/THRIFT-2027 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 > Environment: 64-bit. Windows without NOMINMAX set. >Reporter: Ben Craig >Assignee: Ben Craig >Priority: Minor > Fix For: 0.10.0 > > Attachments: misc_minor.patch > > > TNonblockingServer and THttpServer have size_t -> uint32_t truncations. > TZlibTransport calls std::min without enclosing it in parens. This is a > really minor issue, since we technically build with NOMINMAX in the > environment (which fixes the problem), but I have a strange personal goal of > being able to build without setting NOMINMAX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3411) Go generates remotes with wrong package qualifiers when including
[ https://issues.apache.org/jira/browse/THRIFT-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3411. Resolution: Fixed > Go generates remotes with wrong package qualifiers when including > - > > Key: THRIFT-3411 > URL: https://issues.apache.org/jira/browse/THRIFT-3411 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Affects Versions: 1.0 >Reporter: Eric Klaus >Assignee: Jens Geyer > Fix For: 0.10.0 > > > The Go Thrift compiler assumes that all service methods use only types from > the same namespace. If a service method uses a type from an included Thrift > file, the compiler still attempts to refer to the type using the calling > file's namespace. > *Steps to reproduce:* > 1. Create a new directory/project > 2. Copy the files in the gist to the directory > (https://gist.github.com/ericklaus-wf/d986c6ab00e03fa935e3) > 3. Generate Go code using Thrift > 4. Examine the gen-go/expanded/my_service-remote/my_service-remote.go file > 5. Line 133 refers to `expanded.NewBaseThing()` which does not exist. > Expected: > Line 133 should use `my_base.NewBaseThing` and an import for `my_base` should > be present. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1437) Update RPM spec
[ https://issues.apache.org/jira/browse/THRIFT-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1437. Resolution: Fixed > Update RPM spec > --- > > Key: THRIFT-1437 > URL: https://issues.apache.org/jira/browse/THRIFT-1437 > Project: Thrift > Issue Type: Improvement >Affects Versions: 1.0 >Reporter: Jake Farrell >Assignee: Jake Farrell > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2148) TNonblockingMultiFetchClient imports log4j
[ https://issues.apache.org/jira/browse/THRIFT-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2148. Resolution: Fixed > TNonblockingMultiFetchClient imports log4j > -- > > Key: THRIFT-2148 > URL: https://issues.apache.org/jira/browse/THRIFT-2148 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 1.0 >Reporter: Jake Farrell >Assignee: Jake Farrell > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2021) Improve large binary protocol string performance
[ https://issues.apache.org/jira/browse/THRIFT-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2021. Resolution: Fixed > Improve large binary protocol string performance > > > Key: THRIFT-2021 > URL: https://issues.apache.org/jira/browse/THRIFT-2021 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 0.9 >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: fast_binary_strings.patch > > > Currently, TBinaryProtocol reads into a temporary buffer, then copies the > results into the resulting std::string. For large strings (like a megabyte), > the copy can be a performance issue. > The attached patch reads directly into the std::string instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2424) Recursive Types
[ https://issues.apache.org/jira/browse/THRIFT-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2424. Resolution: Fixed > Recursive Types > --- > > Key: THRIFT-2424 > URL: https://issues.apache.org/jira/browse/THRIFT-2424 > Project: Thrift > Issue Type: Sub-task > Components: Build Process, C++ - Compiler, C++ - Library, Test Suite >Reporter: Roger Meier > Fix For: 0.10.0 > > > Recursive is a nice addon: > https://github.com/facebook/fbthrift/blob/master/thrift/test/Recursive.thrift -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-764) add Support for Vala language
[ https://issues.apache.org/jira/browse/THRIFT-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-764. --- Resolution: Fixed > add Support for Vala language > - > > Key: THRIFT-764 > URL: https://issues.apache.org/jira/browse/THRIFT-764 > Project: Thrift > Issue Type: New Feature >Affects Versions: 0.3 > Environment: Linux,Win32 >Reporter: david han >Assignee: Jake Farrell > Labels: fedora, vala, window > Fix For: 0.10.0 > > Original Estimate: 672h > Remaining Estimate: 672h > > [Vala|http://live.gnome.org/Vala] > * Vala is a new programming language that allows modern programming > techniques to be used to write applications that run on the GNOME runtime > libraries, particularly GLib and GObject. This platform has long provided a > very complete programming environment, with such features as a dynamic type > system and assisted memory management. > * Before Vala, the only ways to program for the platform were with the > machine native C API, which exposes a lot of often unwanted detail, with a > high level language that has an attendant virtual machine, such as Python or > the Mono C# language, or alternatively, with C++ through a wrapper library. > * The GNOME runtime contains GThread ,GIO, GModule, GLib and GObject > libraries , and these libraries are crossing platform such as Windows,Linux > and other platforms. > * The program writed by vala can compiled to C language based GLib library, > the can be used by the applications writed by C language. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined
[ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1751. Resolution: Fixed > definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is > not defined > -- > > Key: THRIFT-1751 > URL: https://issues.apache.org/jira/browse/THRIFT-1751 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9, 1.0 >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: TServer_guard2.patch > > > The definition of increase_max_fds uses struct rlimit, which is defined in > sys/resource.h. If sys/resource.h doesn't get included, you get a compiler > error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3322) CMake generated "make check" failes on python_test
[ https://issues.apache.org/jira/browse/THRIFT-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3322. Resolution: Fixed > CMake generated "make check" failes on python_test > -- > > Key: THRIFT-3322 > URL: https://issues.apache.org/jira/browse/THRIFT-3322 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.9.2 >Reporter: Claudius Heine >Assignee: Roger Meier >Priority: Minor > Fix For: 0.10.0 > > Attachments: > 0001-THRIFT-3322-Fix-python_test-when-generated-via-cmake.patch > > > The "python_test" case failes on the cmake generated test suite called via > "make check" or "ctest -R python_test". > Reason for this is that the code for the python types are not generated via > the thrift compiler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1776) TPipeServer should implement "listen", so that TServerEventHandler preServe will work right
[ https://issues.apache.org/jira/browse/THRIFT-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1776. Resolution: Fixed > TPipeServer should implement "listen", so that TServerEventHandler preServe > will work right > --- > > Key: THRIFT-1776 > URL: https://issues.apache.org/jira/browse/THRIFT-1776 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Environment: Windows >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > > Currently, TPipeServer's named pipe half "listens" and "accepts" in > acceptImpl. This means that TServerEventHandler's preServe() callback will > be fired before TPipeServer is really listening. > It shouldn't be too hard to fix this for named pipes, as there is already a > TCreateNamedPipe method. If that gets called in listen, it will probably fix > this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1351) Compiler does not care about binary strings
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1351. Resolution: Fixed > Compiler does not care about binary strings > --- > > Key: THRIFT-1351 > URL: https://issues.apache.org/jira/browse/THRIFT-1351 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Wade Simmons > Labels: compiler, node, nodejs > Fix For: 0.10.0 > > Attachments: 0001-read-binary-strings-with-readBinary-v2.patch, > 0001-read-binary-strings-with-readBinary.patch > > Original Estimate: 5m > Remaining Estimate: 5m > > The node.js lib has support for binary strings, but the compiler does not > check for it. > It's quite easily fixed: > https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee > With the fix node.js server implementations can operate on binary arguments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2989) Complete CMake build for Apache Thrift
[ https://issues.apache.org/jira/browse/THRIFT-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2989. Resolution: Fixed > Complete CMake build for Apache Thrift > -- > > Key: THRIFT-2989 > URL: https://issues.apache.org/jira/browse/THRIFT-2989 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Reporter: Henrique Mendonça > Labels: gsoc, gsoc2015, travis > Fix For: 0.10.0 > > > CMake is a strong fit for the complexity of the Apache Thrift project with > all its target languages and platforms. > CMake and CPack are already running for C++, C and Java but the support for > remaining language libraries is still to come. > The goal of this ticket is to hold all further patches and sub-tasks aiming > for a full integration and replacement of the current automake build by the > 1.0 release. > The current state can be followed on our continuous integration at > https://travis-ci.org/apache/thrift -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2024) TServer.cpp warns on 64-bit platforms about truncating an rlim_t into an int
[ https://issues.apache.org/jira/browse/THRIFT-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2024. Resolution: Fixed > TServer.cpp warns on 64-bit platforms about truncating an rlim_t into an int > > > Key: THRIFT-2024 > URL: https://issues.apache.org/jira/browse/THRIFT-2024 > Project: Thrift > Issue Type: Bug >Affects Versions: 0.9 > Environment: Linux 64, Mac 64 >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: TServer_rlim.patch > > > Thrift recently changed "increase_max_fds" to return an int instead of an > rlim_t. Now TServer.cpp warns when it converts the internal rlim_t to the > external int. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2020) Thrift library has some empty files that haven't really been deleted
[ https://issues.apache.org/jira/browse/THRIFT-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2020. Resolution: Fixed > Thrift library has some empty files that haven't really been deleted > > > Key: THRIFT-2020 > URL: https://issues.apache.org/jira/browse/THRIFT-2020 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: empty_file_purge.patch > > > A lot of windows specific files have been "removed" recently, but git clone > still creates empty versions of those files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2166) Delphi compiler should generate constant class name prefixed with thrift file name (similar to Java and C#)
[
https://issues.apache.org/jira/browse/THRIFT-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-2166.
Resolution: Fixed
> Delphi compiler should generate constant class name prefixed with thrift file
> name (similar to Java and C#)
> ---
>
> Key: THRIFT-2166
> URL: https://issues.apache.org/jira/browse/THRIFT-2166
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.10.0
>
> Attachments:
> THRIFT-2166_Delphi__constant_class_name_prefixed_with_file_name.patch
>
>
> Similar to Java and C#, the Delphi compiler should generate constant class
> name prefixed with thrift file Name:
> Example: {code}TIncludesTestConstants{code} instead of just
> {code}TConstants{code}.
> This makes it easier to distinguish between different constants when two or
> more generated Delphi units are used from the same source file without the
> need to add (possibly lengthy) prefixes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2149) Add an option to disable the generation of default operators
[ https://issues.apache.org/jira/browse/THRIFT-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2149. Resolution: Fixed > Add an option to disable the generation of default operators > > > Key: THRIFT-2149 > URL: https://issues.apache.org/jira/browse/THRIFT-2149 > Project: Thrift > Issue Type: Wish > Components: C++ - Compiler >Affects Versions: 0.9.1 > Environment: C++ >Reporter: Chris Stylianou > Labels: c++, compiler, thrift > Fix For: 0.10.0 > > Attachments: THRIFT-2149-no-default-operator.patch > > > Currently, the C++ generator automatically writes out the operators ==, != > and <. It would good to have an option to disable this generation if a user > wants to write their own specialised operators for these types in a source > file that sits by the side of the generated source, so that they do not get > overwritten when a thrift file needs to be altered and then regenerated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2031) Make SO_KEEPALIVE configurable for C++ lib
[ https://issues.apache.org/jira/browse/THRIFT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2031. Resolution: Fixed > Make SO_KEEPALIVE configurable for C++ lib > -- > > Key: THRIFT-2031 > URL: https://issues.apache.org/jira/browse/THRIFT-2031 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 0.9 > Environment: All >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: keep_alive3.patch > > > It's a socket option that we haven't made configurable yet, and sometimes you > need it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3473) When "optional' is used with a struct member, C++ server seems to not return it correctly
[
https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-3473.
Resolution: Fixed
> When "optional' is used with a struct member, C++ server seems to not return
> it correctly
> -
>
> Key: THRIFT-3473
> URL: https://issues.apache.org/jira/browse/THRIFT-3473
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Affects Versions: 0.9.3
> Environment: CentOS 7, GCC 4.8.3, Perl 5.16
>Reporter: YU Chang
>Assignee: Jens Geyer
> Fix For: 0.10.0
>
>
> Any "optional" modifier relates to a list will cause to a null/undef return
> value.
> Here is thrift file:
> {code:title=test.thrift|borderStyle=solid}
> namespace cpp thrifttest
> namespace perl thrifttest
> struct Pair {
> 1: optional string a,
> 2: optional string b
> }
> struct Result {
> 1: optional list strList,
> 2: optional list pairList
> }
> service Test {
> Result listTest()
> }
> {code}
> Here is C++ code (server):
> {code:title=Test_server.cpp|borderStyle=solid}
> #include "gen-cpp/Test.h"
> #include
> #include
> #include
> #include
> #include
> using namespace std;
> using namespace ::apache::thrift;
> using namespace ::apache::thrift::protocol;
> using namespace ::apache::thrift::transport;
> using namespace ::apache::thrift::server;
> using boost::shared_ptr;
> using namespace ::thrifttest;
> class TestHandler : virtual public TestIf {
> public:
> TestHandler() {
> // Your initialization goes here
> }
> void listTest(Result& _return) {
> _return.strList.push_back("Test");
> _return.strList.push_back("one level list");
> cout << "strList size: " << _return.strList.size() << endl;
> Pair pair;
> pair.a = "Test";
> pair.b = "two level list";
> _return.pairList.push_back(pair);
> cout << "pairList size: " << _return.pairList.size() << endl;
> printf("call listTest\n");
> }
> };
> int main(int argc, char **argv) {
> int port = 9595;
> shared_ptr handler(new TestHandler());
> shared_ptr processor(new TestProcessor(handler));
> shared_ptr serverTransport(new TServerSocket(port));
> shared_ptr transportFactory(new
> TBufferedTransportFactory());
> shared_ptr protocolFactory(new
> TBinaryProtocolFactory());
> TSimpleServer server(processor, serverTransport, transportFactory,
> protocolFactory);
> server.serve();
> return 0;
> }
> {code}
> Here is perl code (client):
> {code:title=Test_client.pl|borderStyle=solid}
> #!/usr/bin/perl
> use v5.12;
> use warnings;
> use autodie;
> use utf8;
> use Data::Dumper;
> use lib 'gen-perl';
> use thrifttest::Test;
> use thrifttest::Constants;
> use thrifttest::Types;
> use Thrift;
> use Thrift::BinaryProtocol;
> use Thrift::Socket;
> use Thrift::BufferedTransport;
> my $socket= new Thrift::Socket('localhost', 9595);
> my $transport = new Thrift::BufferedTransport($socket, 1024, 1024);
> my $protocol = new Thrift::BinaryProtocol($transport);
> my $client= new thrifttest::TestClient($protocol);
> eval {
> $transport->open();
> my $result = $client->listTest;
> say Dumper($result);
> $transport->close();
> };
> say $@ if $@;
> {code}
> {code:title=C++ server output|borderStyle=solid}
> strList size: 2
> pairList size: 1
> call listTest
> {code}
> {code:title=perl client output|borderStyle=solid}
> $VAR1 = bless( {
> 'pairList' => undef,
> 'strList' => undef
>}, 'thrifttest::Result' );
> {code}
> In this test case, every "optional" corresponding to a undef return value.
> Only If I delete all the "optional" in the thrift file, I will get right
> return value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2170) Generated Go code should populate all ReadErrors completely
[ https://issues.apache.org/jira/browse/THRIFT-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2170. Resolution: Fixed > Generated Go code should populate all ReadErrors completely > --- > > Key: THRIFT-2170 > URL: https://issues.apache.org/jira/browse/THRIFT-2170 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.10.0 > > Attachments: > THRIFT-2170_Generated_Go_code_should_populate_all_ReadErrors_completely.patch > > > The Read(iprot thrift.TProtocol) call for a struct is correctly returning an > error if ReadStructBegin() fails, however the real error message received > from the underlying protocol gets lost at that point. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3355) npm WARN package.json thrift@1.0.0-dev No license field.
[
https://issues.apache.org/jira/browse/THRIFT-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-3355.
Resolution: Fixed
> npm WARN package.json thrift@1.0.0-dev No license field.
>
>
> Key: THRIFT-3355
> URL: https://issues.apache.org/jira/browse/THRIFT-3355
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Environment: npm version 2.14.2
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments:
> 0001-THRIFT-3355-npm-WARN-package.json-thrift-1.0.0-dev-N.patch
>
>
> Using the environment above, I get
> {code}
> Making all in nodejs
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/haxe/lib/nodejs'
> /usr/bin/npm install --no-bin-links ../../
> npm WARN package.json thrift@1.0.0-dev No license field.
> {code}
> According to https://docs.npmjs.com/files/package.json the {{licenses:
> [...]}} array is deprecated and the {{license: "..."}} SPDX expression string
> field should be used instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-1533) Make TTransport should be Closeable
[
https://issues.apache.org/jira/browse/THRIFT-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1533.
Resolution: Fixed
> Make TTransport should be Closeable
> ---
>
> Key: THRIFT-1533
> URL: https://issues.apache.org/jira/browse/THRIFT-1533
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
>Affects Versions: 1.0
>Reporter: Yonatan Graber
>Assignee: Carl Yeksigian
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments: 1533.patch
>
>
> {{org.apache.thrift.transport.TTransport}} should implement the {{Closable}}
> interface. Doing so will allow users to perform
> {{IOUtils.closeQuietly(transport);}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2159) Serializer/Deserializer for Go
[ https://issues.apache.org/jira/browse/THRIFT-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2159. Resolution: Fixed > Serializer/Deserializer for Go > -- > > Key: THRIFT-2159 > URL: https://issues.apache.org/jira/browse/THRIFT-2159 > Project: Thrift > Issue Type: New Feature > Components: Go - Library >Affects Versions: 1.0 > Environment: Linux x64. Go v1.1.1 >Reporter: Justin Judd > Fix For: 0.10.0 > > Attachments: thrift_serialize_deserialize.patch > > > Java and Python provide means to serialize and deserialize Thrift structs. > (Java: http://techxample.blogspot.com/2011/12/thrift-serialization-and.html; > Python: http://wiki.apache.org/thrift/ThriftUsagePython and > https://github.com/flamholz/py-thrift-validation-example/blob/master/util/serialization.py) > This capability can be provided to -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-141) If a required field is not present on serialization, throw an exception
[ https://issues.apache.org/jira/browse/THRIFT-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-141. --- Resolution: Fixed > If a required field is not present on serialization, throw an exception > --- > > Key: THRIFT-141 > URL: https://issues.apache.org/jira/browse/THRIFT-141 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Affects Versions: 1.0 >Reporter: Bryan Duxbury >Assignee: Bryan Duxbury > Fix For: 0.10.0 > > > The desired behavior of the "required" keyword is to state that a given field > MUST be present in the serialized version of a record, or it will fail to > deserialize. If we are going to have such functionality, it makes sense for > us to also fail to serialize in the first place if a required field is > omitted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2519) "processor" class is not being generated
[
https://issues.apache.org/jira/browse/THRIFT-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-2519.
Resolution: Fixed
> "processor" class is not being generated
>
>
> Key: THRIFT-2519
> URL: https://issues.apache.org/jira/browse/THRIFT-2519
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
>Affects Versions: 1.0
> Environment: Ubuntu 12.04
>Reporter: brijraj singh
>Priority: Critical
> Fix For: 0.10.0
>
>
> I just started working with the github hosted build of apache thrift, I am
> basically interested in a java client and PHP server implementation, but for
> now i am using the php server and client only
> namespace php mobiledata
> struct sms
> {
> 1: string from,
> 2: string to,
> 3: string smstext,
> 4: string smsdatetime,
> 5: string smsdirection
> }
> struct smsdetails
> {
> 1: list smsdata
> }
> service mobiledataservice
> {
> void insertsmsdata (1: smsdetails smslist)
> }
> And I generated the gen-php folder, which has got Types.php and
> mobiledataservice.php
> the basic sample that comes with the github for php as server shows a line of
> code $handler = new CalculatorHandler(); $processor = new
> \tutorial\CalculatorProcessor($handler);
> I can't find this class "CalculatorProcessor" and certainly I don't have a
> comparative class generated in my gen_php like mobiledataprocessor, and it
> baffles me as to how I would run my server in absence of processor.
> I have been confirmed on stack overflow that its indeed a bug
> http://stackoverflow.com/questions/23514821/where-is-the-tutorial-processor-generated?noredirect=1#comment36072216_23514821
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-1811) ruby tutorial as part of the regular build
[ https://issues.apache.org/jira/browse/THRIFT-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1811. Resolution: Fixed > ruby tutorial as part of the regular build > -- > > Key: THRIFT-1811 > URL: https://issues.apache.org/jira/browse/THRIFT-1811 > Project: Thrift > Issue Type: Sub-task > Components: Ruby - Compiler, Ruby - Library, Tutorial >Reporter: Roger Meier >Assignee: Roger Meier > Fix For: 0.10.0 > > Attachments: > 0001-THRIFT-1735-integrate-tutorial-into-regular-build.patch > > > ruby tutorial as part of the regular build via configure.ac & co > see tutorial/java as an example -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-1801) Sync up TApplicationException codes across languages and thrift implementations
[ https://issues.apache.org/jira/browse/THRIFT-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1801. Resolution: Fixed > Sync up TApplicationException codes across languages and thrift > implementations > --- > > Key: THRIFT-1801 > URL: https://issues.apache.org/jira/browse/THRIFT-1801 > Project: Thrift > Issue Type: Task >Affects Versions: 1.0 > Environment: all >Reporter: Andrew Cox >Assignee: Andrew Cox > Fix For: 0.10.0 > > Attachments: THRIFT-1801.1.patch > > > Two issues with TApplicationException codes: > 1) some languages contained incomplete lists of existing > TApplicationException codes > 2) internally in Facebook thrift servers, we had reserved a few extra error > codes for TApplicationException, and those error codes were then claimed here > for different uses. this causes conflicts when some clients that know about > one set of codes communicates with servers that know about a different set of > codes. I've reassigned our internal error code numbers to make space for the > ones in more recent thrift code, but to try prevent this from happening > again, I'd like to add our own codes to reserve them (these currently won't > have any other mention in the thrift libraries right now than being in > TApplicationException, but they may eventually be used when we push more of > this internal code out). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2093) added the ability to set compression level in C++ zlib transport
[ https://issues.apache.org/jira/browse/THRIFT-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2093. Resolution: Fixed > added the ability to set compression level in C++ zlib transport > > > Key: THRIFT-2093 > URL: https://issues.apache.org/jira/browse/THRIFT-2093 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 1.0 > Environment: All >Reporter: Randy Abernethy >Assignee: Randy Abernethy >Priority: Minor > Fix For: 0.10.0 > > Attachments: > 0002-added-the-ability-to-set-compression-level-in-zlib-t.patch > > > Currently the C++ TZlibTransport hard wires the compression level to default > (6). The attached patch allows the compression level (0-9) to be set at > construction. > N.B. This patch removes a TZlibTransport constructor signature which has been > unimplemented and private since 2010. The sig was left in the code to > generate compiler errors if used, however it causes ambiguity with the sole > operable constructor and was removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3321) Thrift can't be added as a subdirectory of another CMake-based project
[
https://issues.apache.org/jira/browse/THRIFT-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-3321.
Resolution: Fixed
> Thrift can't be added as a subdirectory of another CMake-based project
> --
>
> Key: THRIFT-3321
> URL: https://issues.apache.org/jira/browse/THRIFT-3321
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Reporter: Frane Šarić
>Assignee: Roger Meier
>Priority: Minor
> Labels: cmake
> Fix For: 0.10.0
>
> Attachments: fix_cpackconfig.patch
>
>
> I wanted my CMake-based project to build thrift as a dependency, so I added
> the following to my CMakeLists.txt:
> {code}
> set(BUILD_COMPILER OFF CACHE BOOL "")
> set(BUILD_TESTING OFF CACHE BOOL "")
> set(BUILD_EXAMPLES OFF CACHE BOOL "")
> set(BUILD_TUTORIALS OFF CACHE BOOL "")
> set(BUILD_LIBRARIES ON CACHE BOOL "")
> set(BUILD_C_GLIB OFF CACHE BOOL "")
> set(BUILD_JAVA OFF CACHE BOOL "")
> set(BUILD_PYTHON OFF CACHE BOOL "")
> add_subdirectory(thrift)
> {code}
> The build process fails because {{build/cmake/CPackConfig.cmake}} fails to
> find {{README.md}} and {{LICENSE}} files. It fails to find them because it
> uses {{CMAKE_SOURCE_DIR}} instead of {{CMAKE_CURRENT_SOURCE_DIR}}. After
> changing {{CMAKE_SOURCE_DIR}} to {{CMAKE_CURRENT_SOURCE_DIR}} everything
> works as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2089) Compiler ignores duplicate typenames
[
https://issues.apache.org/jira/browse/THRIFT-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-2089.
Resolution: Fixed
> Compiler ignores duplicate typenames
>
>
> Key: THRIFT-2089
> URL: https://issues.apache.org/jira/browse/THRIFT-2089
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 1.0
> Environment: all
>Reporter: Randy Abernethy
>Assignee: Randy Abernethy
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments: 0001-added-compiler-duplicate-typename-checking.patch
>
>
> The current IDL compiler will compile the following IDL with no warnings or
> errors:
> {code:title=test.thrift|borderStyle=solid}
> struct A { 1: i16 a }
> struct A { 1: i16 a }
> {code}
> and this (w/ thrift -r):
> {code:title=test2.thrift|borderStyle=solid}
> include "test.thrift"
> struct A { 1: i16 a }
> {code}
> Both of these IDLs generate un-compilable output in most languages.
> The attached patch adds typename collision checking to the compiler. It
> generates errors when a typename is declared twice in the same file or when
> the same typename is declared in two files causing collisions in all
> namespace scopes. Explicit namespace declarations with collisions in some but
> not all scopes are reported as warning because the user could compile for a
> scope that would succeed. More details in the patch comments.
> Built and tested on Windows with VS2012 and Unbuntu w/ gcc 4.7.2
> make check ran on Unbuntu clean (though I had to switch the config.h to
> thrift/thrift-config.h in TFileTransportTest.cpp)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-1735) integrate tutorial into regular build
[ https://issues.apache.org/jira/browse/THRIFT-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1735. Resolution: Fixed > integrate tutorial into regular build > - > > Key: THRIFT-1735 > URL: https://issues.apache.org/jira/browse/THRIFT-1735 > Project: Thrift > Issue Type: Improvement >Reporter: Roger Meier >Assignee: Roger Meier > Fix For: 0.10.0 > > Attachments: THRIFT-1735_python_tutorial.patch, > THRIFT-1735_tutorial.patch, THRIFT-1735_tutorial_build_improvement_cpp.patch > > > I would like to have tutorial built via regular build: > - proof build > - simplify "get started" for new users -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2056) Moved all #include config.h statements to #include
[ https://issues.apache.org/jira/browse/THRIFT-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2056. Resolution: Fixed > Moved all #include config.h statements to #include > > > Key: THRIFT-2056 > URL: https://issues.apache.org/jira/browse/THRIFT-2056 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 1.0 > Environment: All >Reporter: Randy Abernethy >Assignee: Randy Abernethy >Priority: Minor > Fix For: 0.10.0 > > Attachments: > 0006-Replace-all-config.h-includes-with-include-thrift-co.patch > > > This is a follow on to THRIFT-2014. > Everything in the C++ lib is #include except the config.h. The > attached patch changes all config.h includes to #include . > This patch also creates a default thrift/config.h which is empty except for a > _WIN32 guarded include of thrift/windows/config.h. This will be overwritten > by configure/make/make install on *nix but will allow Windows users to just > copy the tree and go. > TODO: > - > I have not addressed the HAVE_CONFIG guards yet. By providing an empty > config.h I can't see a scenario where HAVE_CONFIG is needed. Unless anyone > can see a reason to leave HAVE_CONFIG around I will remove the guard globally > in a new patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2023) gettimeofday implementation on Windows errors when no time zone is passed in.
[ https://issues.apache.org/jira/browse/THRIFT-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2023. Resolution: Fixed > gettimeofday implementation on Windows errors when no time zone is passed in. > - > > Key: THRIFT-2023 > URL: https://issues.apache.org/jira/browse/THRIFT-2023 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9 > Environment: Windows >Reporter: Ben Craig >Assignee: Ben Craig > Fix For: 0.10.0 > > Attachments: win_gettimeofday.patch > > > Some of the Thrift tests use gettimeofday passing NULL as the second > argument. In those situations, the Windows implmentation returns -1, and > causes the tests to freak out. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3354) Fix word-extraction substr bug in initialism code
[
https://issues.apache.org/jira/browse/THRIFT-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-3354.
Resolution: Fixed
> Fix word-extraction substr bug in initialism code
> -
>
> Key: THRIFT-3354
> URL: https://issues.apache.org/jira/browse/THRIFT-3354
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.3
>Reporter: Jens Geyer
>Assignee: Prashant V
> Fix For: 0.10.0
>
>
> GitHub user prashantv opened a pull request:
> https://github.com/apache/thrift/pull/625
> Fix word-extraction substr bug in initialism code
> Initialisms were not handled in the second word or later. E.g. for the
> given Thrift file,
> ```thrift
> service S {
> void get_id()
> }
> ```
>
> The generated code was using `GetIdArgs` instead of `GetIDArgs`. This was
> happening because fix_common_initialism was passing the position of the
> underscore to substr when extracting the word, when substr expects a length.
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/prashantv/thrift initialism_fix
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/625.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #625
>
>
> commit 7df89525116a456b25fff2c903078fece4cb6a2a
> Author: Prashant Varanasi
> Date: 2015-09-24T22:06:47Z
> Fix word-extraction substr bug in initialism code
>
> Initialisms were not handled in the second word or later.
>
> fix_common_initialism was passing the position of the underscore to
> substr when extracting the word, when substr expects a length.
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2163) incorrect Delphi code generated for typedef'ed constants
[
https://issues.apache.org/jira/browse/THRIFT-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-2163.
Resolution: Fixed
> incorrect Delphi code generated for typedef'ed constants
>
>
> Key: THRIFT-2163
> URL: https://issues.apache.org/jira/browse/THRIFT-2163
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.10.0
>
> Attachments:
> THRIFT-2163_incorrect_code_for_typedefed_container_constants.patch
>
>
> The following IDL
> {code}
> typedef map MapType
> const ThriftTest.MapType MAPCONSTANT = {'hello':{}, 'goodnight':{}}
> {code}
> creates uncompileable code at FMAPCONSTANT, because TMapType is a reference
> to an interface type, not the implementing class type:
> {code}
> class constructor TConstants.Create;
> begin
> FMAPCONSTANT := TMapType.Create;
> end;
> {code}
> Expected code would be
> {code}
> class constructor TConstants.Create;
> begin
> FMAPCONSTANT := TThriftDictionaryImpl.Create;
> FMAPCONSTANT.Add( 'hello', TBonkImpl.Create);
> FMAPCONSTANT.Add( 'goodnight', TBonkImpl.Create);
> end;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (THRIFT-2342) Add __FILE__ and __LINE__ to Thrift C++ excpetions
[ https://issues.apache.org/jira/browse/THRIFT-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2342. Resolution: Fixed > Add __FILE__ and __LINE__ to Thrift C++ excpetions > -- > > Key: THRIFT-2342 > URL: https://issues.apache.org/jira/browse/THRIFT-2342 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler, C++ - Library >Reporter: George Godik >Assignee: James E. King, III >Priority: Minor > Labels: newbie > Fix For: 0.10.0 > > > Thrift exceptions are somewhat difficult to trace from debug logs. I'd like > to add __FILE__AND__LINE__ as a second parameter to some exceptions to make > them easier to find. > For example: > Every time a required field is not set, the exception that gets generated is > a very generic > throw TProtocolException(TProtocolException::INVALID_DATA) > see - > https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372 > I think I'll start with patching up TProtocolExcpetion in the compiler and if > people like this I can make a separate issue and patch for other exceptions -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-3443) Thrift include can generate uncompilable code
[ https://issues.apache.org/jira/browse/THRIFT-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-3443. Resolution: Fixed > Thrift include can generate uncompilable code > - > > Key: THRIFT-3443 > URL: https://issues.apache.org/jira/browse/THRIFT-3443 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Minor > Fix For: 0.10.0 > > > Go Tutorial does not seem to compile due to this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3775) 0.10.0 release candidate
Jake Farrell created THRIFT-3775: Summary: 0.10.0 release candidate Key: THRIFT-3775 URL: https://issues.apache.org/jira/browse/THRIFT-3775 Project: Thrift Issue Type: Bug Components: Build Process Reporter: Jake Farrell Assignee: Jake Farrell -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3672) client blocked when remote call
[
https://issues.apache.org/jira/browse/THRIFT-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-3672:
-
Component/s: Compiler (General)
> client blocked when remote call
>
>
> Key: THRIFT-3672
> URL: https://issues.apache.org/jira/browse/THRIFT-3672
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Affects Versions: 0.9.3
>Reporter: jackyfang
>
> this is is the thrift file:
> {code}
> include 'shared.thrift'
> include "pos.thrift"
> include "notice.thrift"
> namespace py syncs.sync
> namespace java syncs.sync
> const string SERVICENAMESPACE = 'sync'
> typedef i32 int
> struct Product{
> 1: string code,
> 2: string name,
> 3: string categoryName,
> 4: optional double price_sell,
> 5: optional double price_buy
> }
> struct OrderItem{
> 1: string productCode,
> 2: double price,
> 3: double multiply,
> 4: double amount,
> 5: double discount
> }
> struct Order{
> 1: string id,
> 2: list items,
> 3: double amount,
> 4: double actualAmount,
> }
> struct StockCurrentBase{
> 1: string productCode,
> 2: int version,
> }
> struct StockCurrent{
> 1: StockCurrentBase stockBase,
> 2: optional double multiply,
> 3: optional Product product
> }
> service SyncService{
> bool postProducts(1: shared.PosContext posContext, 2: list
> products),
> bool postOrders(1: shared.PosContext posContext, 2: list orders),
> list pullOrders(1: shared.PosContext posContext),
> list syncStocks(1: shared.PosContext posContext, 2:
> list clientStocks)
> }
> {code}
> bug resolve:
> when i change the block:
> {code}
> struct StockCurrent{
> 1: StockCurrentBase stockBase,
> 2: optional double multiply,
> 3: optional Product product
> }
> {code}
> to :
> {code}
> struct StockCurrent{
> 1: StockCurrentBase stockBase,
> 2: optional double multiply,
>
> }
> {code}
> everything works ok!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3773) Swift Library
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3773: - Component/s: Swift - Library > Swift Library > - > > Key: THRIFT-3773 > URL: https://issues.apache.org/jira/browse/THRIFT-3773 > Project: Thrift > Issue Type: New Feature > Components: Swift - Library >Reporter: Thomas Bartelmess > > We already have the option to generate Swift code in the Cocoa compiler, > however large parts of the (Objective-C) Cocoa Library still depend on Cocoa > and Objective-C. > It would be good to have a native Swift library that doesn't depend on the > Cocoa libraries. > Design goals: > - Fully compatible with the code that is currently generated by the Cocoa > compiler (both Objective-C and Swift). > - Ability to run on Linux > - Pure Swift, no Objective-C code. > - No dependencies on closed source apple libraries > - Keep the same interface, so that the library is compatible with the code > the current cocoa compiler generates > - Better server support that the current Objective-C library. > - Follow the new Swift packaging format to be compatible with the Swift > Package manager -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3607) Unify exception handling policy of TProcessor
[ https://issues.apache.org/jira/browse/THRIFT-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3607: - Component/s: Wish List > Unify exception handling policy of TProcessor > - > > Key: THRIFT-3607 > URL: https://issues.apache.org/jira/browse/THRIFT-3607 > Project: Thrift > Issue Type: Improvement > Components: Wish List >Reporter: Aki Sukegawa > > A discussion in THRIFT-1805 uncovered inconsistent error handling behaviors > of TProcessors across languages and releases. > Most outstanding are Java sync and async processors as described there, but > others are also subtly different in details. > I propose unifying the TProcessor behavior by specifying mappings from > "uncaught server handler exceptions" to "observable server behaviors" as > follows: > * TApplicationException -> send TApplicationException with the message and > the type as thrown > * TTransportException -> the connection is either already broken or newly > broken > * other exceptions -> send opaque TApplicationException(INTERNAL_ERROR) > That way users can still arbitrarily disconnect the client by throwing > TTransportException. > (IMO ideally this should have been done by exposing "client context" object > to the handler instead) > The first one can be a bit controversial as it can be regarded as information > leak. > Also some may prefer unifying the TProcessor behavior to catch-all, so that > servers never die on handler exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3530) Introduce string and container length limit to more languages
[ https://issues.apache.org/jira/browse/THRIFT-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3530: - Component/s: Wish List > Introduce string and container length limit to more languages > - > > Key: THRIFT-3530 > URL: https://issues.apache.org/jira/browse/THRIFT-3530 > Project: Thrift > Issue Type: Improvement > Components: Wish List >Reporter: Aki Sukegawa > > THRIFT-2572 ported C++ string and container read length limit to Java. > This is very useful feature especially for servers that protects them from > malicious or garbled input. > Currently, only binary and compact have this but JSON and for some reason > THeader do not. > I'm not aware of any language other than C++ and Java that already possesses > this feature. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3539) Use self.process_* instead of Processor.process_* in generated processor code
[
https://issues.apache.org/jira/browse/THRIFT-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-3539:
-
Component/s: Python - Library
> Use self.process_* instead of Processor.process_* in generated processor code
> -
>
> Key: THRIFT-3539
> URL: https://issues.apache.org/jira/browse/THRIFT-3539
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Reporter: Thomas Bartelmess
>
> In our codebase we ended up overriding the process_* handlers because we had
> some special requirements, how exceptions are handled.
> in the __init__ function of processor the self._processMap refers to all the
> process_* functions on the Processor class.
> {code}
> def __init__(self):
> self._processMap = {}
> self._processMap = Processor.process_foo
> {code}
> The processor should refer to the functions using self, so when they are
> overridden in the subclass, the subclass implementation is used.
> {code}
> def __init__(self):
> self._processMap = {}
> self._processMap = self.process_foo
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3637) Implement compact protocol for dart
[ https://issues.apache.org/jira/browse/THRIFT-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3637: - Component/s: Dart - Library > Implement compact protocol for dart > --- > > Key: THRIFT-3637 > URL: https://issues.apache.org/jira/browse/THRIFT-3637 > Project: Thrift > Issue Type: Improvement > Components: Dart - Library >Reporter: Brian Shannan > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3635) D transport_test is flaky on Jenkins and Travis
[ https://issues.apache.org/jira/browse/THRIFT-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-3635: - Component/s: Test Suite D - Library > D transport_test is flaky on Jenkins and Travis > --- > > Key: THRIFT-3635 > URL: https://issues.apache.org/jira/browse/THRIFT-3635 > Project: Thrift > Issue Type: Bug > Components: D - Library, Test Suite >Reporter: Aki Sukegawa > > e.g. > https://builds.apache.org/me/my-views/view/Thrift/job/Thrift-precommit/150/console > It's currently the one of 2 most flaky tests. > (The other is THRIFT-3577) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
