[jira] [Commented] (TINKERPOP-1313) Rename RangeByIsCountStrategy
[ https://issues.apache.org/jira/browse/TINKERPOP-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968116#comment-15968116 ] ASF GitHub Bot commented on TINKERPOP-1313: --- GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/602 TINKERPOP-1313 Rename RangeByIsCountStrategy https://issues.apache.org/jira/browse/TINKERPOP-1313 Renamed `RangeByIsCountStrategy` to `CountStrategy`. `docker/build.sh -t -i -n` succeeded. VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1313 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/602.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #602 commit f08d44fc5c8649658fd775289f0a49ec1816306d Author: Daniel Kuppitz Date: 2017-04-13T19:21:36Z Renamed `RangeByIsCountStrategy` to `CountStrategy`. > Rename RangeByIsCountStrategy > - > > Key: TINKERPOP-1313 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1313 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.0-incubating >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz > Labels: breaking > Fix For: 3.3.0 > > > Rename to {{CountStrategy}}. The reason for this is described in > [TINKERPOP-1312|https://issues.apache.org/jira/browse/TINKERPOP-1312]. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop pull request #602: TINKERPOP-1313 Rename RangeByIsCountStrategy
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/602 TINKERPOP-1313 Rename RangeByIsCountStrategy https://issues.apache.org/jira/browse/TINKERPOP-1313 Renamed `RangeByIsCountStrategy` to `CountStrategy`. `docker/build.sh -t -i -n` succeeded. VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1313 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/602.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #602 commit f08d44fc5c8649658fd775289f0a49ec1816306d Author: Daniel Kuppitz Date: 2017-04-13T19:21:36Z Renamed `RangeByIsCountStrategy` to `CountStrategy`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Very rare indeed. Maybe we should just add a tiny note (and/or an example) in the repeat steps docs. ``` g.V().repeat(out().sideEffect {println it.loops()}).iterate() // don't try this at home g.withoutStrategies(RepeatUnrollStrategy).V().repeat(out().sideEffect {println it.loops()}).iterate() // cool ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1668) RepeatUnrollStrategy should not execute if there is a LoopStep used.
[ https://issues.apache.org/jira/browse/TINKERPOP-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968063#comment-15968063 ] ASF GitHub Bot commented on TINKERPOP-1668: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Very rare indeed. Maybe we should just add a tiny note (and/or an example) in the repeat steps docs. ``` g.V().repeat(out().sideEffect {println it.loops()}).iterate() // don't try this at home g.withoutStrategies(RepeatUnrollStrategy).V().repeat(out().sideEffect {println it.loops()}).iterate() // cool ``` > RepeatUnrollStrategy should not execute if there is a LoopStep used. > > > Key: TINKERPOP-1668 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1668 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Marko A. Rodriguez >Assignee: Marko A. Rodriguez > > BAD. > {code} > gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).times(31).cap('m') > ==>[0:31] > {code} > GOOD > {code} > gremlin> > g.V(0L).repeat(groupCount('m').by(loops()).out()).until(loops().is(31)).cap('m') > ==>[0:1,1:1,2:1,3:1,4:1,5:1,6:1,7:1,8:1,9:1,10:1,11:1,12:1,13:1,14:1,15:1,16:1,17:1,18:1,19:1,20:1,21:1,22:1,23:1,24:1,25:1,26:1,27:1,28:1,29:1,30:1] > g > {code} > If {{LoopStep}} is used, make sure {{RepeatUnrollStrategy}} doesn't execute > as the loops are linearized. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1668) RepeatUnrollStrategy should not execute if there is a LoopStep used.
[ https://issues.apache.org/jira/browse/TINKERPOP-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967985#comment-15967985 ] ASF GitHub Bot commented on TINKERPOP-1668: --- Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/601 Yes, and I decided not to include that given that its rare and the only way to test would be to look for a `LambdaHolder` which would then make the strategy not apply to lots of other situations. I can add that break out of if you think its worth it. > RepeatUnrollStrategy should not execute if there is a LoopStep used. > > > Key: TINKERPOP-1668 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1668 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Marko A. Rodriguez >Assignee: Marko A. Rodriguez > > BAD. > {code} > gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).times(31).cap('m') > ==>[0:31] > {code} > GOOD > {code} > gremlin> > g.V(0L).repeat(groupCount('m').by(loops()).out()).until(loops().is(31)).cap('m') > ==>[0:1,1:1,2:1,3:1,4:1,5:1,6:1,7:1,8:1,9:1,10:1,11:1,12:1,13:1,14:1,15:1,16:1,17:1,18:1,19:1,20:1,21:1,22:1,23:1,24:1,25:1,26:1,27:1,28:1,29:1,30:1] > g > {code} > If {{LoopStep}} is used, make sure {{RepeatUnrollStrategy}} doesn't execute > as the loops are linearized. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/601 Yes, and I decided not to include that given that its rare and the only way to test would be to look for a `LambdaHolder` which would then make the strategy not apply to lots of other situations. I can add that break out of if you think its worth it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1668) RepeatUnrollStrategy should not execute if there is a LoopStep used.
[ https://issues.apache.org/jira/browse/TINKERPOP-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967958#comment-15967958 ] ASF GitHub Bot commented on TINKERPOP-1668: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Lambda steps could do something with `it.loops()` and thus should have the same effect. > RepeatUnrollStrategy should not execute if there is a LoopStep used. > > > Key: TINKERPOP-1668 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1668 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Marko A. Rodriguez >Assignee: Marko A. Rodriguez > > BAD. > {code} > gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).times(31).cap('m') > ==>[0:31] > {code} > GOOD > {code} > gremlin> > g.V(0L).repeat(groupCount('m').by(loops()).out()).until(loops().is(31)).cap('m') > ==>[0:1,1:1,2:1,3:1,4:1,5:1,6:1,7:1,8:1,9:1,10:1,11:1,12:1,13:1,14:1,15:1,16:1,17:1,18:1,19:1,20:1,21:1,22:1,23:1,24:1,25:1,26:1,27:1,28:1,29:1,30:1] > g > {code} > If {{LoopStep}} is used, make sure {{RepeatUnrollStrategy}} doesn't execute > as the loops are linearized. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/601 Lambda steps could do something with `it.loops()` and thus should have the same effect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1668) RepeatUnrollStrategy should not execute if there is a LoopStep used.
[ https://issues.apache.org/jira/browse/TINKERPOP-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967878#comment-15967878 ] ASF GitHub Bot commented on TINKERPOP-1668: --- GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/601 TINKERPOP-1668: RepeatUnrollStrategy should not execute if there is a LoopStep used. https://issues.apache.org/jira/browse/TINKERPOP-1668 If the child traversal of `RepeatStep` has a `LoopsStep`, then `RepeatUnrollStrategy` should not be allowed as it the loops will have been linearized and thus, never incremented. Added test case to verify expected working behavior. VOTE +1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/601.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #601 commit e033e3c6f8132d0b461a75e479ceea8f8b4b9ca8 Author: Marko A. Rodriguez Date: 2017-04-13T16:54:29Z Fixed a bug in where should invalidate the strategy's application. commit 710bcdba20b65ad33aa4af4b0792cabae9c9e1c8 Author: Marko A. Rodriguez Date: 2017-04-13T16:56:54Z got rid of unneeded imports. > RepeatUnrollStrategy should not execute if there is a LoopStep used. > > > Key: TINKERPOP-1668 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1668 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Marko A. Rodriguez >Assignee: Marko A. Rodriguez > > BAD. > {code} > gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).times(31).cap('m') > ==>[0:31] > {code} > GOOD > {code} > gremlin> > g.V(0L).repeat(groupCount('m').by(loops()).out()).until(loops().is(31)).cap('m') > ==>[0:1,1:1,2:1,3:1,4:1,5:1,6:1,7:1,8:1,9:1,10:1,11:1,12:1,13:1,14:1,15:1,16:1,17:1,18:1,19:1,20:1,21:1,22:1,23:1,24:1,25:1,26:1,27:1,28:1,29:1,30:1] > g > {code} > If {{LoopStep}} is used, make sure {{RepeatUnrollStrategy}} doesn't execute > as the loops are linearized. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop pull request #601: TINKERPOP-1668: RepeatUnrollStrategy should not...
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/601 TINKERPOP-1668: RepeatUnrollStrategy should not execute if there is a LoopStep used. https://issues.apache.org/jira/browse/TINKERPOP-1668 If the child traversal of `RepeatStep` has a `LoopsStep`, then `RepeatUnrollStrategy` should not be allowed as it the loops will have been linearized and thus, never incremented. Added test case to verify expected working behavior. VOTE +1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/601.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #601 commit e033e3c6f8132d0b461a75e479ceea8f8b4b9ca8 Author: Marko A. Rodriguez Date: 2017-04-13T16:54:29Z Fixed a bug in where should invalidate the strategy's application. commit 710bcdba20b65ad33aa4af4b0792cabae9c9e1c8 Author: Marko A. Rodriguez Date: 2017-04-13T16:56:54Z got rid of unneeded imports. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (TINKERPOP-1668) RepeatUnrollStrategy should not execute if there is a LoopStep used.
Marko A. Rodriguez created TINKERPOP-1668: - Summary: RepeatUnrollStrategy should not execute if there is a LoopStep used. Key: TINKERPOP-1668 URL: https://issues.apache.org/jira/browse/TINKERPOP-1668 Project: TinkerPop Issue Type: Bug Components: process Affects Versions: 3.2.4 Reporter: Marko A. Rodriguez Assignee: Marko A. Rodriguez BAD. {code} gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).times(31).cap('m') ==>[0:31] {code} GOOD {code} gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).until(loops().is(31)).cap('m') ==>[0:1,1:1,2:1,3:1,4:1,5:1,6:1,7:1,8:1,9:1,10:1,11:1,12:1,13:1,14:1,15:1,16:1,17:1,18:1,19:1,20:1,21:1,22:1,23:1,24:1,25:1,26:1,27:1,28:1,29:1,30:1] g {code} If {{LoopStep}} is used, make sure {{RepeatUnrollStrategy}} doesn't execute as the loops are linearized. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967745#comment-15967745 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/569 Feel free to merge this PR @pluradj. The @spmallette bot is currently being rebooted / is on vacation ;). > Consider GraphManager as an interface > - > > Key: TINKERPOP-1438 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1438 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.2 >Reporter: stephen mallette >Priority: Minor > Labels: breaking > > If {{GraphManager}} were an interface it would make embedding Gremlin Server > easier as {{Graph}} instances could be more easily supplied by the host > application. In doing this, It also might be good to force a > {{TraversalSource}} to be referred to by both the {{Graph}} name and > {{TraversalSource}} name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/569 Feel free to merge this PR @pluradj. The @spmallette bot is currently being rebooted / is on vacation ;). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (TINKERPOP-1667) Inconsistent number comparison with Contains
[ https://issues.apache.org/jira/browse/TINKERPOP-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad resolved TINKERPOP-1667. - Resolution: Duplicate > Inconsistent number comparison with Contains > > > Key: TINKERPOP-1667 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1667 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Jason Plurad >Priority: Minor > > Steps to recreate: > {noformat} > gremlin> conf = new BaseConfiguration() > ==>org.apache.commons.configuration.BaseConfiguration@7048535f > gremlin> conf.setProperty("gremlin.tinkergraph.vertexIdManager","LONG") > ==>null > gremlin> conf.setProperty("gremlin.tinkergraph.edgeIdManager","LONG") > ==>null > gremlin> graph = TinkerGraph.open(conf) > ==>tinkergraph[vertices:0 edges:0] > gremlin> graph.io(gryo()).readGraph('data/tinkerpop-modern.kryo') > ==>null > gremlin> g = graph.traversal() > ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] > gremlin> g.V().hasId(within(1..6)).out().hasId(within(1..6)) > gremlin> g.V().hasId(within(1..6)).out().hasId(between(0,7)) > ==>v[3] > ==>v[2] > ==>v[4] > ==>v[5] > ==>v[3] > ==>v[3] > {noformat} > `P.within` and `P.without` rely on `Collection.contains()` which ends up > doing an Object type comparison during the equality check. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (TINKERPOP-1667) Inconsistent number comparison with Contains
[ https://issues.apache.org/jira/browse/TINKERPOP-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad closed TINKERPOP-1667. --- > Inconsistent number comparison with Contains > > > Key: TINKERPOP-1667 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1667 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Jason Plurad >Priority: Minor > > Steps to recreate: > {noformat} > gremlin> conf = new BaseConfiguration() > ==>org.apache.commons.configuration.BaseConfiguration@7048535f > gremlin> conf.setProperty("gremlin.tinkergraph.vertexIdManager","LONG") > ==>null > gremlin> conf.setProperty("gremlin.tinkergraph.edgeIdManager","LONG") > ==>null > gremlin> graph = TinkerGraph.open(conf) > ==>tinkergraph[vertices:0 edges:0] > gremlin> graph.io(gryo()).readGraph('data/tinkerpop-modern.kryo') > ==>null > gremlin> g = graph.traversal() > ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] > gremlin> g.V().hasId(within(1..6)).out().hasId(within(1..6)) > gremlin> g.V().hasId(within(1..6)).out().hasId(between(0,7)) > ==>v[3] > ==>v[2] > ==>v[4] > ==>v[5] > ==>v[3] > ==>v[3] > {noformat} > `P.within` and `P.without` rely on `Collection.contains()` which ends up > doing an Object type comparison during the equality check. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (TINKERPOP-1048) Vertex lookups by id are inconsistent
[ https://issues.apache.org/jira/browse/TINKERPOP-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Plurad updated TINKERPOP-1048: Description: {{graph.vertices(id)}}, {{g.V(id)}} and {{g.V().hasId(id)}} should all return the same result. However, currently only the latter respects the {{toString()}} representation of ids. {noformat} gremlin> g.addV().id() ==>12 gremlin> graph.vertices("12") gremlin> g.V("12") gremlin> g.V().hasId("12") ==>v[12] {noformat} Inconsistent number comparison with Contains: {noformat} gremlin> conf = new BaseConfiguration() ==>org.apache.commons.configuration.BaseConfiguration@7048535f gremlin> conf.setProperty("gremlin.tinkergraph.vertexIdManager","LONG") ==>null gremlin> conf.setProperty("gremlin.tinkergraph.edgeIdManager","LONG") ==>null gremlin> graph = TinkerGraph.open(conf) ==>tinkergraph[vertices:0 edges:0] gremlin> graph.io(gryo()).readGraph('data/tinkerpop-modern.kryo') ==>null gremlin> g = graph.traversal() ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] gremlin> g.V().hasId(within(1..6)).out().hasId(within(1..6)) gremlin> g.V().hasId(within(1..6)).out().hasId(between(0,7)) ==>v[3] ==>v[2] ==>v[4] ==>v[5] ==>v[3] ==>v[3] {noformat} `P.within` and `P.without` rely on `Collection.contains()` which ends up doing an Object type comparison during the equality check. was: {{graph.vertices(id)}}, {{g.V(id)}} and {{g.V().hasId(id)}} should all return the same result. However, currently only the latter respects the {{toString()}} representation of ids. {noformat} gremlin> g.addV().id() ==>12 gremlin> graph.vertices("12") gremlin> g.V("12") gremlin> g.V().hasId("12") ==>v[12] {noformat} > Vertex lookups by id are inconsistent > - > > Key: TINKERPOP-1048 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1048 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.1.1-incubating >Reporter: Daniel Kuppitz >Assignee: stephen mallette > > {{graph.vertices(id)}}, {{g.V(id)}} and {{g.V().hasId(id)}} should all return > the same result. However, currently only the latter respects the > {{toString()}} representation of ids. > {noformat} > gremlin> g.addV().id() > ==>12 > gremlin> graph.vertices("12") > gremlin> g.V("12") > gremlin> g.V().hasId("12") > ==>v[12] > {noformat} > Inconsistent number comparison with Contains: > {noformat} > gremlin> conf = new BaseConfiguration() > ==>org.apache.commons.configuration.BaseConfiguration@7048535f > gremlin> conf.setProperty("gremlin.tinkergraph.vertexIdManager","LONG") > ==>null > gremlin> conf.setProperty("gremlin.tinkergraph.edgeIdManager","LONG") > ==>null > gremlin> graph = TinkerGraph.open(conf) > ==>tinkergraph[vertices:0 edges:0] > gremlin> graph.io(gryo()).readGraph('data/tinkerpop-modern.kryo') > ==>null > gremlin> g = graph.traversal() > ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] > gremlin> g.V().hasId(within(1..6)).out().hasId(within(1..6)) > gremlin> g.V().hasId(within(1..6)).out().hasId(between(0,7)) > ==>v[3] > ==>v[2] > ==>v[4] > ==>v[5] > ==>v[3] > ==>v[3] > {noformat} > `P.within` and `P.without` rely on `Collection.contains()` which ends up > doing an Object type comparison during the equality check. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1667) Inconsistent number comparison with Contains
[ https://issues.apache.org/jira/browse/TINKERPOP-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967694#comment-15967694 ] Jason Plurad commented on TINKERPOP-1667: - I'll move the scenario over to the other ticket. Consistency for this should be handled at the same time as the other issue. > Inconsistent number comparison with Contains > > > Key: TINKERPOP-1667 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1667 > Project: TinkerPop > Issue Type: Bug > Components: process >Affects Versions: 3.2.4 >Reporter: Jason Plurad >Priority: Minor > > Steps to recreate: > {noformat} > gremlin> conf = new BaseConfiguration() > ==>org.apache.commons.configuration.BaseConfiguration@7048535f > gremlin> conf.setProperty("gremlin.tinkergraph.vertexIdManager","LONG") > ==>null > gremlin> conf.setProperty("gremlin.tinkergraph.edgeIdManager","LONG") > ==>null > gremlin> graph = TinkerGraph.open(conf) > ==>tinkergraph[vertices:0 edges:0] > gremlin> graph.io(gryo()).readGraph('data/tinkerpop-modern.kryo') > ==>null > gremlin> g = graph.traversal() > ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] > gremlin> g.V().hasId(within(1..6)).out().hasId(within(1..6)) > gremlin> g.V().hasId(within(1..6)).out().hasId(between(0,7)) > ==>v[3] > ==>v[2] > ==>v[4] > ==>v[5] > ==>v[3] > ==>v[3] > {noformat} > `P.within` and `P.without` rely on `Collection.contains()` which ends up > doing an Object type comparison during the equality check. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/569 deferring the merge to you @spmallette since you had taken the lead on the review, but i'm happy to handle it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967692#comment-15967692 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/569 deferring the merge to you @spmallette since you had taken the lead on the review, but i'm happy to handle it > Consider GraphManager as an interface > - > > Key: TINKERPOP-1438 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1438 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.2 >Reporter: stephen mallette >Priority: Minor > Labels: breaking > > If {{GraphManager}} were an interface it would make embedding Gremlin Server > easier as {{Graph}} instances could be more easily supplied by the host > application. In doing this, It also might be good to force a > {{TraversalSource}} to be referred to by both the {{Graph}} name and > {{TraversalSource}} name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967680#comment-15967680 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/569 @spmallette isn't a bot ;) > Consider GraphManager as an interface > - > > Key: TINKERPOP-1438 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1438 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.2 >Reporter: stephen mallette >Priority: Minor > Labels: breaking > > If {{GraphManager}} were an interface it would make embedding Gremlin Server > easier as {{Graph}} instances could be more easily supplied by the host > application. In doing this, It also might be good to force a > {{TraversalSource}} to be referred to by both the {{Graph}} name and > {{TraversalSource}} name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/569 @spmallette isn't a bot ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1438) Consider GraphManager as an interface
[ https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967677#comment-15967677 ] ASF GitHub Bot commented on TINKERPOP-1438: --- Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/569 Has this been missed by the ASF bot? I see 3 `VOTE: +1`s > Consider GraphManager as an interface > - > > Key: TINKERPOP-1438 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1438 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.2 >Reporter: stephen mallette >Priority: Minor > Labels: breaking > > If {{GraphManager}} were an interface it would make embedding Gremlin Server > easier as {{Graph}} instances could be more easily supplied by the host > application. In doing this, It also might be good to force a > {{TraversalSource}} to be referred to by both the {{Graph}} name and > {{TraversalSource}} name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #569: TINKERPOP-1438: GraphManager becomes a customizable in...
Github user dpitera commented on the issue: https://github.com/apache/tinkerpop/pull/569 Has this been missed by the ASF bot? I see 3 `VOTE: +1`s --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---