[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/315 There wasn't a JIRA that I can remember @pluradj - just something discussed on the mailing list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/315 LGTM. Is there a JIRA associated with this? VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/315 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/315 All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user analytically commented on the issue: https://github.com/apache/tinkerpop/pull/315 The build error is unrelated to the changes in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/315 @analytically we're trying to finish reviewing PRs for the upcoming release of 3.2.1 and 3.1.3 - did you happen to see my note above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/315 something looks strange - why do you have 27 commits on this PR? shouldn't it just be these: 990a76c, 15c06f5,15c06f5,5322ee3? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/315 @analytically did you happen to see my previous comment about rebasing/fixing conflicts on this PR so that we can begin code review/testing on our end? is that something you have some time to come back to soon? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
