[GitHub] tinkerpop pull request #894: TINKERPOP-2011 Use NumberHelper on choose()

2018-07-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/894


---


[GitHub] tinkerpop pull request #894: TINKERPOP-2011 Use NumberHelper on choose()

2018-07-20 Thread dkuppitz
GitHub user dkuppitz opened a pull request:

https://github.com/apache/tinkerpop/pull/894

TINKERPOP-2011 Use NumberHelper on choose()

https://issues.apache.org/jira/browse/TINKERPOP-2011

Treat numerical options in `ChooseStep` as in any other numerical 
comparison (value matters, data type does not). It was a little bit trickier 
than I thought as option values are only used for `HashMap` lookups and not for 
direct comparisons. Anyway, I think this solution is pretty solid (and easy to 
extend, should we run into any similar issues in the future).

`docker/build.sh -t -i -n` passed.

VOTE: +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2011

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #894


commit f7d628e344ff132fca9c4460521a40231aa8acce
Author: Daniel Kuppitz 
Date:   2018-07-18T19:34:16Z

TINKERPOP-2011 Treat numerical options in `ChooseStep` as in any other 
numerical comparison (value matters, data type does not).




---