Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Mark Thomas
On 20/12/2013 01:40, Andrew Carr wrote:
 On Thu, Dec 19, 2013 at 3:04 PM, sebb seb...@gmail.com wrote:
 On 19 December 2013 18:38, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/

 I get 404 for that URL

 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 
 Getting 404 for this page, like sebb, parent folder only shows a rc9 folder

Sorry - looks like the svn commit to replace RC9 with RC10 failed and I
didn't notice. Re-trying now. There will be a commit notification to the
dev list when it is complete.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55903] tomcat7-mango service on server is stopped unexpectedly and there is a java core file

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55903

--- Comment #4 from Mark Thomas ma...@apache.org ---
(In reply to Christopher Schultz from comment #3)
 Please don't attach the core file. Instead, attach the entire text of the
 JVM dump file -- the one that starts like this:

That file was already attached when you wrote that comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r3955 [2/2] - in /dev/tomcat/tomcat-8: v8.0.0-RC10/ v8.0.0-RC10/bin/ v8.0.0-RC10/bin/embed/ v8.0.0-RC10/bin/extras/ v8.0.0-RC10/src/ v8.0.0-RC9/

2013-12-20 Thread markt
Added: dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.asc 
(added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.asc 
Fri Dec 20 08:49:56 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJSsyboAAoJEBDAHFovYFnnfVAQANUerObzpJg8YdW8VnOM+07X
+hjtIgQuNsmFFQZFAJ/JtwQJzZRZHe0z9kHLtT449ZRt+4AowqCKmwZ3jbS0pX8QV
+sNDB2ZxJ1naePoASQXn6mk7YQfqisYJQ3dFMi/GXOv9u9wNV9BlM+ihGH9Hxq54l
+oemCZIkO1HbcEHdVwdgP+/iYZpaAZAGe5HyEpH9h1QOvkoF29LmM9kSqYCtCgODK
+ytjtP82gP4Ui+ifI5DFaybD3x1456ZpjrHQRFMZfUvrVPjwXrb952zI7SeXGpCDC
+61+H8ZaoeSmcf3xZrG9freV+46gLPHeD2DecQqlOdqnivdn4mMbb/6XnHjU6XYy3
+5cBmNU1jcPliawShN7N5yv0Z8NrKlf7tBttGDNsrAkyAVzVqQz8mPpqB3NaLTypg
+CQK9U0oNtZ5CDcLHNPRbgehCpfRnTaBBO73b5m+AXJ/zS7UG3e795WMwvCspWuE+
+SRZmsVny3yw95X/gzcN5SEIbfX2NGKOzQOIP+ZSzS8CiL4IS/UoKXtlk4KiPih5m
+wpuitoZpiSh8abVHZx8fDM+xpZ+rNmyQ6rmx8XWrrIzn58rrKDxqoUuDH7h11fFM
+kzK1w1otsW2dpf21d9nhNNSXxQP7UT1QMfIa/gL1O++cwjvOQ3gHRqIe0edYjHBt
+KzUbpdReBSkikcnPRlXF
+=kn8U
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.md5
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.md5 
(added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.md5 
Fri Dec 20 08:49:56 2013
@@ -0,0 +1 @@
+1d152b5f354be19f2c8d6e670c756bc1 *apache-tomcat-8.0.0-RC10-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r3955 [2/2] - in /dev/tomcat/tomcat-8: v8.0.0-RC10/ v8.0.0-RC10/bin/ v8.0.0-RC10/bin/embed/ v8.0.0-RC10/bin/extras/ v8.0.0-RC10/src/ v8.0.0-RC9/

2013-12-20 Thread markt
Added: dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.asc 
(added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.asc 
Fri Dec 20 08:49:56 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJSsyboAAoJEBDAHFovYFnnfVAQANUerObzpJg8YdW8VnOM+07X
+hjtIgQuNsmFFQZFAJ/JtwQJzZRZHe0z9kHLtT449ZRt+4AowqCKmwZ3jbS0pX8QV
+sNDB2ZxJ1naePoASQXn6mk7YQfqisYJQ3dFMi/GXOv9u9wNV9BlM+ihGH9Hxq54l
+oemCZIkO1HbcEHdVwdgP+/iYZpaAZAGe5HyEpH9h1QOvkoF29LmM9kSqYCtCgODK
+ytjtP82gP4Ui+ifI5DFaybD3x1456ZpjrHQRFMZfUvrVPjwXrb952zI7SeXGpCDC
+61+H8ZaoeSmcf3xZrG9freV+46gLPHeD2DecQqlOdqnivdn4mMbb/6XnHjU6XYy3
+5cBmNU1jcPliawShN7N5yv0Z8NrKlf7tBttGDNsrAkyAVzVqQz8mPpqB3NaLTypg
+CQK9U0oNtZ5CDcLHNPRbgehCpfRnTaBBO73b5m+AXJ/zS7UG3e795WMwvCspWuE+
+SRZmsVny3yw95X/gzcN5SEIbfX2NGKOzQOIP+ZSzS8CiL4IS/UoKXtlk4KiPih5m
+wpuitoZpiSh8abVHZx8fDM+xpZ+rNmyQ6rmx8XWrrIzn58rrKDxqoUuDH7h11fFM
+kzK1w1otsW2dpf21d9nhNNSXxQP7UT1QMfIa/gL1O++cwjvOQ3gHRqIe0edYjHBt
+KzUbpdReBSkikcnPRlXF
+=kn8U
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.md5
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.md5 
(added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/src/apache-tomcat-8.0.0-RC10-src.zip.md5 
Fri Dec 20 08:49:56 2013
@@ -0,0 +1 @@
+1d152b5f354be19f2c8d6e670c756bc1 *apache-tomcat-8.0.0-RC10-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Feature Request] Is there any chance for Tomcat to support user-defined tcp protocol?

2013-12-20 Thread Mark Thomas
On 20/12/2013 06:13, fulin tang wrote:
 Hi, there:
 
 We are using Tomcat a lot in our production environment, mainly for http
 rest apis. (A lot here means over a thousand instances), and we have just
 upgraded to 7.0.25 from 6.0.32 last month.
 
 And meanwhile, we are developing our own RPC framework, based on Hessian,
 MsgPack etc, we designed our own RPC protocol, a very simple but flexible
 protocol, for supporting text and binary transport at the same time, and
 for configurable serialization, because we have to support multi language
 users, and our users already have their own choices.
 
 So, here is the problem: We want to combine the rest api Tomcat instances
 and the RPC java instances together, in the framework level. Let's say, we
 already have HTTP, HTTPS, AJP, Comet, WebSocket protocols here in Tomcat,
 what if we add our RPC protocol parser besides them, maybe we need another
 rpcRequest and rpcResponse, or we can dispatch all RPC call to a default
 servlet, and let user do their jobs in that servlet.
 
 I looked at the source code, and as far as I see, Tomcat is not ready for
 this, because it is not designed to do this, there are too many code to
 change. Is there any chance for Tomcat to support user-defined protocol
 later, or I just take the wrong way?

There are two obvious places where you can do this.

The first is to add another protocol under org.apache.coyote (like AJP,
HTTP and SPDY). This approach gives you the greatest control but
requires the most work. As an aside, there is probably still some scope
for refactoring this code to reduce duplication and make it easier to
extend. As always, patches are welcome. (Small incremental patches are
best for this sort of thing.)

The second is to use HTTP Upgrade. This is part of the Servlet 3.1 API
so requires Tomcat 8. However, it has been back-ported to Tomcat 7 and
can be used there to (with some minor modifications). Take a look at how
WebSocket is implemented to get an idea of how you might do this. Start
with org.apache.tomcat.websocket.server.WsFilter. You can start here in
both Tomcat 7 and Tomcat 8 and see how they compare.

The downside of the upgrade approach is that you only have access to the
input and output streams, not the sockets so you end up having to
manually handle things like timeouts (if you want to do things in a
container neutral way).

HTH,

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552554 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt bin/daemon.sh webapps/docs/changelog.xml

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 09:26:41 2013
New Revision: 1552554

URL: http://svn.apache.org/r1552554
Log:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55268
Back-port of r1503852 from Tomcat 7.0.x.
Add optional --service-start-wait-time command-line option to bin/daemon.sh to 
change service start wait time from default of 10 seconds. Patch by schultz

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/bin/daemon.sh
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
  Merged /tomcat/trunk:r1494143,1503851,1505843
  Merged /tomcat/tc7.0.x/trunk:r1503852,1505844

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552554r1=1552553r2=1552554view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 09:26:41 2013
@@ -40,15 +40,6 @@ PATCHES PROPOSED TO BACKPORT:
   +1: markt, schultz
   -1:
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55268
-  Back-port of r1503852 from Tomcat 7.0.x.
-  Add optional --service-start-wait-time command-line option to bin/daemon.sh
-  to change service start wait time from default of 10 seconds.
-  http://svn.apache.org/r1503852
-  http://svn.apache.org/r1505844
-  +1: schultz, kkolinko, markt
-  -1:
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55266
   https://issues.apache.org/bugzilla/attachment.cgi?id=30608action=diff
   Parse session ID before redirect as session ID may need to be encoded

Modified: tomcat/tc6.0.x/trunk/bin/daemon.sh
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/bin/daemon.sh?rev=1552554r1=1552553r2=1552554view=diff
==
--- tomcat/tc6.0.x/trunk/bin/daemon.sh (original)
+++ tomcat/tc6.0.x/trunk/bin/daemon.sh Fri Dec 20 09:26:41 2013
@@ -62,6 +62,11 @@ do
 shift; shift;
 continue
 ;;
+--service-start-wait-time )
+SERVICE_START_WAIT_TIME=$2
+shift; shift;
+continue
+;;
 * )
 break
 ;;
@@ -102,6 +107,8 @@ test .$CATALINA_HOME = .  CATALINA_H
 test .$CATALINA_BASE = .  CATALINA_BASE=$CATALINA_HOME
 test .$CATALINA_MAIN = .  
CATALINA_MAIN=org.apache.catalina.startup.Bootstrap
 test .$JSVC = .  JSVC=$CATALINA_BASE/bin/jsvc
+# Set the default service-start wait time if necessary
+test .$SERVICE_START_WAIT_TIME = .  SERVICE_START_WAIT_TIME=10
 
 # Ensure that any user defined CLASSPATH variables are not used on startup,
 # but allow them to be specified in setenv.sh, in rare case when it is needed.
@@ -167,7 +174,7 @@ case $1 in
   $JSVC_OPTS \
   -java-home $JAVA_HOME \
   -pidfile $CATALINA_PID \
-  -wait 10 \
+  -wait $SERVICE_START_WAIT_TIME \
   -nodetach \
   -outfile 1 \
   -errfile 2 \
@@ -185,7 +192,7 @@ case $1 in
   -java-home $JAVA_HOME \
   -user $TOMCAT_USER \
   -pidfile $CATALINA_PID \
-  -wait 10 \
+  -wait $SERVICE_START_WAIT_TIME \
   -outfile $CATALINA_OUT \
   -errfile 1 \
   -classpath $CLASSPATH \

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1552554r1=1552553r2=1552554view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Dec 20 09:26:41 2013
@@ -64,6 +64,11 @@
 bug55404/bug: Log warnings about using security roles in web.xml as
 warnings. (markt)
   /fix
+  fix
+bug55268/bug: Added optional --service-start-wait-time
+command-line option to change service start wait time from default
+of 10 seconds. (schultz)
+  /fix
 /changelog
   /subsection
   subsection name=Coyote



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55268] daemon.sh only waits for 10 seconds

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55268

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Mark Thomas ma...@apache.org ---
This has been fixed in 6.0.x. and will be included in 6.0.38 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-6-trunk

2013-12-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-6-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-6-trunk/builds/584

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc6.0.x/trunk] 1552554
Blamelist: kkolinko,markt,schultz

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552563 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 09:41:18 2013
New Revision: 1552563

URL: http://svn.apache.org/r1552563
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55266
Parse session ID before redirect as session ID may need to be encoded

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552563r1=1552562r2=1552563view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 09:41:18 2013
@@ -40,12 +40,6 @@ PATCHES PROPOSED TO BACKPORT:
   +1: markt, schultz
   -1:
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55266
-  https://issues.apache.org/bugzilla/attachment.cgi?id=30608action=diff
-  Parse session ID before redirect as session ID may need to be encoded
-  +1: markt, schultz, kkolinko
-  -1:
-
 * Fix issue with Manager app and other apps that use i18n in the UI when a
   request that specifies an Accept-Language of English ahead of French, Spanish
   or Japanese.

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1552563r1=1552562r2=1552563view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
Fri Dec 20 09:41:18 2013
@@ -543,6 +543,15 @@ public class CoyoteAdapter implements Ad
 return false;
 }
 
+// Parse session Id
+String sessionID =
+request.getPathParameter(Globals.SESSION_PARAMETER_NAME);
+if (sessionID != null) {
+request.setRequestedSessionId(sessionID);
+request.setRequestedSessionURL(true);
+}
+parseSessionCookiesId(req, request);
+
 // Possible redirect
 MessageBytes redirectPathMB = request.getMappingData().redirectPath;
 if (!redirectPathMB.isNull()) {
@@ -564,15 +573,6 @@ public class CoyoteAdapter implements Ad
 return false;
 }
 
-// Parse session Id
-String sessionID =
-request.getPathParameter(Globals.SESSION_PARAMETER_NAME);
-if (sessionID != null) {
-request.setRequestedSessionId(sessionID);
-request.setRequestedSessionURL(true);
-}
-parseSessionCookiesId(req, request);
-
 return true;
 }
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1552563r1=1552562r2=1552563view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Dec 20 09:41:18 2013
@@ -61,6 +61,11 @@
 a prefix. (kkolinko)
   /fix
   fix
+bug55266/bug: Ensure that the session ID is parsed from the request
+before any redirect as the session ID may need to be encoded as part of
+the redirect URL. (markt)
+  /fix
+  fix
 bug55404/bug: Log warnings about using security roles in web.xml as
 warnings. (markt)
   /fix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55266] Trailing slash redirect loses jsessionid attribute

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55266

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Thomas ma...@apache.org ---
This has been fixed in 6.0.x and will be included in 6.0.38 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552565 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 09:43:33 2013
New Revision: 1552565

URL: http://svn.apache.org/r1552565
Log:
Better adherence to RFC2616 for content-length headers.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11Processor.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552565r1=1552564r2=1552565view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 09:43:33 2013
@@ -49,24 +49,6 @@ PATCHES PROPOSED TO BACKPORT:
   +1: kkolinko (a typo in changelog: s/associated/associate/)
   -1:
 
-* Better adherence to RFC2616 for content-length headers.
-  http://people.apache.org/~markt/patches/2013-09-11-tc6-content-length.patch
-  +1: markt
-  +0: schultz: I don't see anywhere in RFC2616 that suggests that multiple
-   Content-Length headers yields an invalid request. Another option
-   for response code in this case might be 411 Length Required.
-   There are some conditions under which Content-Type RFC MUST be
-   ignored, and I don't see those cases in any of the *Processor
-   classes.
-  markt:   RFC2616 states that multiple headers of the same name may be
-   merged in to a single, multi-valued header without any change in
-   meaning. Content-Length is clearly defined as a single value
-   header. If multiple values are not permitted then neither are
-   multiple headers.
-  +1: schultz: Changing my vote to +1.
-  +1: kkolinko
-  -1:
-
 * Add support for limiting the size of chunk extensions when using chunked
   encoding.
   
http://people.apache.org/~markt/patches/2013-12-17-chunk-extensions-tc6-v2.patch

Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=1552565r1=1552564r2=1552565view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Fri 
Dec 20 09:43:33 2013
@@ -26,6 +26,8 @@ import java.security.NoSuchProviderExcep
 import java.security.cert.CertificateFactory;
 import java.security.cert.X509Certificate;
 
+import javax.servlet.http.HttpServletResponse;
+
 import org.apache.coyote.ActionCode;
 import org.apache.coyote.ActionHook;
 import org.apache.coyote.Adapter;
@@ -695,6 +697,7 @@ public class AjpAprProcessor implements 
 // Set this every time in case limit has been changed via JMX
 headers.setLimit(endpoint.getMaxHeaderCount());
 
+boolean contentLengthSet = false;
 int hCount = requestHeaderMessage.getInt();
 for(int i = 0 ; i  hCount ; i++) {
 String hName = null;
@@ -731,8 +734,15 @@ public class AjpAprProcessor implements 
 (hId == -1  tmpMB.equalsIgnoreCase(Content-Length))) {
 // just read the content-length header, so set it
 long cl = vMB.getLong();
-if(cl  Integer.MAX_VALUE)
-request.setContentLength( (int)cl );
+if (contentLengthSet) {
+response.setStatus(HttpServletResponse.SC_BAD_REQUEST);
+error = true;
+} else {
+contentLengthSet = true;
+// Set the content-length header for the request
+if(cl  Integer.MAX_VALUE)
+request.setContentLength( (int)cl );
+}
 } else if (hId == Constants.SC_REQ_CONTENT_TYPE ||
 (hId == -1  tmpMB.equalsIgnoreCase(Content-Type))) {
 // just read the content-type header, so set it

Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1552565r1=1552564r2=1552565view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Fri Dec 
20 09:43:33 2013
@@ -28,6 +28,8 @@ import java.security.NoSuchProviderExcep
 import java.security.cert.CertificateFactory;
 import 

svn commit: r1552596 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-12-20 Thread kkolinko
Author: kkolinko
Date: Fri Dec 20 11:16:51 2013
New Revision: 1552596

URL: http://svn.apache.org/r1552596
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552596r1=1552595r2=1552596view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 11:16:51 2013
@@ -82,6 +82,20 @@ PATCHES PROPOSED TO BACKPORT:
   compare 6.0.x code with 7.0.x code.
   
http://people.apache.org/~markt/patches/2013-12-19-xml-prep-part1-tc6-v1.patch
   +1: markt
+  +0: kkolinko:
+  I do not like that you change the values of validation flags when
+  STRICT_SERVLET_COMPLIANCE is set. This was a feature required for
+  Servlet 3.0, but I do not remember the same requirement for Servlet
+  2.5.
+  I expect that with this change the bug #351040 in Eclipse IDE will
+  become visible with Tomcat 6, while it is currently observed with
+  Tomcat 7 only. It is not our policy to provide workarounds for 3rd
+  party bugs, so this is not a veto.
+https://bugs.eclipse.org/bugs/show_bug.cgi?id=351040
+  In ParserUtils:
+   // TODO Add a zero-arg constructor
+   This patch has such constructor, annotated as @Deprecated.
+  The rest of the patch is OK.
   -1:
 
 * Back-port some XML processing improvements (part 2)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552597 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 11:36:36 2013
New Revision: 1552597

URL: http://svn.apache.org/r1552597
Log:
Respond to review comments

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552597r1=1552596r2=1552597view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 11:36:36 2013
@@ -96,6 +96,11 @@ PATCHES PROPOSED TO BACKPORT:
// TODO Add a zero-arg constructor
This patch has such constructor, annotated as @Deprecated.
   The rest of the patch is OK.
+  markt:
+  Servlet 2.5, SRV.14.4.3 requires validation for a J2EE compliant
+  implementation. The Eclipse bug is annoying but easy to workaround and
+  only present when using STRICT_SERVLET_COMPLIANCE.
+  I'll fix the TODO I should have removed from ParserUtils.
   -1:
 
 * Back-port some XML processing improvements (part 2)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552602 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 11:58:21 2013
New Revision: 1552602

URL: http://svn.apache.org/r1552602
Log:
Update the proposal with a new patch.
Remove the comments that refer to the issue (completed TODO should have been 
removed) that has been resolved in the new patch

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552602r1=1552601r2=1552602view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 11:58:21 2013
@@ -80,7 +80,7 @@ PATCHES PROPOSED TO BACKPORT:
   The patch could have been smaller but I opted to align some of the code with
   Tomcat 7 (which meant re-ordering methods in places) to make it easier to
   compare 6.0.x code with 7.0.x code.
-  
http://people.apache.org/~markt/patches/2013-12-19-xml-prep-part1-tc6-v1.patch
+  
http://people.apache.org/~markt/patches/2013-12-20-xml-prep-part1-tc6-v2.patch
   +1: markt
   +0: kkolinko:
   I do not like that you change the values of validation flags when
@@ -92,15 +92,11 @@ PATCHES PROPOSED TO BACKPORT:
   Tomcat 7 only. It is not our policy to provide workarounds for 3rd
   party bugs, so this is not a veto.
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=351040
-  In ParserUtils:
-   // TODO Add a zero-arg constructor
-   This patch has such constructor, annotated as @Deprecated.
   The rest of the patch is OK.
   markt:
   Servlet 2.5, SRV.14.4.3 requires validation for a J2EE compliant
   implementation. The Eclipse bug is annoying but easy to workaround and
   only present when using STRICT_SERVLET_COMPLIANCE.
-  I'll fix the TODO I should have removed from ParserUtils.
   -1:
 
 * Back-port some XML processing improvements (part 2)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Jeanfrancois Arcand


On 2013-12-19 1:38 PM, Mark Thomas wrote:


The proposed 8.0.0-RC10 release is:
[ ] Broken - do not release
[X] Alpha - go ahead and release as 8.0.0-RC10 alpha


Tested jsr356  AsyncContext with Atmosphere, no issue.

-- Jeanfrancois




Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552607 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-12-20 Thread kkolinko
Author: kkolinko
Date: Fri Dec 20 12:11:33 2013
New Revision: 1552607

URL: http://svn.apache.org/r1552607
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1552607r1=1552606r2=1552607view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 20 12:11:33 2013
@@ -82,7 +82,7 @@ PATCHES PROPOSED TO BACKPORT:
   compare 6.0.x code with 7.0.x code.
   
http://people.apache.org/~markt/patches/2013-12-20-xml-prep-part1-tc6-v2.patch
   +1: markt
-  +0: kkolinko:
+  +1: kkolinko:
   I do not like that you change the values of validation flags when
   STRICT_SERVLET_COMPLIANCE is set. This was a feature required for
   Servlet 3.0, but I do not remember the same requirement for Servlet
@@ -97,6 +97,9 @@ PATCHES PROPOSED TO BACKPORT:
   Servlet 2.5, SRV.14.4.3 requires validation for a J2EE compliant
   implementation. The Eclipse bug is annoying but easy to workaround and
   only present when using STRICT_SERVLET_COMPLIANCE.
+  kkolinko:
+  Thank you for the chapter number. I am changing my vote to +1. It'd
+  be better to mention the chapter number in the changelog.
   -1:
 
 * Back-port some XML processing improvements (part 2)
@@ -114,6 +117,8 @@ PATCHES PROPOSED TO BACKPORT:
   and amended to retain history.
   
http://people.apache.org/~markt/patches/2013-12-19-xml-prep-part3-tc6-v1.patch
   +1: markt
+  +1: kkolinko (Looks OK. I have not tested into what jar the new package
+  goes and whether it requires an update to build.xml).
   -1:
 
 * Back-port some XML processing improvements (part 4)
@@ -123,6 +128,14 @@ PATCHES PROPOSED TO BACKPORT:
   and amended to retain history.
   
http://people.apache.org/~markt/patches/2013-12-19-xml-prep-part4-tc6-v1.patch
   +1: markt
+  +0: kkolinko:
+  This requires JUnit4. Formally, eclipse.classpath file still uses
+  JUnit 3 and if I understand correctly build.xml does not have JUnit
+  on classpath, but uses whatever version is available with Ant, with
+   available classname=junit.framework.TestCase 
property=junit.present /
+
+  A patch to introduce JUnit 4 may be based on r1408413, but note that
+  it requires Ant = 1.8.0.
   -1:
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Rainer Jung
Can you please add the signature files for
apache-tomcat-8.0.0-RC10.tar.gz and apache-tomcat-8.0.0-RC10.zip. The
other signature files are present, but not for those two files.

Thanks!

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55915] New: Add EECDH support to tcnative-1.dll

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55915

Bug ID: 55915
   Summary: Add EECDH support to tcnative-1.dll
   Product: Tomcat Native
   Version: 1.1.29
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Library
  Assignee: dev@tomcat.apache.org
  Reporter: ognjen.d.blagoje...@gmail.com

EECDH (Ephemeral elliptic-curve Diffie-Hellman) protocol is useful for enabling
Forward Secrecy and for preventing certain attacks.

EECDH support exists in official OpenSSL since version 1.0.0. Note that RHEL /
CentOS did not include EECDH due to patent concerns until recently [1], but
that issue is now resolved, and EECDH is included since RHEL / CentOS version
6.5.

Tcnative Windows binary seems to lack support for EECDH, also. I don't know
why, but I guess it is due to following RedHat decisions on EECDH support in
OpenSSL for RHEL.

Since RedHat resolved aforementioned issue, and included EECDH support in
OpenSSL RPMs, is it possible that developers/packagers of Tomcat native also
add EECDH support to the Windows binary (tcnative-1.dll)?

-Ognjen

[1] https://bugzilla.redhat.com/show_bug.cgi?id=319901

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r3957 [2/2] - in /dev/tomcat/tomcat-7/v7.0.50: ./ bin/ bin/embed/ bin/extras/ src/

2013-12-20 Thread violetagg
Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.asc
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.asc Fri Dec 
20 12:47:09 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSs0kyAAoJECCLCrHWMBHHgQwQAKUlmhICTJapAHP0Cff2B54U
+qfBnPpTDWsCYMlKdjypNFwJqFCajhGiJXMTCRJM5lYTvWBSP9bdEuYzReo4HcSKk
+5iNaAP9USouscRq7QjAxjISxzUE++Vn/uRJy3qtc8C/z5gh3YkFyXeAqmgD1GWUb
+mXqKnUZYANJojwNMO39n+tHvDfeB6FHAFjG2mT6ThQP7P7uFwgz2URqIFBM1G3M5
+tCHNqnYEGlm2pw259yIs91fTyRGDk5sJL7Nuvku64dFaDDLn6tNsaBb1ZiTF5WL+
+PPH9xY98Q2y6IybYGTFxUezOwrC/rq+I8NMUnFAYUANODKMe2AvNrE9No/hrP1b2
+JHEXkO1bMF55JoxEw+5vOZ8F28YFRkPzj7xjRnz4/461gIvA1H6tLYR+pg7+xi7D
+kjZfqY18cx8MBmuVzFtbLaYbDEF2/K7Tk3w/63AZo9Qu/UKc8wTEQbTA+dNEa2em
+TYG17/Sd3jYrbsbRgRSiaRbYgtGRXzhm6cZP6TX3IiCg6KB93LdvspKxwLM+rPo9
+EaaNwNT5rrKAQJ0Ywj3lI1PtmezHXZo7PjkJjcZD7TYa1TESebeFj+UvLPePtv19
+E9sMgdHNmEC8JVXlFM24XGwTfNxkL6H68F4CDludNn3omnBLFdmOmZzLTHxmTjll
+mZVWZgV3g9j/9MF/UQ6l
+=Yv6o
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.md5
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.md5 Fri Dec 
20 12:47:09 2013
@@ -0,0 +1 @@
+36aa0aaec76b00d1f0c51364bc6b1fec *tomcat-juli-adapters.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.asc
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.asc Fri Dec 20 
12:47:09 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSs0kxAAoJECCLCrHWMBHHyiYQAIa1NdE4KzFkfrB2NOa+pyA+
+lRb6Ra/MI6rX6i/jGmaDI4NKXUK8bf9uxx0Zrg9jKnFPyhXWOycrle6/465Z1gdt
+Khv8S9WpthoxhQhoS6GgLsucCBhGR/giPEy1PLiQRvO65DQ5i/c0PHVgFMfvznBc
+lp/garORmi8Tqhy97G7a/1LuNtHSehsATuGURiFyCn/lHpEW+MIogcoqHw5xtt/D
+4lJz7LKLnCfj8eZ4Vqs/mbiVyHvmQxOLVBxnr5czfc3eXubSmMILWkNfI3i2yDIM
+OkzrggsjePxoFjbCl33waFncrkiDqM5fS6c/9jfEKkyRXObffcrcLPLZ3YOxP4hn
+w/vweztM4bD3y6oDtuAVxK07mdLsPiMBuLYI5nfgyTHYFjOpK/u/sGNdxq4SJA0k
+DquUt+avZ5k9iyKTtF6k/964ez4ZwpD4tfeZvAtSzSVIHg52i9lCc5PcqK4BtOp8
+Sp0drZZhjNRYLrZIUNv8LWVVCxeDp58TggFiDqCA7tjEYUHvfzVofeYWOlkp2zBm
+FLDegu0AZi6dj/a4wvKwnc/YnaBkKFZTcjRoN1d3GDbVn9IMbO5PEV9HxLxrin5G
+lw7jtEOMcVMVLns1JQrIUVNq1utl2Yy5598NqWdrcqvEUHz1NZDly1UPuUZAqzSv
+b1wZ3Mu5DTZrM4i2jvNm
+=/lGr
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.md5
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.md5 Fri Dec 20 
12:47:09 2013
@@ -0,0 +1 @@
+0e2a0f558fd7115fcd767fa2901c551c *tomcat-juli.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz
--
svn:mime-type = application/x-gzip

Added: dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz.asc
==
--- dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz.asc Fri Dec 
20 12:47:09 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSs0v5AAoJECCLCrHWMBHHMGkP/Rhi7tMj+hkSMKaa+95/lh0t
+pw9JOKMpfV6CQtnnZa7I+WWONyA87N59K1GHDhOT4Ms027EqBdthjS30h+BKnISN
+6JLPygA7aC+N8vy487Fjrq0I7vzHg/QX2xo2rvfShfLFTkh5spMENLSiof0UKHLA
+y6hpWSv02gcgbHPdc/b6PEG+d5Ofs1c3S+4fD48wOHsuowPWDZWsASYEt0m163yM
+gMKD9Bdo3Jw/WpWAzf+hPT7LA7EtHt7COTgp7X9cbe/oTUTGgvvM3ewKhC6D/Vjg
+HptNWFijqoklS6ZDmbsolwtaFK/8KVcvyactdEseaaJXvGT8vmMN4AIjekyWzG5P
+/iZeA+x4btLk43IjR1pHjwph91WTeCeMq63MfLxrbqEuF7F7AUb9bgp6zC07fZ8K
+uCkg0CzsquccfVfS4vkUthXNOxoXBA8xfx1mgaIIwUTRZXmOtXyzSUwuSP4Mkc1Q
+M3Hy5zMZ/X/hXpVuzTPwKGf6Y6fWm9GSNU7UF+XT2V27Aty/4RqZw3rhh9TOBGz+

svn commit: r3957 [2/2] - in /dev/tomcat/tomcat-7/v7.0.50: ./ bin/ bin/embed/ bin/extras/ src/

2013-12-20 Thread violetagg
Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.asc
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.asc Fri Dec 
20 12:47:09 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSs0kyAAoJECCLCrHWMBHHgQwQAKUlmhICTJapAHP0Cff2B54U
+qfBnPpTDWsCYMlKdjypNFwJqFCajhGiJXMTCRJM5lYTvWBSP9bdEuYzReo4HcSKk
+5iNaAP9USouscRq7QjAxjISxzUE++Vn/uRJy3qtc8C/z5gh3YkFyXeAqmgD1GWUb
+mXqKnUZYANJojwNMO39n+tHvDfeB6FHAFjG2mT6ThQP7P7uFwgz2URqIFBM1G3M5
+tCHNqnYEGlm2pw259yIs91fTyRGDk5sJL7Nuvku64dFaDDLn6tNsaBb1ZiTF5WL+
+PPH9xY98Q2y6IybYGTFxUezOwrC/rq+I8NMUnFAYUANODKMe2AvNrE9No/hrP1b2
+JHEXkO1bMF55JoxEw+5vOZ8F28YFRkPzj7xjRnz4/461gIvA1H6tLYR+pg7+xi7D
+kjZfqY18cx8MBmuVzFtbLaYbDEF2/K7Tk3w/63AZo9Qu/UKc8wTEQbTA+dNEa2em
+TYG17/Sd3jYrbsbRgRSiaRbYgtGRXzhm6cZP6TX3IiCg6KB93LdvspKxwLM+rPo9
+EaaNwNT5rrKAQJ0Ywj3lI1PtmezHXZo7PjkJjcZD7TYa1TESebeFj+UvLPePtv19
+E9sMgdHNmEC8JVXlFM24XGwTfNxkL6H68F4CDludNn3omnBLFdmOmZzLTHxmTjll
+mZVWZgV3g9j/9MF/UQ6l
+=Yv6o
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.md5
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli-adapters.jar.md5 Fri Dec 
20 12:47:09 2013
@@ -0,0 +1 @@
+36aa0aaec76b00d1f0c51364bc6b1fec *tomcat-juli-adapters.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.asc
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.asc Fri Dec 20 
12:47:09 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSs0kxAAoJECCLCrHWMBHHyiYQAIa1NdE4KzFkfrB2NOa+pyA+
+lRb6Ra/MI6rX6i/jGmaDI4NKXUK8bf9uxx0Zrg9jKnFPyhXWOycrle6/465Z1gdt
+Khv8S9WpthoxhQhoS6GgLsucCBhGR/giPEy1PLiQRvO65DQ5i/c0PHVgFMfvznBc
+lp/garORmi8Tqhy97G7a/1LuNtHSehsATuGURiFyCn/lHpEW+MIogcoqHw5xtt/D
+4lJz7LKLnCfj8eZ4Vqs/mbiVyHvmQxOLVBxnr5czfc3eXubSmMILWkNfI3i2yDIM
+OkzrggsjePxoFjbCl33waFncrkiDqM5fS6c/9jfEKkyRXObffcrcLPLZ3YOxP4hn
+w/vweztM4bD3y6oDtuAVxK07mdLsPiMBuLYI5nfgyTHYFjOpK/u/sGNdxq4SJA0k
+DquUt+avZ5k9iyKTtF6k/964ez4ZwpD4tfeZvAtSzSVIHg52i9lCc5PcqK4BtOp8
+Sp0drZZhjNRYLrZIUNv8LWVVCxeDp58TggFiDqCA7tjEYUHvfzVofeYWOlkp2zBm
+FLDegu0AZi6dj/a4wvKwnc/YnaBkKFZTcjRoN1d3GDbVn9IMbO5PEV9HxLxrin5G
+lw7jtEOMcVMVLns1JQrIUVNq1utl2Yy5598NqWdrcqvEUHz1NZDly1UPuUZAqzSv
+b1wZ3Mu5DTZrM4i2jvNm
+=/lGr
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.md5
==
--- dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.md5 (added)
+++ dev/tomcat/tomcat-7/v7.0.50/bin/extras/tomcat-juli.jar.md5 Fri Dec 20 
12:47:09 2013
@@ -0,0 +1 @@
+0e2a0f558fd7115fcd767fa2901c551c *tomcat-juli.jar
\ No newline at end of file

Added: dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz
--
svn:mime-type = application/x-gzip

Added: dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz.asc
==
--- dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz.asc (added)
+++ dev/tomcat/tomcat-7/v7.0.50/src/apache-tomcat-7.0.50-src.tar.gz.asc Fri Dec 
20 12:47:09 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2.0.21 (MingW32)
+
+iQIcBAABCgAGBQJSs0v5AAoJECCLCrHWMBHHMGkP/Rhi7tMj+hkSMKaa+95/lh0t
+pw9JOKMpfV6CQtnnZa7I+WWONyA87N59K1GHDhOT4Ms027EqBdthjS30h+BKnISN
+6JLPygA7aC+N8vy487Fjrq0I7vzHg/QX2xo2rvfShfLFTkh5spMENLSiof0UKHLA
+y6hpWSv02gcgbHPdc/b6PEG+d5Ofs1c3S+4fD48wOHsuowPWDZWsASYEt0m163yM
+gMKD9Bdo3Jw/WpWAzf+hPT7LA7EtHt7COTgp7X9cbe/oTUTGgvvM3ewKhC6D/Vjg
+HptNWFijqoklS6ZDmbsolwtaFK/8KVcvyactdEseaaJXvGT8vmMN4AIjekyWzG5P
+/iZeA+x4btLk43IjR1pHjwph91WTeCeMq63MfLxrbqEuF7F7AUb9bgp6zC07fZ8K
+uCkg0CzsquccfVfS4vkUthXNOxoXBA8xfx1mgaIIwUTRZXmOtXyzSUwuSP4Mkc1Q
+M3Hy5zMZ/X/hXpVuzTPwKGf6Y6fWm9GSNU7UF+XT2V27Aty/4RqZw3rhh9TOBGz+

[VOTE] Release Apache Tomcat 7.0.50

2013-12-20 Thread Violeta Georgieva
The proposed Apache Tomcat 7.0.50 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.50/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-004/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_50/

The proposed 7.0.50 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.50 Stable

Regards
Violeta


svn commit: r3958 - in /dev/tomcat/tomcat-8/v8.0.0-RC10/bin: apache-tomcat-8.0.0-RC10.tar.gz.asc apache-tomcat-8.0.0-RC10.zip.asc

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 12:54:00 2013
New Revision: 3958

Log:
Add missing signatures

Added:
dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc

Added: dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc 
(added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc Fri 
Dec 20 12:54:00 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJStD3BAAoJEBDAHFovYFnnqxgQAMY5wFCTIdZJYcIxpBJoKMT2
+uXG5cW5MxBAEjD3LLYoBsuq9oeWgMmSF+o3ZnRCESKIkCqHlYnABJxOGoikiCSYK
+kEzNVNiSXuh3jgkelUog7inbDSS2hRo7gjcrOjsiiBJflIurvDy88HHLL0fdjmuI
+lqsHrdDx7pzqqF5VAN/WFuZkcGj/U9GC2RUDD1Xfa4DFcsK93QaPqyXC05wRN5kU
+RK9xfV16yjmkq80bnkoO5OZtCqtwgvgxGwLgRikCuErDfW1XQwvv7S42gl9Ck/gR
+d0Rr5180CgmGBPCStuelFKyEJbNBpwuL2jZfR6ooqYRzRgHFzHxgKCfSy4nnUoMN
+/TYUWBeHd646HHQmGyb20Ssbmi0rob7mqFT+O4EXJaTjnxfqzRVI3m3Zj4tk8MjB
+nzT5SliCzNvsWpIq9p1PeKbOmH1aB/CPqnRLZrIL43EDWBIj+3waAU6z5+HnHs3F
++nQSsXergeohg82yGo1zHzuFxDdiB2JxZKazlenhcSr8Zr7LwEgDCcLuv2SQaHSa
+oGmuGJSSoUKV7YGRu92ieWcHrhZJMhuzD9QJRQZtJekwVZOIMLcC/qABztMJ6dD4
+K6//FaJvsIkTfHOkvPMphg6bhQ2kiM9hpJLz/cMBeDdcC5u4hUkCVxWg9NJmuvxS
+kB0ZiBng5GA4C1xl9RXW
+=P102
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc Fri 
Dec 20 12:54:00 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJStD25AAoJEBDAHFovYFnnXmEP/2f8YMaFjgZuyU5uBtXuvjQ+
+AuggD+4khE4B/pGRrXg35QuC95tPzgNBOYAergID7B1ieI6tUTD2kcQdIkDPqvZv
+Lg3JhPu69/KnFJEzNahSBoGPDeuf4Rc5YfIKxxz33BBqlkMQWcOkoRM5oAYz5Pvh
+qFwUWlmV5cWAVpiiXUHxUAc3PC+zxtpx1L1JEPWOZL2J5DnkvY1QJdi3nvXi+kvg
+I5VpBqdVHephIsxSqMQlY/d+lsEp6VgQmq+WjW61UXnzNxWkEDFlBaw1HjQBhFZ+
+DpY8crgvu+KSUK6dLqQnAdmo5QQxSfBNThrNtquh3PrisD8eXNQ1SvuZCHFphbt5
+oCn3GKYsbnXB9Uv9bcnFtGVLpVPuez5wSjPyAoAPh7nmkFO7oP0HQ4ZbVVF5sFRw
+NLg72et8k0vjjXGz51ew/150iG8A1xsYs4xxQDH1BZVUH6FiYQLg7v/t3VX8bm2f
+u8cXbAQYCa7w5BIP+kx8sjAFue928P+cQKJRK41WcI+Zrrfs3Bpu6r9pRggyZAHo
+GIkfb1Rs3Ly2qkOVsnqlo+hHqoR2usEvOEzIZkti48KYpfzqsfcbjrTGp4IY62pz
+A4RctP8373d23q8y8+Ek7PnIxERRnQ6booTaAVwacP1glIydHH5CzqqelVnZEojl
+Hox6mTl/N8hFOrEzTSeg
+=0/C7
+-END PGP SIGNATURE-



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r3958 - in /dev/tomcat/tomcat-8/v8.0.0-RC10/bin: apache-tomcat-8.0.0-RC10.tar.gz.asc apache-tomcat-8.0.0-RC10.zip.asc

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 12:54:00 2013
New Revision: 3958

Log:
Add missing signatures

Added:
dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc
dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc

Added: dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc 
(added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.tar.gz.asc Fri 
Dec 20 12:54:00 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJStD3BAAoJEBDAHFovYFnnqxgQAMY5wFCTIdZJYcIxpBJoKMT2
+uXG5cW5MxBAEjD3LLYoBsuq9oeWgMmSF+o3ZnRCESKIkCqHlYnABJxOGoikiCSYK
+kEzNVNiSXuh3jgkelUog7inbDSS2hRo7gjcrOjsiiBJflIurvDy88HHLL0fdjmuI
+lqsHrdDx7pzqqF5VAN/WFuZkcGj/U9GC2RUDD1Xfa4DFcsK93QaPqyXC05wRN5kU
+RK9xfV16yjmkq80bnkoO5OZtCqtwgvgxGwLgRikCuErDfW1XQwvv7S42gl9Ck/gR
+d0Rr5180CgmGBPCStuelFKyEJbNBpwuL2jZfR6ooqYRzRgHFzHxgKCfSy4nnUoMN
+/TYUWBeHd646HHQmGyb20Ssbmi0rob7mqFT+O4EXJaTjnxfqzRVI3m3Zj4tk8MjB
+nzT5SliCzNvsWpIq9p1PeKbOmH1aB/CPqnRLZrIL43EDWBIj+3waAU6z5+HnHs3F
++nQSsXergeohg82yGo1zHzuFxDdiB2JxZKazlenhcSr8Zr7LwEgDCcLuv2SQaHSa
+oGmuGJSSoUKV7YGRu92ieWcHrhZJMhuzD9QJRQZtJekwVZOIMLcC/qABztMJ6dD4
+K6//FaJvsIkTfHOkvPMphg6bhQ2kiM9hpJLz/cMBeDdcC5u4hUkCVxWg9NJmuvxS
+kB0ZiBng5GA4C1xl9RXW
+=P102
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc
==
--- dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.0.0-RC10/bin/apache-tomcat-8.0.0-RC10.zip.asc Fri 
Dec 20 12:54:00 2013
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1.4.9 (MingW32)
+
+iQIcBAABAgAGBQJStD25AAoJEBDAHFovYFnnXmEP/2f8YMaFjgZuyU5uBtXuvjQ+
+AuggD+4khE4B/pGRrXg35QuC95tPzgNBOYAergID7B1ieI6tUTD2kcQdIkDPqvZv
+Lg3JhPu69/KnFJEzNahSBoGPDeuf4Rc5YfIKxxz33BBqlkMQWcOkoRM5oAYz5Pvh
+qFwUWlmV5cWAVpiiXUHxUAc3PC+zxtpx1L1JEPWOZL2J5DnkvY1QJdi3nvXi+kvg
+I5VpBqdVHephIsxSqMQlY/d+lsEp6VgQmq+WjW61UXnzNxWkEDFlBaw1HjQBhFZ+
+DpY8crgvu+KSUK6dLqQnAdmo5QQxSfBNThrNtquh3PrisD8eXNQ1SvuZCHFphbt5
+oCn3GKYsbnXB9Uv9bcnFtGVLpVPuez5wSjPyAoAPh7nmkFO7oP0HQ4ZbVVF5sFRw
+NLg72et8k0vjjXGz51ew/150iG8A1xsYs4xxQDH1BZVUH6FiYQLg7v/t3VX8bm2f
+u8cXbAQYCa7w5BIP+kx8sjAFue928P+cQKJRK41WcI+Zrrfs3Bpu6r9pRggyZAHo
+GIkfb1Rs3Ly2qkOVsnqlo+hHqoR2usEvOEzIZkti48KYpfzqsfcbjrTGp4IY62pz
+A4RctP8373d23q8y8+Ek7PnIxERRnQ6booTaAVwacP1glIydHH5CzqqelVnZEojl
+Hox6mTl/N8hFOrEzTSeg
+=0/C7
+-END PGP SIGNATURE-



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Mark Thomas
On 20/12/2013 12:36, Rainer Jung wrote:
 Can you please add the signature files for
 apache-tomcat-8.0.0-RC10.tar.gz and apache-tomcat-8.0.0-RC10.zip. The
 other signature files are present, but not for those two files.

Done. No idea how they got missed. I'll keep an eye on the next release.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.50

2013-12-20 Thread Ognjen Blagojevic

Violeta,

On 20.12.2013 13:52, Violeta Georgieva wrote:

The proposed 7.0.50 release is:
[X] Broken - do not release
[ ] Stable - go ahead and release as 7.0.50 Stable


My vote is non-binding.

NIO connector fails during smoke tests from time to time (one failed 
request on every ~5000). I smoke test by repeatedly crawling links on 
default Tomcat installation in one single thread.


I use Windows 7 64-bit, Oracle JDK 1.7.0_40. These are exceptions I get 
in the logs:



??? 20, 2013 2:03:13 PM org.apache.coyote.http11.AbstractHttp11Processor 
endRequest

SEVERE: Error finishing response
java.lang.IllegalArgumentException
at java.nio.Buffer.position(Buffer.java:236)
at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:96)
at sun.nio.ch.IOUtil.write(IOUtil.java:51)
at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:487)
	at 
org.apache.tomcat.util.net.SecureNioChannel.flush(SecureNioChannel.java:135)
	at 
org.apache.tomcat.util.net.SecureNioChannel.write(SecureNioChannel.java:509)
	at 
org.apache.tomcat.util.net.NioBlockingSelector.write(NioBlockingSelector.java:94)
	at 
org.apache.tomcat.util.net.NioSelectorPool.write(NioSelectorPool.java:174)
	at 
org.apache.coyote.http11.InternalNioOutputBuffer.writeToSocket(InternalNioOutputBuffer.java:163)
	at 
org.apache.coyote.http11.InternalNioOutputBuffer.flushBuffer(InternalNioOutputBuffer.java:242)
	at 
org.apache.coyote.http11.InternalNioOutputBuffer.endRequest(InternalNioOutputBuffer.java:121)
	at 
org.apache.coyote.http11.AbstractHttp11Processor.endRequest(AbstractHttp11Processor.java:1746)
	at 
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1100)
	at 
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:607)
	at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1721)
	at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1679)
	at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

at java.lang.Thread.run(Thread.java:724)

-

??? 20, 2013 2:08:11 PM 
org.apache.tomcat.util.net.NioEndpoint$PollerEvent run

SEVERE:
java.nio.channels.ClosedChannelException
	at 
java.nio.channels.spi.AbstractSelectableChannel.register(AbstractSelectableChannel.java:194)
	at 
org.apache.tomcat.util.net.NioEndpoint$PollerEvent.run(NioEndpoint.java:896)
	at 
org.apache.tomcat.util.net.NioEndpoint$Poller.events(NioEndpoint.java:1038)

at 
org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1194)
at java.lang.Thread.run(Thread.java:724)

-

??? 20, 2013 2:26:36 PM org.apache.tomcat.util.net.NioEndpoint processSocket
SEVERE: Error allocating socket processor
java.lang.NullPointerException
	at 
org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:726)
	at 
org.apache.tomcat.util.net.NioEndpoint$Poller.processKey(NioEndpoint.java:1257)

at 
org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1210)
at java.lang.Thread.run(Thread.java:724)

-

??? 20, 2013 2:30:38 PM org.apache.tomcat.util.net.NioEndpoint processSocket
SEVERE: Error allocating socket processor
java.lang.NullPointerException

-



These are URLs that caused exceptions:

ERROR: couldn't open URL: http://(snip):82/examples/jsp/chat/
Invalid Http response

ERROR: couldn't open URL: http://(snip):82/examples/jsp/checkbox/check.html
Invalid Http response

ERROR: couldn't open URL: http://(snip):82/examples/websocket-deprecated
Invalid Http response

ERROR: couldn't open URL: http://(snip):82/examples/servlets
Invalid Http response

ERROR: couldn't open URL: http://(snip):82/examples/jsp
Invalid Http response


Only those 5 URLs are repeating, other URLs doesn't couse exceptions. I 
see exceptions both over HTTP and HTTPS.



-Ognjen



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Rémy Maucherat
2013/12/19 Mark Thomas ma...@apache.org

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha

 Rémy


svn commit: r1552773 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 18:09:02 2013
New Revision: 1552773

URL: http://svn.apache.org/r1552773
Log:
CTR. No functional change.
Make it easier to diff against 7.0.x.
Comment fixes. Whitespace alignment.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1552773r1=1552772r2=1552773view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java Fri 
Dec 20 18:09:02 2013
@@ -1,5 +1,4 @@
-/* $Id$
- *
+/*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
  * this work for additional information regarding copyright ownership.
@@ -79,8 +78,6 @@ public class Digester extends DefaultHan
 
 
 // -- Static Fields
-
-
 private static class SystemPropertySource 
 implements IntrospectionUtils.PropertySource {
 public String getProperty( String key ) {
@@ -126,7 +123,7 @@ public class Digester extends DefaultHan
  * allows Digester to be used in environments which are unfriendly to
  * JAXP1.1 (such as WebLogic 6.0).  Note that if you use this option you
  * have to configure namespace and validation support yourself, as these
- * properties only affect the SAXParser and emtpy constructor.
+ * properties only affect the SAXParser and empty constructor.
  */
 public Digester(XMLReader reader) {
 
@@ -634,7 +631,7 @@ public class Digester extends DefaultHan
 
 
 /**
- * Set the publid id of the current file being parse.
+ * Set the public id of the current file being parse.
  * @param publicId the DTD/Schema public's id.
  */
 public void setPublicId(String publicId){
@@ -1204,7 +1201,7 @@ public class Digester extends DefaultHan
 new String(buffer, start, len) + ));
 }
 
-;   // No processing required
+// No processing required
 
 }
 
@@ -1224,7 +1221,7 @@ public class Digester extends DefaultHan
 saxLog.debug(processingInstruction(' + target + ',' + data + 
'));
 }
 
-;   // No processing is required
+// No processing is required
 
 }
 
@@ -1269,7 +1266,7 @@ public class Digester extends DefaultHan
 saxLog.debug(skippedEntity( + name + ));
 }
 
-; // No processing required
+// No processing required
 
 }
 
@@ -1820,7 +1817,7 @@ public class Digester extends DefaultHan
  *  for a single parameter from the body of this element)
  * @param paramTypes Set of Java class names for the types
  *  of the expected parameters
- *  (if you wish to use a primitive type, specify the corresonding
+ *  (if you wish to use a primitive type, specify the corresponding
  *  Java wrapper class instead, such as codejava.lang.Boolean/code
  *  for a codeboolean/code parameter)
  * @see CallMethodRule
@@ -1849,7 +1846,7 @@ public class Digester extends DefaultHan
  * @param paramCount Number of expected parameters (or zero
  *  for a single parameter from the body of this element)
  * @param paramTypes The Java class names of the arguments
- *  (if you wish to use a primitive type, specify the corresonding
+ *  (if you wish to use a primitive type, specify the corresponding
  *  Java wrapper class instead, such as codejava.lang.Boolean/code
  *  for a codeboolean/code parameter)
  * @see CallMethodRule
@@ -2253,7 +2250,7 @@ public class Digester extends DefaultHan
  * @param pattern Element matching pattern
  * @param methodName Method name to call on the parent element
  * @param paramType Java class name of the expected parameter type
- *  (if you wish to use a primitive type, specify the corresonding
+ *  (if you wish to use a primitive type, specify the corresponding
  *  Java wrapper class instead, such as codejava.lang.Boolean/code
  *  for a codeboolean/code parameter)
  * @see SetNextRule
@@ -2387,7 +2384,7 @@ public class Digester extends DefaultHan
  * @param pattern Element matching pattern
  * @param methodName Method name to call on the parent element
  * @param paramType Java class name of the expected parameter type
- *  (if you wish to use a primitive type, specify the corresonding
+ *  (if you wish to use a primitive type, specify the corresponding
  *  Java wrapper class instead, such as codejava.lang.Boolean/code
  *  for a codeboolean/code parameter)
  * @see SetTopRule
@@ -2668,7 +2665,7 @@ public class Digester extends 

svn commit: r1552795 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 19:50:51 2013
New Revision: 1552795

URL: http://svn.apache.org/r1552795
Log:
CTR: No functional change
Re-ordering and whitespace changes to make diffs against 7.0.x easier

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1552795r1=1552794r2=1552795view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java 
Fri Dec 20 19:50:51 2013
@@ -5,20 +5,17 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the License); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
 package org.apache.catalina.startup;
 
-
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
@@ -52,6 +49,8 @@ import org.apache.catalina.deploy.Filter
 import org.apache.catalina.deploy.LoginConfig;
 import org.apache.catalina.deploy.SecurityConstraint;
 import org.apache.catalina.util.StringManager;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
 import org.apache.tomcat.util.digester.Digester;
 import org.apache.tomcat.util.digester.RuleSet;
 import org.xml.sax.ErrorHandler;
@@ -64,14 +63,18 @@ import org.xml.sax.SAXParseException;
  *
  * @author Craig R. McClanahan
  * @author Jean-Francois Arcand
- * @version $Id$
+ * @version $Id:$
  */
+public class ContextConfig implements LifecycleListener {
 
-public class ContextConfig
-implements LifecycleListener {
+protected static Log log = LogFactory.getLog( ContextConfig.class );
+
+/**
+ * The string resources for this package.
+ */
+protected static final StringManager sm =
+StringManager.getManager(Constants.Package);
 
-protected static org.apache.juli.logging.Log log=
-org.apache.juli.logging.LogFactory.getLog( ContextConfig.class );
 
 // - Instance Variables
 
@@ -100,14 +103,14 @@ public class ContextConfig
  * The default web application's context file location.
  */
 protected String defaultContextXml = null;
-
-
+
+
 /**
  * The default web application's deployment descriptor location.
  */
 protected String defaultWebXml = null;
-
-
+
+
 /**
  * Track any fatal errors during startup configuration processing.
  */
@@ -119,12 +122,12 @@ public class ContextConfig
  */
 protected SAXParseException parseException = null;
 
-
+
 /**
  * Original docBase.
  */
 protected String originalDocBase = null;
-
+
 
 /**
  * Anti-locking docBase. It is a path to a copy of the web application
@@ -134,26 +137,19 @@ public class ContextConfig
 
 
 /**
- * The string resources for this package.
- */
-protected static final StringManager sm =
-StringManager.getManager(Constants.Package);
-
-
-/**
  * The codeDigester/code we will use to process web application
  * context files.
  */
 protected static Digester contextDigester = null;
-
-
+
+
 /**
  * The codeDigester/code we will use to process web application
  * deployment descriptor files.
  */
 protected static Digester webDigester = null;
-
-
+
+
 /**
  * The codeRule/code used to parse the web.xml
  */
@@ -170,20 +166,18 @@ public class ContextConfig
  */
 protected static boolean xmlNamespaceAware = false;
 
-
+
 /**
  * Deployment count.
  */
 protected static long deploymentCount = 0L;
-
-
+
+
 protected static final LoginConfig DUMMY_LOGIN_CONFIG =
 new LoginConfig(NONE, null, null, null);
 
 
 // - Properties
-
-
 /**
  * Return the location of the default deployment descriptor
  */
@@ -291,11 +285,11 @@ public class ContextConfig
  * Process the application classes annotations, if it exists.
  */
 protected void applicationAnnotationsConfig() {
-
+
 long t1=System.currentTimeMillis();
-
+
 WebAnnotationSet.loadApplicationAnnotations(context);
-
+

svn commit: r1552804 - /tomcat/trunk/java/org/apache/coyote/Response.java

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 20:19:50 2013
New Revision: 1552804

URL: http://svn.apache.org/r1552804
Log:
Avoid possible NPE

Modified:
tomcat/trunk/java/org/apache/coyote/Response.java

Modified: tomcat/trunk/java/org/apache/coyote/Response.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/Response.java?rev=1552804r1=1552803r2=1552804view=diff
==
--- tomcat/trunk/java/org/apache/coyote/Response.java (original)
+++ tomcat/trunk/java/org/apache/coyote/Response.java Fri Dec 20 20:19:50 2013
@@ -464,11 +464,14 @@ public final class Response {
 
 this.contentType = m.toStringNoCharset();
 
-String charsetValue = m.getCharset().trim();
+String charsetValue = m.getCharset();
 
-if (charsetValue != null  charsetValue.length()  0) {
-charsetSet = true;
-this.characterEncoding = charsetValue;
+if (charsetValue != null) {
+charsetValue = charsetValue.trim();
+if (charsetValue.length()  0) {
+charsetSet = true;
+this.characterEncoding = charsetValue;
+}
 }
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55917] New: Cookie parsing fails hard with ISO-8859-1 values

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917

Bug ID: 55917
   Summary: Cookie parsing fails hard with ISO-8859-1 values
   Product: Tomcat 7
   Version: trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: jboy...@apache.org

Some popular JavaScript libraries have started to set cookie values in the
browser directly and include ISO-8859-1 (Latin-1) characters in the range
0xA0-0xFF. When the Cookie header is parsed by Tomcat, the request fails with
an IllegalArgumentException[1] from the connector without giving the
application an opportunity to validate the cookie value received.

RFC2616 (HTTP/1.1) allows header field-values to contain ISO-8859-1 characters
which includes the range 0xA0-0xFF. RFC2109 (cookies) allows for
quoted-string values which can contain TEXT octets (which includes those
characters). This is different to cookie names which are defined as the more
restricted token which only allows USASCII values. The original Netscape spec
does not mention character encodings.

[1]
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/CookieSupport.java?revision=1200183view=markup#l190

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552805 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/Response.java webapps/docs/changelog.xml

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 20:21:56 2013
New Revision: 1552805

URL: http://svn.apache.org/r1552805
Log:
Avoid possible NPE when no charset is specified

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/coyote/Response.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1552804

Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/Response.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/coyote/Response.java?rev=1552805r1=1552804r2=1552805view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/coyote/Response.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/coyote/Response.java Fri Dec 20 
20:21:56 2013
@@ -461,11 +461,14 @@ public final class Response {
 
 this.contentType = m.toStringNoCharset();
 
-String charsetValue = m.getCharset().trim();
+String charsetValue = m.getCharset();
 
-if (charsetValue != null  charsetValue.length()  0) {
-charsetSet = true;
-this.characterEncoding = charsetValue;
+if (charsetValue != null) {
+charsetValue = charsetValue.trim();
+if (charsetValue.length()  0) {
+charsetSet = true;
+this.characterEncoding = charsetValue;
+}
 }
 }
 

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1552805r1=1552804r2=1552805view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri Dec 20 20:21:56 2013
@@ -55,6 +55,14 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues to not pop up wrt. others).
 --
+section name=Tomcat 7.0.51 (violetagg)
+  subsection name=Coyote
+fix
+  Avoid possible NPE if a content type is specified without a character 
set.
+  (markt)
+/fix
+  /subsection
+/section
 section name=Tomcat 7.0.50 (violetagg)
   subsection name=Catalina
 changelog



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55917] Cookie parsing fails hard with ISO-8859-1 values

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917

--- Comment #1 from Jeremy Boynes jboy...@apache.org ---
Created attachment 31139
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=31139action=edit
Fix to allow chars in the range 0xa0-0xff

Patch allows characters in the range 0xA0-0xFF (so it continues to exclude
controls both 0x20 and 0x80-0x9F). Added testcase for a Latin-1 character and
test-suite passes.

To keep it simple, this patch does not attempt to differentiate between quoted
and unquoted values. It also does not attempt to deal with values containing
UTF-8 encoded data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552806 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 20:33:16 2013
New Revision: 1552806

URL: http://svn.apache.org/r1552806
Log:
Add missing tag

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1552806r1=1552805r2=1552806view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri Dec 20 20:33:16 2013
@@ -57,10 +57,12 @@
 --
 section name=Tomcat 7.0.51 (violetagg)
   subsection name=Coyote
-fix
-  Avoid possible NPE if a content type is specified without a character 
set.
-  (markt)
+changelog
+  fix
+Avoid possible NPE if a content type is specified without a character
+set. (markt)
 /fix
+/changelog
   /subsection
 /section
 section name=Tomcat 7.0.50 (violetagg)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55917] Cookie parsing fails hard with ISO-8859-1 values

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917

--- Comment #2 from Mark Thomas ma...@apache.org ---
This simple patch is not acceptable as it does not retain the limitation that
cookie names must be tokens.

Now might be the time to re-write the cookie parsing using the HttpParser.

Given the 'fun' we have had with cookie processing in the past we need to be
very careful about any changes we introduce. Now could be a good time to do
this in 8.0.x and then back-port it once it is stable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55917] Cookie parsing fails hard with ISO-8859-1 values

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917

--- Comment #3 from Mark Thomas ma...@apache.org ---
If we do revisit cookie parsing we should keep RFC6265 in mind as well as the
fact that Tomcat moved to a strict adherence to the cookie specs in order to
avoid a number of potential security issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-7-trunk

2013-12-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1659

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1552805
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot





[Bug 55917] Cookie parsing fails hard with ISO-8859-1 values

2013-12-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55917

Jeremy Boynes jboy...@apache.org changed:

   What|Removed |Added

  Component|Connectors  |Connectors
Product|Tomcat 7|Tomcat 8
   Target Milestone|--- |

--- Comment #4 from Jeremy Boynes jboy...@apache.org ---
I agree that this would be a good time for a larger cleanup. To keep things
incremental I'll start with refining the patch (against trunk) to handle names
and values separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1552826 - in /tomcat/tc7.0.x/trunk: java/org/apache/jasper/xmlparser/ParserUtils.java webapps/docs/changelog.xml

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 22:13:33 2013
New Revision: 1552826

URL: http://svn.apache.org/r1552826
Log:
Correct a regression in the XML refactoring that meant that errors in TLD files 
were swallowed.

Modified:
tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java?rev=1552826r1=1552825r2=1552826view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java Fri 
Dec 20 22:13:33 2013
@@ -36,7 +36,6 @@ import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
 import org.w3c.dom.Text;
 import org.xml.sax.EntityResolver;
-import org.xml.sax.ErrorHandler;
 import org.xml.sax.InputSource;
 import org.xml.sax.SAXException;
 import org.xml.sax.SAXParseException;
@@ -53,11 +52,6 @@ import org.xml.sax.SAXParseException;
 public class ParserUtils {
 
 /**
- * An error handler for use when parsing XML documents.
- */
-static ErrorHandler errorHandler = new XmlErrorHandler();
-
-/**
  * An entity resolver for use when parsing XML documents.
  */
 static EntityResolver entityResolver;
@@ -106,8 +100,13 @@ public class ParserUtils {
 factory.setValidating(validating);
 DocumentBuilder builder = factory.newDocumentBuilder();
 builder.setEntityResolver(entityResolverInstance);
-builder.setErrorHandler(errorHandler);
+XmlErrorHandler handler = new XmlErrorHandler();
+builder.setErrorHandler(handler);
 document = builder.parse(is);
+if (!handler.getErrors().isEmpty()) {
+// throw the first to indicate there was a error during 
processing
+throw handler.getErrors().iterator().next();
+}
 } catch (ParserConfigurationException ex) {
 throw new JasperException
 (Localizer.getMessage(jsp.error.parse.xml, location), ex);

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1552826r1=1552825r2=1552826view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri Dec 20 22:13:33 2013
@@ -64,6 +64,14 @@
 /fix
 /changelog
   /subsection
+  subsection name=Jasper
+changelog
+  fix
+Correct a regression in the XML refactoring that meant that errors in
+TLD files were swallowed. (markt)
+  /fix
+/changelog
+  /subsection
 /section
 section name=Tomcat 7.0.50 (violetagg)
   subsection name=Catalina



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-12-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1660

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1552806
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot





svn commit: r1552829 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java

2013-12-20 Thread markt
Author: markt
Date: Fri Dec 20 22:25:51 2013
New Revision: 1552829

URL: http://svn.apache.org/r1552829
Log:
CTR: No functional change. Align 6.0.x closer to 7.0.x to make diffs
clearer
Whitespace changes
Variable rename
Remove unused variable

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java?rev=1552829r1=1552828r2=1552829view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/xmlparser/ParserUtils.java Fri 
Dec 20 22:25:51 2013
@@ -5,16 +5,15 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the License); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package org.apache.jasper.xmlparser;
 
 import java.io.IOException;
@@ -48,9 +47,8 @@ import org.xml.sax.SAXParseException;
  * use a separate class loader for the parser to be used.
  *
  * @author Craig R. McClanahan
- * @version $Id$
+ * @version $Id:$
  */
-
 public class ParserUtils {
 
 /**
@@ -73,13 +71,13 @@ public class ParserUtils {
  * Parse the specified XML document, and return a codeTreeNode/code
  * that corresponds to the root node of the document tree.
  *
- * @param uri URI of the XML document being parsed
+ * @param location Location (eg URI) of the XML document being parsed
  * @param is Input source containing the deployment descriptor
  *
  * @exception JasperException if an input/output error occurs
  * @exception JasperException if a parsing error occurs
  */
-public TreeNode parseXMLDocument(String uri, InputSource is)
+public TreeNode parseXMLDocument(String location, InputSource is)
 throws JasperException {
 
 Document document = null;
@@ -96,20 +94,20 @@ public class ParserUtils {
 document = builder.parse(is);
} catch (ParserConfigurationException ex) {
 throw new JasperException
-(Localizer.getMessage(jsp.error.parse.xml, uri), ex);
+(Localizer.getMessage(jsp.error.parse.xml, location), ex);
} catch (SAXParseException ex) {
 throw new JasperException
 (Localizer.getMessage(jsp.error.parse.xml.line,
- uri,
+  location,
  Integer.toString(ex.getLineNumber()),
  Integer.toString(ex.getColumnNumber())),
 ex);
} catch (SAXException sx) {
 throw new JasperException
-(Localizer.getMessage(jsp.error.parse.xml, uri), sx);
+(Localizer.getMessage(jsp.error.parse.xml, location), sx);
 } catch (IOException io) {
 throw new JasperException
-(Localizer.getMessage(jsp.error.parse.xml, uri), io);
+(Localizer.getMessage(jsp.error.parse.xml, location), io);
}
 
 // Convert the resulting document to a graph of TreeNodes
@@ -176,11 +174,11 @@ public class ParserUtils {
 treeNode.setBody(body);
 }
 } else {
-TreeNode treeChild = convert(treeNode, child);
+convert(treeNode, child);
 }
 }
 }
-
+
 // Return the completed TreeNode graph
 return (treeNode);
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2013-12-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/5355

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1552804
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot





Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Yoav Shapira
On Thu, Dec 19, 2013 at 1:38 PM, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [ X ] Alpha - go ahead and release as 8.0.0-RC10 alpha

Looks good to me -- home-brewed app, mostly default config.

Yoav

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-7-trunk

2013-12-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1661

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1552826
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot





[jira] [Created] (MTOMCAT-251) User is not logged in as current user

2013-12-20 Thread ram (JIRA)
ram created MTOMCAT-251:
---

 Summary: User is not logged in as current user
 Key: MTOMCAT-251
 URL: https://issues.apache.org/jira/browse/MTOMCAT-251
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Created] (MTOMCAT-252) User is not logged in as current user

2013-12-20 Thread ram (JIRA)
ram created MTOMCAT-252:
---

 Summary: User is not logged in as current user
 Key: MTOMCAT-252
 URL: https://issues.apache.org/jira/browse/MTOMCAT-252
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: backlog






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Resolved] (MTOMCAT-252) User is not logged in as current user

2013-12-20 Thread ram (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ram resolved MTOMCAT-252.
-

   Resolution: Fixed
Fix Version/s: 2.0-beta-1

where  you fixed

 User is not logged in as current user
 -

 Key: MTOMCAT-252
 URL: https://issues.apache.org/jira/browse/MTOMCAT-252
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: backlog, 2.0-beta-1






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Resolved] (MTOMCAT-252) User is not logged in as current user

2013-12-20 Thread ram (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ram resolved MTOMCAT-252.
-

Resolution: Fixed

 User is not logged in as current user
 -

 Key: MTOMCAT-252
 URL: https://issues.apache.org/jira/browse/MTOMCAT-252
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: backlog, 2.0-beta-1






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Reopened] (MTOMCAT-252) User is not logged in as current user

2013-12-20 Thread ram (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ram reopened MTOMCAT-252:
-


 User is not logged in as current user
 -

 Key: MTOMCAT-252
 URL: https://issues.apache.org/jira/browse/MTOMCAT-252
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.0-beta-1, backlog






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Closed] (MTOMCAT-252) User is not logged in as current user

2013-12-20 Thread ram (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ram closed MTOMCAT-252.
---


where you tested..



 User is not logged in as current user
 -

 Key: MTOMCAT-252
 URL: https://issues.apache.org/jira/browse/MTOMCAT-252
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.0-beta-1, backlog






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Reopened] (MTOMCAT-252) User is not logged in as current user

2013-12-20 Thread ram (JIRA)

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ram reopened MTOMCAT-252:
-


 User is not logged in as current user
 -

 Key: MTOMCAT-252
 URL: https://issues.apache.org/jira/browse/MTOMCAT-252
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6
Affects Versions: 2.0-beta-1
Reporter: ram
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.0-beta-1, backlog






--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org