Reg: Bug 56438
Hi Mark, Can you review the patches that i submitted? Thanks, Pravallika
Fwd: [Bug 56438] If jar scan does not find context config or TLD config, log a message
Hi Mark, Can you verify the patches that i submitted? Thanks, Pravallika(VIN) -- Forwarded message -- From: bugzi...@apache.org Date: Thu, May 21, 2015 at 2:33 PM Subject: [Bug 56438] If jar scan does not find context config or TLD config, log a message To: dev@tomcat.apache.org https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #20 from VIN reachme.va...@gmail.com --- Created attachment 32748 -- https://bz.apache.org/bugzilla/attachment.cgi?id=32748action=edit Fix for printing log messages in case of contextconfig scan-Tomcat8 Patch for Tomcat8 with below fixes: 1) Log positive and negative matches when Jars/files scanned for fragments. Add summary message if atleast one JAR or file is scanned unnecessarily(with out having fragments). 2) Log positive and negative matches when files/jars scanned for annotations 3) Log positive and negative matches when files/jars scanned for static resource paths Did slight modification to TLDScanner as well to fix below: Previously though Jars/files both are scanned, summary message used to print only for Jars. Now added fix to print summary message even when files are also scanned unnecessarily. Please review the patch and let me know if any changes are required. Thanks, Pravallika(VIN) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 56438] If jar scan does not find context config or TLD config, log a message
Hi Mark, Any update on this? Thanks, Pravallika(VIN) On Monday, May 11, 2015, bugzi...@apache.org wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #17 from VIN reachme.va...@gmail.com javascript:; --- Thanks Mark. Below are the pending items to close this bug: 1) Adding debug log messages for both negative and positive matches of Pluggbility scan for all 3 versions(as trunk/8.0/7.0 are not having this) 2) Identify the default jars that can be added to JarsToSkip property and add them under all 3 versions. Please let me know if i miss any thing. Thanks, Pravallika(VIN) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org javascript:; For additional commands, e-mail: dev-h...@tomcat.apache.org javascript:;
Fwd: [Bug 56438] If jar scan does not find context config or TLD config, log a message
Hi Mark, Can you check this fix? Thanks, Pravallika(VIN) -- Forwarded message -- From: Pravallika Peddi reachme.va...@gmail.com Date: Fri, May 8, 2015 at 10:32 AM Subject: Fwd: [Bug 56438] If jar scan does not find context config or TLD config, log a message To: Tomcat Developers List dev@tomcat.apache.org Hi Mark, Can you review my patch and let me know if any changes required? Thanks, Pravallika(VIN) -- Forwarded message -- From: bugzi...@apache.org Date: Thu, May 7, 2015 at 3:23 PM Subject: [Bug 56438] If jar scan does not find context config or TLD config, log a message To: dev@tomcat.apache.org https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #13 from VIN reachme.va...@gmail.com --- Created attachment 32719 -- https://bz.apache.org/bugzilla/attachment.cgi?id=32719action=edit Fix for adding debug log message for positive matches of tld-trunk This patch contains fix for Tomcat recent trunk: 1) Added debug log message when positive tld match was found 2) Added debug log messages for both positive and negative matches of tld at resource path scan(previously it has only for JAR scanning). Summary message is not added. 3) Added debug log messages for both positive and negative matches of tld at directory level scan like Web-Inf/classes. Summary message is not added. Please verify the fix and let me know. Thanks, Pravallika(VIN) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Fwd: [Bug 56438] If jar scan does not find context config or TLD config, log a message
Hi Mark, Can you review my patch and let me know if any changes required? Thanks, Pravallika(VIN) -- Forwarded message -- From: bugzi...@apache.org Date: Thu, May 7, 2015 at 3:23 PM Subject: [Bug 56438] If jar scan does not find context config or TLD config, log a message To: dev@tomcat.apache.org https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #13 from VIN reachme.va...@gmail.com --- Created attachment 32719 -- https://bz.apache.org/bugzilla/attachment.cgi?id=32719action=edit Fix for adding debug log message for positive matches of tld-trunk This patch contains fix for Tomcat recent trunk: 1) Added debug log message when positive tld match was found 2) Added debug log messages for both positive and negative matches of tld at resource path scan(previously it has only for JAR scanning). Summary message is not added. 3) Added debug log messages for both positive and negative matches of tld at directory level scan like Web-Inf/classes. Summary message is not added. Please verify the fix and let me know. Thanks, Pravallika(VIN) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Fwd: [Bug 56438] If jar scan does not find context config or TLD config, log a message
Hi Mark, I have provided second fix as you mentioned in issue description. Can you review and let me know? Thanks, pravallika -- Forwarded message -- From: bugzi...@apache.org Date: Thu, Apr 30, 2015 at 2:17 PM Subject: [Bug 56438] If jar scan does not find context config or TLD config, log a message To: dev@tomcat.apache.org https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 --- Comment #11 from VIN reachme.va...@gmail.com --- Created attachment 32702 -- https://bz.apache.org/bugzilla/attachment.cgi?id=32702action=edit Fix for adding debug log message for positive matches of tld-Tomcat7 This patch contains fix Tomcat7 for for below things: 1) Added debug log messages to print positive matches when tld files are found 2) Added info log message to print both negative and positive tld matches in tldScanResourcePaths(Web_Inf). But did not mention that Consider adding this path to Summary message At least one resource path was scanned for TLDs yet contained no TLDs is also not added because 8.0 and trunk are not having this.
Fwd: [Bug 56438] If jar scan does not find context config or TLD config, log a message
Hi Mark, As you mentioned in issue thread, i have provided fix for TLD scan to inline Tomcat7 with 8.0 and trunk. Please review the patch and let me know if you see any problem. regards, pravallika -- Forwarded message -- From: bugzi...@apache.org Date: Tue, Apr 28, 2015 at 2:52 PM Subject: [Bug 56438] If jar scan does not find context config or TLD config, log a message To: dev@tomcat.apache.org Created attachment 32694 -- https://bz.apache.org/bugzilla/attachment.cgi?id=32694action=edit Fix for TLD scan in Tomcat7.0 This is the first patch to make Tomcat7.0 to make it in line with 8.0 and recent trunks. It has fix for only TLD scans. It does not include fix for context configs. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Reg: Bug 56438
Hi Mark and Justin, I have updated my comments on top of yours. Can you help check them and confirm so that i can provide the patch? Thanks, Pravallika(VIN)
Re: Reg: Bug 56438
Hi Mark,
I can add the Boolean variable at ContextConfig class level so that all
pluggability scans can access it and set the value accordingly.
Almost all web-inf/lib/class scans are internally calling
“processAnnotationsStream()” method of ContextConfig.java. So in this
method I can change the Boolean variable to true if annotations are found.
Here the problem is: In case if a JAR is unnecessarily processed we can
ask user to add that jAR under “JarsToSkip” property. But in case if a
class file is scanned unnecessarily, we cannot ask user to add it under
“JARsToSkip” property.
So I felt there is no point in handling for class scans.
Please correct me if my understanding is wrong.
Thanks,
Pravallika(VIN)
On Thu, Apr 9, 2015 at 1:10 PM, Mark Thomas ma...@apache.org wrote:
On 08/04/2015 14:07, Pravallika Peddi wrote:
Hi Mark,
*Fix for Pluggability Scan in Tomcat 7.0: *
You have only addressed fragment scanning. You have not addressed the
other scans such as class scanning which are part of the pluggability
scanning process.
I agree adding a flag to track if a patch is found is the way to solve
this. I disagree with where you have placed it. It needs to be somewhere
that is accessible for all types of pluggability scans.
Mark
1) Org.apache.catalina.startup.ContextConfig.java à
processJarsForWebFragments(WebXml application)
FragmentJarScannerCallbackcallback =
*new*FragmentJarScannerCallback(parseRequired);
jarScanner.scan(context.getServletContext(),
context.getLoader().getClassLoader(), callback,
/pluggabilityJarsToSkip/);
*if*(callback.scanFoundNoFragments()){
/log/.info(/sm/.getString(contextConfig.NoFragmentSummary));
}
2) In Org.apache.catalina.startup.ContextConfig.java à
FragmentJarScannerCallbackinner class:
Add new Boolean variable:
private boolean fragmentFoundInJar = false;
*Create a method to return the variable status.*
*public**boolean*scanFoundNoFragments(){
*return*!fragmentFoundInJar;
}
Attached the class file with fix.
Thanks,
Pravallika(VIN)
On Sun, Mar 29, 2015 at 4:07 AM, Mark Thomas ma...@apache.org
mailto:ma...@apache.org wrote:
On 26/03/2015 13:27, Pravallika Peddi wrote:
snip/
1) As mentioned in bug, in Tomcat7.0 catalina.properties file
first 4
default jars(except jdom.jar) are missing:
commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
We can add them under
“tomcat.util.scan.DefaultJarScanner.jarsToSkip”
jdom.jar isn't covered by the existing filters.
snip/
3) 3) So I am planning to provide a fix as below for
Tomcat 7.0
TLD scan:
Looks OK so far.
snip/
But in Tomcat 7.0, StandardJarScanner.scan method only called
from both
TldConfig.java and ContextConfig.java. So I am afraid I cannot add
the
Summary message in Tomcat7.0. When User enables FINE level then
only they
can see the noTldInJar messages
Look again. It certainly is possible to add the summary message for
TLDs
in Tomcat 7.
4) Tomcat7.0 ContextConfig scan is taking less time, hence I feel
we can
ignore it for now.
I disagree. The pluggability scanning can add a significant start-up
delay to web applications. The reason that the bug report was opened
in
the first place is the time taken for the pluggability scans.
Please let me know your opinion.
I think you have some more research to do.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
mailto:dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
mailto:dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Fix submitted for bug 56438
Hi Mark, I have submitted a fix for 56438 bug for Tomcat7. Can you help review it and let me know? Thanks in advance. Regards, Pravallika(VIN)
Re: Reg: Bug 56438
Hi Mark,
Currently there is no mechanism to skip the JARs from Pluggability scan in
Tomcat 8.0.
Below are the fix details that i propose for *tomcat 8* pluggability scan
problem:
1) Added below code in
org.apache.tomcat.util.descriptor.web.FragmentJarScannerCallBack.java à
private boolean fragmentFoundInJar = false;
In scan methods of this calls setting this variable to true when
needed and if JAR does not has any fragments added a message:
*if(!fragmentFoundInJar){*
*log.info
http://log.info(Localizer.getMessage(jspc.warning.NoFragmentInFile,
fragmentFile.getAbsolutePath()));*
* }*
Added below method to retrieve this value:
*public* *boolean* scanFoundNoFragments(){
*return* !fragmentFoundInJar;
}
2) We are doing fragment scan in two locations:
*First:*
Org.apache.catalina.startup.ContextConfig.java à
processJarsForWebFragments(WebXml
application)
Highlighted text is the Fix:
FragmentJarScannerCallback callback =
*new* FragmentJarScannerCallback(webXmlParser, delegate,
parseRequired);
jarScanner.scan(JarScanType.*PLUGGABILITY*,
context.getServletContext(), callback);
*boolean* scanFoundNoFrag = callback.scanFoundNoFragments();
*if*(!callback.scanFoundNoFragments()){
*log*.info(Localizer.*getMessage*(
jspc.warning.NoFragmentSummary));
}
*if* (!callback.isOk()) {
ok = *false*;
}
* Second:*
Org.apache.jasper.servlet.JspCServletContext.java à
scanForFragments(WebXmlParser
webXmlParser)
Highlighted text is the fix:
FragmentJarScannerCallback callback =
*new* FragmentJarScannerCallback(webXmlParser, *false*,
*true*);
scanner.scan(JarScanType.*PLUGGABILITY*, *this*, callback);
*if*(!callback.scanFoundNoFragments()){
log(Localizer.*getMessage*(jspc.warning.NoFragmentSummary));
}
*if* (!callback.isOk()) {
*throw* *new* JasperException(Localizer.*getMessage*(
jspc.error.invalidFragment));
}
I tested the changes and the Jars mentioned under
tomcat.util.scan.StandardJarScanFilter.jarsToSkip
are getting skipped from both pluggability and tld scans.
Attached the changed classes for review.
For *Tomcat7* related changes, i will send another email.
On Sun, Mar 29, 2015 at 4:07 AM, Mark Thomas ma...@apache.org wrote:
On 26/03/2015 13:27, Pravallika Peddi wrote:
snip/
1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
default jars(except jdom.jar) are missing:
commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
We can add them under
“tomcat.util.scan.DefaultJarScanner.jarsToSkip”
jdom.jar isn't covered by the existing filters.
snip/
3) 3) So I am planning to provide a fix as below for Tomcat
7.0
TLD scan:
Looks OK so far.
snip/
But in Tomcat 7.0, StandardJarScanner.scan method only called from both
TldConfig.java and ContextConfig.java. So I am afraid I cannot add the
Summary message in Tomcat7.0. When User enables FINE level then only
they
can see the noTldInJar messages
Look again. It certainly is possible to add the summary message for TLDs
in Tomcat 7.
4) Tomcat7.0 ContextConfig scan is taking less time, hence I feel we can
ignore it for now.
I disagree. The pluggability scanning can add a significant start-up
delay to web applications. The reason that the bug report was opened in
the first place is the time taken for the pluggability scans.
Please let me know your opinion.
I think you have some more research to do.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Reg: Bug 56438
Hi Mark,
Highlighted code is the Fix to add summary message to *Tomcat7.0*:
In org.apache.catalina.startup.TldConfig.java à
a) Return a Boolean variable from tldScanJar(JarURLConnection jarConn)
method which indicates tld found or not.
b) In TldJarScannerCallback inner class à add code a sbelow:
boolean isFound = false;
@Override
public void scan(JarURLConnection urlConn) throws IOException {
log.info(Scanning jar in scan function: + urlConn);
isFound = tldScanJar(urlConn);
}
@Override
public void scan(File file) {
File metaInf = new File(file, META-INF);
if (metaInf.isDirectory()) {
isFound = tldScanDir(metaInf);
}
}
private boolean scanFoundNoTLDs() {
log.info(tldFound at end: + isFound);
return !isFound;
}
c) In execute() method add below code:
TldJarScannerCallback objCallBack = *new* TldJarScannerCallback();
jarScanner.scan(context.getServletContext(),
context.getLoader().getClassLoader(),
objCallBack, *noTldJars*);
*if*(objCallBack.scanFoundNoTLDs()){
*log*.info(*sm*.getString(tldConfig.noTldSummary));
}
I tested the fix and Summary message is getting added to log.
Attached the java file that contains these changes.
Please review and let me know if the fix is ok or not.
I will send another mail for pluggability scan fix details for Tomcat7.0
Thanks,
Pravallika (VIN)
On Sun, Mar 29, 2015 at 4:07 AM, Mark Thomas ma...@apache.org wrote:
On 26/03/2015 13:27, Pravallika Peddi wrote:
snip/
1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
default jars(except jdom.jar) are missing:
commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
We can add them under
“tomcat.util.scan.DefaultJarScanner.jarsToSkip”
jdom.jar isn't covered by the existing filters.
snip/
3) 3) So I am planning to provide a fix as below for Tomcat
7.0
TLD scan:
Looks OK so far.
snip/
But in Tomcat 7.0, StandardJarScanner.scan method only called from both
TldConfig.java and ContextConfig.java. So I am afraid I cannot add the
Summary message in Tomcat7.0. When User enables FINE level then only
they
can see the noTldInJar messages
Look again. It certainly is possible to add the summary message for TLDs
in Tomcat 7.
4) Tomcat7.0 ContextConfig scan is taking less time, hence I feel we can
ignore it for now.
I disagree. The pluggability scanning can add a significant start-up
delay to web applications. The reason that the bug report was opened in
the first place is the time taken for the pluggability scans.
Please let me know your opinion.
I think you have some more research to do.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Reg: Bug 56438
Hi Mark,
*Fix for Pluggability Scan in Tomcat 7.0: *
1) Org.apache.catalina.startup.ContextConfig.java à
processJarsForWebFragments(WebXml
application)
FragmentJarScannerCallback callback =
*new* FragmentJarScannerCallback(parseRequired);
jarScanner.scan(context.getServletContext(),
context.getLoader().getClassLoader(), callback,
*pluggabilityJarsToSkip*);
*if*(callback.scanFoundNoFragments()){
*log*.info(*sm*.getString(contextConfig.NoFragmentSummary));
}
2) In Org.apache.catalina.startup.ContextConfig.java à
FragmentJarScannerCallback inner class:
Add new Boolean variable:
private boolean fragmentFoundInJar = false;
*Create a method to return the variable status.*
*public* *boolean* scanFoundNoFragments(){
*return* !fragmentFoundInJar;
}
Attached the class file with fix.
Thanks,
Pravallika(VIN)
On Sun, Mar 29, 2015 at 4:07 AM, Mark Thomas ma...@apache.org wrote:
On 26/03/2015 13:27, Pravallika Peddi wrote:
snip/
1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
default jars(except jdom.jar) are missing:
commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
We can add them under
“tomcat.util.scan.DefaultJarScanner.jarsToSkip”
jdom.jar isn't covered by the existing filters.
snip/
3) 3) So I am planning to provide a fix as below for Tomcat
7.0
TLD scan:
Looks OK so far.
snip/
But in Tomcat 7.0, StandardJarScanner.scan method only called from both
TldConfig.java and ContextConfig.java. So I am afraid I cannot add the
Summary message in Tomcat7.0. When User enables FINE level then only
they
can see the noTldInJar messages
Look again. It certainly is possible to add the summary message for TLDs
in Tomcat 7.
4) Tomcat7.0 ContextConfig scan is taking less time, hence I feel we can
ignore it for now.
I disagree. The pluggability scanning can add a significant start-up
delay to web applications. The reason that the bug report was opened in
the first place is the time taken for the pluggability scans.
Please let me know your opinion.
I think you have some more research to do.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Reg: Bug 56438
Hi Mark,
can you please review my previous mail and confirm whether i can proceed
with the fix or not?
Thanks,
Pravallika(VIN)
On Thu, Mar 26, 2015 at 6:57 PM, Pravallika Peddi reachme.va...@gmail.com
wrote:
Hi Mark,
Sorry, I was on long vacation due to which I could not respond immediately
on bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
*Below are my further observations on Tomcat7.0 trunk:*
1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
default jars(except jdom.jar) are missing:
commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
We can add them under
“tomcat.util.scan.DefaultJarScanner.jarsToSkip”
2) I observed that all the remaining jars are processed for TLDs
and Context configs.
When I add those jars under
“org.apache.catalina.startup.TldConfig.jarsToSkip” and
“org.apache.catalina.startup.ContextConfig.jarsToSkip” they are getting
skipped from processing.
3) 3) So I am planning to provide a fix as below for Tomcat
7.0 TLD scan:
*org.apache.catalina.startup.TldConfig.java à tldScanJar(JarURLConnection
jarConn) method à** introduce a Boolean variable called isTldFound as
below:* *boolean isTldFound = false;*
*Set this variable to true in below case(when tld found in jar):*
*if (entryName.startsWith(META-INF/) *
*entryName.endsWith(.tld)) {*
*isTldFound
= true;*
*After the while loop ends(processed all entries of jar), add
below code:*
*if(!isFound){*
* if (log.isDebugEnabled()) {*
*
log.info(sm.getString(tldConfig.noTldInJar,*
*
jarConn.getURL().toString()));*
*}*
* }*
Here tldConfig.noTldInJar = No TLD files were found in [{0}]. Consider
adding the JAR to the org.apache.catalina.startup.TldConfig.jarsToSkip
property in CATALINA_BASE/conf/catalina.properties file.
This message will be printed at FINE level. So unless user enables Debug
mode, he can not see the noTldInJar message.
This message was taken from 8.0 trunk.
*In Tomcat 8.0 trunk, we print a info Summary message to warn the user
saying “Atleast one jar was scanned …” Since in 8.0 both TLD and
ContextConfig are having two different approaches we can add that.*
But in Tomcat 7.0, StandardJarScanner.scan method only called from both
TldConfig.java and ContextConfig.java. So I am afraid I cannot add the
Summary message in Tomcat7.0. When User enables FINE level then only they
can see the noTldInJar messages
4) Tomcat7.0 ContextConfig scan is taking less time, hence I feel we can
ignore it for now.
Please let me know your opinion.
On Thu, Feb 26, 2015 at 12:59 AM, Mark Thomas ma...@apache.org wrote:
On 25/02/2015 11:46, Pravallika Peddi wrote:
Hi Mark,
More updates on bug 56438:
I have downloaded all the jars mentioned in the issue
except(Protomatter.jar, openspml2-toolkit.jar, ha-jdbc.jar, db2jcc4.jar,
hazelcast.jar) and added import statements in my web application for
these
jars.
I have added couple of more log messages for my research purpose in
trunk
code of 8.0.x and 7.0.x and observed that,
With 8.0.x trunk:
1) All Jars got scanned for PLUGGABILITY and TLD's.
Are you sure? Check the metadata-complete setting of the app you are
using.
2) After Pluggability scan, i do not see any log message stating
Atleast
one jar was scanned having no fragments and it is unnecessary to scan
this
jar. Not sure whether it is expected or not.
3) For TLD scan, i could see a message stating Atleast one jar was
scanned without TLD's. Enable debug logging provides more details on
which
jars got scanned for TLDs.. When i enable Debug mode, i could see
messages stating No TLDS were found in file:jar path. Consider adding
this
to the tomcat.util.scan.StandardJarScanFilter.jarsToSkip property in
CATALINA_BASE/conf/catalina.properties file.
With 7.0.x trunk:
1) All Jars got scanned for TLDs. Seems Pluggability scan was not
there(I
did not find the code for it. Correct me if i am wrong)
The code is there. Look in ContextConfig.
2) Afetr TLD scan, I do not see any message stating No TLDs were found
in
a jar even with debug mode enabled.
My action items based on your confirmation:
For 8.0.x trunk:
1) For Pluggability scan, add code in such a way that it prints No
Fragments were found in Jar. Hence add it under some filter in
catalina.properties file to avoid future scanning.
2) For TLDs: Nothing is required.
For 7.0.x trunk:
1) For TLD scan, add proper log message as in 8.0.x trunk for TLD not
found
jars.
Please add your suggestions.
That looks like a good place to start. The tricky bit will be how you
mark a JAR as 'skippable
Re: Reg: Bug 56438
Hi Mark,
Sorry, I was on long vacation due to which I could not respond immediately
on bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
*Below are my further observations on Tomcat7.0 trunk:*
1) As mentioned in bug, in Tomcat7.0 catalina.properties file first 4
default jars(except jdom.jar) are missing:
commons-discovery-*.jar,commons-el-*.jar,commons-net-*.jar
We can add them under
“tomcat.util.scan.DefaultJarScanner.jarsToSkip”
2) I observed that all the remaining jars are processed for TLDs
and Context configs.
When I add those jars under
“org.apache.catalina.startup.TldConfig.jarsToSkip” and
“org.apache.catalina.startup.ContextConfig.jarsToSkip” they are getting
skipped from processing.
3) 3) So I am planning to provide a fix as below for Tomcat 7.0
TLD scan:
*org.apache.catalina.startup.TldConfig.java à tldScanJar(JarURLConnection
jarConn) method à** introduce a Boolean variable called isTldFound as
below:* *boolean isTldFound = false;*
*Set this variable to true in below case(when tld found in jar):*
*if (entryName.startsWith(META-INF/) *
*entryName.endsWith(.tld)) {*
*isTldFound
= true;*
*After the while loop ends(processed all entries of jar), add
below code:*
*if(!isFound){*
* if (log.isDebugEnabled()) {*
*
log.info(sm.getString(tldConfig.noTldInJar,*
*
jarConn.getURL().toString()));*
*}*
* }*
Here tldConfig.noTldInJar = No TLD files were found in [{0}]. Consider
adding the JAR to the org.apache.catalina.startup.TldConfig.jarsToSkip
property in CATALINA_BASE/conf/catalina.properties file.
This message will be printed at FINE level. So unless user enables Debug
mode, he can not see the noTldInJar message.
This message was taken from 8.0 trunk.
*In Tomcat 8.0 trunk, we print a info Summary message to warn the user
saying “Atleast one jar was scanned …” Since in 8.0 both TLD and
ContextConfig are having two different approaches we can add that.*
But in Tomcat 7.0, StandardJarScanner.scan method only called from both
TldConfig.java and ContextConfig.java. So I am afraid I cannot add the
Summary message in Tomcat7.0. When User enables FINE level then only they
can see the noTldInJar messages
4) Tomcat7.0 ContextConfig scan is taking less time, hence I feel we can
ignore it for now.
Please let me know your opinion.
On Thu, Feb 26, 2015 at 12:59 AM, Mark Thomas ma...@apache.org wrote:
On 25/02/2015 11:46, Pravallika Peddi wrote:
Hi Mark,
More updates on bug 56438:
I have downloaded all the jars mentioned in the issue
except(Protomatter.jar, openspml2-toolkit.jar, ha-jdbc.jar, db2jcc4.jar,
hazelcast.jar) and added import statements in my web application for
these
jars.
I have added couple of more log messages for my research purpose in trunk
code of 8.0.x and 7.0.x and observed that,
With 8.0.x trunk:
1) All Jars got scanned for PLUGGABILITY and TLD's.
Are you sure? Check the metadata-complete setting of the app you are using.
2) After Pluggability scan, i do not see any log message stating
Atleast
one jar was scanned having no fragments and it is unnecessary to scan
this
jar. Not sure whether it is expected or not.
3) For TLD scan, i could see a message stating Atleast one jar was
scanned without TLD's. Enable debug logging provides more details on
which
jars got scanned for TLDs.. When i enable Debug mode, i could see
messages stating No TLDS were found in file:jar path. Consider adding
this
to the tomcat.util.scan.StandardJarScanFilter.jarsToSkip property in
CATALINA_BASE/conf/catalina.properties file.
With 7.0.x trunk:
1) All Jars got scanned for TLDs. Seems Pluggability scan was not there(I
did not find the code for it. Correct me if i am wrong)
The code is there. Look in ContextConfig.
2) Afetr TLD scan, I do not see any message stating No TLDs were found
in
a jar even with debug mode enabled.
My action items based on your confirmation:
For 8.0.x trunk:
1) For Pluggability scan, add code in such a way that it prints No
Fragments were found in Jar. Hence add it under some filter in
catalina.properties file to avoid future scanning.
2) For TLDs: Nothing is required.
For 7.0.x trunk:
1) For TLD scan, add proper log message as in 8.0.x trunk for TLD not
found
jars.
Please add your suggestions.
That looks like a good place to start. The tricky bit will be how you
mark a JAR as 'skippable'.
Mark
Regards,
Pravallika(VIN)
On Mon, Feb 23, 2015 at 2:46 PM, Pravallika Peddi
reachme.va...@gmail.com
wrote:
Sure Mark. I am doing the research.
On Thu, Feb 19, 2015 at 3:11 PM, Mark Thomas ma...@apache.org wrote:
On 19/02/2015 07:17
Re: Reg: Bug 56438
Hi Mark, More updates on bug 56438: I have downloaded all the jars mentioned in the issue except(Protomatter.jar, openspml2-toolkit.jar, ha-jdbc.jar, db2jcc4.jar, hazelcast.jar) and added import statements in my web application for these jars. I have added couple of more log messages for my research purpose in trunk code of 8.0.x and 7.0.x and observed that, With 8.0.x trunk: 1) All Jars got scanned for PLUGGABILITY and TLD's. 2) After Pluggability scan, i do not see any log message stating Atleast one jar was scanned having no fragments and it is unnecessary to scan this jar. Not sure whether it is expected or not. 3) For TLD scan, i could see a message stating Atleast one jar was scanned without TLD's. Enable debug logging provides more details on which jars got scanned for TLDs.. When i enable Debug mode, i could see messages stating No TLDS were found in file:jar path. Consider adding this to the tomcat.util.scan.StandardJarScanFilter.jarsToSkip property in CATALINA_BASE/conf/catalina.properties file. With 7.0.x trunk: 1) All Jars got scanned for TLDs. Seems Pluggability scan was not there(I did not find the code for it. Correct me if i am wrong) 2) Afetr TLD scan, I do not see any message stating No TLDs were found in a jar even with debug mode enabled. My action items based on your confirmation: For 8.0.x trunk: 1) For Pluggability scan, add code in such a way that it prints No Fragments were found in Jar. Hence add it under some filter in catalina.properties file to avoid future scanning. 2) For TLDs: Nothing is required. For 7.0.x trunk: 1) For TLD scan, add proper log message as in 8.0.x trunk for TLD not found jars. Please add your suggestions. Regards, Pravallika(VIN) On Mon, Feb 23, 2015 at 2:46 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Sure Mark. I am doing the research. On Thu, Feb 19, 2015 at 3:11 PM, Mark Thomas ma...@apache.org wrote: On 19/02/2015 07:17, Pravallika Peddi wrote: Hi Mark, Below are my observations during my research on the bug: 1) I downloaded recent trunk and ran the ant command so that the build/bin/lib folders are generated. 2) I created a simple web application and exported to WAR file which is of 3.4 MB size including 10 required jar files. 3) I enabled debugging as mentioned in bug: org.apache.tomcat.util.scan.StandardJarScanner.level = FINE org.apache.catalina.startup.Catalina.level = INFO 4) I deployed the WAR file using trunk/output/build/bin/catalina.bat file. Deployment is successful and i could see my application running. One Log message observed is: 19-Feb-2015 04:30:45.958 INFO [localhost-startStop-1] org.apache.jasper.servlet.TldScanner.scanJars At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time. 19-Feb-2015 04:30:47.144 INFO [main] org.apache.catalina.startup.Catalina.start Server startup in 2680 ms Even though i kept 10jars only 5 jars got scanned and don't see the issue reproduced. My assumptions on Bug: Deploy simple WAR taking longer time due to tomcat 7.0 JAR scanning is taking more time. Correct. Enhancement requested is: If some jar file is missing then add a log message in log file saying add it under JarsToSkip. There are multiple reasons a JAR can be scanned and different properties to control which scans it is included in / excluded from. The properties that control the scanning process changed between 7.0.x and 8.0.x. 8.0.x also introduced the JarScanFilter configuration element. Please correct me if my understanding about the bug is wrong. It isn't quite as simple as it looks. There are different views about what should appear by default. I'd suggest you aim for the following (some of which may already be implemented). 1) By default, no more than 1 log message per type of JAR scan (TLD, Pluggability) per web application stating that one or more JARs were scanned unnecessarily and that Tomcat could be configured to skip them in future. Include details of how to get the full list of JARs if required and what configuration option to change. 2) A simple way to enable additional logging to log each JAR and scan type combination that was unnecessary. This additional logging should not 'hide' the JAR/scan details and in a pile of other log messages. 3) Review the list of JARs in that bug to see which ones should be added to which JAR scan skip option - if any - by default. The solution for trunk and 8.0.x is likely to be different than the solution for 7.0.x. A quick look at the code suggests that the TLD scanning is pretty much there (but you should check it). The pluggability scanning isn't and it is harder to determine which JARs can be skipped because there are multiple things
Re: Reg: Bug 56438
Sure Mark. I am doing the research. On Thu, Feb 19, 2015 at 3:11 PM, Mark Thomas ma...@apache.org wrote: On 19/02/2015 07:17, Pravallika Peddi wrote: Hi Mark, Below are my observations during my research on the bug: 1) I downloaded recent trunk and ran the ant command so that the build/bin/lib folders are generated. 2) I created a simple web application and exported to WAR file which is of 3.4 MB size including 10 required jar files. 3) I enabled debugging as mentioned in bug: org.apache.tomcat.util.scan.StandardJarScanner.level = FINE org.apache.catalina.startup.Catalina.level = INFO 4) I deployed the WAR file using trunk/output/build/bin/catalina.bat file. Deployment is successful and i could see my application running. One Log message observed is: 19-Feb-2015 04:30:45.958 INFO [localhost-startStop-1] org.apache.jasper.servlet.TldScanner.scanJars At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time. 19-Feb-2015 04:30:47.144 INFO [main] org.apache.catalina.startup.Catalina.start Server startup in 2680 ms Even though i kept 10jars only 5 jars got scanned and don't see the issue reproduced. My assumptions on Bug: Deploy simple WAR taking longer time due to tomcat 7.0 JAR scanning is taking more time. Correct. Enhancement requested is: If some jar file is missing then add a log message in log file saying add it under JarsToSkip. There are multiple reasons a JAR can be scanned and different properties to control which scans it is included in / excluded from. The properties that control the scanning process changed between 7.0.x and 8.0.x. 8.0.x also introduced the JarScanFilter configuration element. Please correct me if my understanding about the bug is wrong. It isn't quite as simple as it looks. There are different views about what should appear by default. I'd suggest you aim for the following (some of which may already be implemented). 1) By default, no more than 1 log message per type of JAR scan (TLD, Pluggability) per web application stating that one or more JARs were scanned unnecessarily and that Tomcat could be configured to skip them in future. Include details of how to get the full list of JARs if required and what configuration option to change. 2) A simple way to enable additional logging to log each JAR and scan type combination that was unnecessary. This additional logging should not 'hide' the JAR/scan details and in a pile of other log messages. 3) Review the list of JARs in that bug to see which ones should be added to which JAR scan skip option - if any - by default. The solution for trunk and 8.0.x is likely to be different than the solution for 7.0.x. A quick look at the code suggests that the TLD scanning is pretty much there (but you should check it). The pluggability scanning isn't and it is harder to determine which JARs can be skipped because there are multiple things the JARs are checked for in different places. This could get messy if you aren't careful. I suggest you come up with a proposal and run it past the dev list before you go to far with development of this. Mark Thanks, Pravallika(VIN) On Wed, Feb 18, 2015 at 12:30 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Sure Mark, I will try and let you know. On Tue, Feb 17, 2015 at 4:20 PM, Mark Thomas ma...@apache.org wrote: On 17/02/2015 06:42, Pravallika Peddi wrote: Hi Mark, Its regarding the another bug that you shared to me: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 This bug involves migration from 5.5 to 7.0, and i am new to migration of Tomcat releases. Hence can you assign me some other issues which can handle with code directly? Or please let me know the search criteria to find out the right issues based on my expertise. Do some more research on that issue. Migration was just the point in time where the user discovered the issue with the current Tomcat behaviour. You should be able to replicate the problem with a very simple web application with trunk (or just add JARs to one of the web applications that ships with Tomcat). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Reg: Bug 56438
Hi Mark, Below are my observations during my research on the bug: 1) I downloaded recent trunk and ran the ant command so that the build/bin/lib folders are generated. 2) I created a simple web application and exported to WAR file which is of 3.4 MB size including 10 required jar files. 3) I enabled debugging as mentioned in bug: org.apache.tomcat.util.scan.StandardJarScanner.level = FINE org.apache.catalina.startup.Catalina.level = INFO 4) I deployed the WAR file using trunk/output/build/bin/catalina.bat file. Deployment is successful and i could see my application running. One Log message observed is: 19-Feb-2015 04:30:45.958 INFO [localhost-startStop-1] org.apache.jasper.servlet.TldScanner.scanJars At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time. 19-Feb-2015 04:30:47.144 INFO [main] org.apache.catalina.startup.Catalina.start Server startup in 2680 ms Even though i kept 10jars only 5 jars got scanned and don't see the issue reproduced. My assumptions on Bug: Deploy simple WAR taking longer time due to tomcat 7.0 JAR scanning is taking more time. Enhancement requested is: If some jar file is missing then add a log message in log file saying add it under JarsToSkip. Please correct me if my understanding about the bug is wrong. Thanks, Pravallika(VIN) On Wed, Feb 18, 2015 at 12:30 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Sure Mark, I will try and let you know. On Tue, Feb 17, 2015 at 4:20 PM, Mark Thomas ma...@apache.org wrote: On 17/02/2015 06:42, Pravallika Peddi wrote: Hi Mark, Its regarding the another bug that you shared to me: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 This bug involves migration from 5.5 to 7.0, and i am new to migration of Tomcat releases. Hence can you assign me some other issues which can handle with code directly? Or please let me know the search criteria to find out the right issues based on my expertise. Do some more research on that issue. Migration was just the point in time where the user discovered the issue with the current Tomcat behaviour. You should be able to replicate the problem with a very simple web application with trunk (or just add JARs to one of the web applications that ships with Tomcat). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Reg: Bug 56438
Sure Mark, I will try and let you know. On Tue, Feb 17, 2015 at 4:20 PM, Mark Thomas ma...@apache.org wrote: On 17/02/2015 06:42, Pravallika Peddi wrote: Hi Mark, Its regarding the another bug that you shared to me: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 This bug involves migration from 5.5 to 7.0, and i am new to migration of Tomcat releases. Hence can you assign me some other issues which can handle with code directly? Or please let me know the search criteria to find out the right issues based on my expertise. Do some more research on that issue. Migration was just the point in time where the user discovered the issue with the current Tomcat behaviour. You should be able to replicate the problem with a very simple web application with trunk (or just add JARs to one of the web applications that ships with Tomcat). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Reg: Bug 56438
Hi Mark, Its regarding the another bug that you shared to me: https://bz.apache.org/bugzilla/show_bug.cgi?id=56438 This bug involves migration from 5.5 to 7.0, and i am new to migration of Tomcat releases. Hence can you assign me some other issues which can handle with code directly? Or please let me know the search criteria to find out the right issues based on my expertise. Thanks, Pravallika(VIN)
Re: Hi
Hi Mark Chris, I implemented the suggestions and uploaded the patch with changes. can you verify it? https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 Thanks, VIN On Wed, Feb 11, 2015 at 6:12 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for your guidance in this Mark and Chris. Hope my first fix will be accepted. On Wed, Feb 11, 2015 at 5:16 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 11:32, Pravallika Peddi wrote: Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Don't worry about those. They can be completed later. Another query is: When can i mark the issue as RESOLVED? You don't. A committer will mark this issue as fixed once they have review and applied your patch. and who will verify my patch to make sure it is working? This is the responsibility of the committer who commits the patch. From my side i verified the fix. Great. One of the committers will look at this shortly. Mark On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Another query is: When can i mark the issue as RESOLVED? and who will verify my patch to make sure it is working? From my side i verified the fix. On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks for your guidance in this Mark and Chris. Hope my first fix will be accepted. On Wed, Feb 11, 2015 at 5:16 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 11:32, Pravallika Peddi wrote: Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Don't worry about those. They can be completed later. Another query is: When can i mark the issue as RESOLVED? You don't. A committer will mark this issue as fixed once they have review and applied your patch. and who will verify my patch to make sure it is working? This is the responsibility of the committer who commits the patch. From my side i verified the fix. Great. One of the committers will look at this shortly. Mark On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. Regards, VIN On Mon, Feb 9, 2015 at 10:59 PM, Christopher Schultz ch...@christopherschultz.net wrote: Pravallika, On 2/9/15 7:01 AM, Pravallika Peddi wrote: Hi Mark, Finally, I am able to Import the Tomcat source project to Eclipse with minor compile errors.. I will work on one of the issues and let you know. If you use Eclipse, after you check-out from Subversion, do this: 1. Close the project from within Eclipse 2. Go to the command-line 3. Run the ant target ide-eclipse 4. Re-open the project in Eclipse This should configure everything for you -- especially the build path so that you don't have to go looking-around for everything. Welcome to the community. Hope that helps, -chris On Mon, Feb 9, 2015 at 3:04 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Hi Mark, Finally, I am able to Import the Tomcat source project to Eclipse with minor compile errors.. I will work on one of the issues and let you know. Regards, VIN On Mon, Feb 9, 2015 at 3:04 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Can you help assign a bug or some assignment considering my skills so that i can start working? Thanks, VIN On Thu, Feb 5, 2015 at 6:16 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 09:57, Pravallika Peddi wrote: Hi Mark, Thanks for your reply. I downloaded the tomcat source code of apache-tomcat-8.0.18-src but not from the Trunk. I am able to build it and Tomcat is running successfully in my environment. OK. If you can build 8.0.x form source then building trunk from an svn checkout isn't that different. I do not know how to download the Trunk from SVN. Details are in reference [1] in my previous e-mail. You can either checkout from the ASF's svn server or clone the github mirror. Mark Thanks, VIN. On Thu, Feb 5, 2015 at 2:31 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 08:56, Pravallika Peddi wrote: Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Welcome. The first task is to make sure you can build Tomcat. Have you checked out trunk (9.0.x). See [1]. Can you build a working Tomcat instance? Mark [1] http://tomcat.apache.org/svn.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Hi
Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Thanks, Vin.
Re: Hi
Hi Mark, Thanks for your reply. I downloaded the tomcat source code of apache-tomcat-8.0.18-src but not from the Trunk. I am able to build it and Tomcat is running successfully in my environment. I do not know how to download the Trunk from SVN. Thanks, VIN. On Thu, Feb 5, 2015 at 2:31 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 08:56, Pravallika Peddi wrote: Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Welcome. The first task is to make sure you can build Tomcat. Have you checked out trunk (9.0.x). See [1]. Can you build a working Tomcat instance? Mark [1] http://tomcat.apache.org/svn.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
