(tomcat) branch 10.1.x updated: Update comment to reflect current usage
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new f09344f4b0 Update comment to reflect current usage
f09344f4b0 is described below
commit f09344f4b0cbce9451a4ebd591ab60bc298f3d46
Author: Mark Thomas
AuthorDate: Tue Oct 1 10:50:34 2024 +0100
Update comment to reflect current usage
---
java/org/apache/coyote/http2/RecycledStream.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/java/org/apache/coyote/http2/RecycledStream.java
b/java/org/apache/coyote/http2/RecycledStream.java
index fc689f7c2a..54ca63399b 100644
--- a/java/org/apache/coyote/http2/RecycledStream.java
+++ b/java/org/apache/coyote/http2/RecycledStream.java
@@ -19,8 +19,8 @@ package org.apache.coyote.http2;
import java.nio.ByteBuffer;
/**
- * Represents a closed stream in the priority tree. Used in preference to the
full {@link Stream} as has much lower
- * memory usage.
+ * Represents a closed stream and is used to correctly respond to (or ignore)
frames for the stream that are processed
+ * after the stream has been closed. Used in preference to the full {@link
Stream} as has much lower memory usage.
*/
class RecycledStream extends AbstractNonZeroStream {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.1.x updated: Update comment
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new b6da30e558 Update comment
b6da30e558 is described below
commit b6da30e55895cdd0d6d5af02447fdb85e4c326d6
Author: Mark Thomas
AuthorDate: Thu Jul 27 15:48:59 2023 +0100
Update comment
---
java/org/apache/coyote/http2/Stream.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/coyote/http2/Stream.java
b/java/org/apache/coyote/http2/Stream.java
index 6b32049b82..51170e9935 100644
--- a/java/org/apache/coyote/http2/Stream.java
+++ b/java/org/apache/coyote/http2/Stream.java
@@ -939,7 +939,7 @@ class Stream extends AbstractNonZeroStream implements
HeaderEmitter {
private volatile boolean endOfStreamSent = false;
/*
- * The write methods are synchronized to ensure that only one thread
at a time is able to access the buffer.
+ * The write methods share a common lock to ensure that only one
thread at a time is able to access the buffer.
* Without this protection, a client that performed concurrent writes
could corrupt the buffer.
*/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.1.x updated: Update comment
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new efbeae4f4a Update comment
efbeae4f4a is described below
commit efbeae4f4a86f0d9c49543a6a80ba0052259de14
Author: Mark Thomas
AuthorDate: Wed Jul 26 17:19:22 2023 +0100
Update comment
---
java/org/apache/coyote/http2/Http2UpgradeHandler.java | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index ec3e098c0d..811737bf83 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -1338,9 +1338,10 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
Stream pushStream;
-// Synchronized since PUSH_PROMISE frames have to be sent in order.
Once
-// the stream has been created we need to ensure that the PUSH_PROMISE
-// is sent before the next stream is created for a PUSH_PROMISE.
+/*
+ * Uses SocketWrapper lock since PUSH_PROMISE frames have to be sent
in order. Once the stream has been created
+ * we need to ensure that the PUSH_PROMISE is sent before the next
stream is created for a PUSH_PROMISE.
+ */
Lock lock = socketWrapper.getLock();
lock.lock();
try {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.1.x updated: Update comment
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 878e69d78a Update comment
878e69d78a is described below
commit 878e69d78a879ee50b49052d7dc061fe76d34a27
Author: Mark Thomas
AuthorDate: Wed Mar 15 14:32:57 2023 +
Update comment
---
java/org/apache/catalina/connector/Connector.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/connector/Connector.java
b/java/org/apache/catalina/connector/Connector.java
index 54f9915ba6..96d5b7af34 100644
--- a/java/org/apache/catalina/connector/Connector.java
+++ b/java/org/apache/catalina/connector/Connector.java
@@ -203,7 +203,7 @@ public class Connector extends LifecycleMBeanBase {
private int maxCookieCount = 200;
/**
- * The maximum number of parameters (GET plus POST) which will be
automatically parsed by the container. 1 by
+ * The maximum number of parameters (GET plus POST) which will be
automatically parsed by the container. 1000 by
* default. A value of less than 0 means no limit.
*/
protected int maxParameterCount = 1000;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
