Thanks Richard.
I got personal issues with my computer and it's taking a bit of time to set
everything up again.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Wed, Mar 30, 2022 at 8:45 AM Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> wrote:
> Update regarding TOMEE-3879: We were missing --add-opens options in the
> failover tests to run with Java 11+ - we added it to the bat / sh
> scripts of openejb-standalone. However, bat / sh is not used in the
> failover tests.
>
> I added the options in the tests, so TOMEE-3879 is fixed now.
>
> Gruß
> Richard
>
> Am Dienstag, dem 29.03.2022 um 06:53 + schrieb Zowalla, Richard:
> > Hi,
> >
> > to follow up on TOMEE-3879 [1]: I add some more context to the Jira.
> > The permissions do not matter as we are not invoking the scripts in
> > bin/* in the failover itests (itests/failover).
> >
> > We are directly booting the servers via the java command (via
> > Bootstrap
> > from openejb-core) and a lot of properties to configure it, which
> > fails
> > (at least for me atm) with a ClassNotFoundException (see issue). Due
> > to
> > this exception, the servers never become ready and the tests will
> > just
> > timeout.
> >
> > Don't have time to dig into it now but hope it helps anyone, who will
> > work on it in the near future :)
> >
> > Gruß
> > Richard
> >
> > [1] https://issues.apache.org/jira/browse/TOMEE-3879
> >
> > Am Montag, dem 28.03.2022 um 08:16 + schrieb Zowalla, Richard:
> > > Heyho,
> > >
> > > the ZIP created for TOMEE-3879 looks good to me. It has +x set.
> > > Perhaps
> > > it looses the info during extraction in our code.
> > >
> > > Can you give a pointer, which tests are suspected to be impacted by
> > > it?
> > >
> > > Gruß
> > > Richard
> > >
> > > Am Samstag, dem 26.03.2022 um 10:40 +0100 schrieb Jean-Louis
> > > Monteiro:
> > > > Awesome, divide and conquer.
> > > >
> > > > Trying to add a bit more...
> > > > This one might be small for someone with some spare cycles.
> > > >
> > > > https://issues.apache.org/jira/browse/TOMEE-3879
> > > >
> > > >
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Sat, Mar 26, 2022 at 5:35 AM David Blevins <
> > > > david.blev...@gmail.com>
> > > > wrote:
> > > >
> > > > > > On Mar 24, 2022, at 2:28 AM, Jean-Louis Monteiro <
> > > > > jlmonte...@tomitribe.com> wrote:
> > > > > > We can now divide and conquer. An issue has been created
> > > > > > https://issues.apache.org/jira/browse/TOMEE-3862
> > > > > > We are going to add as many small tasks as possible so people
> > > > > > can
> > > > > > pick
> > > > > and
> > > > > > contribute in parallel.
> > > > >
> > > > > Thanks for that JIRA. I saw an easy one I could do and went a
> > > > > head
> > > > > and
> > > > > knocked it out :)
> > > > >
> > > > > -
> > > > >
> https://github.com/apache/tomee/commit/6e37ec02ca60fe955a3a909d761e09aa5a506978
> > > > >
> > > > > That yanks 1 minute out of the build on my machine.
> > > > >
> > > > >
> > > > > -David
> > > > >
> > > > >
> > > > > > On Tue, Mar 22, 2022 at 1:59 PM Jean-Louis Monteiro <
> > > > > > jlmonte...@tomitribe.com> wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > I've been working for quite a long time on TomEE 9.x, and
> > > > > > > it's
> > > > > > > been more
> > > > > > > challenging and painful than I was expecting. I thought it
> > > > > > > would be
> > > > > good to
> > > > > > > give you some sort of status.
> > > > > > >
> > > > > > > I created a PR for the work. As a reminder, since Java EE
> > > > > > > moved
> > > > > > > to
> > > > > Eclipse
> > > > > > > to become Jakarta EE, we had a switch from javax.*
> > > > > > > namespace
> > > > > > > to
> > > > > jakarta.*
> > > > > > > namespace. This is an impacting change, since all
> > > > > > > applications
> > > > > > > and
> > > > > > > applications servers are built on top of it.
> > > > > > >
> > > > > > > In TomEE, we decided to do that change in TomEE. We had
> > > > > > > previously a
> > > > > > > bytecode change approach like an application could do. It
> > > > > > > worked and we
> > > > > > > were able to get certified. But it had a lot of
> > > > > > > limitations,
> > > > > > > so
> > > > > > > we had
> > > > > to
> > > > > > > do the migration in the code and fix all compatibility
> > > > > > > issues.
> > > > > > >
> > > > > > > Here is the PR https://github.com/apache/tomee/pull/814
> > > > > > > It has 90+ commits and nearly 5000 files touched (added,
> > > > > > > removed,
> > > > > > > updated). I understand it's a lot and it makes it almost
> > > > > > > impossible to
> > > > > > > review. But I did not see much approaches in this scenario
> > > > > > > to
> > > > > > > create
> > > > > > > smaller PRs.
> > > > > > >
> > > > > > > I created a Jenkins build though available at
> > > > > > >
> https://ci-builds.apache.org/job/Tomee/job/master-build-quick-9.x/
> >