[jira] [Commented] (TWILL-147) Allow using external Kafka server for log collection
[ https://issues.apache.org/jira/browse/TWILL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089214#comment-16089214 ] Terence Yim commented on TWILL-147: --- When Twill started using Kafka, Kafka was on version 0.7-0.8, which doesn't have a pure java api yet. Things have changed and the general principle is to minimize dependencies if it doesn't involve reinventing a lot of code. Regarding the log appender library, I think the best way to address it is to make it somewhat pluggable so that user doesn't need to use the one that comes from Twill. > Allow using external Kafka server for log collection > > > Key: TWILL-147 > URL: https://issues.apache.org/jira/browse/TWILL-147 > Project: Apache Twill > Issue Type: Improvement > Components: api, core >Reporter: Terence Yim > > Show allow user to use any Kafka server for log collection, not necessarily > starting an embedded one in the AM. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim resolved TWILL-238. --- Resolution: Fixed > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089212#comment-16089212 ] ASF GitHub Bot commented on TWILL-238: -- Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/56 > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] twill pull request #56: (TWILL-238) Change TwillController restartInstances ...
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089210#comment-16089210 ] ASF GitHub Bot commented on TWILL-238: -- Github user chtyim commented on the issue: https://github.com/apache/twill/pull/56 LGTM. > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] twill issue #56: (TWILL-238) Change TwillController restartInstances API
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/56 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---