[jira] [Commented] (TWILL-264) Discovery.hashCode implementation is wrong
[ https://issues.apache.org/jira/browse/TWILL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752765#comment-16752765 ] ASF GitHub Bot commented on TWILL-264: -- Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/80 > Discovery.hashCode implementation is wrong > -- > > Key: TWILL-264 > URL: https://issues.apache.org/jira/browse/TWILL-264 > Project: Apache Twill > Issue Type: Bug >Reporter: Terence Yim >Priority: Major > > The equals() method compare the payload array content, but the hashCode is > computed based on the payload reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (TWILL-264) Discovery.hashCode implementation is wrong
[ https://issues.apache.org/jira/browse/TWILL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim reassigned TWILL-264: - Assignee: Terence Yim > Discovery.hashCode implementation is wrong > -- > > Key: TWILL-264 > URL: https://issues.apache.org/jira/browse/TWILL-264 > Project: Apache Twill > Issue Type: Bug >Reporter: Terence Yim >Assignee: Terence Yim >Priority: Major > > The equals() method compare the payload array content, but the hashCode is > computed based on the payload reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] twill pull request #80: (TWILL-264) Fix Discoverable.hashCode implementation
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/80 ---
[jira] [Commented] (TWILL-264) Discovery.hashCode implementation is wrong
[ https://issues.apache.org/jira/browse/TWILL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752554#comment-16752554 ] ASF GitHub Bot commented on TWILL-264: -- Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/80#discussion_r251089608 --- Diff: twill-discovery-api/src/test/java/org/apache/twill/discovery/DiscoverableTest.java --- @@ -0,0 +1,36 @@ +package org.apache.twill.discovery; --- End diff -- please add copyright > Discovery.hashCode implementation is wrong > -- > > Key: TWILL-264 > URL: https://issues.apache.org/jira/browse/TWILL-264 > Project: Apache Twill > Issue Type: Bug >Reporter: Terence Yim >Priority: Major > > The equals() method compare the payload array content, but the hashCode is > computed based on the payload reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] twill pull request #80: (TWILL-264) Fix Discoverable.hashCode implementation
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/80#discussion_r251089608 --- Diff: twill-discovery-api/src/test/java/org/apache/twill/discovery/DiscoverableTest.java --- @@ -0,0 +1,36 @@ +package org.apache.twill.discovery; --- End diff -- please add copyright ---
[jira] [Commented] (TWILL-264) Discovery.hashCode implementation is wrong
[ https://issues.apache.org/jira/browse/TWILL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752521#comment-16752521 ] ASF GitHub Bot commented on TWILL-264: -- GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/80 (TWILL-264) Fix Discoverable.hashCode implementation You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill TWILL-264-fix-discoverable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit b4feee26f827fe4c8f9f667f9af05edd83305a47 Author: Terence Yim Date: 2019-01-25T18:00:00Z (TWILL-264) Fix Discoverable.hashCode implementation > Discovery.hashCode implementation is wrong > -- > > Key: TWILL-264 > URL: https://issues.apache.org/jira/browse/TWILL-264 > Project: Apache Twill > Issue Type: Bug >Reporter: Terence Yim >Priority: Major > > The equals() method compare the payload array content, but the hashCode is > computed based on the payload reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] twill pull request #80: (TWILL-264) Fix Discoverable.hashCode implementation
GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/80 (TWILL-264) Fix Discoverable.hashCode implementation You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill TWILL-264-fix-discoverable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit b4feee26f827fe4c8f9f667f9af05edd83305a47 Author: Terence Yim Date: 2019-01-25T18:00:00Z (TWILL-264) Fix Discoverable.hashCode implementation ---
