[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500340#comment-14500340 ] Chris Nauroth commented on ZOOKEEPER-1893: -- I recently discovered that this change requires build environments to have version 1.12 or greater for automake. I'd like to update the documentation, so I attached a patch on ZOOKEEPER-1707. [~michim], would you be able to review it? Thanks! > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362092#comment-14362092 ] Hadoop QA commented on ZOOKEEPER-1893: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634342/ZOOKEEPER-1893.patch against trunk revision 1666760. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2565//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2565//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2565//console This message is automatically generated. > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362100#comment-14362100 ] Hongchao Deng commented on ZOOKEEPER-1893: -- +1. Finally saw a all successful build. [~fournc]. Can you help commit this? > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362107#comment-14362107 ] Hadoop QA commented on ZOOKEEPER-1893: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634342/ZOOKEEPER-1893.patch against trunk revision 1666764. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2567//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2567//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2567//console This message is automatically generated. > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362108#comment-14362108 ] Camille Fournier commented on ZOOKEEPER-1893: - Awesome I will do it [~hdeng] > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362129#comment-14362129 ] Hudson commented on ZOOKEEPER-1893: --- SUCCESS: Integrated in ZooKeeper-trunk #2628 (See [https://builds.apache.org/job/ZooKeeper-trunk/2628/]) ZOOKEEPER-1893. automake: use serial-tests option (michim via camille) (camille: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1666768) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/Makefile.am > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932860#comment-13932860 ] Hadoop QA commented on ZOOKEEPER-1893: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634342/ZOOKEEPER-1893.patch against trunk revision 1577019. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1959//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1959//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1959//console This message is automatically generated. > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Priority: Minor > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932871#comment-13932871 ] Hadoop QA commented on ZOOKEEPER-1893: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634342/ZOOKEEPER-1893.patch against trunk revision 1577019. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1960//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1960//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1960//console This message is automatically generated. > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Priority: Minor > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932896#comment-13932896 ] Raul Gutierrez Segales commented on ZOOKEEPER-1893: --- Would you like to get this fixed for the 3.4.7 (assuming there'll be one) or for 3.5.0? If for 3.5.0, do you think it's a worth-while effort enabling those tests for parallel runs? Having a faster test suite is always nice :-) > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Priority: Minor > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932925#comment-13932925 ] Michi Mutsuzaki commented on ZOOKEEPER-1893: I think we should fix this for both 3.5.0 and 3.4.7. It looks the buildbot uses automake-1.11, so I need to fix the patch to handle that. Yes, it would be great to make these tests run in parallel. I'm guessing it's mostly about making sure the server ports don't conflict. > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Priority: Minor > Fix For: 3.4.7, 3.5.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937322#comment-13937322 ] Michi Mutsuzaki commented on ZOOKEEPER-1893: ... and it would be even better if we can make java tests run in parallel :) > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Priority: Minor > Fix For: 3.4.7, 3.5.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ZOOKEEPER-1893) automake: use serial-tests option
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035709#comment-14035709 ] Flavio Junqueira commented on ZOOKEEPER-1893: - I can't access the test results here any longer, so I don't know if the test failure was due to this patch or not. Otherwise, the change looks good. The comments about parallel tests sound good, but that's a separate jira (possibly an umbrella one), no? Let me know if you still need this committed. > automake: use serial-tests option > - > > Key: ZOOKEEPER-1893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1893 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-1893.patch > > > automake switched to run tests in parallel by default in 1.13, but zktest-st > and zktest-mt can't run in parallel. We can use the serial-tests option to > run tests serially but this option was introduced in automake 1.12. I don't > know which version of automake buidbot has. I'll upload the patch and see. -- This message was sent by Atlassian JIRA (v6.2#6252)