[jira] [Updated] (ZOOKEEPER-2625) zkServer.sh creates PID file in the folder data?/ instead of data/

[Arne Bachmann (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arne Bachmann updated ZOOKEEPER-2625:
-
Labels: build  (was: )

> zkServer.sh creates PID file in the folder data?/ instead of data/
> --
>
> Key: ZOOKEEPER-2625
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2625
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.5.2
> Environment: Linux vagrant-ubuntu-trusty-32 3.13.0-100-generic 
> #147-Ubuntu SMP Tue Oct 18 16:49:53 UTC 2016 i686 i686 i686 GNU/Linux
>Reporter: Arne Bachmann
>Priority: Minor
>  Labels: build
>
> I provision a vagrant vm that installs zookeeper into /home/vagrant/zk and 
> adjusts all owner and read/write rights.
> With the vagrant user, I start zookeeper as bin/zkServer.sh start 
> /vagrant/data/zoo.cfg
> However, the folder data? (or data^M) gets created with the PID inside, 
> instead of putting it into the data folder, which contains the version-2 
> folder.
> Since I'm using the official start scripts, I'm at a loss.
> Also, the data? folder comes with root:root ownership, which is strange, as 
> zKServer.sh is executed from the vagrant user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_openjdk7 - Build # 1269 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1269/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H13 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
Cloning the remote Git repository
Cloning repository git://git.apache.org/zookeeper.git
 > git init /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7 # 
 > timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 967c3a71bd8eaf1ac29b2702173115976874bd8e 
(refs/remotes/origin/branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 967c3a71bd8eaf1ac29b2702173115976874bd8e
 > git rev-list 967c3a71bd8eaf1ac29b2702173115976874bd8e # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2625) zkServer.sh creates PID file in the folder data?/ instead of data/

[Arne Bachmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647827#comment-15647827
 ] 

Arne Bachmann commented on ZOOKEEPER-2625:
--

I found the issue. As I suspected, the reason for data? is actually a data^M 
which translates into a \r character.

The following code executed in the bin/ folder resolved the issue:
perl -p -i -e "s/\r//g" *.sh

This converts line endings from Windows mode into Linux mode, which one would 
expect to find in the zk.tar.gz anyway.
I'm not sure if I should create a pull request or patch, as this seems to be 
more of a problem with the developer's build chain, rather a simple code fix.

If anybody is interested, I can zip my Vagrant code that sets up distributed 
zookeeper instances inside Virtualbox containers (which may be a bad practice, 
as there is only ephemeral disk storage).

> zkServer.sh creates PID file in the folder data?/ instead of data/
> --
>
> Key: ZOOKEEPER-2625
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2625
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.5.2
> Environment: Linux vagrant-ubuntu-trusty-32 3.13.0-100-generic 
> #147-Ubuntu SMP Tue Oct 18 16:49:53 UTC 2016 i686 i686 i686 GNU/Linux
>Reporter: Arne Bachmann
>Priority: Minor
>
> I provision a vagrant vm that installs zookeeper into /home/vagrant/zk and 
> adjusts all owner and read/write rights.
> With the vagrant user, I start zookeeper as bin/zkServer.sh start 
> /vagrant/data/zoo.cfg
> However, the folder data? (or data^M) gets created with the PID inside, 
> instead of putting it into the data folder, which contains the version-2 
> folder.
> Since I'm using the official start scripts, I'm at a loss.
> Also, the data? folder comes with root:root ownership, which is strange, as 
> zKServer.sh is executed from the vagrant user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648178#comment-15648178
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87038798
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -141,109 +141,128 @@ public String genCsharpWriteWrapper(String fname, 
String tag) {
 
 static HashMap vectorStructs = new HashMap();
 public void genCCode(FileWriter h, FileWriter c) throws IOException {
-for (JField f : mFields) {
-if (f.getType() instanceof JVector) {
-JVector jv = (JVector)f.getType();
-JType jvType = jv.getElementType();
-String struct_name = JVector.extractVectorName(jvType);
-if (vectorStructs.get(struct_name) == null) {
-vectorStructs.put(struct_name, struct_name);
-h.write("struct " + struct_name + " {\nint32_t 
count;\n" + jv.getElementType().genCDecl("*data") + "\n};\n");
-h.write("int serialize_" + struct_name + "(struct 
oarchive *out, const char *tag, struct " + struct_name + " *v);\n");
-h.write("int deserialize_" + struct_name + "(struct 
iarchive *in, const char *tag, struct " + struct_name + " *v);\n");
-h.write("int allocate_" + struct_name + "(struct " + 
struct_name + " *v, int32_t len);\n");
-h.write("int deallocate_" + struct_name + "(struct " + 
struct_name + " *v);\n");
-c.write("int allocate_" + struct_name + "(struct " + 
struct_name + " *v, int32_t len) {\n");
-c.write("if (!len) {\n");
-c.write("v->count = 0;\n");
-c.write("v->data = 0;\n");
-c.write("} else {\n");
-c.write("v->count = len;\n");
-c.write("v->data = calloc(sizeof(*v->data), 
len);\n");
-c.write("}\n");
-c.write("return 0;\n");
-c.write("}\n");
-c.write("int deallocate_" + struct_name + "(struct " + 
struct_name + " *v) {\n");
-c.write("if (v->data) {\n");
-c.write("int32_t i;\n");
-c.write("for(i=0;icount; i++) {\n");
-c.write("
deallocate_"+JRecord.extractMethodSuffix(jvType)+"(>data[i]);\n");
-c.write("}\n");
-c.write("free(v->data);\n");
-c.write("v->data = 0;\n");
-c.write("}\n");
-c.write("return 0;\n");
-c.write("}\n");
-c.write("int serialize_" + struct_name + "(struct 
oarchive *out, const char *tag, struct " + struct_name + " *v)\n");
-c.write("{\n");
-c.write("int32_t count = v->count;\n");
-c.write("int rc = 0;\n");
-c.write("int32_t i;\n");
-c.write("rc = out->start_vector(out, tag, 
);\n");
-c.write("for(i=0;icount;i++) {\n");
-genSerialize(c, jvType, "data", "data[i]");
-c.write("}\n");
-c.write("rc = rc ? rc : out->end_vector(out, 
tag);\n");
-c.write("return rc;\n");
-c.write("}\n");
-c.write("int deserialize_" + struct_name + "(struct 
iarchive *in, const char *tag, struct " + struct_name + " *v)\n");
-c.write("{\n");
-c.write("int rc = 0;\n");
-c.write("int32_t i;\n");
-c.write("rc = in->start_vector(in, tag, 
>count);\n");
-c.write("v->data = calloc(v->count, 
sizeof(*v->data));\n");
-c.write("for(i=0;icount;i++) {\n");
-genDeserialize(c, jvType, "value", "data[i]");
-c.write("}\n");
-c.write("rc = in->end_vector(in, tag);\n");
-c.write("return rc;\n");
-c.write("}\n");
-
+try {
+for (JField f : mFields) {
+if (f.getType() instanceof JVector) {
+JVector jv = (JVector) f.getType();
+JType 

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648177#comment-15648177
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87027302
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 ---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set set){
  * Check if all groups have majority
  */
 int majGroupCounter = 0;
-for(long gid : expansion.keySet()) {
-LOG.debug("Group info: " + expansion.get(gid) + ", " + gid + 
", " + groupWeight.get(gid));
-if(expansion.get(gid) > (groupWeight.get(gid) / 2) )
+for (Entry entry : expansion.entrySet()) {
+Long gid = entry.getKey();
+LOG.debug("Group info: " + entry.getValue() + ", " + gid + ", 
" + groupWeight.get(gid));
+if(entry.getValue() > (groupWeight.get(gid) / 2) )
--- End diff --

nit: add space after the `if` and remove space before the last parenthesis.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648176#comment-15648176
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87027160
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 ---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set set){
  * Check if all groups have majority
  */
 int majGroupCounter = 0;
-for(long gid : expansion.keySet()) {
-LOG.debug("Group info: " + expansion.get(gid) + ", " + gid + 
", " + groupWeight.get(gid));
-if(expansion.get(gid) > (groupWeight.get(gid) / 2) )
+for (Entry entry : expansion.entrySet()) {
+Long gid = entry.getKey();
+LOG.debug("Group info: " + entry.getValue() + ", " + gid + ", 
" + groupWeight.get(gid));
--- End diff --

We could use modern LOG printing here: 

``
LOG.debug("Group info: {}, {}, {}", entry.getValue(), gid, 
groupWeight.get(gid));
``


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648179#comment-15648179
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87026194
  
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -50,10 +50,8 @@ public static void generateFile(File outputDir, Version 
version, int rev, String
 System.out.println(path + " is not a directory.");
 System.exit(1);
 }
-File file = new File(pkgdir, TYPE_NAME + ".java");
-FileWriter w = null;
-try {
-w = new FileWriter(file);
+
+try (FileWriter w = new FileWriter(new File(pkgdir, TYPE_NAME + 
".java"));) {
--- End diff --

nit: spurious ";"


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648175#comment-15648175
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87028116
  
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1293,13 +1293,12 @@ public synchronized WatchesSummary 
getWatchesSummary() {
  * @param pwriter the output to write to
  */
 public void dumpEphemerals(PrintWriter pwriter) {
-Set keys = ephemerals.keySet();
 pwriter.println("Sessions with Ephemerals ("
-+ keys.size() + "):");
-for (long k : keys) {
-pwriter.print("0x" + Long.toHexString(k));
++ ephemerals.keySet().size() + "):");
+for (Entry entry : ephemerals.entrySet()) {
+pwriter.print("0x" + Long.toHexString(entry.getKey()));
 pwriter.println(":");
-HashSet tmp = ephemerals.get(k);
+HashSet tmp = entry.getValue();
--- End diff --

Could we define `tmp` as `Set` instead of `HashSet`?


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/84#discussion_r87057041
  
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.data.ACL;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class KeyAuthClientTest extends ClientBase {
+private static final Logger LOG = 
LoggerFactory.getLogger(KeyAuthClientTest.class);
+static {
+
System.setProperty("zookeeper.authProvider.1","org.apache.zookeeper.server.auth.KeyAuthenticationProvider");
+}
+
+public void createNodePrintAcl(ZooKeeper zk, String path, String 
testName) {
+  try {
+LOG.debug("KeyAuthenticationProvider Creating Test 
Node:"+path+".\n");
+zk.create(path, null, Ids.CREATOR_ALL_ACL, CreateMode.PERSISTENT);
+List acls = zk.getACL(path, null);
+LOG.debug("Node: "+path+" Test:"+testName+" ACLs:");
+for (ACL acl : acls) {
+  LOG.debug("  "+acl.toString());
+}
+  } catch (Exception e) {
+  LOG.debug("  EXCEPTION THROWN", e);
+  }
+}
+
+public void testPreAuth() throws Exception {
+ZooKeeper zk = createClient();
+zk.addAuthInfo("key", "25".getBytes());
+try {
+createNodePrintAcl(zk, "/pre", "testPreAuth");
+zk.setACL("/", Ids.CREATOR_ALL_ACL, -1);
+zk.getChildren("/", false);
+zk.create("/abc", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/abc", "testData1".getBytes(), -1);
+zk.create("/key", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/key", "5".getBytes(), -1);
+Thread.sleep(1000);
--- End diff --

So, a question for a future ticket (IMHO). :cactus: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2462) force authentication/authorization

[Botond Hejj (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648280#comment-15648280
 ] 

Botond Hejj commented on ZOOKEEPER-2462:


I haven't noticed that. I could have updated that.
There is certainly an overlap. There are some differences though:
- There is a disableWorldAcl option here
- There is an option to enforce a specific Auth scheme in 1634
- The code where enforcement done is different so one need to be picked. 
- 1634 doesn't do anything if actually the check fails. It looks like it was 
never finished
- 1634 is lacking cfg option and unit tests

If one is merged than I don't think the other could be closed. It would be 
great create a union.

> force authentication/authorization
> --
>
> Key: ZOOKEEPER-2462
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2462
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Botond Hejj
>Priority: Minor
> Attachments: ZOOKEEPER-2462.patch, ZOOKEEPER-2462.patch
>
>
> This change introduces two new config options to force authorization and 
> authentication:
> 1. disableWorldACL
> The purpose of this option is disable the builtin mechanism which authorizes 
> everyone.
> If it is turned on than the world/anyone usage is ignored. ZooKeeper will not 
> check operations based on world/anyone.
> This option is useful to force some kind of authorization mechanism. This 
> restriction is useful in a strictly audited environment.
> 2. forceAuthentication
> If this option is turned on than ZooKeeper won't authorize any operation if 
> the user has not authenticated either with SASL or with addAuth.
> There is way to enforce SASL authentication but currently there is no way to 
> enforce authentication using the plugin mechanism. Enforcing authentication 
> for that is more tricky since authentication can come any time later. This 
> option doesn't drop the connection if there was no authentication. It is only 
> throwing NoAuth for any operation until the Auth packet arrives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 310 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/310/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 443154 lines...]
[junit] 2016-11-08 17:14:33,010 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-11-08 17:14:33,010 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-11-08 17:14:33,011 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-11-08 17:14:33,012 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-11-08 17:14:33,012 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-11-08 17:14:33,012 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-11-08 17:14:33,012 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5696618374509823438.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5696618374509823438.junit.dir/version-2
[junit] 2016-11-08 17:14:33,013 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5696618374509823438.junit.dir/version-2/snapshot.b
[junit] 2016-11-08 17:14:33,015 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5696618374509823438.junit.dir/version-2/snapshot.b
[junit] 2016-11-08 17:14:33,017 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-11-08 17:14:33,017 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-11-08 17:14:33,017 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:59130
[junit] 2016-11-08 17:14:33,018 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:59130
[junit] 2016-11-08 17:14:33,018 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-11-08 17:14:33,018 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:59130 (no session established for client)
[junit] 2016-11-08 17:14:33,019 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-11-08 17:14:33,020 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-11-08 17:14:33,020 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-11-08 17:14:33,020 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-11-08 17:14:33,020 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-11-08 17:14:33,021 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17683
[junit] 2016-11-08 17:14:33,021 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-11-08 17:14:33,021 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-11-08 17:14:33,021 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-08 17:14:33,092 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x124c1e9a930 closed
[junit] 2016-11-08 17:14:33,092 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x124c1e9a930
[junit] 2016-11-08 17:14:33,092 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-08 17:14:33,093 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-11-08 17:14:33,093 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-08 17:14:33,093 [myid:] - INFO  

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

[Randgalt]

Github user Randgalt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/84#discussion_r87054533
  
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.data.ACL;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class KeyAuthClientTest extends ClientBase {
+private static final Logger LOG = 
LoggerFactory.getLogger(KeyAuthClientTest.class);
+static {
+
System.setProperty("zookeeper.authProvider.1","org.apache.zookeeper.server.auth.KeyAuthenticationProvider");
+}
+
+public void createNodePrintAcl(ZooKeeper zk, String path, String 
testName) {
+  try {
+LOG.debug("KeyAuthenticationProvider Creating Test 
Node:"+path+".\n");
+zk.create(path, null, Ids.CREATOR_ALL_ACL, CreateMode.PERSISTENT);
+List acls = zk.getACL(path, null);
+LOG.debug("Node: "+path+" Test:"+testName+" ACLs:");
+for (ACL acl : acls) {
+  LOG.debug("  "+acl.toString());
+}
+  } catch (Exception e) {
+  LOG.debug("  EXCEPTION THROWN", e);
+  }
+}
+
+public void testPreAuth() throws Exception {
+ZooKeeper zk = createClient();
+zk.addAuthInfo("key", "25".getBytes());
+try {
+createNodePrintAcl(zk, "/pre", "testPreAuth");
+zk.setACL("/", Ids.CREATOR_ALL_ACL, -1);
+zk.getChildren("/", false);
+zk.create("/abc", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/abc", "testData1".getBytes(), -1);
+zk.create("/key", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/key", "5".getBytes(), -1);
+Thread.sleep(1000);
--- End diff --

These types of sleeps are all over the ZK tests (and Curator for that 
matter). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87027160
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 ---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set set){
  * Check if all groups have majority
  */
 int majGroupCounter = 0;
-for(long gid : expansion.keySet()) {
-LOG.debug("Group info: " + expansion.get(gid) + ", " + gid + 
", " + groupWeight.get(gid));
-if(expansion.get(gid) > (groupWeight.get(gid) / 2) )
+for (Entry entry : expansion.entrySet()) {
+Long gid = entry.getKey();
+LOG.debug("Group info: " + entry.getValue() + ", " + gid + ", 
" + groupWeight.get(gid));
--- End diff --

We could use modern LOG printing here: 

``
LOG.debug("Group info: {}, {}, {}", entry.getValue(), gid, 
groupWeight.get(gid));
``


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87026194
  
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -50,10 +50,8 @@ public static void generateFile(File outputDir, Version 
version, int rev, String
 System.out.println(path + " is not a directory.");
 System.exit(1);
 }
-File file = new File(pkgdir, TYPE_NAME + ".java");
-FileWriter w = null;
-try {
-w = new FileWriter(file);
+
+try (FileWriter w = new FileWriter(new File(pkgdir, TYPE_NAME + 
".java"));) {
--- End diff --

nit: spurious ";"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87027302
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 ---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set set){
  * Check if all groups have majority
  */
 int majGroupCounter = 0;
-for(long gid : expansion.keySet()) {
-LOG.debug("Group info: " + expansion.get(gid) + ", " + gid + 
", " + groupWeight.get(gid));
-if(expansion.get(gid) > (groupWeight.get(gid) / 2) )
+for (Entry entry : expansion.entrySet()) {
+Long gid = entry.getKey();
+LOG.debug("Group info: " + entry.getValue() + ", " + gid + ", 
" + groupWeight.get(gid));
+if(entry.getValue() > (groupWeight.get(gid) / 2) )
--- End diff --

nit: add space after the `if` and remove space before the last parenthesis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87028116
  
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1293,13 +1293,12 @@ public synchronized WatchesSummary 
getWatchesSummary() {
  * @param pwriter the output to write to
  */
 public void dumpEphemerals(PrintWriter pwriter) {
-Set keys = ephemerals.keySet();
 pwriter.println("Sessions with Ephemerals ("
-+ keys.size() + "):");
-for (long k : keys) {
-pwriter.print("0x" + Long.toHexString(k));
++ ephemerals.keySet().size() + "):");
+for (Entry entry : ephemerals.entrySet()) {
+pwriter.print("0x" + Long.toHexString(entry.getKey()));
 pwriter.println(":");
-HashSet tmp = ephemerals.get(k);
+HashSet tmp = entry.getValue();
--- End diff --

Could we define `tmp` as `Set` instead of `HashSet`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/102#discussion_r87038798
  
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -141,109 +141,128 @@ public String genCsharpWriteWrapper(String fname, 
String tag) {
 
 static HashMap vectorStructs = new HashMap();
 public void genCCode(FileWriter h, FileWriter c) throws IOException {
-for (JField f : mFields) {
-if (f.getType() instanceof JVector) {
-JVector jv = (JVector)f.getType();
-JType jvType = jv.getElementType();
-String struct_name = JVector.extractVectorName(jvType);
-if (vectorStructs.get(struct_name) == null) {
-vectorStructs.put(struct_name, struct_name);
-h.write("struct " + struct_name + " {\nint32_t 
count;\n" + jv.getElementType().genCDecl("*data") + "\n};\n");
-h.write("int serialize_" + struct_name + "(struct 
oarchive *out, const char *tag, struct " + struct_name + " *v);\n");
-h.write("int deserialize_" + struct_name + "(struct 
iarchive *in, const char *tag, struct " + struct_name + " *v);\n");
-h.write("int allocate_" + struct_name + "(struct " + 
struct_name + " *v, int32_t len);\n");
-h.write("int deallocate_" + struct_name + "(struct " + 
struct_name + " *v);\n");
-c.write("int allocate_" + struct_name + "(struct " + 
struct_name + " *v, int32_t len) {\n");
-c.write("if (!len) {\n");
-c.write("v->count = 0;\n");
-c.write("v->data = 0;\n");
-c.write("} else {\n");
-c.write("v->count = len;\n");
-c.write("v->data = calloc(sizeof(*v->data), 
len);\n");
-c.write("}\n");
-c.write("return 0;\n");
-c.write("}\n");
-c.write("int deallocate_" + struct_name + "(struct " + 
struct_name + " *v) {\n");
-c.write("if (v->data) {\n");
-c.write("int32_t i;\n");
-c.write("for(i=0;icount; i++) {\n");
-c.write("
deallocate_"+JRecord.extractMethodSuffix(jvType)+"(>data[i]);\n");
-c.write("}\n");
-c.write("free(v->data);\n");
-c.write("v->data = 0;\n");
-c.write("}\n");
-c.write("return 0;\n");
-c.write("}\n");
-c.write("int serialize_" + struct_name + "(struct 
oarchive *out, const char *tag, struct " + struct_name + " *v)\n");
-c.write("{\n");
-c.write("int32_t count = v->count;\n");
-c.write("int rc = 0;\n");
-c.write("int32_t i;\n");
-c.write("rc = out->start_vector(out, tag, 
);\n");
-c.write("for(i=0;icount;i++) {\n");
-genSerialize(c, jvType, "data", "data[i]");
-c.write("}\n");
-c.write("rc = rc ? rc : out->end_vector(out, 
tag);\n");
-c.write("return rc;\n");
-c.write("}\n");
-c.write("int deserialize_" + struct_name + "(struct 
iarchive *in, const char *tag, struct " + struct_name + " *v)\n");
-c.write("{\n");
-c.write("int rc = 0;\n");
-c.write("int32_t i;\n");
-c.write("rc = in->start_vector(in, tag, 
>count);\n");
-c.write("v->data = calloc(v->count, 
sizeof(*v->data));\n");
-c.write("for(i=0;icount;i++) {\n");
-genDeserialize(c, jvType, "value", "data[i]");
-c.write("}\n");
-c.write("rc = in->end_vector(in, tag);\n");
-c.write("return rc;\n");
-c.write("}\n");
-
+try {
+for (JField f : mFields) {
+if (f.getType() instanceof JVector) {
+JVector jv = (JVector) f.getType();
+JType jvType = jv.getElementType();
+String struct_name = JVector.extractVectorName(jvType);
+if (vectorStructs.get(struct_name) == null) {
+vectorStructs.put(struct_name, 

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/84#discussion_r87052291
  
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.data.ACL;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class KeyAuthClientTest extends ClientBase {
+private static final Logger LOG = 
LoggerFactory.getLogger(KeyAuthClientTest.class);
+static {
+
System.setProperty("zookeeper.authProvider.1","org.apache.zookeeper.server.auth.KeyAuthenticationProvider");
+}
+
+public void createNodePrintAcl(ZooKeeper zk, String path, String 
testName) {
+  try {
+LOG.debug("KeyAuthenticationProvider Creating Test 
Node:"+path+".\n");
+zk.create(path, null, Ids.CREATOR_ALL_ACL, CreateMode.PERSISTENT);
+List acls = zk.getACL(path, null);
+LOG.debug("Node: "+path+" Test:"+testName+" ACLs:");
+for (ACL acl : acls) {
+  LOG.debug("  "+acl.toString());
+}
+  } catch (Exception e) {
+  LOG.debug("  EXCEPTION THROWN", e);
+  }
+}
+
+public void testPreAuth() throws Exception {
+ZooKeeper zk = createClient();
+zk.addAuthInfo("key", "25".getBytes());
+try {
+createNodePrintAcl(zk, "/pre", "testPreAuth");
+zk.setACL("/", Ids.CREATOR_ALL_ACL, -1);
+zk.getChildren("/", false);
+zk.create("/abc", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/abc", "testData1".getBytes(), -1);
+zk.create("/key", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/key", "5".getBytes(), -1);
+Thread.sleep(1000);
--- End diff --

Only thing I can suppose (and **please** correct me if I am saying 
something **utterly stupid**) is that this ``sleep`` was inserted in the hopes 
of giving some time to ZK commit the changes. Naive but yet (shrug)... 

Well, I guess we can either remove it or replace it with a 
``zk.getData("/key");``, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648359#comment-15648359
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1525:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/84#discussion_r87052291
  
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.data.ACL;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class KeyAuthClientTest extends ClientBase {
+private static final Logger LOG = 
LoggerFactory.getLogger(KeyAuthClientTest.class);
+static {
+
System.setProperty("zookeeper.authProvider.1","org.apache.zookeeper.server.auth.KeyAuthenticationProvider");
+}
+
+public void createNodePrintAcl(ZooKeeper zk, String path, String 
testName) {
+  try {
+LOG.debug("KeyAuthenticationProvider Creating Test 
Node:"+path+".\n");
+zk.create(path, null, Ids.CREATOR_ALL_ACL, CreateMode.PERSISTENT);
+List acls = zk.getACL(path, null);
+LOG.debug("Node: "+path+" Test:"+testName+" ACLs:");
+for (ACL acl : acls) {
+  LOG.debug("  "+acl.toString());
+}
+  } catch (Exception e) {
+  LOG.debug("  EXCEPTION THROWN", e);
+  }
+}
+
+public void testPreAuth() throws Exception {
+ZooKeeper zk = createClient();
+zk.addAuthInfo("key", "25".getBytes());
+try {
+createNodePrintAcl(zk, "/pre", "testPreAuth");
+zk.setACL("/", Ids.CREATOR_ALL_ACL, -1);
+zk.getChildren("/", false);
+zk.create("/abc", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/abc", "testData1".getBytes(), -1);
+zk.create("/key", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/key", "5".getBytes(), -1);
+Thread.sleep(1000);
--- End diff --

Only thing I can suppose (and **please** correct me if I am saying 
something **utterly stupid**) is that this ``sleep`` was inserted in the hopes 
of giving some time to ZK commit the changes. Naive but yet (shrug)... 

Well, I guess we can either remove it or replace it with a 
``zk.getData("/key");``, right?


> Plumb ZooKeeperServer object into auth plugins
> --
>
> Key: ZOOKEEPER-1525
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Warren Turkal
>Assignee: Jordan Zimmerman
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch
>
>
> I want to plumb the ZooKeeperServer object into the auth plugins so that I 
> can store authentication data in zookeeper itself. With access to the 
> ZooKeeperServer object, I also have access to the ZKDatabase and can look up 
> entries in the local copy of the zookeeper data.
> In order to implement this, I make sure that a ZooKeeperServer instance is 
> passed in to the ProviderRegistry.initialize() method. Then initialize() will 
> try to find a constructor for the AuthenticationProvider that takes a 
> ZooKeeperServer instance. If the constructor is 

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648398#comment-15648398
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1525:
---

Github user Randgalt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/84#discussion_r87054533
  
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.data.ACL;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class KeyAuthClientTest extends ClientBase {
+private static final Logger LOG = 
LoggerFactory.getLogger(KeyAuthClientTest.class);
+static {
+
System.setProperty("zookeeper.authProvider.1","org.apache.zookeeper.server.auth.KeyAuthenticationProvider");
+}
+
+public void createNodePrintAcl(ZooKeeper zk, String path, String 
testName) {
+  try {
+LOG.debug("KeyAuthenticationProvider Creating Test 
Node:"+path+".\n");
+zk.create(path, null, Ids.CREATOR_ALL_ACL, CreateMode.PERSISTENT);
+List acls = zk.getACL(path, null);
+LOG.debug("Node: "+path+" Test:"+testName+" ACLs:");
+for (ACL acl : acls) {
+  LOG.debug("  "+acl.toString());
+}
+  } catch (Exception e) {
+  LOG.debug("  EXCEPTION THROWN", e);
+  }
+}
+
+public void testPreAuth() throws Exception {
+ZooKeeper zk = createClient();
+zk.addAuthInfo("key", "25".getBytes());
+try {
+createNodePrintAcl(zk, "/pre", "testPreAuth");
+zk.setACL("/", Ids.CREATOR_ALL_ACL, -1);
+zk.getChildren("/", false);
+zk.create("/abc", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/abc", "testData1".getBytes(), -1);
+zk.create("/key", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/key", "5".getBytes(), -1);
+Thread.sleep(1000);
--- End diff --

These types of sleeps are all over the ZK tests (and Curator for that 
matter). 


> Plumb ZooKeeperServer object into auth plugins
> --
>
> Key: ZOOKEEPER-1525
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Warren Turkal
>Assignee: Jordan Zimmerman
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch
>
>
> I want to plumb the ZooKeeperServer object into the auth plugins so that I 
> can store authentication data in zookeeper itself. With access to the 
> ZooKeeperServer object, I also have access to the ZKDatabase and can look up 
> entries in the local copy of the zookeeper data.
> In order to implement this, I make sure that a ZooKeeperServer instance is 
> passed in to the ProviderRegistry.initialize() method. Then initialize() will 
> try to find a constructor for the AuthenticationProvider that takes a 
> ZooKeeperServer instance. If the constructor is found, it will be used. 
> Otherwise, initialize() will look for a constructor that takes no arguments 
> and use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648442#comment-15648442
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1525:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/84#discussion_r87057041
  
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.test;
+
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.ZooDefs.Ids;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.data.ACL;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+public class KeyAuthClientTest extends ClientBase {
+private static final Logger LOG = 
LoggerFactory.getLogger(KeyAuthClientTest.class);
+static {
+
System.setProperty("zookeeper.authProvider.1","org.apache.zookeeper.server.auth.KeyAuthenticationProvider");
+}
+
+public void createNodePrintAcl(ZooKeeper zk, String path, String 
testName) {
+  try {
+LOG.debug("KeyAuthenticationProvider Creating Test 
Node:"+path+".\n");
+zk.create(path, null, Ids.CREATOR_ALL_ACL, CreateMode.PERSISTENT);
+List acls = zk.getACL(path, null);
+LOG.debug("Node: "+path+" Test:"+testName+" ACLs:");
+for (ACL acl : acls) {
+  LOG.debug("  "+acl.toString());
+}
+  } catch (Exception e) {
+  LOG.debug("  EXCEPTION THROWN", e);
+  }
+}
+
+public void testPreAuth() throws Exception {
+ZooKeeper zk = createClient();
+zk.addAuthInfo("key", "25".getBytes());
+try {
+createNodePrintAcl(zk, "/pre", "testPreAuth");
+zk.setACL("/", Ids.CREATOR_ALL_ACL, -1);
+zk.getChildren("/", false);
+zk.create("/abc", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/abc", "testData1".getBytes(), -1);
+zk.create("/key", null, Ids.CREATOR_ALL_ACL, 
CreateMode.PERSISTENT);
+zk.setData("/key", "5".getBytes(), -1);
+Thread.sleep(1000);
--- End diff --

So, a question for a future ticket (IMHO). :cactus: 


> Plumb ZooKeeperServer object into auth plugins
> --
>
> Key: ZOOKEEPER-1525
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Warren Turkal
>Assignee: Jordan Zimmerman
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
> ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch
>
>
> I want to plumb the ZooKeeperServer object into the auth plugins so that I 
> can store authentication data in zookeeper itself. With access to the 
> ZooKeeperServer object, I also have access to the ZKDatabase and can look up 
> entries in the local copy of the zookeeper data.
> In order to implement this, I make sure that a ZooKeeperServer instance is 
> passed in to the ProviderRegistry.initialize() method. Then initialize() will 
> try to find a constructor for the AuthenticationProvider that takes a 
> ZooKeeperServer instance. If the constructor is found, it will be used. 
> Otherwise, initialize() will look for a constructor that takes no arguments 
> and use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

[Yuliya Feldman (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648561#comment-15648561
 ] 

Yuliya Feldman commented on ZOOKEEPER-2549:
---

the test failure is irrelevant

> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it 
> can stop main ZK requests processing thread
> --
>
> Key: ZOOKEEPER-2549
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2549
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Yuliya Feldman
>Assignee: Yuliya Feldman
> Attachments: ZOOKEEPER-2549-2.patch, ZOOKEEPER-2549-3.patch, 
> ZOOKEEPER-2549-3.patch, ZOOKEEPER-2549-4.patch, ZOOKEEPER-2549.patch, 
> ZOOKEEPER-2549.patch, zookeeper-2549-1.patch
>
>
> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it 
> can stop main ZK requests processing thread and make Zookeeper server look 
> like it is hanging, while it just can not process any request anymore.
> Idea is to catch all the exceptions in NettyServerCnxn.sendResponse() , 
> convert them to IOException and allow it propagating up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-openjdk7 - Build # 1232 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1232/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H17 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 440e0923dd9e3be533a196fdd6ada960860ca7f6 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 440e0923dd9e3be533a196fdd6ada960860ca7f6
 > git rev-list 440e0923dd9e3be533a196fdd6ada960860ca7f6 # timeout=10
No emails were triggered.
[ZooKeeper-trunk-openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #51

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/51/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 123 lines...]
 [exec] 
 [exec] 
 [exec] There appear to be 0 test files referenced in the patch.
 [exec] The patch appears to be a documentation patch that doesn't require 
tests.
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  GitHub Pull Request  Build
 [exec]   
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/51//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0curl: (6) Could not resolve host: .diff/bin/grep: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/jira:
 No such file or directory
 [exec] Error: No value specified for option "issue"
 [exec] 24ffded2f2c477a0fe7402b89237f5a2739d1ca5 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1627:
 exec returned: 1

Total time: 58 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648697#comment-15648697
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Updated PR to address review comments from @eribeiro.


> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #102: ZOOKEEPER-2628: Fix findbug warnings.

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Updated PR to address review comments from @eribeiro.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch34 - Build # 1714 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/1714/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1566 lines...]
[mkdir] Created dir: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 2 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 8 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/bin
 [copy] Copying 3 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/conf
 [copy] Copying 318 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/docs
 [copy] Copied 22 empty directories to 3 empty directories under 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/docs
 [copy] Copying 8 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT
 [copy] Copying 918 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/src
 [copy] Copied 238 empty directories to 1 empty directory under 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/src

tar:
  [tar] Building tar: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT.tar.gz

check-for-findbugs:

findbugs:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1481: 
java.lang.UnsupportedClassVersionError: 
edu/umd/cs/findbugs/anttask/FindBugsTask : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at 
org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1149)
at 
org.apache.tools.ant.AntClassLoader.getClassFromStream(AntClassLoader.java:1320)
at 
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1376)
at 
org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1337)
at 
org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1089)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:249)
at org.apache.tools.ant.taskdefs.Definer.addDefinition(Definer.java:579)
at org.apache.tools.ant.taskdefs.Definer.execute(Definer.java:237)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
at org.apache.tools.ant.Project.executeTarget(Project.java:1376)
at 
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
at org.apache.tools.ant.Main.runBuild(Main.java:854)
at org.apache.tools.ant.Main.startAnt(Main.java:236)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112)

Total time: 1 minute 3 seconds
mv: cannot stat 'build/test/findbugs': No such file or directory
Build Failed
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

Re: [DISCUSS] QA github pre-commit queue

[Michael Han]

Git PR bot builds
 have
been failing after build 44. From the log it looks like for some reasons,
variables like 'GIT_PR_NUMBER', 'GIT_PR_TITLE' etc were undefined. Is this
a configuration issue of build bot?

On Mon, Nov 7, 2016 at 9:49 AM, Michael Han  wrote:

> +1 for disabling jira qa and only support pull request for code change
> contributions. Besides making support easier this approach is also aligned
> with what Spark and Kafka is doing, and being consistent across Apache
> projects regarding how to use PR seems a good thing to do.
>
> >> have the tool upload the *.patch file to Jira for archiving purposes.
> I think nothing will prevent a user submit a patch file to JIRA with our
> script changes, so the functionality of archiving patches will still work.
> Though, I noticed that Kafka [1] and Spark [2] explicitly stated that do
> not include patch file in JIRA for code contributions, so probably we'd do
> this too for consistency purpose? Are there any benefit of archiving
> patches given we prefer (or actually require) pull request instead of
> patches?
>
> [1] https://cwiki.apache.org/confluence/display/KAFKA/
> Contributing+Code+Changes#ContributingCodeChanges-PullRequest
> [2] https://cwiki.apache.org/confluence/display/SPARK/
> Contributing+to+Spark#ContributingtoSpark-PullRequest
>
> On Mon, Nov 7, 2016 at 8:04 AM, Edward Ribeiro 
> wrote:
>
>> I am +1 about having patches submitted via PRs. IMHO, we should disable
>> the
>> Jira QA altogether, but have the tool upload the *.patch file to Jira for
>> archiving purposes.
>>
>> On Sun, Nov 6, 2016 at 6:42 PM, Raúl Gutiérrez Segalés <
>> r...@itevenworks.net>
>> wrote:
>>
>> > On 6 November 2016 at 11:54, Flavio Junqueira  wrote:
>> >
>> > > ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for
>> > reviewing.
>> > >
>> > > The QA for pull requests should be working for pull requests agains
>> > > master, but let's keep an eye and polish any rough edges that might
>> still
>> > > be there.
>> > >
>> > > With ZOOKEEPER-2624 in, there is one last major decision we need to
>> make
>> > > to wrap this up. The pull request QA currently do not make a jira
>> patch
>> > > available. This is intentional because making it patch available will
>> > > trigger the original Jira QA, which will be confusing because we will
>> > see a
>> > > failure (I haven't tested, but I think that's what's going to
>> happen). If
>> > > we change the script to make the Jira patch available, then we need to
>> > > either:
>> > >
>> > > 1- Disable the Jira QA altogether, which means that we will only have
>> > pull
>> > > request QA available
>> > > 2- Make the Jira QA script spot that there is a pull request available
>> > and
>> > > not build it.
>> > >
>> > > I'm wondering if folks would be ok with only having patches submitted
>> via
>> > > pull requests or if we should continue to support the old Jira QA.
>> > >
>> >
>> > I am +1 on only having patches submitted via PRs, it's simpler to only
>> have
>> > to support one method. Thanks Flavio for making this happen!
>> >
>> >
>> > -rgs
>> >
>>
>
>
>
> --
> Cheers
> Michael.
>



-- 
Cheers
Michael.

Re: [DISCUSS] QA github pre-commit queue

[Flavio P JUNQUEIRA]

I don't have any strong argument for keeping the Jira patches other than
the fact that this is what we have been doing since the project was
created. If there is anyone who do not want to use github in the community,
please speak up.

-Flavio

On Mon, Nov 7, 2016 at 9:49 AM, Michael Han  wrote:

> +1 for disabling jira qa and only support pull request for code change
> contributions. Besides making support easier this approach is also aligned
> with what Spark and Kafka is doing, and being consistent across Apache
> projects regarding how to use PR seems a good thing to do.
>
> >> have the tool upload the *.patch file to Jira for archiving purposes.
> I think nothing will prevent a user submit a patch file to JIRA with our
> script changes, so the functionality of archiving patches will still work.
> Though, I noticed that Kafka [1] and Spark [2] explicitly stated that do
> not include patch file in JIRA for code contributions, so probably we'd do
> this too for consistency purpose? Are there any benefit of archiving
> patches given we prefer (or actually require) pull request instead of
> patches?
>
> [1]
> https://cwiki.apache.org/confluence/display/KAFKA/
> Contributing+Code+Changes#ContributingCodeChanges-PullRequest
> [2]
> https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#
> ContributingtoSpark-PullRequest
>
> On Mon, Nov 7, 2016 at 8:04 AM, Edward Ribeiro 
> wrote:
>
> > I am +1 about having patches submitted via PRs. IMHO, we should disable
> the
> > Jira QA altogether, but have the tool upload the *.patch file to Jira for
> > archiving purposes.
> >
> > On Sun, Nov 6, 2016 at 6:42 PM, Raúl Gutiérrez Segalés <
> > r...@itevenworks.net>
> > wrote:
> >
> > > On 6 November 2016 at 11:54, Flavio Junqueira  wrote:
> > >
> > > > ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for
> > > reviewing.
> > > >
> > > > The QA for pull requests should be working for pull requests agains
> > > > master, but let's keep an eye and polish any rough edges that might
> > still
> > > > be there.
> > > >
> > > > With ZOOKEEPER-2624 in, there is one last major decision we need to
> > make
> > > > to wrap this up. The pull request QA currently do not make a jira
> patch
> > > > available. This is intentional because making it patch available will
> > > > trigger the original Jira QA, which will be confusing because we will
> > > see a
> > > > failure (I haven't tested, but I think that's what's going to
> happen).
> > If
> > > > we change the script to make the Jira patch available, then we need
> to
> > > > either:
> > > >
> > > > 1- Disable the Jira QA altogether, which means that we will only have
> > > pull
> > > > request QA available
> > > > 2- Make the Jira QA script spot that there is a pull request
> available
> > > and
> > > > not build it.
> > > >
> > > > I'm wondering if folks would be ok with only having patches submitted
> > via
> > > > pull requests or if we should continue to support the old Jira QA.
> > > >
> > >
> > > I am +1 on only having patches submitted via PRs, it's simpler to only
> > have
> > > to support one method. Thanks Flavio for making this happen!
> > >
> > >
> > > -rgs
> > >
> >
>
>
>
> --
> Cheers
> Michael.
>

Re: [DISCUSS] QA github pre-commit queue

[Flavio P JUNQUEIRA]

My bad, I made the build parameterized to see if I could trigger it
manually. I have disabled the parameters and should be back to normal now.

-Flavio

On Tue, Nov 8, 2016 at 4:00 PM, Michael Han  wrote:

> Git PR bot builds
>  have
> been failing after build 44. From the log it looks like for some reasons,
> variables like 'GIT_PR_NUMBER', 'GIT_PR_TITLE' etc were undefined. Is this
> a configuration issue of build bot?
>
> On Mon, Nov 7, 2016 at 9:49 AM, Michael Han  wrote:
>
> > +1 for disabling jira qa and only support pull request for code change
> > contributions. Besides making support easier this approach is also
> aligned
> > with what Spark and Kafka is doing, and being consistent across Apache
> > projects regarding how to use PR seems a good thing to do.
> >
> > >> have the tool upload the *.patch file to Jira for archiving purposes.
> > I think nothing will prevent a user submit a patch file to JIRA with our
> > script changes, so the functionality of archiving patches will still
> work.
> > Though, I noticed that Kafka [1] and Spark [2] explicitly stated that do
> > not include patch file in JIRA for code contributions, so probably we'd
> do
> > this too for consistency purpose? Are there any benefit of archiving
> > patches given we prefer (or actually require) pull request instead of
> > patches?
> >
> > [1] https://cwiki.apache.org/confluence/display/KAFKA/
> > Contributing+Code+Changes#ContributingCodeChanges-PullRequest
> > [2] https://cwiki.apache.org/confluence/display/SPARK/
> > Contributing+to+Spark#ContributingtoSpark-PullRequest
> >
> > On Mon, Nov 7, 2016 at 8:04 AM, Edward Ribeiro  >
> > wrote:
> >
> >> I am +1 about having patches submitted via PRs. IMHO, we should disable
> >> the
> >> Jira QA altogether, but have the tool upload the *.patch file to Jira
> for
> >> archiving purposes.
> >>
> >> On Sun, Nov 6, 2016 at 6:42 PM, Raúl Gutiérrez Segalés <
> >> r...@itevenworks.net>
> >> wrote:
> >>
> >> > On 6 November 2016 at 11:54, Flavio Junqueira  wrote:
> >> >
> >> > > ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for
> >> > reviewing.
> >> > >
> >> > > The QA for pull requests should be working for pull requests agains
> >> > > master, but let's keep an eye and polish any rough edges that might
> >> still
> >> > > be there.
> >> > >
> >> > > With ZOOKEEPER-2624 in, there is one last major decision we need to
> >> make
> >> > > to wrap this up. The pull request QA currently do not make a jira
> >> patch
> >> > > available. This is intentional because making it patch available
> will
> >> > > trigger the original Jira QA, which will be confusing because we
> will
> >> > see a
> >> > > failure (I haven't tested, but I think that's what's going to
> >> happen). If
> >> > > we change the script to make the Jira patch available, then we need
> to
> >> > > either:
> >> > >
> >> > > 1- Disable the Jira QA altogether, which means that we will only
> have
> >> > pull
> >> > > request QA available
> >> > > 2- Make the Jira QA script spot that there is a pull request
> available
> >> > and
> >> > > not build it.
> >> > >
> >> > > I'm wondering if folks would be ok with only having patches
> submitted
> >> via
> >> > > pull requests or if we should continue to support the old Jira QA.
> >> > >
> >> >
> >> > I am +1 on only having patches submitted via PRs, it's simpler to only
> >> have
> >> > to support one method. Thanks Flavio for making this happen!
> >> >
> >> >
> >> > -rgs
> >> >
> >>
> >
> >
> >
> > --
> > Cheers
> > Michael.
> >
>
>
>
> --
> Cheers
> Michael.
>

ZooKeeper-trunk-WinVS2008 - Build # 2319 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2319/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 78 lines...]

ivy-retrieve:
[ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 :: 
http://ant.apache.org/ivy/ ::
[ivy:retrieve] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  found jline#jline;2.11 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-server;9.2.18.v20160721 in maven2
[ivy:retrieve]  found javax.servlet#javax.servlet-api;3.1.0 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-http;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-util;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-io;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-servlet;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-security;9.2.18.v20160721 in 
maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-mapper-asl;1.9.11 in maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-core-asl;1.9.11 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-api;1.7.5 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-log4j12;1.7.5 in maven2
[ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
[ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
[ivy:retrieve]  found io.netty#netty;3.10.5.Final in maven2
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] :: resolution report :: resolve 578ms :: artifacts dl 65ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   16  |   0   |   0   |   0   ||   16  |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  16 artifacts copied, 0 already retrieved (4635kB/257ms)

generate_jute_parser:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\jute_compiler\org\apache\jute\compiler\generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
 [move] Moving 1 file to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\src\java\main\org\apache\jute\compiler\generated\rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build.xml:273: 
Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "C:\Program Files\Java\jre1.8.0_92"

Total time: 4 seconds
Build step 'Invoke Ant' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

RE: [jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug warnings

[Kanniappan, Mohanarangan (Nokia - IN/Bangalore)]

Please unsubscribe me.



-Original Message-
From: ASF GitHub Bot (JIRA) [mailto:j...@apache.org] 
Sent: Tuesday, November 08, 2016 11:27 AM
To: dev@zookeeper.apache.org
Subject: [jira] [Commented] (ZOOKEEPER-2628) Investigate and fix findbug 
warnings


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646614#comment-15646614
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2628:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/102
  
Updated PR to address review comments from @breed.



> Investigate and fix findbug warnings
> 
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to 
> Infra team, and this leads to 20 new warnings produced by findbug. The 
> warning reports can be found on [pre commit 
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build 
> number >= 3513. These warnings need to be triaged and fixed if they are 
> legitimate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1377 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1377/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 437314 lines...]
[junit] 2016-11-08 08:23:36,177 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-11-08 08:23:36,177 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-11-08 08:23:36,178 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-11-08 08:23:36,179 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-11-08 08:23:36,179 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-11-08 08:23:36,180 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-11-08 08:23:36,180 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2778402329456968798.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2778402329456968798.junit.dir/version-2
[junit] 2016-11-08 08:23:36,182 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2778402329456968798.junit.dir/version-2/snapshot.b
[junit] 2016-11-08 08:23:36,185 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2778402329456968798.junit.dir/version-2/snapshot.b
[junit] 2016-11-08 08:23:36,187 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-11-08 08:23:36,187 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-11-08 08:23:36,188 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:33811
[junit] 2016-11-08 08:23:36,189 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:33811
[junit] 2016-11-08 08:23:36,190 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-11-08 08:23:36,190 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:33811 (no session established for client)
[junit] 2016-11-08 08:23:36,190 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-11-08 08:23:36,192 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-11-08 08:23:36,192 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-11-08 08:23:36,193 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-11-08 08:23:36,193 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-11-08 08:23:36,193 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17666
[junit] 2016-11-08 08:23:36,193 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-11-08 08:23:36,194 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-11-08 08:23:36,194 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-08 08:23:36,263 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x124c0038f0a closed
[junit] 2016-11-08 08:23:36,263 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x124c0038f0a
[junit] 2016-11-08 08:23:36,263 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-08 08:23:36,264 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-11-08 08:23:36,264 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-08 08:23:36,264 [myid:] - INFO  

ZooKeeper_branch35_openjdk7 - Build # 290 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/290/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H16 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.5^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.5^{commit} # timeout=10
Checking out Revision 6bd38e3d89ecc03285459be3e511d32f487ced0c 
(refs/remotes/origin/branch-3.5)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 6bd38e3d89ecc03285459be3e511d32f487ced0c
 > git rev-list 6bd38e3d89ecc03285459be3e511d32f487ced0c # timeout=10
No emails were triggered.
[ZooKeeper_branch35_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk7 - Build # 725 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/725/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 470336 lines...]
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:19425
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-11-08 08:52:35,521 [myid:] - INFO  [New I/O boss 
#9471:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-11-08 08:52:35,521 [myid:127.0.0.1:19425] - INFO  
[main-SendThread(127.0.0.1:19425):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x203486ce794 is lost, closing socket connection and attempting 
reconnect
[junit] 2016-11-08 08:55:19,172 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 27636
[junit] 2016-11-08 08:55:19,173 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55
[junit] 2016-11-08 08:55:19,173 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2016-11-08 08:55:19,173 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-08 08:55:19,174 [myid:] - INFO  [ProcessThread(sid:0 
cport:16611)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x10348657524
[junit] 2016-11-08 08:55:19,211 [myid:] - INFO  
[NIOWorkerThread-19:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=Connections,name2=127.0.0.1,name3=0x10348657524]
[junit] 2016-11-08 08:55:19,211 [myid:] - INFO  
[NIOWorkerThread-19:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:43752 which had sessionid 0x10348657524
[junit] 2016-11-08 08:55:19,212 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x10348657524 closed
[junit] 2016-11-08 08:55:19,212 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x10348657524
[junit] 2016-11-08 08:55:19,313 [myid:] - INFO  [ProcessThread(sid:0 
cport:16611)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x103486575240001
[junit] 2016-11-08 08:55:19,339 [myid:] - INFO  
[NIOWorkerThread-12:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=Connections,name2=127.0.0.1,name3=0x103486575240001]
[junit] 2016-11-08 08:55:19,340 [myid:] - INFO  
[NIOWorkerThread-12:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:43741 which had sessionid 0x103486575240001
[junit] 2016-11-08 08:55:19,340 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x103486575240001 closed
[junit] 2016-11-08 08:55:19,340 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-08 08:55:19,340 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x103486575240001
[junit] 2016-11-08 08:55:19,341 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:16611:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-11-08 08:55:19,341 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-11-08 08:55:19,344 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-08 08:55:19,344 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-08 08:55:19,345 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-11-08 08:55:19,350