Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvat...@ami.com
Hi mikub...@linux.microsoft.com, gaolim...@byosoft.com.cn,michael.d.kin...@intel.com, vasudev...@ami.com, sundares...@ami.com Created PULL request for Coverity Issue changes. UFS PR: https://github.com/tianocore/edk2/pull/3552 BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3989 ( https://bugzilla.tianocore.org/show_bug.cgi?id=3994 ) All Checks are Passed. Thanks, Sivaparvathi C -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95669): https://edk2.groups.io/g/devel/message/95669 Mute This Topic: https://groups.io/mt/94378547/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205
Hi mikub...@linux.microsoft.com, gaolim...@byosoft.com.cn,michael.d.kin...@intel.com, vasudev...@ami.com, sundares...@ami.com Created PULL request for Coverity Issue changes. SCSI PR: https://github.com/tianocore/edk2/pull/3544 BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3994 All Checks are Passed. Thanks, Sivaparvathi C -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95668): https://edk2.groups.io/g/devel/message/95668 Mute This Topic: https://groups.io/mt/94229354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvat...@ami.com
Hi mikub...@linux.microsoft.com , gaolim...@byosoft.com.cn , michael.d.kin...@intel.com Created PULL request for edk2_stable202205 coverity issue changes for Ufs driver. https://github.com/tianocore/edk2/pull/3472 Thanks, Sivaparvathi C -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95147): https://edk2.groups.io/g/devel/message/95147 Mute This Topic: https://groups.io/mt/94193359/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205
Hi mikub...@linux.microsoft.com , gaolim...@byosoft.com.cn , michael.d.kin...@intel.com Created Pull Request for edk2_Stable202205 Coverity Changes for SCSI driver. https://github.com/tianocore/edk2/pull/3473 Thanks, Sivaparvathi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95146): https://edk2.groups.io/g/devel/message/95146 Mute This Topic: https://groups.io/mt/94229354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvat...@ami.com
On Tue, Sep 13, 2022 at 10:44 AM, gaoliming wrote: > > gaoliming Hi GaoLiming, Could you please review the changes? Thanks, Sivaparvathi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94782): https://edk2.groups.io/g/devel/message/94782 Mute This Topic: https://groups.io/mt/93649766/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line
HI GaoLiming, The redundant symbol is available after using Hexedit and Edit command in the shell. I have tried these 2 commands. These changes are required for Hexedit and Edit commands only. I have tried the edk2-edk2-stable202002 source Emulator64 environment. It will produce shell.efi application. Tried this application on the MSI platform, and the redundant cursor symbol was available on the shell screen. Thanks, Sivaparvathi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94781): https://edk2.groups.io/g/devel/message/94781 Mute This Topic: https://groups.io/mt/93650526/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205
Hi gaoliming, How can i create EDK2 pull request ? Can you share the steps? Thanks, Sivaparvathi C -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94780): https://edk2.groups.io/g/devel/message/94780 Mute This Topic: https://groups.io/mt/93649786/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line
Hi gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>, The redundant symbol is available after using Hexedit and Edit command in the shell. I have tried these 2 commands only. These changes are required for Hexedit and Edit commands only. Thanks, Sivaparvathi C From: gaoliming Sent: Tuesday, September 13, 2022 12:22 PM To: devel@edk2.groups.io; Sivaparvathi Chellaiah Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Sivaparvathi: Is EnableCursor always required after ClearScreen()? Or, is it only required in Hexedit command? Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> 代表 sivaparvathi C via groups.io 发送时间: 2022年9月12日 17:13 收件人: sivaparvathi C mailto:sivaparvat...@ami.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> 主题: Re: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line Hi gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn> , Could you please review the changes? Thanks, Sivaparvathi C -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93801): https://edk2.groups.io/g/devel/message/93801 Mute This Topic: https://groups.io/mt/93650526/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line
Hi gaolim...@byosoft.com.cn , Could you please review the changes? Thanks, Sivaparvathi C -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93645): https://edk2.groups.io/g/devel/message/93645 Mute This Topic: https://groups.io/mt/92765913/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvat...@ami.com
Hi gaolim...@byosoft.com.cn , Could you please review the changes ? Thanks, Sivaparvathi C -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93644): https://edk2.groups.io/g/devel/message/93644 Mute This Topic: https://groups.io/mt/92765057/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205
Hi gaoliming, When these changes will include in the EDK2 source? in next EDK2 release? Thanks, Sivaparvathi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93643): https://edk2.groups.io/g/devel/message/93643 Mute This Topic: https://groups.io/mt/92829971/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line
Added changes to clear the redundant symbol after using Hexedit cmd in shell screen page. During ClearScreen(),first screen was cleared and cursor was set to new position(0,0) ,but the visible state of cursor is always 1. in setcursorposition(),cursor was disabled during that time,old cursor data is drawn to screen. Signed-off-by: sivaparvat...@ami.com --- .../Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c| 2 ++ .../Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c index 58beaaf9c5..58df2e022b 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c @@ -1627,6 +1627,7 @@ MainEditorCleanup ( ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_EDIT_LIBEDITOR_FILEBUFFER_CLEANUP), gShellDebug1HiiHandle); } + gST->ConOut->EnableCursor (gST->ConOut, FALSE); // // restore old mode // @@ -1644,6 +1645,7 @@ MainEditorCleanup ( gST->ConOut->ClearScreen (gST->ConOut); + gST->ConOut->EnableCursor (gST->ConOut, TRUE); return EFI_SUCCESS; } diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c index 0eb917acf7..8b3d5225db 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c @@ -1833,6 +1833,7 @@ HMainEditorCleanup ( ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_HEXEDIT_LIBEDITOR_CLIPBOARD_CLEAN), gShellDebug1HiiHandle); } + gST->ConOut->EnableCursor (gST->ConOut, FALSE); // // restore old mode // @@ -1845,6 +1846,7 @@ HMainEditorCleanup ( EFI_TEXT_ATTR (HOriginalColors.Foreground, HOriginalColors.Background) ); gST->ConOut->ClearScreen (gST->ConOut); + gST->ConOut->EnableCursor (gST->ConOut, TRUE); return EFI_SUCCESS; } -- 2.31.0.windows.1 -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92042): https://edk2.groups.io/g/devel/message/92042 Mute This Topic: https://groups.io/mt/92765913/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205
Attached changes to resolve the coverity Issues
Signed-off-by: sivaparvat...@ami.com
To: sivaparvat...@ami.com
---
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 3 +++
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 10 +-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
index 9ea69ee740..2cc61bb942 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c
@@ -531,6 +531,9 @@ SCSIBusDriverBindingStart (
// then create handle and install scsi i/o protocol.
//
Status = ScsiScanCreateDevice (This, Controller, , Lun,
ScsiBusDev);
+if (Status == EFI_OUT_OF_RESOURCES) {
+goto ErrorExit;
+}
}
return EFI_SUCCESS;
diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
index 98e84b4ea8..5f4ead7669 100644
--- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
+++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c
@@ -4247,7 +4247,7 @@ BackOff:
if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) ||
(EFI_ERROR (ReturnStatus))) {
DEBUG ((DEBUG_ERROR, "ScsiDiskRead10: Check Condition happened!\n"));
-Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA),
);
+DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData,
SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), );
if (Action == ACTION_RETRY_COMMAND_LATER) {
*NeedRetry = TRUE;
return EFI_DEVICE_ERROR;
@@ -4371,7 +4371,7 @@ BackOff:
if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) ||
(EFI_ERROR (ReturnStatus))) {
DEBUG ((DEBUG_ERROR, "ScsiDiskWrite10: Check Condition happened!\n"));
-Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA),
);
+DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData,
SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), );
if (Action == ACTION_RETRY_COMMAND_LATER) {
*NeedRetry = TRUE;
return EFI_DEVICE_ERROR;
@@ -4494,7 +4494,7 @@ BackOff:
if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) ||
(EFI_ERROR (ReturnStatus))) {
DEBUG ((DEBUG_ERROR, "ScsiDiskRead16: Check Condition happened!\n"));
-Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA),
);
+DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData,
SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), );
if (Action == ACTION_RETRY_COMMAND_LATER) {
*NeedRetry = TRUE;
return EFI_DEVICE_ERROR;
@@ -4618,7 +4618,7 @@ BackOff:
if ((TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) ||
(EFI_ERROR (ReturnStatus))) {
DEBUG ((DEBUG_ERROR, "ScsiDiskWrite16: Check Condition happened!\n"));
-Status = DetectMediaParsingSenseKeys (ScsiDiskDevice,
ScsiDiskDevice->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA),
);
+DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData,
SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), );
if (Action == ACTION_RETRY_COMMAND_LATER) {
*NeedRetry = TRUE;
return EFI_DEVICE_ERROR;
@@ -4728,7 +4728,7 @@ ScsiDiskNotify (
if (Request->TargetStatus == EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) {
DEBUG ((DEBUG_ERROR, "ScsiDiskNotify: Check Condition happened!\n"));
-Status = DetectMediaParsingSenseKeys (
+DetectMediaParsingSenseKeys (
ScsiDiskDevice,
Request->SenseData,
Request->SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA),
--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92041): https://edk2.groups.io/g/devel/message/92041
Mute This Topic: https://groups.io/mt/92765259/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvat...@ami.com
---
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c | 18 --
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c | 3 +++
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
index 62aeaf86c8..b4b0f07d5e 100644
--- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
+++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/DmaMem.c
@@ -240,10 +240,16 @@ IoMmuInit (
VOID
)
{
- PeiServicesLocatePpi (
-,
-0,
-NULL,
-(VOID **)
-);
+EFI_STATUSStatus;
+
+Status = PeiServicesLocatePpi (
+,
+0,
+NULL,
+(VOID **)
+);
+
+if (EFI_ERROR(Status)) {
+DEBUG ((DEBUG_INFO, "Locate mIoMmu Ppi is failed!!!\n"));
+}
}
diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
index b7dd9b6acd..b5f0324908 100644
--- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
+++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
@@ -414,6 +414,9 @@ UfsPeimFreeMem (
//
ASSERT (Block != NULL);
+ if (Block == NULL) {
+ return;
+ }
//
// Release the current memory block if it is empty and not the head
//
--
2.31.0.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92040): https://edk2.groups.io/g/devel/message/92040
Mute This Topic: https://groups.io/mt/92765057/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
