Re: [edk2-devel] [PATCH 2/3] MdePkg: Add EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dionna Glaze > via groups.io > Sent: Tuesday, November 8, 2022 8:46 AM > To: devel@edk2.groups.io > Cc: Dionna Glaze ; Ard Biescheuvel ; > Xu, Min M ; Gerd Hoffmann > ; James Bottomley ; Tom Lendacky > ; Yao, Jiewen > ; Aktas, Erdem ; Yao, Jiewen > > Subject: [edk2-devel] [PATCH 2/3] MdePkg: Add > EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID > > Event group as defined in UEFI standard v2.9. > > Cc: Ard Biescheuvel > Cc: "Min M. Xu" > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Tom Lendacky > Cc: Jiewen Yao > Cc: Erdem Aktas > > Acked-by: Jiewen Yao > Signed-off-by: Dionna Glaze > --- > MdePkg/Include/Guid/EventGroup.h | 5 + > MdePkg/MdePkg.dec| 5 - > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Guid/EventGroup.h > b/MdePkg/Include/Guid/EventGroup.h > index 063d1f7157..64bfd4bab9 100644 > --- a/MdePkg/Include/Guid/EventGroup.h > +++ b/MdePkg/Include/Guid/EventGroup.h > @@ -14,6 +14,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > extern EFI_GUID gEfiEventExitBootServicesGuid; > > +#define EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES \ > + { 0x8be0e274, 0x3970, 0x4b44, { 0x80, 0xc5, 0x1a, 0xb9, 0x50, 0x2f, 0x3b, > 0xfc } } > + > +extern EFI_GUID gEfiEventBeforeExitBootServicesGuid; > + > #define EFI_EVENT_GROUP_VIRTUAL_ADDRESS_CHANGE \ >{ 0x13fa7698, 0xc831, 0x49c7, { 0x87, 0xea, 0x8f, 0x43, 0xfc, 0xc2, 0x51, > 0x96 } } > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 6b6bfbec29..359a85ea10 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -408,7 +408,10 @@ >gEfiEventMemoryMapChangeGuid = { 0x78BEE926, 0x692F, 0x48FD, { 0x9E, > 0xDB, 0x01, 0x42, 0x2E, 0xF0, 0xD7, 0xAB }} > >## Include/Guid/EventGroup.h > - gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { 0x87, > 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }} > + gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { > 0x87, 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }} > + > + ## Include/Guid/EventGroup.h > + gEfiEventBeforeExitBootServicesGuid = { 0x8BE0E274, 0x3970, 0x4B44, { > 0x80, 0xC5, 0x1A, 0xB9, 0x50, 0x2F, 0x3B, 0xFC }} > >## Include/Guid/EventGroup.h >gEfiEventExitBootServicesGuid = { 0x27ABF055, 0xB1B8, 0x4C26, { 0x80, > 0x48, 0x74, 0x8F, 0x37, 0xBA, 0xA2, 0xDF }} > -- > 2.38.1.431.g37b22c650d-goog > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96166): https://edk2.groups.io/g/devel/message/96166 Mute This Topic: https://groups.io/mt/94894286/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] MdePkg: Add EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID
Hi Dionna, For the feature you are working on, it looks like you only require the before exit boot services event. However, the UEFI 2.9 Spec added the before and after events at the same time. I recommend these patches be updated to add both events and signal both events. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dionna Glaze > via groups.io > Sent: Tuesday, November 8, 2022 8:46 AM > To: devel@edk2.groups.io > Cc: Dionna Glaze ; Ard Biescheuvel ; > Xu, Min M ; Gerd Hoffmann > ; James Bottomley ; Tom Lendacky > ; Yao, Jiewen > ; Aktas, Erdem ; Yao, Jiewen > > Subject: [edk2-devel] [PATCH 2/3] MdePkg: Add > EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID > > Event group as defined in UEFI standard v2.9. > > Cc: Ard Biescheuvel > Cc: "Min M. Xu" > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Tom Lendacky > Cc: Jiewen Yao > Cc: Erdem Aktas > > Acked-by: Jiewen Yao > Signed-off-by: Dionna Glaze > --- > MdePkg/Include/Guid/EventGroup.h | 5 + > MdePkg/MdePkg.dec| 5 - > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Guid/EventGroup.h > b/MdePkg/Include/Guid/EventGroup.h > index 063d1f7157..64bfd4bab9 100644 > --- a/MdePkg/Include/Guid/EventGroup.h > +++ b/MdePkg/Include/Guid/EventGroup.h > @@ -14,6 +14,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > extern EFI_GUID gEfiEventExitBootServicesGuid; > > +#define EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES \ > + { 0x8be0e274, 0x3970, 0x4b44, { 0x80, 0xc5, 0x1a, 0xb9, 0x50, 0x2f, 0x3b, > 0xfc } } > + > +extern EFI_GUID gEfiEventBeforeExitBootServicesGuid; > + > #define EFI_EVENT_GROUP_VIRTUAL_ADDRESS_CHANGE \ >{ 0x13fa7698, 0xc831, 0x49c7, { 0x87, 0xea, 0x8f, 0x43, 0xfc, 0xc2, 0x51, > 0x96 } } > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 6b6bfbec29..359a85ea10 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -408,7 +408,10 @@ >gEfiEventMemoryMapChangeGuid = { 0x78BEE926, 0x692F, 0x48FD, { 0x9E, > 0xDB, 0x01, 0x42, 0x2E, 0xF0, 0xD7, 0xAB }} > >## Include/Guid/EventGroup.h > - gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { 0x87, > 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }} > + gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { > 0x87, 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }} > + > + ## Include/Guid/EventGroup.h > + gEfiEventBeforeExitBootServicesGuid = { 0x8BE0E274, 0x3970, 0x4B44, { > 0x80, 0xC5, 0x1A, 0xB9, 0x50, 0x2F, 0x3B, 0xFC }} > >## Include/Guid/EventGroup.h >gEfiEventExitBootServicesGuid = { 0x27ABF055, 0xB1B8, 0x4C26, { 0x80, > 0x48, 0x74, 0x8F, 0x37, 0xBA, 0xA2, 0xDF }} > -- > 2.38.1.431.g37b22c650d-goog > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96094): https://edk2.groups.io/g/devel/message/96094 Mute This Topic: https://groups.io/mt/94894286/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 2/3] MdePkg: Add EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID
Event group as defined in UEFI standard v2.9. Cc: Ard Biescheuvel Cc: "Min M. Xu" Cc: Gerd Hoffmann Cc: James Bottomley Cc: Tom Lendacky Cc: Jiewen Yao Cc: Erdem Aktas Acked-by: Jiewen Yao Signed-off-by: Dionna Glaze --- MdePkg/Include/Guid/EventGroup.h | 5 + MdePkg/MdePkg.dec| 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/EventGroup.h b/MdePkg/Include/Guid/EventGroup.h index 063d1f7157..64bfd4bab9 100644 --- a/MdePkg/Include/Guid/EventGroup.h +++ b/MdePkg/Include/Guid/EventGroup.h @@ -14,6 +14,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent extern EFI_GUID gEfiEventExitBootServicesGuid; +#define EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES \ + { 0x8be0e274, 0x3970, 0x4b44, { 0x80, 0xc5, 0x1a, 0xb9, 0x50, 0x2f, 0x3b, 0xfc } } + +extern EFI_GUID gEfiEventBeforeExitBootServicesGuid; + #define EFI_EVENT_GROUP_VIRTUAL_ADDRESS_CHANGE \ { 0x13fa7698, 0xc831, 0x49c7, { 0x87, 0xea, 0x8f, 0x43, 0xfc, 0xc2, 0x51, 0x96 } } diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 6b6bfbec29..359a85ea10 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -408,7 +408,10 @@ gEfiEventMemoryMapChangeGuid = { 0x78BEE926, 0x692F, 0x48FD, { 0x9E, 0xDB, 0x01, 0x42, 0x2E, 0xF0, 0xD7, 0xAB }} ## Include/Guid/EventGroup.h - gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { 0x87, 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }} + gEfiEventVirtualAddressChangeGuid = { 0x13FA7698, 0xC831, 0x49C7, { 0x87, 0xEA, 0x8F, 0x43, 0xFC, 0xC2, 0x51, 0x96 }} + + ## Include/Guid/EventGroup.h + gEfiEventBeforeExitBootServicesGuid = { 0x8BE0E274, 0x3970, 0x4B44, { 0x80, 0xC5, 0x1A, 0xB9, 0x50, 0x2F, 0x3B, 0xFC }} ## Include/Guid/EventGroup.h gEfiEventExitBootServicesGuid = { 0x27ABF055, 0xB1B8, 0x4C26, { 0x80, 0x48, 0x74, 0x8F, 0x37, 0xBA, 0xA2, 0xDF }} -- 2.38.1.431.g37b22c650d-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96090): https://edk2.groups.io/g/devel/message/96090 Mute This Topic: https://groups.io/mt/94894286/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-