Re: [edk2-devel] [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files
On Wed, 6 Apr 2022 at 22:02, Marcin Wojtas wrote: > > Hi, > > pon., 14 mar 2022 o 18:17 Sunny Wang napisał(a): > > > > Looks good. Thanks much, Marcin. > > > > This will be helpful as http://wiki.macchiatobin.net/tiki-index.php has > > been not accessible for quite a while. > > > > Reviewed-by: Sunny Wang > > > > Do you have any feedback about the patch? > Pushed as fe223fb30f74..c06b98a171be Thanks, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89127): https://edk2.groups.io/g/devel/message/89127 Mute This Topic: https://groups.io/mt/89771621/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files
Hi, pon., 14 mar 2022 o 18:17 Sunny Wang napisał(a): > > Looks good. Thanks much, Marcin. > > This will be helpful as http://wiki.macchiatobin.net/tiki-index.php has been > not accessible for quite a while. > > Reviewed-by: Sunny Wang > Do you have any feedback about the patch? Best regards, Marcin > Best Regards, > Sunny > -Original Message- > From: Marcin Wojtas > Sent: 14 March 2022 12:06 > To: devel@edk2.groups.io > Cc: quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; j...@semihalf.com; > g...@semihalf.com; Sunny Wang ; Marcin Wojtas > > Subject: [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files > > From: Grzegorz Bernacki > > This patch reworks Readme.md files of Marvell and SolidRun > platforms as follows: > * Add supported features list. > * Leave minmal EDK2 build command. > * Add 'NOTE' box about INCLUDE_TFTP_COMMAND build flag. > * Move full firmware image build/burn howtos to external wiki pages. > * Add links and update paragraphs. > > Signed-off-by: Marcin Wojtas > > --- > In order to ease review/merge the patch is available in a public repository: > https://github.com/Semihalf/edk2-platforms/commits/marvell-howtos-upstream-r20220314 > > Platform/Marvell/Cn913xDb/Readme.md | 104 +++--- > Platform/SolidRun/Armada80x0McBin/Readme.md | 113 > Platform/SolidRun/Cn913xCEx7Eval/Readme.md | 109 --- > 3 files changed, 124 insertions(+), 202 deletions(-) > > diff --git a/Platform/Marvell/Cn913xDb/Readme.md > b/Platform/Marvell/Cn913xDb/Readme.md > index ecdb78302b..0b2ab676f8 100644 > --- a/Platform/Marvell/Cn913xDb/Readme.md > +++ b/Platform/Marvell/Cn913xDb/Readme.md > @@ -5,93 +5,65 @@ > > > This is a port of 64-bit TianoCore EDK II firmware for the Marvell CN913x > Development Board. > > > > -# Building the firmware > > - > > -## Prepare toolchain (for cross-compilation only): > > - > > -1. Download the toolchain: > > - > > - ``` > > - wget > https://releases.linaro.org/components/toolchain/binaries/7.5-2019.12/aarch64-linux-gnu/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu.tar.xz > > - ``` > > +# Supported features > > > > -1. After extracting, setup the path and compiler prefix to > GCC5\_AARCH64\_PREFIX variable: > > +Features supported in EDK2: > > > > - ``` > > - export > GCC5_AARCH64_PREFIX=/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu- > > - ``` > > +* 1x PCIE root complex > > +* Networking: > > + * 3x 10 GbE via SFP+ > > + * 2x 1 GbE RGMII via RJ45 > > +* 5x USB 2.0/3.0 > > +* 3x SATA > > +* 2x uSD > > +* 1x eMMC > > +* RTC > > +* SPI flash & memory-mapped variable storage access > > +* I2C > > +* GPIO > > > > -## Prepare prerequisites > > +Hardware description: > > > > -1. Create a new folder (directory) on your local development machine > > - for use as your workspace. This example uses `/work/git/tianocore`, > modify as > > - appropriate for your needs. > > +* ACPI (default) > > +* Device Tree > > > > - ``` > > - $ export WORKSPACE=/work/git/tianocore > > - $ mkdir -p $WORKSPACE > > - $ cd $WORKSPACE > > - ``` > > +Others: > > > > -1. Clone the Trusted Firmware repository: > > +* Signed capsule update > > +* X64 option ROM emulator > > > > - ``` > > - $ cd ${WORKSPACE} > > - $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git > > - ``` > > -1. Clone repository for auxiliary firmware on the SoC co-processors and > checkout to binaries-marvell-armada-SDK10.0.1.0: > > - > > - ``` > > - $ cd ${WORKSPACE} > > - $ git clone > https://github.com/MarvellEmbeddedProcessors/binaries-marvell.git > > - $ cd binaries-marvell/ > > - $ git checkout -b binaries-marvell-armada-SDK10.0.1.0 > origin/binaries-marvell-armada-SDK10.0.1.0 > > - ``` > > -1. Clone the DDR training code from: > > +# Building the firmware > > > > - ``` > > - $ cd ${WORKSPACE} > > - $ git clone > https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git > > - ``` > > ## Prepare EDKII environment: > > > > -Please follow instructions from "Obtaining source code" and "Manual > building" from the top level edk2-platforms > [Readme.md](https://github.com/tianocore/edk2-platforms#readme). > > +Please follow instructions from [Obtaining source > code](https://github.com/tianocore/edk2-platforms#obtaining-source-code) > > +and [Manual > building](https://github.com/tianocore/edk2-platforms#manual-building) from > the > > +top level edk2-platforms > [Readme.md](https://github.com/tianocore/edk2-platforms#readme). > > > > ## Build EDKII: > > > > -1. Use below build command: > > +Use below build command: > > > > - ``` > > - $ cd ${WORKSPACE} > > - $ build -a AARCH64 -t GCC5 -b RELEASE -D CN9132 -D INCLUDE_TFTP_COMMAND > -D CAPSULE_ENABLE -p Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > > - ``` > > + ``` > > + $ build -a AARCH64 -t GCC5 -b RELEASE -D CN9132 -D CAPSULE_ENABLE -D > X64EMU_ENABLE -p Platform/M
Re: [edk2-devel] [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files
Looks good. Thanks much, Marcin. This will be helpful as http://wiki.macchiatobin.net/tiki-index.php has been not accessible for quite a while. Reviewed-by: Sunny Wang Best Regards, Sunny -Original Message- From: Marcin Wojtas Sent: 14 March 2022 12:06 To: devel@edk2.groups.io Cc: quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; j...@semihalf.com; g...@semihalf.com; Sunny Wang ; Marcin Wojtas Subject: [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files From: Grzegorz Bernacki This patch reworks Readme.md files of Marvell and SolidRun platforms as follows: * Add supported features list. * Leave minmal EDK2 build command. * Add 'NOTE' box about INCLUDE_TFTP_COMMAND build flag. * Move full firmware image build/burn howtos to external wiki pages. * Add links and update paragraphs. Signed-off-by: Marcin Wojtas --- In order to ease review/merge the patch is available in a public repository: https://github.com/Semihalf/edk2-platforms/commits/marvell-howtos-upstream-r20220314 Platform/Marvell/Cn913xDb/Readme.md | 104 +++--- Platform/SolidRun/Armada80x0McBin/Readme.md | 113 Platform/SolidRun/Cn913xCEx7Eval/Readme.md | 109 --- 3 files changed, 124 insertions(+), 202 deletions(-) diff --git a/Platform/Marvell/Cn913xDb/Readme.md b/Platform/Marvell/Cn913xDb/Readme.md index ecdb78302b..0b2ab676f8 100644 --- a/Platform/Marvell/Cn913xDb/Readme.md +++ b/Platform/Marvell/Cn913xDb/Readme.md @@ -5,93 +5,65 @@ This is a port of 64-bit TianoCore EDK II firmware for the Marvell CN913x Development Board. -# Building the firmware - -## Prepare toolchain (for cross-compilation only): - -1. Download the toolchain: - - ``` - wget https://releases.linaro.org/components/toolchain/binaries/7.5-2019.12/aarch64-linux-gnu/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu.tar.xz - ``` +# Supported features -1. After extracting, setup the path and compiler prefix to GCC5\_AARCH64\_PREFIX variable: +Features supported in EDK2: - ``` - export GCC5_AARCH64_PREFIX=/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu- - ``` +* 1x PCIE root complex +* Networking: + * 3x 10 GbE via SFP+ + * 2x 1 GbE RGMII via RJ45 +* 5x USB 2.0/3.0 +* 3x SATA +* 2x uSD +* 1x eMMC +* RTC +* SPI flash & memory-mapped variable storage access +* I2C +* GPIO -## Prepare prerequisites +Hardware description: -1. Create a new folder (directory) on your local development machine - for use as your workspace. This example uses `/work/git/tianocore`, modify as - appropriate for your needs. +* ACPI (default) +* Device Tree - ``` - $ export WORKSPACE=/work/git/tianocore - $ mkdir -p $WORKSPACE - $ cd $WORKSPACE - ``` +Others: -1. Clone the Trusted Firmware repository: +* Signed capsule update +* X64 option ROM emulator - ``` - $ cd ${WORKSPACE} - $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git - ``` -1. Clone repository for auxiliary firmware on the SoC co-processors and checkout to binaries-marvell-armada-SDK10.0.1.0: - - ``` - $ cd ${WORKSPACE} - $ git clone https://github.com/MarvellEmbeddedProcessors/binaries-marvell.git - $ cd binaries-marvell/ - $ git checkout -b binaries-marvell-armada-SDK10.0.1.0 origin/binaries-marvell-armada-SDK10.0.1.0 - ``` -1. Clone the DDR training code from: +# Building the firmware - ``` - $ cd ${WORKSPACE} - $ git clone https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git - ``` ## Prepare EDKII environment: -Please follow instructions from "Obtaining source code" and "Manual building" from the top level edk2-platforms [Readme.md](https://github.com/tianocore/edk2-platforms#readme). +Please follow instructions from [Obtaining source code](https://github.com/tianocore/edk2-platforms#obtaining-source-code) +and [Manual building](https://github.com/tianocore/edk2-platforms#manual-building) from the +top level edk2-platforms [Readme.md](https://github.com/tianocore/edk2-platforms#readme). ## Build EDKII: -1. Use below build command: +Use below build command: - ``` - $ cd ${WORKSPACE} - $ build -a AARCH64 -t GCC5 -b RELEASE -D CN9132 -D INCLUDE_TFTP_COMMAND -D CAPSULE_ENABLE -p Platform/Marvell/Cn913xDb/Cn913xDbA.dsc - ``` + ``` + $ build -a AARCH64 -t GCC5 -b RELEASE -D CN9132 -D CAPSULE_ENABLE -D X64EMU_ENABLE -p Platform/Marvell/Cn913xDb/Cn913xDbA.dsc + ``` -## Build the final firmware image: +--- +**NOTE** -1. Set BL33 variable to path to EDK II output binary: +'-D INCLUDE_TFTP_COMMAND' is optional and can be added in order to enable `tftp` command in UEFI Shell. - ``` - $ export BL33=${WORKSPACE}/Build/Cn9132DbA-AARCH64/RELEASE_GCC5/FV/ARMADA_EFI.fd - ``` -1. Export SCP_BL2 variable: +--- - ``` - $ export SCP_BL2=${WORKSKPACE}/binaries-marvell/mrvl_scp_bl2.img - ``` -1
[edk2-devel] [edk2-platforms PATCH] Marvell/SolidRun: Rework Readme.md files
From: Grzegorz Bernacki This patch reworks Readme.md files of Marvell and SolidRun platforms as follows: * Add supported features list. * Leave minmal EDK2 build command. * Add 'NOTE' box about INCLUDE_TFTP_COMMAND build flag. * Move full firmware image build/burn howtos to external wiki pages. * Add links and update paragraphs. Signed-off-by: Marcin Wojtas --- In order to ease review/merge the patch is available in a public repository: https://github.com/Semihalf/edk2-platforms/commits/marvell-howtos-upstream-r20220314 Platform/Marvell/Cn913xDb/Readme.md | 104 +++--- Platform/SolidRun/Armada80x0McBin/Readme.md | 113 Platform/SolidRun/Cn913xCEx7Eval/Readme.md | 109 --- 3 files changed, 124 insertions(+), 202 deletions(-) diff --git a/Platform/Marvell/Cn913xDb/Readme.md b/Platform/Marvell/Cn913xDb/Readme.md index ecdb78302b..0b2ab676f8 100644 --- a/Platform/Marvell/Cn913xDb/Readme.md +++ b/Platform/Marvell/Cn913xDb/Readme.md @@ -5,93 +5,65 @@ This is a port of 64-bit TianoCore EDK II firmware for the Marvell CN913x Development Board. -# Building the firmware - -## Prepare toolchain (for cross-compilation only): - -1. Download the toolchain: - - ``` - wget https://releases.linaro.org/components/toolchain/binaries/7.5-2019.12/aarch64-linux-gnu/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu.tar.xz - ``` +# Supported features -1. After extracting, setup the path and compiler prefix to GCC5\_AARCH64\_PREFIX variable: +Features supported in EDK2: - ``` - export GCC5_AARCH64_PREFIX=/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu- - ``` +* 1x PCIE root complex +* Networking: + * 3x 10 GbE via SFP+ + * 2x 1 GbE RGMII via RJ45 +* 5x USB 2.0/3.0 +* 3x SATA +* 2x uSD +* 1x eMMC +* RTC +* SPI flash & memory-mapped variable storage access +* I2C +* GPIO -## Prepare prerequisites +Hardware description: -1. Create a new folder (directory) on your local development machine - for use as your workspace. This example uses `/work/git/tianocore`, modify as - appropriate for your needs. +* ACPI (default) +* Device Tree - ``` - $ export WORKSPACE=/work/git/tianocore - $ mkdir -p $WORKSPACE - $ cd $WORKSPACE - ``` +Others: -1. Clone the Trusted Firmware repository: +* Signed capsule update +* X64 option ROM emulator - ``` - $ cd ${WORKSPACE} - $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git - ``` -1. Clone repository for auxiliary firmware on the SoC co-processors and checkout to binaries-marvell-armada-SDK10.0.1.0: - - ``` - $ cd ${WORKSPACE} - $ git clone https://github.com/MarvellEmbeddedProcessors/binaries-marvell.git - $ cd binaries-marvell/ - $ git checkout -b binaries-marvell-armada-SDK10.0.1.0 origin/binaries-marvell-armada-SDK10.0.1.0 - ``` -1. Clone the DDR training code from: +# Building the firmware - ``` - $ cd ${WORKSPACE} - $ git clone https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git - ``` ## Prepare EDKII environment: -Please follow instructions from "Obtaining source code" and "Manual building" from the top level edk2-platforms [Readme.md](https://github.com/tianocore/edk2-platforms#readme). +Please follow instructions from [Obtaining source code](https://github.com/tianocore/edk2-platforms#obtaining-source-code) +and [Manual building](https://github.com/tianocore/edk2-platforms#manual-building) from the +top level edk2-platforms [Readme.md](https://github.com/tianocore/edk2-platforms#readme). ## Build EDKII: -1. Use below build command: +Use below build command: - ``` - $ cd ${WORKSPACE} - $ build -a AARCH64 -t GCC5 -b RELEASE -D CN9132 -D INCLUDE_TFTP_COMMAND -D CAPSULE_ENABLE -p Platform/Marvell/Cn913xDb/Cn913xDbA.dsc - ``` + ``` + $ build -a AARCH64 -t GCC5 -b RELEASE -D CN9132 -D CAPSULE_ENABLE -D X64EMU_ENABLE -p Platform/Marvell/Cn913xDb/Cn913xDbA.dsc + ``` -## Build the final firmware image: +--- +**NOTE** -1. Set BL33 variable to path to EDK II output binary: +'-D INCLUDE_TFTP_COMMAND' is optional and can be added in order to enable `tftp` command in UEFI Shell. - ``` - $ export BL33=${WORKSPACE}/Build/Cn9132DbA-AARCH64/RELEASE_GCC5/FV/ARMADA_EFI.fd - ``` -1. Export SCP_BL2 variable: +--- - ``` - $ export SCP_BL2=${WORKSKPACE}/binaries-marvell/mrvl_scp_bl2.img - ``` -1. Export compiler variables (for cross-compilation only): +## Build the final firmware image: - ``` - $ export ARCH=arm64 - $ export CROSS_COMPILE=/gcc-linaro-7.5.0-2019.12-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu- - ``` -1. Build the image: +In addition to EDKII binary, the complete firmware image comprises the TF-A and other components. +A complete build instruction can be found at [wiki page](https://github.com/Semihalf/edk2-platforms/wiki/Build_firmware). - ``` - $ cd ${WORKSPACE}/trusted-firmware-a/ - $ make LOG_LEVEL=20 MV_DDR_PATH=${WORKSPACE