Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-09 Thread Dridi Boukelmoune
Hi Sandro,

Sorry for the delay, but I've been very busy at work for the past
couple weeks. I've only read mails mentioning me, hence the very short
answer on the BZ. I also got sick last friday, before the very weekend
I wanted to work on fedora (your review, but also my packages). It's
only today that I've come back to work and started catching up with
mails and I'm glad you found someone for the review. I've quickly
tried to run a fedora-review when I was sick, but it failed (I've also
tried to tweak the command line to review it on fc21, but I still got
the missing dep). So I gave up and came back to bed...

Please let me know if there is another package of yours to review.

Best Regards,
Dridi

On Mon, Oct 7, 2013 at 8:46 AM, Ville Skyttä ville.sky...@iki.fi wrote:
 On Mon, Oct 7, 2013 at 3:32 AM, Sérgio Basto ser...@serjux.com wrote:
 On Dom, 2013-10-06 at 11:46 +0300, Ville Skyttä wrote:
 On Sun, Oct 6, 2013 at 7:27 AM, Sérgio Basto ser...@serjux.com wrote:
 
  we still doesn't have rpmdevtools-8.4 packaged for F21 ...

 I'll look into it as soon as it starts to look that devscripts will be 
 approved.

 haven't we enter in loop here ?, I think we are waiting for
 rpmdevtools-8.4 packaged for F21 , to be able to install devscripts
 without have conflicts with rpmdevtools .

 Don't wait for that, just remove rpmdevtools while reviewing devscripts.
 https://bugzilla.redhat.com/show_bug.cgi?id=101#c15
 --
 devel mailing list
 devel@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/devel
 Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-09 Thread Sandro Mani


On 09.10.2013 18:56, Dridi Boukelmoune wrote:

Hi Sandro,

Sorry for the delay, but I've been very busy at work for the past
couple weeks. I've only read mails mentioning me, hence the very short
answer on the BZ. I also got sick last friday, before the very weekend
I wanted to work on fedora (your review, but also my packages). It's
only today that I've come back to work and started catching up with
mails and I'm glad you found someone for the review. I've quickly
tried to run a fedora-review when I was sick, but it failed (I've also
tried to tweak the command line to review it on fc21, but I still got
the missing dep). So I gave up and came back to bed...

Please let me know if there is another package of yours to review.

Best Regards,
Dridi

Hi Dridi,

No problem, health is certainly far more important. I've got nothing up 
for review atm, but no worries, I'll finish your review regardless once 
you upload the new SRPM ;)


Best,
Sandro

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-07 Thread Ville Skyttä
On Mon, Oct 7, 2013 at 3:32 AM, Sérgio Basto ser...@serjux.com wrote:
 On Dom, 2013-10-06 at 11:46 +0300, Ville Skyttä wrote:
 On Sun, Oct 6, 2013 at 7:27 AM, Sérgio Basto ser...@serjux.com wrote:
 
  we still doesn't have rpmdevtools-8.4 packaged for F21 ...

 I'll look into it as soon as it starts to look that devscripts will be 
 approved.

 haven't we enter in loop here ?, I think we are waiting for
 rpmdevtools-8.4 packaged for F21 , to be able to install devscripts
 without have conflicts with rpmdevtools .

Don't wait for that, just remove rpmdevtools while reviewing devscripts.
https://bugzilla.redhat.com/show_bug.cgi?id=101#c15
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Ville Skyttä
On Sun, Oct 6, 2013 at 7:27 AM, Sérgio Basto ser...@serjux.com wrote:

 we still doesn't have rpmdevtools-8.4 packaged for F21 ...

I'll look into it as soon as it starts to look that devscripts will be approved.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sandro Mani


On 04.10.2013 20:49, Zbigniew Jędrzejewski-Szmek wrote:

On Mon, Sep 23, 2013 at 10:30:11AM +0200, Sandro Mani wrote:

On 23.09.2013 02:01, Zbigniew Jędrzejewski-Szmek wrote:

On Mon, Sep 23, 2013 at 12:14:29AM +0200, Sandro Mani wrote:

On 20.09.2013 06:37, Zbigniew Jędrzejewski-Szmek wrote:

On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:

Hi,

In the hope to continue the effort of getting pbuilder (and hence an
easy way to build deb packages from fedora) into the repos (review
here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
and jetring. Reviews are here:

- jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
- debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
- ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
- perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
- devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101

A question concerning the keyrings: currently, the only other
package (afaics) containing distro keyrings is archlinux-keyring.
That package installs the keyrings in /usr/share/pacman/keyrings.

Pacman installs the keyrings into /usr/share/pacman/keyrings
because that's what Arch does. I guess that archlinux.gpg may
move to /usr/share/keyrings, but there are other files (lists
of trusted and revoked keys), which are specific to pacman's libalpm,
so I think they deserve a directory on it's own. If archlinux.gpg
moves, it can be symlinked into /usr/share/pacman/keyrings.


The debian-keyring and ubuntu-keyring packages I've posted for
review install the keyrings in /usr/share/keyrings. This directory
is however unowned. I see two options:
- install {debian,ubuntu} keyrings in
/usr/share/{ubuntu,debian}/keyrings, and have them own the
directories
- have gnupg own the directory /usr/share/keyrings (and possibly
have archlinux-keyring also install the keyrings there)

This has the downside that it'll add the dependency on gnupg,
which is not great. Maybe simply create a keyrings-filesystem
package with this directory and have whoever installs keyrings
depend on it.


Any other opinions on this?
Or would it be appropriate to file a fpc
ticket for this?

I guess that we two are currently the only interested parties. I'm
sure we can agree on a solution without involing the FPC. An FPC
ticket means probably a month delay, and I don't think there's
anything controversial here.

Please see https://bugzilla.redhat.com/show_bug.cgi?id=998690#c3,
for some rationale for a -filesystem package.

I'll try to do some reviews of the remaining packages tomorrow. This
should help to finish this faster.


Ok, thanks. I've gone ahead and created a keyrings-filesytem
package, review is here:

https://bugzilla.redhat.com/show_bug.cgi?id=1010857

I've also update the other reviews to use this package.

Hi Sandro,
it's great to see that this is progressing so quickly.

I've started to add a dependency on keyrings-filesystem to
archlinux-keyring, but there's a problem:
/usr/share/pacman/keyrings/archlinux.gpg is a text file:

% head -n3 /usr/share/pacman/keyrings/archlinux.gpg
-BEGIN PGP PUBLIC KEY BLOCK-

mQINBE7VXhABEAC7AB9vHjR4b/lXq/HANeeN2vWQYK3xL2/01nvUPwycjDbCkOg2
...

while /usr/share/keyrings/debian-archive-keyring.gpg is a real gpg2
(binary) keyring.

I could
(a) symlink archlinux.gpg into /usr/share/keyrings/ as is
(b) convert archlinux.gpg to the gpg2 binary format, but that would
 probably require duplicating the file, since pacman expects
 the text format.
So the question is, what is the purpose/intended user of 
/usr/share/keyring/*.gpg ?
I'd say the main purpose is to stay consistent with the layout found on 
debian systems for their keyrings, so that for instance the how-tos 
found on the net also apply to fedora. But if archlinux expects its 
keyring in /usr/share/pacman/keyrings/, and references in the net also 
point to that directory, then maybe there is little value in placing a 
symlink in /usr/share/keyrings, so I'd just leave it as is.


Sandro

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sandro Mani


On 06.10.2013 06:27, Sérgio Basto wrote:

On Seg, 2013-09-23 at 10:30 +0200, Sandro Mani wrote:

On 23.09.2013 02:01, Zbigniew Jędrzejewski-Szmek wrote:

On Mon, Sep 23, 2013 at 12:14:29AM +0200, Sandro Mani wrote:

On 20.09.2013 06:37, Zbigniew Jędrzejewski-Szmek wrote:

On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:

Hi,

In the hope to continue the effort of getting pbuilder (and hence an
easy way to build deb packages from fedora) into the repos (review
here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
and jetring. Reviews are here:

- jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
- debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
- ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
- perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
- devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101

(...)

Ok, thanks. I've gone ahead and created a keyrings-filesytem package,
review is here:

https://bugzilla.redhat.com/show_bug.cgi?id=1010857

I've also update the other reviews to use this package.

Hi Sandro , sorry I don't had time to look into this, but seems over
packages have a package to have just keyrings-filesytem, can't we group
jetring, debian-keyring and ubuntu-keyring in one package and add
keyrings-filesytem as sub package like pacman package does ?
As for jetring, I don't thinkg that merging unrelated packages (besides 
the BR relationship) in the same package just to avoid one additional 
package is a good idea?
As for ubuntu-keyring and debian-keyring: I did think of that, but 
again, they are effectively different packages. But first thing to see 
is what Canonical answers to my enquiry regarding package names 
containing ubuntu (they still have not replied to date). If they end up 
not allowing us to use their trademark in the package names, then one 
approach might be to merge debian-keyring and ubuntu-keyring in 
deb-keyring. But personally I'd prefer the current structure.


Other thing, what are dependencies of debian-keyring and ubuntu-keyring
to pbuider or perl-Parse-DebControl ?
perl-Parse-DebControl is just a depdendency for devscripts which is a 
dependency for pbuilder. The *-keyring packages are not strictly 
dependencies (though they would probably be appropriate Suggests: if 
we had something similar), since pbuilder is not limited to building 
packages for debian and ubuntu, but might also be used to build debian 
packages using an other mirror.

we still doesn't have rpmdevtools-8.4 packaged for F21 ...
If anyone wants to finish the review of devscripts to accelerate things, 
please do so :)


Best regards,


--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sérgio Basto
On Dom, 2013-10-06 at 12:05 +0200, Sandro Mani wrote:
 The *-keyring packages are not strictly 
 dependencies (though they would probably be appropriate Suggests:
 if 
 we had something similar), since pbuilder is not limited to building 
 packages for debian and ubuntu, but might also be used to build
 debian 
 packages using an other mirror.

OK not strictly dependencies, but pbuilder needs one keyring ? or we can
build and run pbuilder without any keyring ? 

  we still doesn't have rpmdevtools-8.4 packaged for F21 ...
 If anyone wants to finish the review of devscripts to accelerate
 things, 
 please do so :)

-- 
Sérgio M. B.

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sandro Mani


On 07.10.2013 02:17, Sérgio Basto wrote:

On Dom, 2013-10-06 at 12:05 +0200, Sandro Mani wrote:

The *-keyring packages are not strictly
dependencies (though they would probably be appropriate Suggests:
if
we had something similar), since pbuilder is not limited to building
packages for debian and ubuntu, but might also be used to build
debian
packages using an other mirror.

OK not strictly dependencies, but pbuilder needs one keyring ? or we can
build and run pbuilder without any keyring ?
It should be possible for instance to use a local or third-party mirror, 
which may be unsigned.

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sérgio Basto
On Seg, 2013-10-07 at 02:21 +0200, Sandro Mani wrote: 
 On 07.10.2013 02:17, Sérgio Basto wrote:
  On Dom, 2013-10-06 at 12:05 +0200, Sandro Mani wrote:
  The *-keyring packages are not strictly
  dependencies (though they would probably be appropriate Suggests:
  if
  we had something similar), since pbuilder is not limited to building
  packages for debian and ubuntu, but might also be used to build
  debian
  packages using an other mirror.
  OK not strictly dependencies, but pbuilder needs one keyring ? or we can
  build and run pbuilder without any keyring ?
 It should be possible for instance to use a local or third-party mirror, 
 which may be unsigned.

And keyring can be used for other thing than pbuilder , not in theory ,
in Fedora in general can have other package that use keyrings ? 

-- 
Sérgio M. B.

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sandro Mani


On 07.10.2013 02:26, Sérgio Basto wrote:

On Seg, 2013-10-07 at 02:21 +0200, Sandro Mani wrote:

On 07.10.2013 02:17, Sérgio Basto wrote:

On Dom, 2013-10-06 at 12:05 +0200, Sandro Mani wrote:

The *-keyring packages are not strictly
dependencies (though they would probably be appropriate Suggests:
if
we had something similar), since pbuilder is not limited to building
packages for debian and ubuntu, but might also be used to build
debian
packages using an other mirror.

OK not strictly dependencies, but pbuilder needs one keyring ? or we can
build and run pbuilder without any keyring ?

It should be possible for instance to use a local or third-party mirror,
which may be unsigned.

And keyring can be used for other thing than pbuilder , not in theory ,
in Fedora in general can have other package that use keyrings ?

debootstrap would be an example (which is already packaged for fedora, 
and actually used by pbuilder)


--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sérgio Basto
On Dom, 2013-10-06 at 11:46 +0300, Ville Skyttä wrote: 
 On Sun, Oct 6, 2013 at 7:27 AM, Sérgio Basto ser...@serjux.com wrote:
 
  we still doesn't have rpmdevtools-8.4 packaged for F21 ...
 
 I'll look into it as soon as it starts to look that devscripts will be 
 approved.

haven't we enter in loop here ?, I think we are waiting for
rpmdevtools-8.4 packaged for F21 , to be able to install devscripts
without have conflicts with rpmdevtools .


-- 
Sérgio M. B.

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-06 Thread Sandro Mani


On 07.10.2013 02:32, Sérgio Basto wrote:

On Dom, 2013-10-06 at 11:46 +0300, Ville Skyttä wrote:

On Sun, Oct 6, 2013 at 7:27 AM, Sérgio Basto ser...@serjux.com wrote:

we still doesn't have rpmdevtools-8.4 packaged for F21 ...

I'll look into it as soon as it starts to look that devscripts will be approved.

haven't we enter in loop here ?, I think we are waiting for
rpmdevtools-8.4 packaged for F21 , to be able to install devscripts
without have conflicts with rpmdevtools .

This is what Ralf Corsepius complained about in the bug report [1]. The 
agreement with Ville Skyttä was that to test devscripts for review, one 
needs to uninstall rpmdevtools (or build devscripts with the conflicting 
files removed from the package), and as soon as devscripts has passed 
review, I will coordinate with Ville to have him push out a new 
rpmdevtools while I push devscripts. If it helps, I can upload an 
updated SRPM with the conflicting files temporarily removed.



P.s. I still wish Ralf pointed out what issues he encountered in the 
past with devscripts as he pointed out in [1].


[1] https://bugzilla.redhat.com/show_bug.cgi?id=101#c16
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-05 Thread Sérgio Basto
On Seg, 2013-09-23 at 10:30 +0200, Sandro Mani wrote: 
 On 23.09.2013 02:01, Zbigniew Jędrzejewski-Szmek wrote:
  On Mon, Sep 23, 2013 at 12:14:29AM +0200, Sandro Mani wrote:
  On 20.09.2013 06:37, Zbigniew Jędrzejewski-Szmek wrote:
  On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:
  Hi,
 
  In the hope to continue the effort of getting pbuilder (and hence an
  easy way to build deb packages from fedora) into the repos (review
  here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
  and jetring. Reviews are here:
 
  - jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
  - debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
  - ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
  - perl-Parse-DebControl: 
  https://bugzilla.redhat.com/show_bug.cgi?id=100
  - devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101
(...) 
 Ok, thanks. I've gone ahead and created a keyrings-filesytem package, 
 review is here:
 
 https://bugzilla.redhat.com/show_bug.cgi?id=1010857
 
 I've also update the other reviews to use this package.

Hi Sandro , sorry I don't had time to look into this, but seems over
packages have a package to have just keyrings-filesytem, can't we group
jetring, debian-keyring and ubuntu-keyring in one package and add
keyrings-filesytem as sub package like pacman package does ? 

Other thing, what are dependencies of debian-keyring and ubuntu-keyring
to pbuider or perl-Parse-DebControl ? 

we still doesn't have rpmdevtools-8.4 packaged for F21 ...

Best regards, 
-- 
Sérgio M. B.

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-10-04 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 23, 2013 at 10:30:11AM +0200, Sandro Mani wrote:
 
 On 23.09.2013 02:01, Zbigniew Jędrzejewski-Szmek wrote:
 On Mon, Sep 23, 2013 at 12:14:29AM +0200, Sandro Mani wrote:
 On 20.09.2013 06:37, Zbigniew Jędrzejewski-Szmek wrote:
 On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:
 Hi,
 
 In the hope to continue the effort of getting pbuilder (and hence an
 easy way to build deb packages from fedora) into the repos (review
 here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
 and jetring. Reviews are here:
 
 - jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
 - debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
 - ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
 - perl-Parse-DebControl: 
 https://bugzilla.redhat.com/show_bug.cgi?id=100
 - devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101
 
 A question concerning the keyrings: currently, the only other
 package (afaics) containing distro keyrings is archlinux-keyring.
 That package installs the keyrings in /usr/share/pacman/keyrings.
 Pacman installs the keyrings into /usr/share/pacman/keyrings
 because that's what Arch does. I guess that archlinux.gpg may
 move to /usr/share/keyrings, but there are other files (lists
 of trusted and revoked keys), which are specific to pacman's libalpm,
 so I think they deserve a directory on it's own. If archlinux.gpg
 moves, it can be symlinked into /usr/share/pacman/keyrings.
 
 The debian-keyring and ubuntu-keyring packages I've posted for
 review install the keyrings in /usr/share/keyrings. This directory
 is however unowned. I see two options:
 - install {debian,ubuntu} keyrings in
 /usr/share/{ubuntu,debian}/keyrings, and have them own the
 directories
 - have gnupg own the directory /usr/share/keyrings (and possibly
 have archlinux-keyring also install the keyrings there)
 This has the downside that it'll add the dependency on gnupg,
 which is not great. Maybe simply create a keyrings-filesystem
 package with this directory and have whoever installs keyrings
 depend on it.
 
 Any other opinions on this?
 Or would it be appropriate to file a fpc
 ticket for this?
 I guess that we two are currently the only interested parties. I'm
 sure we can agree on a solution without involing the FPC. An FPC
 ticket means probably a month delay, and I don't think there's
 anything controversial here.
 
 Please see https://bugzilla.redhat.com/show_bug.cgi?id=998690#c3,
 for some rationale for a -filesystem package.
 
 I'll try to do some reviews of the remaining packages tomorrow. This
 should help to finish this faster.
 
 Ok, thanks. I've gone ahead and created a keyrings-filesytem
 package, review is here:
 
 https://bugzilla.redhat.com/show_bug.cgi?id=1010857
 
 I've also update the other reviews to use this package.
Hi Sandro,
it's great to see that this is progressing so quickly.

I've started to add a dependency on keyrings-filesystem to
archlinux-keyring, but there's a problem:
/usr/share/pacman/keyrings/archlinux.gpg is a text file:

% head -n3 /usr/share/pacman/keyrings/archlinux.gpg
-BEGIN PGP PUBLIC KEY BLOCK-

mQINBE7VXhABEAC7AB9vHjR4b/lXq/HANeeN2vWQYK3xL2/01nvUPwycjDbCkOg2
...

while /usr/share/keyrings/debian-archive-keyring.gpg is a real gpg2
(binary) keyring.

I could
(a) symlink archlinux.gpg into /usr/share/keyrings/ as is
(b) convert archlinux.gpg to the gpg2 binary format, but that would
probably require duplicating the file, since pacman expects
the text format.
So the question is, what is the purpose/intended user of 
/usr/share/keyring/*.gpg ?

Zbyszek

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-22 Thread Sandro Mani


On 20.09.2013 06:37, Zbigniew Jędrzejewski-Szmek wrote:

On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:

Hi,

In the hope to continue the effort of getting pbuilder (and hence an
easy way to build deb packages from fedora) into the repos (review
here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
and jetring. Reviews are here:

- jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
- debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
- ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
- perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
- devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101

A question concerning the keyrings: currently, the only other
package (afaics) containing distro keyrings is archlinux-keyring.
That package installs the keyrings in /usr/share/pacman/keyrings.

Pacman installs the keyrings into /usr/share/pacman/keyrings
because that's what Arch does. I guess that archlinux.gpg may
move to /usr/share/keyrings, but there are other files (lists
of trusted and revoked keys), which are specific to pacman's libalpm,
so I think they deserve a directory on it's own. If archlinux.gpg
moves, it can be symlinked into /usr/share/pacman/keyrings.


The debian-keyring and ubuntu-keyring packages I've posted for
review install the keyrings in /usr/share/keyrings. This directory
is however unowned. I see two options:
- install {debian,ubuntu} keyrings in
/usr/share/{ubuntu,debian}/keyrings, and have them own the
directories
- have gnupg own the directory /usr/share/keyrings (and possibly
have archlinux-keyring also install the keyrings there)

This has the downside that it'll add the dependency on gnupg,
which is not great. Maybe simply create a keyrings-filesystem
package with this directory and have whoever installs keyrings
depend on it.



Any other opinions on this? Or would it be appropriate to file a fpc 
ticket for this?


Thanks,
Sandro

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-22 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Sep 23, 2013 at 12:14:29AM +0200, Sandro Mani wrote:
 
 On 20.09.2013 06:37, Zbigniew Jędrzejewski-Szmek wrote:
 On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:
 Hi,
 
 In the hope to continue the effort of getting pbuilder (and hence an
 easy way to build deb packages from fedora) into the repos (review
 here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
 and jetring. Reviews are here:
 
 - jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
 - debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
 - ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
 - perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
 - devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101
 
 A question concerning the keyrings: currently, the only other
 package (afaics) containing distro keyrings is archlinux-keyring.
 That package installs the keyrings in /usr/share/pacman/keyrings.
 Pacman installs the keyrings into /usr/share/pacman/keyrings
 because that's what Arch does. I guess that archlinux.gpg may
 move to /usr/share/keyrings, but there are other files (lists
 of trusted and revoked keys), which are specific to pacman's libalpm,
 so I think they deserve a directory on it's own. If archlinux.gpg
 moves, it can be symlinked into /usr/share/pacman/keyrings.
 
 The debian-keyring and ubuntu-keyring packages I've posted for
 review install the keyrings in /usr/share/keyrings. This directory
 is however unowned. I see two options:
 - install {debian,ubuntu} keyrings in
 /usr/share/{ubuntu,debian}/keyrings, and have them own the
 directories
 - have gnupg own the directory /usr/share/keyrings (and possibly
 have archlinux-keyring also install the keyrings there)
 This has the downside that it'll add the dependency on gnupg,
 which is not great. Maybe simply create a keyrings-filesystem
 package with this directory and have whoever installs keyrings
 depend on it.
 
 
 Any other opinions on this?
 Or would it be appropriate to file a fpc
 ticket for this?

I guess that we two are currently the only interested parties. I'm
sure we can agree on a solution without involing the FPC. An FPC
ticket means probably a month delay, and I don't think there's
anything controversial here.

Please see https://bugzilla.redhat.com/show_bug.cgi?id=998690#c3,
for some rationale for a -filesystem package.

I'll try to do some reviews of the remaining packages tomorrow. This
should help to finish this faster.

Zbyszek
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-22 Thread T.C. Hollingsworth
On Thu, Sep 19, 2013 at 9:37 PM, Zbigniew Jędrzejewski-Szmek
zbys...@in.waw.pl wrote:
 This has the downside that it'll add the dependency on gnupg,
 which is not great. Maybe simply create a keyrings-filesystem
 package with this directory and have whoever installs keyrings
 depend on it.

If gnupg owns the directory, but your package doesn't need gnupg to function,
your packages are permitted to co-own the directory with gnupg:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

A -filesystem package is a little cleaner, so it'd be nice to pursue that option
if the gnupg maintainers are amenable.  But, there's no need to block on either
them or FPC to get this done since directory co-ownership is explicitly
permitted in this instance.

-T.C.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-20 Thread Dridi Boukelmoune
On Thu, Sep 19, 2013 at 6:41 PM, Sandro Mani manisan...@gmail.com wrote:
 Hi,

 In the hope to continue the effort of getting pbuilder (and hence an easy
 way to build deb packages from fedora) into the repos (review here: [1]),
 I've packaged devscripts, debian-keyring, ubuntu-keyring and jetring.
 Reviews are here:

 - jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
 - debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
 - ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
 - perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
 - devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101

I can swap devscripts with varnish-agent if you're interested:
https://bugzilla.redhat.com/show_bug.cgi?id=varnish-agent

 A question concerning the keyrings: currently, the only other package
 (afaics) containing distro keyrings is archlinux-keyring. That package
 installs the keyrings in /usr/share/pacman/keyrings. The debian-keyring and
 ubuntu-keyring packages I've posted for review install the keyrings in
 /usr/share/keyrings. This directory is however unowned. I see two options:
 - install {debian,ubuntu} keyrings in /usr/share/{ubuntu,debian}/keyrings,
 and have them own the directories
 - have gnupg own the directory /usr/share/keyrings (and possibly have
 archlinux-keyring also install the keyrings there)
 Suggestions?

 Thanks,
 Sandro

 [1] https://bugzilla.redhat.com/show_bug.cgi?id=969718
 --
 devel mailing list
 devel@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/devel
 Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-20 Thread Sandro Mani


On 20.09.2013 13:33, Dridi Boukelmoune wrote:

On Thu, Sep 19, 2013 at 6:41 PM, Sandro Mani manisan...@gmail.com wrote:

Hi,

In the hope to continue the effort of getting pbuilder (and hence an easy
way to build deb packages from fedora) into the repos (review here: [1]),
I've packaged devscripts, debian-keyring, ubuntu-keyring and jetring.
Reviews are here:

- jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
- debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
- ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
- perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
- devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101

I can swap devscripts with varnish-agent if you're interested:
https://bugzilla.redhat.com/show_bug.cgi?id=varnish-agent



Sure, thanks!
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-19 Thread Sandro Mani

Hi,

In the hope to continue the effort of getting pbuilder (and hence an 
easy way to build deb packages from fedora) into the repos (review here: 
[1]), I've packaged devscripts, debian-keyring, ubuntu-keyring and 
jetring. Reviews are here:


- jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
- debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
- ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
- perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
- devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101

A question concerning the keyrings: currently, the only other package 
(afaics) containing distro keyrings is archlinux-keyring. That package 
installs the keyrings in /usr/share/pacman/keyrings. The debian-keyring 
and ubuntu-keyring packages I've posted for review install the keyrings 
in /usr/share/keyrings. This directory is however unowned. I see two 
options:
- install {debian,ubuntu} keyrings in 
/usr/share/{ubuntu,debian}/keyrings, and have them own the directories
- have gnupg own the directory /usr/share/keyrings (and possibly have 
archlinux-keyring also install the keyrings there)

Suggestions?

Thanks,
Sandro

[1] https://bugzilla.redhat.com/show_bug.cgi?id=969718
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Re: Review swaps: perl-Parse-DebControl, devscripts, debian-keyring, ubuntu-keyring, jetring + question: where to install keyrings?

2013-09-19 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Sep 19, 2013 at 06:41:03PM +0200, Sandro Mani wrote:
 Hi,
 
 In the hope to continue the effort of getting pbuilder (and hence an
 easy way to build deb packages from fedora) into the repos (review
 here: [1]), I've packaged devscripts, debian-keyring, ubuntu-keyring
 and jetring. Reviews are here:
 
 - jetring: https://bugzilla.redhat.com/show_bug.cgi?id=1009996
 - debian-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009997
 - ubuntu-keyring: https://bugzilla.redhat.com/show_bug.cgi?id=1009998
 - perl-Parse-DebControl: https://bugzilla.redhat.com/show_bug.cgi?id=100
 - devscripts: https://bugzilla.redhat.com/show_bug.cgi?id=101
 
 A question concerning the keyrings: currently, the only other
 package (afaics) containing distro keyrings is archlinux-keyring.
 That package installs the keyrings in /usr/share/pacman/keyrings.
Pacman installs the keyrings into /usr/share/pacman/keyrings
because that's what Arch does. I guess that archlinux.gpg may
move to /usr/share/keyrings, but there are other files (lists
of trusted and revoked keys), which are specific to pacman's libalpm,
so I think they deserve a directory on it's own. If archlinux.gpg
moves, it can be symlinked into /usr/share/pacman/keyrings.

 The debian-keyring and ubuntu-keyring packages I've posted for
 review install the keyrings in /usr/share/keyrings. This directory
 is however unowned. I see two options:
 - install {debian,ubuntu} keyrings in
 /usr/share/{ubuntu,debian}/keyrings, and have them own the
 directories
 - have gnupg own the directory /usr/share/keyrings (and possibly
 have archlinux-keyring also install the keyrings there)
This has the downside that it'll add the dependency on gnupg,
which is not great. Maybe simply create a keyrings-filesystem
package with this directory and have whoever installs keyrings
depend on it.

Zbyszek

 [1] https://bugzilla.redhat.com/show_bug.cgi?id=969718
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct