Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
--+
 Reporter:  melinath  |Owner:  akaariai
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Carl Meyer ):

 In [changeset:"a98465c040319b74b697bace11da5b13cc42427f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a98465c040319b74b697bace11da5b13cc42427f"
 Refs #14567 -- Fixed failing test that wasn't being run.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
--+
 Reporter:  melinath  |Owner:  akaariai
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by akaariai):

 Committed with some docs additions and some changes to the tests to avoid
 even larger HTML output comparisons.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
--+
 Reporter:  melinath  |Owner:  akaariai
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Anssi Kääriäinen ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"218abcc9e550d266a9979e10f562fc21b8f34c6a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="218abcc9e550d266a9979e10f562fc21b8f34c6a"
 Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as
 empty value
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
--+
 Reporter:  melinath  |Owner:  akaariai
 Type:  Bug   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by akaariai):

 * status:  assigned => new
 * owner:  melinath => akaariai


Comment:

 To me it seems this needs a minor note as a backwards incompatible change.
 In any case, this is a change we should do. The return value should always
 be of consistent type (that is, a queryset). The docs aren't exactly
 accurate currently anyways as of the return value.

 I will take care of committing this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
--+
 Reporter:  melinath  |Owner:  melinath
 Type:  Bug   |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by melinath):

 I've updated the patch to apply to the latest develop and opened a pull
 request: https://github.com/django/django/pull/398.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
---+
  Reporter:  melinath  | Owner:  melinath
Status:  assigned  | Milestone:  
 Component:  Forms |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by melinath):

 * cc: stephen.r.burr...@gmail.com (added)

Comment:

 Added git branch for this ticket @
 http://github.com/melinath/django/tree/ticket14567. The patch is still
 current as of r15353.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
---+
  Reporter:  melinath  | Owner:  melinath
Status:  assigned  | Milestone:  
 Component:  Forms |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by melinath):

 Updated empty_queryset_and_tests_r14864.diff to include necessary
 documentation changes. Note that as things stand, the documentation is
 already incorrect: it claims that ModelMultipleChoiceField normalizes to a
 list, when in fact it normalizes to a QuerySet.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
---+
  Reporter:  melinath  | Owner:  melinath
Status:  assigned  | Milestone:  
 Component:  Forms |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by melinath):

 Updated the patch to r14864 to account for changes in file structure. The
 full test suite passes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
---+
  Reporter:  melinath  | Owner:  melinath
Status:  assigned  | Milestone:  
 Component:  Forms |   Version:  SVN 
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by melinath):

  * owner:  nobody => melinath
  * needs_better_patch:  1 => 0
  * status:  new => assigned

Comment:

 empty_queryset_and_tests.diff corrects the failures by accounting for the
 changes to the forms rendered in test_callable_initial_value and
 test_initial_instance_value caused by the additional field on
 !ChoiceFieldModel which was introduced in my previous patch. I've run the
 regression test suite this time and have no unexpected failures. I can
 continue working on this if there's anything else to do for it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
---+
  Reporter:  melinath  | Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by dmoisset):

  * needs_better_patch:  0 => 1

Comment:

 I have two tests failures after applying the patch (which weren't there
 before):

 {{{
 ==
 FAIL: test_callable_initial_value
 (regressiontests.forms.models.ModelFormCallableModelDefault)
 The initial value for a callable default returning a queryset is the pk
 (refs #13769)
 --
 ==
 FAIL: test_initial_instance_value
 (regressiontests.forms.models.ModelFormCallableModelDefault)
 Initial instances for model fields may also be instances (refs #7287)
 --
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
---+
  Reporter:  melinath  | Owner:  nobody
Status:  new   | Milestone:
 Component:  Forms |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by dmoisset):

  * stage:  Unreviewed => Accepted

Comment:

 Looks legitimate... taking a look at the patch to see if it's ready for
 checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14567: ModelMultipleChoiceField inconsistently returns a list if empty.

[Django]

#14567: ModelMultipleChoiceField inconsistently returns a list if empty.
--+-
 Reporter:  melinath  |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Forms | Version:  1.2   
 Keywords:|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 The ModelMultipleChoiceField is described as "A MultipleChoiceField whose
 choices are a model QuerySet." If some models have been selected, then the
 cleaned value of this field is a queryset. However, if the field is not
 required and the value is empty, the cleaned value returned is a list.

 This is inconsistent and causes problems if, say, you want to check that
 the value passed to a method is a queryset and, if so, access
 queryset.model. The attached patch replaces [] with self.queryset.none().
 I'll work on tests tomorrow if nobody beats me to it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.