Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
-+-
 Reporter:  charles@…|Owner:  bpeschier
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (URLs)  |  Version:  1.3
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b4382b7055fc8b0078cbb50ed9c3f924635d9971" b4382b7]:
 {{{
 #!CommitTicketReference repository=""
 revision="b4382b7055fc8b0078cbb50ed9c3f924635d9971"
 Fixed #16362 -- Allowed lookaround assertions in URL patterns.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.898b644275a92e7d77bdfe7c4a34780e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
-+-
 Reporter:  charles@…|Owner:  bpeschier
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (URLs)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


Comment:

 Looks good, pending some cosmetic comments.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.acd87cf5e769a643cf756f94e589a5bd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
-+-
 Reporter:  charles@…|Owner:  bpeschier
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (URLs)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bpeschier):

 * owner:  nobody => bpeschier
 * needs_docs:  1 => 0
 * status:  new => assigned
 * needs_tests:  1 => 0


Comment:

 It was never documented that it was not allowed except for the source
 comments above {{{normalize}}}. These assertions are part of a valid
 regular expression, so I only added a release note.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.8455ba127f33b0ec68ae9ae50b6f586c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
--+
 Reporter:  charles@… |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (URLs)   |  Version:  1.3
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by DrMeers):

 * cc: DrMeers@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.a9a20b7f6a456f5eb31f029b6258d7a7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
-+-
   Reporter:  charles@…  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  1
Needs documentation:  1  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by bmihelac):

 * cc: bmihelac@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
-+-
   Reporter:  charles@…  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  1
Needs documentation:  1  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * needs_docs:  0 => 1
 * type:  Uncategorized => Cleanup/optimization
 * component:  Uncategorized => Core (Other)
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Reading the comment on #2977 and duplicate tickets, I think we can accept
 this. I'm a bit surprised that the patch is so simple, but why not.

 Until now, lookahead/behind assertions were forbidden, so it can't be
 backwards incompatible.

 The docs probably needs updating.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
-+---
   Reporter:  charles@…  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Milestone: |  Component:  Uncategorized
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+---
Changes (by ahknight):

 * cc: adam@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16362: Ignore, rather than disallow, negative lookahead assertions

[Django]

#16362: Ignore, rather than disallow, negative lookahead assertions
---+---
 Reporter:  charles@…  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Milestone: |  Component:  Uncategorized
  Version:  1.3|   Severity:  Normal
 Keywords: |   Triage Stage:  Unreviewed
Has patch:  1  |  Easy pickings:  0
UI/UX:  0  |
---+---
 At present, `django.utils.regexhelper.normalize()` is defined and
 documented to raise an exception on encountering lookahead and lookbehind
 matches in the name of reversability. This behaviour unnecessarily
 restricts the range of valid configurations.

 Consider the following case:

 {{{
 #!python
 url(r'^(?P[-\w._])/', name='city-landing'),
 }}}

 One may wish to assert that certain inputs are *certainly not* cities, and
 should never match this (in my particular use case, the desired outcome is
 actually a `Resolver404`, such that adding an additional, earlier `url()`
 entry to the urlconf is not an option):

 {{{
 #!python
 url(r'^(?!NotACity)(?P[-\w._])/', name='city-landing'),
 }}}

 This *does* mean that `reverse('city-landing', kwargs={'name':
 'NotACity'})` will result in an invalid result (a URL which, when
 resolved, does not in fact match the given reversed string). However, such
 a case clearly constitutes user error -- as the application developer
 trying to request a `city-landing` URL for `NotACity` is asking the
 impossible -- and does not constitute cause for making such patterns
 unsupported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.