Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
-+-
 Reporter:  russellm |Owner:  marw85
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"c3e108694966f045adcc0ba11133a2b3bf238770" c3e10869]:
 {{{
 #!CommitTicketReference repository=""
 revision="c3e108694966f045adcc0ba11133a2b3bf238770"
 Stopped truncating AdminEmailHandler message subjects

 Refs #26572, #17281. The RFC doesn't limit total length, just the line
 length
 which is already taken care of by Python itself.
 Thanks Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.979b46eeb53796f4ffbdede3af751be0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
-+-
 Reporter:  russellm |Owner:  marw85
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by julien):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [17501]:
 {{{
 #!CommitTicketReference repository="" revision="17501"
 Fixed #17281 -- Prevented `AdminErrorHandler` from silently failing if the
 log message contains newlines. Thanks to Russell Keith-Magee for the
 report and to Bartolome Sanchez Salado and Marcin Wróbel for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
-+-
 Reporter:  russellm |Owner:  marw85
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by cataliniacob):

 * cc: iacobcatalin@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
-+-
 Reporter:  russellm |Owner:  marw85
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by oinopion):

 * stage:  Accepted => Ready for checkin


Comment:

 I've reviewed the patch and it looks very good.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
--+
 Reporter:  russellm  |Owner:  marw85
 Type:  Bug   |   Status:  assigned
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by marw85):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
--+
 Reporter:  russellm  |Owner:  marw85
 Type:  Bug   |   Status:  assigned
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by viciu):

 I checked and the problem exists in django 1.3.1. The supplied patch fixes
 it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
--+
 Reporter:  russellm  |Owner:  marw85
 Type:  Bug   |   Status:  assigned
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by marw85):

 * owner:  elbarto => marw85
 * status:  new => assigned
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
--+
 Reporter:  russellm  |Owner:  elbarto
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by elbarto):

 * has_patch:  0 => 1


Comment:

 I've followed the glencoates indications in order to create the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
--+
 Reporter:  russellm  |Owner:  elbarto
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by glencoates):

 * cc: glencoates (added)


Comment:

 I would guess that in many cases the bit of an error message after the
 first newline is a stack trace, and that in that case you probably don't
 want all that stuff in the email subject (it will be in the body anyway).
 It would be good if AdminEmailHandler defined a make_subject( record )
 method which strips everything after the first newline, but allows the
 user to easily override that behaviour in a custom handler class if they
 choose.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
--+
 Reporter:  russellm  |Owner:  elbarto
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by elbarto):

 * owner:  nobody => elbarto


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17281: AdminErrorHandler silently fails if the log message contains newlines

[Django]

#17281: AdminErrorHandler silently fails if the log message contains newlines
+
   Reporter:  russellm  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Core (Other)  |Version:
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 If you have loggers configured with an django.utils.log.AdminEmailHandler,
 and you log a message that has a newline in it, the log message is handled
 by the logger, but is silently discarded.

 For example if you sent the following:
 {{{
 logger.error('This is a\n test message')
 }}}

 The log message will be correctly written to any text-based log handlers
 or console log handlers, but the AdminEmailHandler silently fails.

 This is because the subject of an email can't contain newlines.

 Given that the AdminEmailHandler is intended as a mechanism for reporting
 serious errors, it's pretty bad that it can fail silently due to the
 contents of the message it's reporting. The "subject" of the log email
 should be cleansed of newlines before the call to mail_admins is made.

 This cleansing could also be performed in the mail utilities themselves.
 However, I'm not convinced this is the right place; the general mail tools
 have "fail_silently" as an option, so it would be possible to handle this
 error in a better way. Failing is not an option during logging, so we
 should make sure that the messages to be sent are appropriately cleansed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.