Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+-
 Reporter:  Cloudream |Owner:  mlevental
 Type:  New feature   |   Status:  closed
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"617e36dc1ede2a311dfd03f18432b31cbfe4c0f7" 617e36dc]:
 {{{
 #!CommitTicketReference repository=""
 revision="617e36dc1ede2a311dfd03f18432b31cbfe4c0f7"
 Fixed #20705 -- Allowed using PasswordResetForm with user models with an
 email field not named 'email'.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4f1ec0dd8001ff3be98f654c4e7e47a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+-
 Reporter:  Cloudream |Owner:  mlevental
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0576c9220d5a1e074d51fd0da2058f72%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+-
 Reporter:  Cloudream |Owner:  mlevental
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by mlevental):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e55276234aacfe3408c7c59cd8b73486%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+-
 Reporter:  Cloudream |Owner:  mlevental
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 I left some ideas for improvement on the
 [https://github.com/django/django/pull/7265 PR].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fcff83ca44c562c463f3a95781f67055%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by AleksejManaev):

 * cc: AleksejManaev (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d16fb27431f083bc1fa3eff851af76d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+-
 Reporter:  Cloudream |Owner:  mlevental
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by mlevental):

 * owner:  nobody => mlevental
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5e7fdc59920c8e3a367c9ce6391366ee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by mlevental):

 * cc: m.levental@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bcb2b329f8438865a06392b98f16f241%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * Attachment "20705-initial.diff" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d5e1c82e49e2df57810993568a594c77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 No, I think it's still an issue. I'll attach a patch with a sketch of the
 code changes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.73ef940f14fe00db98363f581b09b7a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by jorgecarleitao):

 * cc: jorgecarleitao (added)


Comment:

 Doesn't the ticket #17431 solves this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.34a1a2138a7e6725400754fd2b810630%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timo):

 This isn't about renaming the form field, but rather not assuming the
 "email" field on the `UserModel` is called "email". We could accomplish
 this on `PasswordResetForm` by passing in a parameter to the `save` method
 with the name of the field, but it would be better to get an idea of the
 "other customized user model functions" the OP had in mind to better
 determine the feasibility and design of this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2a60e9d3613ca759097c800a1be99e1e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by susan):

 I've been reading this doc for context + background:
 
https://docs.djangoproject.com/en/1.5/topics/auth/default/#django.contrib.auth.forms.PasswordResetForm

 It seems that I'll need to edit the PasswordResetForm class method located
 in `contrib.auth.forms`. In particular, L27 might needed to be changed:
 "email = forms.EmailField(label=_("Email"), max_length=254)"

 Is there an existing similar example that I can follow? I've done a global
 search on USERNAME_FIELD, which returned a lot of results; I'm not sure
 which are the relevant files to look at.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.202749c68aa5a66349049d9d5975f328%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20705: Allow customizing the email field name for PasswordResetForm (was: Set email field for PasswordResetForm)

[Django]

#20705: Allow customizing the email field name for PasswordResetForm
--+
 Reporter:  Cloudream |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * stage:  Unreviewed => Accepted


Comment:

 Seems like a reasonable request.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4539b9573807009fd07c5f2695dfa72d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.